- 19 Dec, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d04ef219ddbf..aa39e6f58369 git log d04ef219ddbf..aa39e6f58369 --date=short --first-parent --format='%ad %ae %s' 2019-12-18 dberris@chromium.org Dashboard: Do not assume that a path has a parent Created with: gclient setdep -r src/third_party/catapult@aa39e6f58369 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1033485 Tbr: sadrul@google.com Change-Id: Id80624224a2b5af1076110f25446d15f72f9f395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975010Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726199}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e82d88538072..4fd7fccd6db5 git log e82d88538072..4fd7fccd6db5 --date=short --first-parent --format='%ad %ae %s' 2019-12-18 chrisforbes@google.com Regres: Roll deqp forward to latest 1.1.6 Created with: gclient setdep -r src/third_party/swiftshader@4fd7fccd6db5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I338a5905f7df6d49bf35550a3466c49ecca09dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974783Reviewed-by:
-
Caleb Rouleau authored
This will make it clearer what the root cause of an error is. Bug: 1035590 Change-Id: I760ace1c4b420c3b751915528f7ff049f5af0571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974677 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#726197}
-
Mitsuru Oshima authored
* Consolidate wallpaper animation into cross fade animation. It is now handled in WallpaperWidgetController. * Make each classes' responsibility more clear. WallpaperView: Responsible for just drawing wallpaper WallpaperWidgetController: Responsible for applying effects and animation. WallpaperController/OverviewWallpaperController: make decision what property to set, when to apply animation. * This will fix 1035568. There are tests that checks animation, and not sure why it didn't catch the issue, but it should be able to catch now. * This also fixes 1030747 by using the display's bounds, not bounds in display_managed_info, which does not provide the correct bounds when the panel orientation is rotated like krane. It was causing 'center' effect. Bug: 1030747, 1035568 Test: Updated existing test to test more correctly. Test for 1030747 T.B.D. Change-Id: I0f24bbc8a4db9fad72ef9b97d907efcbb66ac57f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967741 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#726196}
-
Charlie Hu authored
Wire everything instead of only url from navigation info to navigation params in TestRenderFrame::BeginNavigation. After fixing crbug.com/972089, frame policy is captured at BeginNavigation and the snapshot value is used in CommitNavigation. Previously, the value comes directly from frame owner element. TestRenderFrame::BeginNavigation previously only set url in navigation params which is used to commit navigation. This results in tests not able to get frame policy. Specifically ScriptContextTest.GetEffectiveDocumentURL failed when it is not supposed to because of this reason. Change-Id: I1e35620e6c9ad86438f3975901c85afc5c6a88a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968256Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#726195}
-
Adithya Srinivasan authored
Currently, after activation and adoption, both AX trees for the newly activated page and the portal have their parent_tree_id set to each other, which can lead to a stack overflow when trying to retrieve the root BrowserAccessibilityManager. This CL breaks this cycle by unsetting the parent_tree_id of the detached WebContents' AX tree. Bug: 1033999 Change-Id: Ibd0b6f4f9af28df2795574728800438a7ec5dd12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972234Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#726194}
-
Askar Aitzhan authored
Experiment: CloudPolicyOverFcm.gcl. Bug: 939039 Change-Id: I709bb13a4002952f8f3a29bb1536434b63c0fe58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1964074 Commit-Queue: Askar Aitzhan <askaraitzhan@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#726193}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c3ebb9a4. With Chromium commits locally applied on WPT: c15c1083 "Add test that datachannels close when connection does." fadf6027 "[css-pseudo] Recalculate viewport units in ::marker" 044ad8ad "[OT-PW] Make it work with OOP-R" 2ad15546 "Make interpolation-testcommon.js support composition" 9899425d "[css-layout-api] IntrinsicSizes Implementation" 7d838af7 "[scroll-to-text-fragment] Apply :target CSS pseudo-class to match." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I2c2c2f48ee43ea0c90b3bef4cb8a9549bf9dd1e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974001Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726192}
-
Marijn Kruisselbrink authored
And use that to fix test flakiness caused by the listener in NativeFileSystemDirectoryHandleImpl::GetEntries sometimes not being deleted on the right sequence. Bug: 1035115 Change-Id: I03f404db002e8deb6cad885ba189e48333676a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972774Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#726191}
-
Max Moroz authored
https://chromium-review.googlesource.com/c/chromium/src/+/1906472 has broken the ability to run arbitrary testcases without any expectations. This CL introduces an explicit option --no-expectations that disables expectation parsing and test results post-processing. This mode is useful for generating code coverage reports, as it may work with any arbitrary testcases (passed via --test-list=) and also should be running faster than the default mode, though likely not significantly faster, hence I did not measure that aspect. Bug: 957581 Change-Id: I3c91cb55ba0cad73fa6b39d386c1b37949332ef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974699Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#726190}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f64e958e897a..c880346ba5d1 git log f64e958e897a..c880346ba5d1 --date=short --first-parent --format='%ad %ae %s' 2019-12-18 reed@google.com Detect when perspective is really affine, and update the matrix as we handoff 2019-12-18 mtklein@google.com Reland "roll clang_win" 2019-12-18 mtklein@google.com demote -fsanitize=pointer-overflow to warning 2019-12-18 herb@google.com Only checksum and query a valid descriptor 2019-12-18 bsalomon@google.com "fix" formatting of auto generated cpp from fp Created with: gclient setdep -r src/third_party/skia@c880346ba5d1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: Id9bb6bf1eb4c7bebc8dda0d7ea6cfc6557659024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974781Reviewed-by:
-
Simon Que authored
This reverts commit d2613d46. Reason for revert: Retrying after increasing and reconfiguring RBE workers. This CL will land if win_chromium_compile_dbg_ng remains stable over the course of a day in MTV. Original change's description: > Revert "infra: Migrate builders to Goma RBE (Win Week 4)" > > This reverts commit cde0fa7b. > > Reason for revert: large number of builds on win_chromium_compile_dbg_ng failing w/ goma issues, e.g. > > https://ci.chromium.org/p/chromium/builders/try/win_chromium_compile_dbg_ng/461710 > https://ci.chromium.org/p/chromium/builders/try/win_chromium_compile_dbg_ng/461518 > > Original change's description: > > infra: Migrate builders to Goma RBE (Win Week 4) > > > > CI: > > -win32-archive-rel > > -win32-archive-dbg > > -Libfuzzer Upload Windows ASan > > -Windows deterministic > > -Mojo Windows > > -win-celab-builder-rel > > -win-asan > > -Win 10 Fast Ring > > -win-annotator-rel > > -win-pixel-builder-rel > > -win32-arm64-rel > > -WebRTC Chromium Win Builder > > -WebRTC Chromium FYI Win Builder > > -WebRTC Chromium FYI Win Builder (dbg) > > -win-swangle-x86 > > -win-swangle-x64 > > -win-swangle-tot-angle-x86 > > -win-swangle-tot-angle-x64 > > -win-swangle-tot-swiftshader-x86 > > -win-swangle-tot-swiftshader-x64 > > > > Try: > > -win_archive > > -win_mojo > > -win-asan > > -win-annotator-rel > > -win-swangle-try-x86 > > -win-swangle-try-tot-angle-x86 > > -win-swangle-try-x64 > > -win-swangle-try-tot-swiftshader-x86 > > -win-swangle-try-tot-angle-x64 > > -win-swangle-try-tot-swiftshader-x64 > > -win-libfuzzer-asan-rel > > -win10-blink-rel > > -win7-blink-rel > > -win10_chromium_x64_rel_ng_exp > > -win-celab-try-rel > > > > Schedule of migration: > > https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0 > > > > Bug: 950413 > > Change-Id: I476de2fe97d88f3b636b97b91457b0b61ffe30d1 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924184 > > Reviewed-by: Aaron Gable <agable@chromium.org> > > Commit-Queue: Simon Que <sque@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#724036} > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 950413 > No-Try: true > Change-Id: I1a8eab16c75972803d4867f172e4da77ef2f3c41 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967566 > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Auto-Submit: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#724696} TBR=sque@chromium.org,agable@chromium.org,bpastene@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 950413 Change-Id: I873e02a4ffc5e8d23c7cd17d9c0231d48226e0bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971630Reviewed-by:
Simon Que <sque@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#726188}
-
Rakesh Soma authored
login attempt. Bug: 993430 Change-Id: I2f632393463bfa530b98e3c604d8b368cfff0024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954539 Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#726187}
-
Brian White authored
Bug: 871934 Change-Id: I00dfc3b02b12159af95090c13e5aaab1b45364f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969984Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#726186}
-
Demetrios Papadopoulos authored
Specifically moving: - manage_a11y_page - switch_access_subpage - tts_subpage These subpages are no longer used anywhere other than OS Settings. Bug: 1026455 Change-Id: I1f22f73ea66158e100a98407ce6850ebccd9f5b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972620 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#726185}
-
Avery Musbach authored
For multi-display dragging from overview, there shall be a drop target in the display being dragged in. Test: manual Bug: 961170 Change-Id: If8439a301310f82896a776589c3d6be751b9504e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972297Reviewed-by:
-
Kunihiko Sakamoto authored
This reverts commit 79fc11a5. Reason for revert: Broke android-archive-rel build. https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/7634 Original change's description: > Implement __cxa_pure_virtual to avoid undefined symbol error > > "undefined symbol: __cxa_pure_virtual" will happen when building > //base/android/linker:chromium_android_linker with > use_clang_coverage = true > > It seems we can use infinite loop to avoid this error: > https://stackoverflow.com/questions/920500/what-is-the-purpose-of-cxa-pure-virtual > > > Bug: 1018780 > Change-Id: I97cc0a495320c4ede1ecd43cf1b7816b58646960 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968050 > Commit-Queue: Yun Liu <yliuyliu@google.com> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726178} TBR=digit@chromium.org,rmcilroy@chromium.org,yliuyliu@google.com Change-Id: Ia68fbab2f43bed74b8e134397973b83dcc5bf6e8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1018780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974294Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#726183}
-
John Budorick authored
Also adds .ini file reading & writing logic. Bug: 922145 Change-Id: I6abd19f70dc610f2b8b0e0bb5068ef0d64bf659a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973194Reviewed-by:
Yun Liu <yliuyliu@google.com> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#726182}
-
David Schinazi authored
https://quiche.googlesource.com/quiche.git/+log/ce445c76d..e223d0ec $ git log ce445c76d..e223d0ec6 --date=short --no-merges --format='%ad %ae %s' 2019-12-18 dschinazi@google.com Internal QUICHE change 2019-12-18 ianswett@google.com Define kAlarmGranularity and use it in the non-test QUIC code. 2019-12-18 wub@google.com gfe-relnote: (n/a) Add a Bbr2Sender::GetTargetBytesInflight function and use it in Bbr2ProbeBwMode. Refactor only, no behavior change. Change-Id: I30bac31d7255f70031ae9af4fcc1653841d067ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974812 Commit-Queue: David Schinazi <dschinazi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#726181}
-
Caleb Rouleau authored
This is a first draft to get something out there. I'm thinking I will rotation the chart to swap x and y later. Bug: 1030840 Change-Id: I0b5c8204cb5be8f3d3708efc5588c382a8ce0d5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974836Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#726180}
-
Marijn Kruisselbrink authored
Instead of timing out when reading of the file fails, actually report an error. Bug: none Change-Id: I1a32f3b1bc1361eb61ba17d86e67bf8d05692033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974394Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#726179}
-
Yun Liu authored
"undefined symbol: __cxa_pure_virtual" will happen when building //base/android/linker:chromium_android_linker with use_clang_coverage = true It seems we can use infinite loop to avoid this error: https://stackoverflow.com/questions/920500/what-is-the-purpose-of-cxa-pure-virtual Bug: 1018780 Change-Id: I97cc0a495320c4ede1ecd43cf1b7816b58646960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968050 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#726178}
-
Jarryd authored
This change removes the copy constructor for ImportantDomainInfo to prevent accidental copies of instances. The change also gets rid calls to said constructor. Bug: 1034140 Change-Id: Ib4fe05701df84922333c864f8c6094c95f8a192e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967739 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#726177}
-
Victor Vasiliev authored
R=rch@chromium.org Change-Id: Ib9e27b96a4f2b7bb6975444dc3ba57472afa6897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974611Reviewed-by:
-
Saman Sami authored
Bug: 1035482 Change-Id: I68c34d0a3c2b2bb5867bcf1142d87a7a67434217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974692 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#726175}
-
Darren Shen authored
<This change is hidden behind a flag> As part of migrating PK rule-based IMEs to native code, this CL migrates activate/deactivate to native code path. We port RuleBasedController#onActivate/onDeactivate in chos/pk/rulebasedcontroller.js. Note that we need these to call through to the extension, as it has side effects that may affect the extension when it is running (e.g. when VK is up). We also added a bunch of metrics collection that was in the extension code. Note that the JS code has already been guarded by the runtime flag. Bug: 1009903 Change-Id: Ib72ea3916d6f66c17c6553a7f137e1eb1647e181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970294 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#726174}
-
chrome://flagsTakumi Fujimoto authored
Add a flag to show Cast sessions in the Global Media Controls UI. Bug: 987479 Change-Id: Iaeb93ec79365319020bde0c216091a861d8de509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971050Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#726173}
-
Ken Rockot authored
This is a reland of c6e3166e Original change's description: > Convert base::Bind etc in services/ (1/2) > > This covers removal of deprecated base::Bind, base::Callback, > base::Closure, base::Passed across services/data_decoder/ and > services/device/. > > Bug: 1007831 > Change-Id: I03ca32424d53e91e6720e9209cb19a564a19de96 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970231 > Reviewed-by: Matt Reynolds <mattreynolds@chromium.org> > Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#725374} Bug: 1007831 Change-Id: Ic9be3c5e1d9db3d7addaf1c952506dd33e8b8ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974754Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#726172}
-
Klaus Weidner authored
Using 'simulateSelect()' should generate only one "select" event, but since the state value wasn't being reset it was also creating additional ones for each following frame. This wasn't causing problems for the single existing test using it (events_session_select_subframe), but is a trap for other uses. Change-Id: I87cd55b1c0654d0183aa39af9bd5ad178d7409da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974682Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#726171}
-
Stefan Zager authored
If a frame is throttled, then it may have dirty layout by the time PageAnimator::UpdateHitTestOcclusionData runs. There is no empirical evidence that render throttling is actually causing the crashes in the wild, so also add a diagnostic CHECK. BUG=1035029 R=chrishtr@chromium.org Change-Id: Ie8d1aa5d48cf94832616403e27965722b809020b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972230Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#726170}
-
Devlin Cronin authored
Introduce a WebContentsObserver test helper that tracks the console for a message to be introduced, and records seen messages. This leverages the new WebContentsObserver::OnDidAddMessageToConsole() method. This also replaces content::ConsoleObserverDelegate. It's superior because it doesn't require replacing the existing WebContentsDelegate - which can at best be extra work and at worst cause different behavior and mask test issues. Use the new class in BrowserTest.NoJavaScriptDialogsActivateTab, which is an example of where it's better and more ergonomic. Instead of having a custom ConsoleObserverDelegate that forwards along certain calls (here, GetJavaScriptDialogManager()) to the original WebContentsDelegate, we just instantiate a WebContentsConsoleObserver. Bug: 1034150 Change-Id: Id5776f93fdcd747305ac62960d0f1b5a29d318d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974490 Commit-Queue: Peter Boström <pbos@chromium.org> Auto-Submit: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
-
Alexander Cooper authored
This reverts commit 4b1723f2. Reason for revert:crbug.com/1035586 Original change's description: > Remove native deps from chrome_junit_tests > > And adds an "assert_no_deps" to prevent regressions. > Would be nice to assert that the junit target does not depend on //base, > but it looks like all grit targets depend on //base, and fixing that > would require a larger refactor. > > Bug: None > Change-Id: I970cdb458d50a32f55165756a10e66857470d75a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953400 > Reviewed-by: Peter Wen <wnwen@chromium.org> > Reviewed-by: Matt Reynolds <mattreynolds@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#723080} TBR=wnwen@chromium.org,agrieve@chromium.org,mattreynolds@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: None Change-Id: I5f5d1e67637e6aa4d1008b8227c84ce114bcf867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974586Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#726168}
-
Erik Jensen authored
Previously, the keyboard layout was read in the context of the network process, which wasn't necessarily the same as the keyboard the user currently had activated. This CL moves querying the keyboard to the desktop process, which is able to determine the active window and query that window's keyboard layout. Bug: 1026029 Change-Id: I3475113d428fe141e419b519d55a4cf99e508471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949295 Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#726167}
-
Ian Kilpatrick authored
In this patch we add a |NGPhysicalFragment::IsPaintedAtomically| flag to determine if a fragment should be painted atomically. This is treated as the source of truth, v.s. checking if something is an atomic-inline, a flex-item, etc. This bit also in the |NGConstraintSpace| as a parent layout will determine if a child should be painted atomically (as it typically has this information). See calls to |NGConstraintSpaceBuilder::SetIsPaintedAtomically|. This passes two additional tests. Bug: 845235 Change-Id: I145ca8c53c667727ed776d6901bb1b76bfd9063c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924877Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#726166}
-
Bruce Dawson authored
Using TerminateProcess to exit from utility processes has dropped the crash rate significantly so it makes sense to apply the same recipe to ppapi processes. Over 80% of utility and ppapi process crashes are during shutdown so using TerminateProcess will get rid of most of the crashes, thus making triage easier. TerminateProcess is also faster. Bug: 1024560 Change-Id: I214e0bdcaddfdac41a7d6f5dd2ff3a0e749871a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972896Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#726165}
-
Doug Arnett authored
Replaces waiting on a histogram recording to know when a navigation is complete with a content::WaitForLoadStop(). This seems to address the flakey timeout I was reproducing locally. Bug: 1032558, 1035377 Change-Id: I2a6e032ea6b112988699ea06275bbd28ec261362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974431 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#726164}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ibaa2022172bc5395ec295f1a639a18c4f560d467 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974789Reviewed-by:
-
Xiaoqian Dai authored
The reason for this issue is a bubble dialog does not get the correct bounds if the anchor window changes bounds when the anchor window has an un-identity transform in place. This CL forces the bubble dialog relayout itself when the anchor window's transform reset to the identity transform. Bug: 1035512 Change-Id: I3e73400320ecb5df99016ff1f53e6325dca2a1ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974594Reviewed-by:
-
Stephen Chenney authored
The metric is sending twice as much data as it should, and we are about to add a corresponding compositor latency metric. Hence we need to reduce the sampling rate by a factor of 4. Bug: 1035531 Change-Id: If3dfcce9db624d28495c1f44c4887f55cf004326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974610 Auto-Submit: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#726161}
-
Antonio Gomes authored
Instead it (and its devired class WebRtcAudioDeviceImpl) operate over WTF::String. BUG=923394 R=guidou@chromium.org Change-Id: I13928733af68463d789170ebb7aa7a6836288b55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970138Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#726160}
-
