- 11 Mar, 2020 40 commits
-
-
Kamila Hasanbega authored
This reverts commit 30e93e6f. Reason for revert: Suspect revert https://ci.chromium.org/p/chromium/builders/ci/GPU%20Mac%20Builder/184286? Original change's description: > Move the canMakePayment toggle to the Payments settings subpage > > When the privacy settings redesign is enabled, this setting will be > removed from the privacy card. However, it needs to be resurfaced > somewhere else. > > See https://docs.google.com/presentation/d/1Y1hSAUri9SuKtByE1xNv0-1TxbgbUFHPhwWS77fcEEE/ > for more background. > > Bug: 1032584 > Change-Id: Ia2a5b45625ba42223a1ccecd8f2b790d289bc95d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090424 > Commit-Queue: Martin Šrámek <msramek@chromium.org> > Reviewed-by: dpapad <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#749142} TBR=dpapad@chromium.org,msramek@chromium.org,sauski@google.com Change-Id: I999ed803eb652e4aaa15aff51c09e7d2ad1f4567 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1032584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096591Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Commit-Queue: Kamila Hasanbega <hkamila@chromium.org> Cr-Commit-Position: refs/heads/master@{#749145}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ccdbaf215f0c..029aa0d6eb2c git log ccdbaf215f0c..029aa0d6eb2c --date=short --first-parent --format='%ad %ae %s' 2020-03-11 treehugger-gerrit@google.com Merge changes I0cbe7c90,I6e4a3344 Created with: gclient setdep -r src/third_party/perfetto@029aa0d6eb2c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I2ee9031c1b5448c2bab8b9907c05c41a7b235f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098058Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749144}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/59f3b71c04de..78964c1e0afa git log 59f3b71c04de..78964c1e0afa --date=short --first-parent --format='%ad %ae %s' 2020-03-11 marinaciocea@webrtc.org Transform encoded frames in RtpVideoStreamReceiver. 2020-03-11 hbos@webrtc.org [Adaptation] Rename and move resource adaptation module/processor stuff. 2020-03-11 mbonadei@webrtc.org Fix 'all' build on Android platforms. 2020-03-11 mbonadei@webrtc.org Fix 'all' build on non Android platforms. Created with: gclient setdep -r src/third_party/webrtc@78964c1e0afa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If9190e16470196673372be9edf9d5f8ec30b73f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098056Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749143}
-
Martin Šrámek authored
When the privacy settings redesign is enabled, this setting will be removed from the privacy card. However, it needs to be resurfaced somewhere else. See https://docs.google.com/presentation/d/1Y1hSAUri9SuKtByE1xNv0-1TxbgbUFHPhwWS77fcEEE/ for more background. Bug: 1032584 Change-Id: Ia2a5b45625ba42223a1ccecd8f2b790d289bc95d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090424 Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#749142}
-
Henrique Ferreiro authored
Internals::getCurrentCursorInfo() was logging hotspot and image attributes unconditionally. Those should only be available for custom cursors. Bug: 1040499 Change-Id: I9c59b425e922cfa15deb891ea70cb13c3eacd522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095095 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#749141}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I1f3ddf528e98289f50aba61df62586875d831ac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098055Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749140}
-
Jan Wilken Dörrie authored
This change implements guarding the automatic checking of an edited password on the leak detection and safe browsing prefs. Bug: 1049205 Change-Id: I0874933615a67ee837f3b5d8b8284cfec214eb79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096757 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#749139}
-
Viktor Semeniuk authored
This change fixes problem with layout when username/url is too long to display fully. The end is truncated. Bug: 1059334 Change-Id: I0b6d42d500c51835330b04daf75a921070022410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095724Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#749138}
-
danakj authored
Currently the visible_viewport_size is passed to each RenderView separately from other properties which are passed down through the RenderWidget/local root hierarchy. This moves the property into the standard waterfall flow. Prior logic to determine the value was spread out between various implementations of RenderWidgetHostViews, with RenderWidgetHostViewChildFrame doing some tricky (and incomplete for portals) checking to see if it is the main frame of a nested frame tree/WebContents. Now RenderWidgetHostImpl contains the logic to decide which visible_viewport_size to use, using the RenderWidgetHostView for main frames (nested and top level). For child widgets it always uses the value received from the parent. This change may cause child widgets to receive the value a bit slower than before as it has to bounce through the RenderWidget hierarchy to get to them, but it will allow them to all be synchronized for display to the user. It will also cause child frames inside a nested WebContents to get the value of their parent instead of their own RenderWidgetHostView, which is more correct. Based on a previous CL that was reverted: https://chromium-review.googlesource.com/c/chromium/src/+/1863512 R=avi@chromium.org, dcheng@chromium.org, wjmaclean@chromium.org Change-Id: Ia5b99f48266ad758592f088e13a23002d90ba05b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083916Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#749137}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0340292972b9..21beacccb930 git log 0340292972b9..21beacccb930 --date=short --first-parent --format='%ad %ae %s' 2020-03-11 egdaniel@google.com Revert "Experiment with no longer avoiding uploading same uniforms in vulkan." Created with: gclient setdep -r src/third_party/skia@21beacccb930 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: brianosman@google.com Change-Id: Id0793f6241a33ac80de9db6423323163f5e6ea66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097934Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749136}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1422f8e60e7b..3ea855dea97e Created with: gclient setdep -r src-internal@3ea855dea97e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1046374 Tbr: jbudorick@google.com Change-Id: I88dda459750f1fb11f17efadac8152c81bb02e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097933Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749135}
-
Wei Lee authored
When taking photo, there are two stages: 1. Click shutter button -> Shutter is done 2. Shutter is done -> Captured image is returned and save We already have 'photo-taking' event to measure (1) + (2) and 'photo-capture-post-processing' for (2). It will be helpful to have a 'photo-capture-shutter' for (1) as well. In addition, to measure performance for front camera and back camera respectively, we can add events with facing information in their names. Therefore, the ones without facing information are the average metrics and the ones with facing information are results for specific facing. Bug: b/149454553 Test: tast run [DUT] camera.CCAUIPerf Change-Id: I5889ddde4df7c1b3ca4a71ba1c1c0f1628af2fff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087501Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#749134}
-
Johannes Kron authored
Set capture time to the NTP timestamp of the video frame for remote video sources. Compensate for NTP offset. Bug: 1011581 Change-Id: I75916d53503141bab7fd88cebe52c4aee83652fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095007Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Johannes Kron <kron@chromium.org> Cr-Commit-Position: refs/heads/master@{#749133}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e4aabc8bab65..7004f998c7ba git log e4aabc8bab65..7004f998c7ba --date=short --first-parent --format='%ad %ae %s' 2020-03-11 phoglund@google.com Fix parsing of summary options. Created with: gclient setdep -r src/third_party/catapult@7004f998c7ba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029452 Tbr: eseckler@google.com Change-Id: I3fc0238f99f183e767e08efe6ee2abb2b6fffcf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097931Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749132}
-
Kamila Hasanbega authored
This reverts commit a9816cf6. Reason for revert: [Sheriff] suspecting this cl might cause https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/2376 to fail. Original change's description: > Merge blink-specific video_capture_types typemap into the original > > This is inspired on [1], by kinuko@. > > [1] https://crrev.com/c/2016524 > > BUG=704136 > R=dcheng@chromium.org, guidou@chromium.org > > Change-Id: Ib51d558858d831aa1d3ba96345d3986b5afc0c54 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096387 > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Cr-Commit-Position: refs/heads/master@{#749108} TBR=dalecurtis@chromium.org,haraken@chromium.org,tsepez@chromium.org,guidou@chromium.org,tonikitoo@igalia.com Change-Id: I565415e378bd5cecd53b24335a39a3b1bc393bd0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 704136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095111Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Commit-Queue: Kamila Hasanbega <hkamila@chromium.org> Cr-Commit-Position: refs/heads/master@{#749131}
-
Colin Blundell authored
This CL eliminates the last //chrome dependence of ExternalNavigationHandler.java, on ChromeFeatureList.java. To do so it componentizes the one feature that ExternalNavigationHandler uses into //components/external_intents via a minimal ExternalIntentsFeatureList.java. Bug: 1031465 Change-Id: If3c81a1d03516a4d71a98126c939255f74296616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096559 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#749130}
-
Yutaka Hirano authored
Implements https://github.com/mikewest/corpp/pull/10 Bug: 1052764 Change-Id: I76464069d3a0a4ea1463a2e626f5e0b355f175ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091326 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#749129}
-
arthursonzogni authored
For every CacheStorage request, bind it with the correct COEP value. A difficulty: the browser process do not always have the correct value at startup for new ServiceWorker. It would requires PlzServiceWorker to be implemented first. Instead, this keeps track of the CacheStorage requests and bind them later when the COEP value will be known. Bug: 1058787, 1031542 Change-Id: I7abcadf67d9627c82c295d5a05430ee9c6bca109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095060 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#749128}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/af976e22c803..f4941654a1fe git log af976e22c803..f4941654a1fe --date=short --first-parent --format='%ad %ae %s' 2020-03-11 petermarshall@chromium.org [ui] Fix square focus rings for lighthouse radio boxes, fix alignment Created with: gclient setdep -r src/third_party/devtools-frontend/src@f4941654a1fe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1060463,chromium:920154 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic5d8b6f79c9370637c60957664f3fb93cc0bd78d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097932Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749127}
-
Minyue Li authored
Bug: 1054403 Change-Id: I6349687ce55535a0cdc405db67687d967a04fea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066777 Commit-Queue: Minyue Li <minyue@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#749126}
-
Friedrich Horschig authored
This CL changes the banner of the chrome:settings/passwords/check site according to the number of found passwords: - it's hidden if there are compromised credentials - it's positive if the analysis is completed without results - it's neutral if the analysis is still running Screenshots at the linked https://crbug.com/1047726#c31 Additionally, all images support dark mode. The new SVGs were compressed using svgo (~60% smaller than the originals). Bug: 1047726 Change-Id: I1105735ebbb90064a5daa0af1e0fc64ba708ec31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087623 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#749125}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f7ce540e. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" acf33020 "Add testing for the scrolling attribute" 2594f643 "Fix timeout in update-and-send-events-replacment.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I17ec33e25bb22b7a1910751077100d106af96162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096938Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749124}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/984dc32776be..59f3b71c04de git log 984dc32776be..59f3b71c04de --date=short --first-parent --format='%ad %ae %s' 2020-03-11 danilchap@webrtc.org Automate conversion from c++ VideoCodeType to java VideoCodecType Created with: gclient setdep -r src/third_party/webrtc@59f3b71c04de If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I58083a39af56df135f0aae51ea1b0ed6b95d49b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097930Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749123}
-
Jan Wilken Dörrie authored
This change modifies the SavedPasswordPresenter to ignore blacklisted and federated credentials. Bug: 1047726 Change-Id: Ib20ac5ef7a4b33d2d9f0251ca36ade4dbf5d0e6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097976 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#749122}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/56a7e020561a..9b620aa0c12d git log 56a7e020561a..9b620aa0c12d --date=short --first-parent --format='%ad %ae %s' 2020-03-11 laddoc@outlook.com Add flag to check whether offset is implicit or explicit (#2031) Created with: gclient setdep -r src/third_party/glslang/src@9b620aa0c12d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,jmadill@google.com Change-Id: Idde8f4314eb2c0503b74395c9bf5e0b9b2757d1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097929Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749121}
-
Morten Stenshorne authored
This will be used by the pre paint code (in an upcoming patch) when traversing the NG fragment tree rather than the layout object tree. We'll also need the fragment child iterator to understand block fragmentation, but I decided to follow up on that in a separate CL. Bug: 1043787 Change-Id: Ib85cbc5cc011142b3060bbf6f1d59cefe6130704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089894Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#749120}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1b12f6e513ac..45c5398037c4 git log 1b12f6e513ac..45c5398037c4 --date=short --first-parent --format='%ad %ae %s' 2020-03-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 8be72df60462..16ae92a4ee52 (1 commits) 2020-03-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 343d4f6f1870..e2176c91b23c (2 commits) Created with: gclient setdep -r src/third_party/angle@45c5398037c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: Ia86c64f6cf1beef90d1a8194863bc2a09a9a48ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097927Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749119}
-
Vasilii Sukhanov authored
It's applicable to "Clear browsing data" dialog. Bug: 1049193 Change-Id: Ide2495f9f5deec249de8cb71a843239891d20e70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089866Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#749118}
-
Pavol Marko authored
This converts the remaining "pref_mapping" entries in policy_test_cases.json (which are currently just ignored) to "policy_pref_mapping_tests". As one of the pref mappings is only available if USE_CUPS is defined, this also adds a way to specify that some tests should only run if a preprocessor macro is defined. Bug: 1017632 Test: browser_tests --gtest_filter=PolicyPrefsTest.PolicyToPrefsMapping Change-Id: Ia8aac403eaf561af0d657e557b36b231bd1c2576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055104 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#749117}
-
Kei Nakashima authored
This CL adds tests for VectorBackedLinkedList, where |ValueType| is String or unique_ptr. Change-Id: I05969c37324aa424e0ff26e8e87ebb8dfe6f1193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096172 Commit-Queue: Kei Nakashima <keinakashima@google.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#749116}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f66ee2d6004a..1422f8e60e7b Created with: gclient setdep -r src-internal@1422f8e60e7b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I49783f4be2f90739e40edd8a6f40090d51512c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097928Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749115}
-
Philipp Hancke authored
adding a positive test for "it bundles on the first transport and closed the second" BUG=1058826 Change-Id: I1dad046855739d033f028385fb6caca288fa0cf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096763 Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#749114}
-
Marian Fechete authored
Bug: b/150927780 Change-Id: Ic2f49a13bc36c2ce6e693779c9991cfffd1d4e2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096576 Commit-Queue: Marian Fechete <marianfe@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#749113}
-
Vidhan authored
Bug: 1045401 Change-Id: I2635b294c4349d4178f898a43eaf48f411bccab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091531 Commit-Queue: Vidhan Jain <vidhanj@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#749112}
-
Monica Basta authored
Bug: 1043128 Change-Id: I9171e8e8238347d427db01cbb7553140ddc92d8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093226 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#749111}
-
Jan Wilken Dörrie authored
This change adds detailedOrigin and isAndroidCredential to the CompromisedCredential object. These properties will be required when showing an edit dialog, allowing the user to change a compromised credential. Bug: 1047726 Change-Id: Ie6c7ecf41629e486f1fa06288c5bf4b2d348b843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093603 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#749110}
-
Jan Wilken Dörrie authored
This change cleans up the passwordsPrivate.CompromisedCredentialsInfo dictionary by moving the elapsedTimeSinceLastCheck into the more appropriate PasswordCheckStatus dictionary. Since after this change CompromisedCredentialsInfo would only have a single compromisedCredentials member, the dictionary is removed in favor of using the list directly. Bug: 1047726 Change-Id: Ibfc499c50065f82b560eea03dc1244d094e30eeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096956 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#749109}
-
Antonio Gomes authored
This is inspired on [1], by kinuko@. [1] https://crrev.com/c/2016524 BUG=704136 R=dcheng@chromium.org, guidou@chromium.org Change-Id: Ib51d558858d831aa1d3ba96345d3986b5afc0c54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096387Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#749108}
-
Clemens Arbesser authored
This is a reland of f440b571 Original change's description: > [Autofill Assistant] Added ShowCalendarPopup to UI framework. > > This adds a new interaction to the framework, which shows a calendar > popup and lets the user set or clear a date from the specified range. > > Bug: b/145043394 > Change-Id: I739e6b5ccb5821352b1ce63e63d8573bdde74f8f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093224 > Commit-Queue: Clemens Arbesser <arbesser@google.com> > Reviewed-by: Sandro Maggi <sandromaggi@google.com> > Cr-Commit-Position: refs/heads/master@{#748718} Bug: b/145043394 Change-Id: I04f14fd1f982ce9f358b705b350c35a31784bea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096586 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#749107}
-
Rob Buis authored
Implement the <mfrac> element [1] by adding support for it on the DOM and adding a layout algorithm. Add more layout utilities to obtain metrics for laying out the fraction. Add a MathML painter class for painting the fraction bar, this class will be used later on for painting other MathML parts. Bug: 6606 [1] https://mathml-refresh.github.io/mathml-core/#fractions-mfrac Change-Id: I0ab580844e1431d38d14252695bc140786349189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041665 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#749106}
-