- 20 May, 2019 13 commits
-
-
Kenichi Ishibashi authored
WorkerInspectorProxy doesn't exist anymore. Bug: N/A Tbr: alph@chromium.org Change-Id: I4523f9fee7320dc745969699590c3980fc952f35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617057Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#661249}
-
Alexey Baskakov authored
We will need it to implement InstallWebAppWithOptions. Bug: 901226 Change-Id: I88797140789a06eb9915a22c81b50d0f1bc20471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616923 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#661248}
-
Jay Harris authored
to toggle between a location bar and custom tab bar. The flag was originally slated for removal in M76. Bug: 964203 Change-Id: I2d13f3af16fcc603d4eb5c6231ac7468737003ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616875Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#661247}
-
Anand K. Mistry authored
On error, an extension API is meant to only set the error, and not a result. However, some APIs didn't follow this convention and both set the error and result. The following fileManagerPrivate functions are affected: getDownloadUrl addFileWatch removeFileWatch executeTask BUG=514135 Change-Id: Ie8116c14e5d3c558bd596594f24ca68a56171696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614580Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#661246}
-
Hiroki Nakagawa authored
Worker: Make sure to install features controlled by origin trial after OriginTrialContext::AddTokens() JavaScript's properties controlled by origin trials are installed for workers in WorkerOrWorkletScriptController::Initialize(). This is too early for shared/service workers with off-the-main-thread worker script fetch. This is because their origin trial tokens are served via worker script's response headers, and are applied to OriginTrialContext *after* WorkerOrWorkletScriptController::Initialize(). This CL separates WorkerOrWorkletScriptController::Initialize() into 2 parts: Initialize() to create and initialize the global object, and ReadyToEvaluate() to install the conditional features. Then, this makes sure to call ReadyToEvaluate() after the tokens are applied. This change fixes a following test with off-the-main-thread service worker script fetch: - virtual/origin-trials-runtimeflags-disabled/http/tests/origin_trials/webexposed/cookiestore-origin-trial-interfaces.html Change-Id: I024915b470600d6dc4835d7d3aef297da616da3e Bug: 945215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614645 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#661245}
-
Fergus Dall authored
TBR=bokan@chromium.org Bug: 963739 Change-Id: I00a2908c78a81f788b5af458dc49bb96a79238d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616936Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#661244}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b16d69c32cff..70958d15db70 git log b16d69c32cff..70958d15db70 --date=short --no-merges --format='%ad %ae %s' 2019-05-19 cnorthrop@google.com Let attribute aliasing logic detect overflow Created with: gclient setdep -r src/third_party/angle@70958d15db70 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:964404 TBR=syoussefi@google.com Change-Id: I90dc6429645b10d71367c4e07f4fc6cfec93f8fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618113Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661243}
-
Joel Hockey authored
Added tests for dialog messages, and refactored tests by combining 2 similar tests together. This should reduce overall overhead on the bots and maybe help keep test time within timeout limits. Bug: 946273 Change-Id: I8f0c3ee98c308b45a3ce56eb6fb72931170ec477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616718Reviewed-by:
-
Joel Hockey authored
This is now enabled by default. Change-Id: I79253ff1f638e341996c80794b61652716b3ec3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616935 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Giovanni Ortuño Urquidi authored
Previously a PendingBookmarkAppManager could be created with either installation tasks that always succeeded or with installation tasks that always failed. This made writing tests that needed some tasks to fail and some to succeed impossible to write. This CL changes how fake tasks are created and allows tests to control the result of each specific task. Bug: 916381 Change-Id: Ie10b5fd8866713414d3878ce7dd38615a2aec44f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615041 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#661240}
-
Darren Shen authored
Currently, the MODECHANGE key just switches to the next IME (same as pressing Ctrl-Shift-Space). However, because users may accidentally press the key, we want it to be a no-op initially. So the user pressing the key once just shows the current IME. Pressing it again while the IME mode indicator is visible will switch to the next IME. TBR=holte@chromium.org Bug: 953901 Test: accelerator_controller_unittest.cc; manual test with fake key. Change-Id: Ibf0cc0379d35c4aae50f5f41a2dceb1e14de3b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614997 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Cr-Commit-Position: refs/heads/master@{#661239}
-
Edin Kadric authored
This makes it such that when the EditableCombobox is focused but the menu isn't open, a click on the textfield but not the arrow still opens the menu (as would happen with a click on the textfield if the menu weren't focused). We can get in this situation in two ways: 1) After selecting an item or closing the menu with something like Esc, the menu is still in focus. 2) When first opening a View hosting the EditableCombobox, it could have been set not to show the menu on initial focus (as is the case in the password bubble for example). See associated bug for screenshot. We look at mouse release instead of press so that the user can still select the by clicking and dragging the mouse. If we look at mouse press events then the menu will open and the drag will not select text. Note that we added a call to TextfieldController::HandleMouseEvent in Textfield::OnMouseReleased, so we also had to add a check in other users of TextfieldController::HandleMouseEvent. Bug: 960317 Change-Id: Iaba4834be5e0f68ad3191ca572f2ab011825678e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608805Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Edin Kadric <edinkadric@google.com> Cr-Commit-Position: refs/heads/master@{#661238}
-
Jinsuk Kim authored
TabWebContentsDelegateAndroid should always be able to get the fullscreen manager to return the right control height (https://crrev.com/c/1475677). This CL replaces FullscreenManager.from() which can return |null| while tabs are in transition with the reinstated getFullscreenManager() that always returns the ChromeActivity's FullscreenManager correctly. Bug: 963820 Change-Id: Iafef11ed7dff14de38a305e6494eb0f3f83b6b46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615406Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#661237}
-
- 19 May, 2019 27 commits
-
-
Darren Shen authored
Fullscreen VK was abandoned a long time ago. It seems unlikely to make a comeback. Let's just delete the dead code. TBR=benwells@chromium.org Bug: 845780 Change-Id: I1a31739c21948cc046caa9e8175e28508fe1f489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611625 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b5938566c985..ff9090d033d8 Created with: gclient setdep -r src-internal@ff9090d033d8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@google.com,collinbaker@google.com,bcwhite@google.com,tasak@google.com Change-Id: I9829afc9fee0037201c89d8a7b38678464c80b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619243Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661235}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/977a0a436918..7ab65834bc02 git log 977a0a436918..7ab65834bc02 --date=short --no-merges --format='%ad %ae %s' 2019-05-19 swiftshader.regress@gmail.com Regres: Update test lists @ 977a0a43 Created with: gclient setdep -r src/third_party/swiftshader@7ab65834bc02 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Change-Id: I5b011250d9ca5d497c29f66aeb141dbb1a5b7014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618594Reviewed-by:
-
Xianzhu Wang authored
Combine FlipForWritingMode of LayoutInline and LayoutText into LayoutObject. In this way, it's conveinent to convert between PhysicalRect/PhysicalOffset and (flipped) LayoutRect/LayoutPoint for any type of LayoutObject. LayoutBox will also use the new FlipForWritingMode() with almost the same performance as before for normal cases. Actual flipping (in flipped blocks writing mode) will be slightly slower because of the virtual FlipForWritingModeInternal(). If this is shown to impact performance, we can devirtualize it by duplicating some code in LayoutBox's version of FlipForWritingMode() instead of inheriting from LayoutObject. Specifically, this can simplify the following code: if (object->IsBox()) ToLayoutBox(object)->FlipForWritingMode(rect); else object->ContainingBlock()->FlipForWritingMode(rect); into object->FlipForWritingMode(rect), which will be used in next steps of physical rect convertion (e.g. https://chromium-review.googlesource.com/c/chromium/src/+/1619042). Change-Id: I954bfda20a31310f9b53ddee7a16e68cd5f29137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618805Reviewed-by:Emil A Eklund <eae@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#661233}
-
Jun Mukai authored
aura::Env is now singleton. This doesn't have to exist. Bug: 958467, 960503, 826386 Test: trybot Change-Id: I18a49511d9428204c438af48231f9e89650306a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616326 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9da165a69140..82728b140ee0 git log 9da165a69140..82728b140ee0 --date=short --no-merges --format='%ad %ae %s' 2019-05-19 treehugger-gerrit@google.com Merge "Fix fuzzer build" Created with: gclient setdep -r src/third_party/perfetto@82728b140ee0 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ieb341b68f3496e25c2c9e4cf9e8f560d9377d37c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619048Reviewed-by:
-
Robert Sesek authored
The test hard-codes a path to the Helper app, which needs to be updated. Tbr: avi@chromium.org Bug: 958976,964767 Change-Id: Iebf6fb71841fd9b03d226f8047128a683058bb62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618273 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Auto-Submit: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#661230}
-
Robert Sesek authored
The options used to code sign parts are integral to their function, and so they do not belong as options of the config. Instead, they should be associated with the CodeSignedProduct part that is being signed. This also removes the `-o library` option to the Helper application, which was accidentally added during the transition to the new scripts. The Helper is not yet ready for library validation, since it currently loads Flash which is signed by a different Team ID. Bug: 964673, 958163 Change-Id: Iefc8dfb56decc94f6618d4d27fd4c0daae9a059b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618274Reviewed-by:
-
Koji Ishii authored
Following r661214 (crrev.com/c/1617565), this patch extends the lifetime of all styles being destroyed by |TextAutosizer| to |LocalFrameView|. Two more cases were found: 1. |styles_retained_during_layout_| may contain the same style twice, which makes the ref count 2. The previous fix saved only when the ref count is 1. 2. Sometimes other parts of code path may have a ref to the style; e.g., |NGFragmentBuilder|. Bug: 962003, 963622 Change-Id: I0afd43cc736ae2dad8f11092eeef1a68a9c4fc95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617568Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c46a90c9e779..9da165a69140 git log c46a90c9e779..9da165a69140 --date=short --no-merges --format='%ad %ae %s' 2019-05-19 treehugger-gerrit@google.com Merge "traced: support unique trace session names" Created with: gclient setdep -r src/third_party/perfetto@9da165a69140 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I181995680935fe89a64cbad640d4de4fec0ce056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619322Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/127e7c651c0c..b5938566c985 Created with: gclient setdep -r src-internal@b5938566c985 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@google.com,collinbaker@google.com,bcwhite@google.com,tasak@google.com Change-Id: I4c7ceb0bdd5a6e59955c7b2a9bb27c77fc0c03e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619266Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I4f5c4febc9c5b7fe7eb313f36db1ac03cc28308d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619100Reviewed-by:
-
Koji Ishii authored
This patch changes |NGPhysicalLineBoxFragment::layout_object_| to the containg |LayoutBlockFlow| of the line box. This was |nullptr| before this change, because line boxes do not have corresponding |LayoutObject|. Instead, |NGPhysicalLineBoxFragment| kept a reference to the style. This is problematic because paint-properties such as |color| can change without layout, but line boxes kept the style of the last layout. This required some work around when we paint `::first-line` line box in r660968 (crrev.com/c/1611700). This change makes |Style()| faster while |GetLayoutObject()| a little slower. It looks like it's a net-win for blink_perf: https://pinpoint-dot-chromeperf.appspot.com/job/13406c8e2c0000 With this change, |NGPhysicalLineBoxFragment::layout_object_| is never |nullptr|. This patch changes it to a reference. Changing the semantics of |GetLayoutObject()| (to return non- nullptr for NGPhysicalLineBoxFragment) caused a lot of test failures. We seem to rely on it to return |nullptr| for line boxes. It's not clear if it is semantically reasonable or not, we may revisit this in future. Bug: 636993 Change-Id: Ia947dfeebe25722400c7d484909479db7e3623e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614732 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#661224}
-
Robert Sesek authored
https://gn.googlesource.com/gn.git/+log/64b846c9..81ee1967 81ee1967 Fix recursion on io_conversion help directions 73e89074 [docs] Fix typo 'is' => 'it' f5ad8072 [docs] Use variable 'include_dirs' instead of 'includes‘ 252674db Let source_target_relative be a valid substitution for bundle_data. be0c06cb [infra] Switch to older Clang 9bd94208 Properly exit when an unknown tool is defined. 9a469b22 Refactor SubstitutionType for increased flexibility 19f79dec Add test for empty source set/static lib to NinjaBinaryTargetWriter c599fdbb Fix use of 'is' operator for comparison a4026b74 [infra] Delete cq.cfg cf4c0734 [infra] Update recipes engine to 0589a4 d409ab89 Fix gn meta to handle non-string metadata 72a485f0 Remove check for C/C++ files on binary writer 9a3779dc Add support for .rs and .go source files 9ef31762 Move C logic to child class of NinjaBinaryTargetWriter 5b0bb6a7 Move Tool logic out of Toolchain 2691ec86 Canonicalize metadata walk_keys list before comaparing. 78db9de5 Fix formatting of escaping table. cd8d9d47 Optimize string escape functions 2c72317e Support for building on OpenBSD. 2349dc4e [compdb] Optionally filter the compilation database. 0f3dbca6 Use LLVM archiver on macOS Bug: gn:68, gn:67, gn:74, gn:77 Bug: chromium:958874, chromium:955936, chromium:608382 Change-Id: I79a25f6ad8e6656bc8d189821ac8311185868156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616996 Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#661223}
-
Xianzhu Wang authored
There is a difference between LayoutNG and Legacy about the scrollbar layer when an iframe is translated to out-of-view. The behavior of LayoutNG looks correct, but the fact is unrelated to the purpose of the test, so modified the test to make it pass for both LayoutNG and Legacy, and still test the graphics layer throttling behavior. TBR=pdr@chromium.org Change-Id: I27953ff3a6f3859ef26196f1782ba7e70102b3d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619009Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#661222}
-
Ryan Hamilton authored
https://quiche.googlesource.com/quiche.git/+log/da26cdbf3574..034c98c00b23 $ git log da26cdbf3..034c98c00 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 rch Move virtually all the toy server logic out of quic_server_bin.cc and into a new QuicToyServer class which can be used in chromium. 2019-05-17 rch Simplify quic_client_bin.cc by factoring out the factory into a stand-alone file. 2019-05-17 rch gfe-relnote: n/a - Remove useless "Base" name suffix from QuicToyClient Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Id2c533babeedab5ef5c2c1570c982c599c3f143f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616975 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#661221}
-
Emily Stark authored
This is a reland of a6f001ae The revert didn't help. Original change's description: > Add pre- and post-commit modes to LoginHandler > > LoginHandler currently handles two tasks when showing an interstitial: > running the request through extensions and then showing a login > prompt. When converted to committed interstitials, we need to run the > request through extensions before the navigation commits, and then > show a login prompt on top of a committed error page. This CL adds a > "mode" argument to LoginHandler. When committed interstitials are > enabled, the "mode" argument determines whether we should just run the > request through extensions and then cancel it (pre-commit mode), or > show a login prompt (post-commit). The post-commit mode is currently > not reachable; we'll use it once we add the WebContentsObserver that > observes the committed error page (https://crbug.com/963313). > > Note: this "mode" design is kind of messy and we'll probably want to > come back and clean it up later. For now, it's the simplest way to > leave LoginHandler intact for when committed interstitials are > disabled, and use the parts of it that we need before+after commit > when committed interstitials are enabled. Once committed interstitials > land and we clean up the old code, we will probably want to split > LoginHandler into two classes rather than having one class that can > operate in two different modes. > > Bug: 963311 > Change-Id: I1efddb3eca3a6b822135bd721db05f2f47561a86 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616943 > Reviewed-by: Carlos IL <carlosil@chromium.org> > Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org> > Commit-Queue: Emily Stark <estark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#661141} TBR=estark Bug: 963311 Change-Id: I518122f7a769e4dd38224a6a30294e3e15249b9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618272Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/85a0dd07188c..c46a90c9e779 git log 85a0dd07188c..c46a90c9e779 --date=short --no-merges --format='%ad %ae %s' 2019-05-19 treehugger-gerrit@google.com Merge "perfetto-ui: Generalise handling of data requests at limit" Created with: gclient setdep -r src/third_party/perfetto@c46a90c9e779 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Iae7f9a53b5409dfd2026787c60c02efe967708c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619265Reviewed-by:
-
Nico Weber authored
Previously, we built it in a separate build directory for no good reason. Also stop building compiler-rt during bootstrap on Windows (and don't start building it during bootstrap on Linux, now that we add compiler-rt during the normal build on Linux). Also severely limit how much of compiler-rt we build during bootstrap on macOS: We only need the builtins library for x86_64. So disable other parts of compiler-rt, and build the builtins library only for macOS (not for iOS), and only for x86_64 (not i386 and x86_64h). No intended behavior change, the final package should not change due to this. (But in practice we start bundling the xray headers since package.py packs lib/clang/*/include/* and previously when we had a separate build dir for compiler-rt we only copied the sanitizer/ headers over. The xray headers are small, so it's ok -- and we can set -DCOMPILER_RT_BUILD_XRAY=OFF for stage 2 on all platforms in the follow-up where we also disable some compiler-rt archs for stage 2 on macOS. Also, on Linux, the runtime .a files are now built with -ffunction-sections -fdata-sections, which makes them a bit bigger -- but linking against them should now produce slightly smaller binaries in turn.) linux_upload_clang cycle time seems unaffected (which makes sense, since it does basically the same work before and after this change). win_upload_clang cycle time goes down by ~1-10 minutes (the build times on the builds in the last 2 days before this change were 1 hrs 52 mins, 1 hrs 54 mins, 1 hrs 51 mins, 1 hrs 56 mins, 1 hrs 47 mins, 1 hrs 52 mins; the build time with this patch was 1 hrs 46 mins. Again, this makes sense since win_upload_clang now no longer needs to build compiler-rt during bootstrap). mac_upload_clang cycle time recovers some of the losses from, 30-40min faster: https://chromium-review.googlesource.com/c/chromium/src/+/1594894 : (Before this change: 3 hrs, 3 hrs 7 mins, 3 hrs 10 mins, 3 hrs 14 mins, 3 hrs 8 mins, 3 hrs 8 mins, 3 hrs 14 mins; with this change: 2 hrs 31 mins. macOS built compiler-rt in the most configurations during bootstrap, so it makes sense the win is biggest here – from ~7900 build steps for bootstrap to ~3300). (See patch set 22 for the bot times.) Bug: 959966,959361 Change-Id: I896c06ef7377a72da8b751994263437c7a00d04f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605422 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#661218}
-
Mark Mentovai authored
These broke when the new disk layout was enabled in 4602841f for bug 958976. The updater work done in bug 964023 didn’t properly account for canaries. dmgdiffer.sh is invoked with a “product_name” parameter which is either “Google Chrome” or “Google Chrome Canary”. Under both old and new layouts, the framework embedded in the canary is not renamed, but ships as “Google Chrome Framework.framework”. This is intentional. But because that framework directory is now outside the versioned directory, dmgdiffer.sh needs to be aware of its path, because it defines a “cut” at the versioned directory. By accidentally using the product_name to define the name of the framework, dmgdiffer.sh broke for just the canary channel. As a solution, for just the purpose of defining the name of the framework under the new layout, dmgdiffer.sh will use the name “Google Chrome Framework.framework” for the framework when producing a canary updater. This was chosen instead of a full-time hard-code of “Google Chrome Framework.framework” in case anyone else uses dmgdiffer.sh to produce binary diffs of Chromium-like products. For example, Chromium.app embeds a framework named “Chromium Framework.framework”, not “Google Chrome Framework.framework”. This also has a better way to get the Current symbolic link to appear in the application dirpatch, and fixes a bug in README generation. Bug: 964712 Change-Id: I3e0a529b1fad08ac7066fcb79423a1dff5df003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619066 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Auto-Submit: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#661217}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/49840624d1ce..127e7c651c0c Created with: gclient setdep -r src-internal@127e7c651c0c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@google.com,collinbaker@google.com,bcwhite@google.com,tasak@google.com Change-Id: Id16628d10f490cb8134fd4c7533a4554d3aab7a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619008Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d4e4026d364b..49840624d1ce Created with: gclient setdep -r src-internal@49840624d1ce The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@google.com,collinbaker@google.com,bcwhite@google.com,tasak@google.com Change-Id: I225bbdc6d2716a7b65fb48ca2b2f3cf3e97f912a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619202Reviewed-by:
-
Koji Ishii authored
This patch retains temporary styles |TextAutosizer| creates during the layout. Normally, these temporary styles need to be kept alive only during the lifetime of the |TextAutosizer| instance. However, in case something bad happens, these temporary styles can lead to use-after-free. This patch keeps them alive until the layout cycle ends. Bug: 963563 Change-Id: Id657409a3b93f34c76297848c5ded3128486f031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617565 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8c6bfe5350cf..ed2255b4ea13 git log 8c6bfe5350cf..ed2255b4ea13 --date=short --no-merges --format='%ad %ae %s' 2019-05-19 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@ed2255b4ea13 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Change-Id: Iaafff4663c4c715d9f77b2fc6fedd338820f6058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619007Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I1efca2a6cd1411528916fefdd757d4a6854eac25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619044Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ab84c6b5f1a2..d4e4026d364b Created with: gclient setdep -r src-internal@d4e4026d364b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@google.com,collinbaker@google.com,bcwhite@google.com,tasak@google.com Change-Id: Ieaf4b96bf0f23883b86f9aa5017da70f4d5822f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617274Reviewed-by:
-
jdragon.bae authored
There are the same things in two files. components/autofill/core/browser/autofill_address_util.cc, browser/extensions/api/autofill_private/autofill_private_api.cc. This patch means refactoring to use a single code path for this. Bug: 903594 Change-Id: I3f0b18363805d76dc232ce3eaf4147d07f9dcba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1331448Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Auto-Submit: Jaeyong Bae <jdragon.bae@gmail.com> Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Cr-Commit-Position: refs/heads/master@{#661210}
-
