- 22 Feb, 2019 40 commits
-
-
Lukasz Anforowicz authored
This CL makes the following changes: Product code changes: - Moving most of verification of CommonNavigationParams that used to be done in RenderFrameHostImpl::BeginNavigation into a new helper function in frame_host/ipc_utils.cc - VerifyCommonNavigationParams. - Making sure that VerifyCommonNavigationParams verifies things that used to be covered by RenderFrameHostImpl::BeginNavigation and *also* covers verification of |initiator_origin| (reusing other verification helpers present in frame_host/ipc_utils.cc). - Auditing callers of SetRequestorOrigin and making sure they use the right origin - they should use the initiating frame's origin. The following functions have been tweaked: 1) blink::FrameLoader::ResourceRequestForReload 2) blink::HTMLAnchorElement::HandleClick - Without tweak #1 some browser tests would have failed (e.g. the existing DNSErrorPageTest.StaleCacheStatus or the new ErrorPageNavigationReload_InSubframe_BlockedByClient in the RenderFrameHostManagerTest suite). - I also note that the tweaked line in blink::FrameLoader::ResourceRequestForReload was added in r529246 which also added a regression test which still passes: RenderFrameDevToolsAgentHostBrowserTest.ReloadDinoPage Test changes: - Moving IsolateOrigin[ForTesting] from security_exploit_browsertest.cc into content/public/test/content_browser_test_utils.h - Renaming DidCommitProvisionalLoadInterceptor into FrameHostInterceptor and supporting intercepting one more method of FrameHost - BeginNavigation (in addition to the old support for intercepting DidCommitProvisionalLoad). - Adding test coverage for terminating a renderer that provides an invalid value in the |initiator_origin| argument of BeginNavigation. - Adding test coverage for renderer-initiated reloading of an erorred-out subframe. Bug: 919144 Change-Id: I2de74a634e6691b490cd94df1ac8494248f7c363 Reviewed-on: https://chromium-review.googlesource.com/c/1455470 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:Nasko Oskov <nasko@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#634486}
-
Oksana Zhuravlova authored
This change replaces then() with await() as suggested in a previous review. It also moves the first assert to a point after the override is set to verify that calls on previously created proxies are not affected by setting the override. Bug: 718652 Change-Id: Ia0ac1e1793503b8548cac8e8ef468f22eac9d934 Reviewed-on: https://chromium-review.googlesource.com/c/1481578Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#634485}
-
tby authored
This uses the Dolphin model added in previous CLs to tweak the search result scores. For context, see: https://docs.google.com/document/d/1BUHZyQ1a07laOgbxSRNNbQnTHaUPLRGjENJEJHYTtn0/edit?usp=sharing Details: - Currently rankings are very conservative, with a multiplier set via a Finch flag. - ranking_item_util has been slightly refactored. This isn't strictly necessary for this CL, but will prevent a merge conflict with CLs from other team members. - Tests have been expanded to support testing the effect of the Dolphin model. Bug: 931149 Change-Id: Ida824072d7553033000eeba771f97816bd71548a Reviewed-on: https://chromium-review.googlesource.com/c/1481172 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#634484}
-
Khushal authored
In DoEndRasterCHROMIUM skia flushes the GL work for the complete tile in its GrOpList in prepareForExternalIO which can be a slow operation. Make sure the watchdog thread is notified to avoid spurious hangs. R=piman@chromium.org Bug: 934483 Change-Id: Ifb35ceb70da93796b59da5b9bff78636cd4cea0d Reviewed-on: https://chromium-review.googlesource.com/c/1482032 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#634483}
-
Fabrice de Gans-Riberi authored
This is the second part of a mass renaming of files and associated classes for consistency. All the files under //fuchsia/engine are parts of the Fuchsia WebEngine and not the WebRunner. The renaming is done in 2 parts to preserve git history across the file renames. Bug: 922635 Change-Id: I8e09b83af755d87e682bf8f38382f884b6a79a3a Reviewed-on: https://chromium-review.googlesource.com/c/1479417 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#634482}
-
Simon authored
Bug: 931336 Change-Id: Ief94ae8d2b2b6bb03d5eeb11e26ea53c80abdb7b Reviewed-on: https://chromium-review.googlesource.com/c/1467803Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Simon Hatch <simonhatch@chromium.org> Cr-Commit-Position: refs/heads/master@{#634481}
-
Bill Budge authored
- Gives a name to the CodeCacheStatus::WriteFailed enum value. Bug: chromium:719172 Change-Id: I1291b8926877e6a782ebeb92b02331c49bd5ed96 Reviewed-on: https://chromium-review.googlesource.com/c/1480724Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#634480}
-
Lan Wei authored
We should support the input source type of none, and it is a list of pause actions. When the pause action has a duration value, we should hold all the actions in the same tick for that amount of time before we process the actions in the next tick. Bug: 606367 Change-Id: I0afde7afdb4c4eb0d8131efd34932d1c0cdf8d12 Reviewed-on: https://chromium-review.googlesource.com/c/1474283 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#634479}
-
Yiming Zhou authored
Bug: 885350 Change-Id: I7b60d389ea9ba5a454e13042ee356ec308f0a36b Reviewed-on: https://chromium-review.googlesource.com/c/1481807 Auto-Submit: Yiming Zhou <uwyiming@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#634478}
-
Gabriel Charette authored
I found this much more practical when doing some local debugging as R=kylechar@chromium.org StackTrace: :OutputToStream() can't be used in conjunction with DCHECK. Change-Id: If9eb007b914a4a33d6fffb5016e0da3ada1ebc4b Reviewed-on: https://chromium-review.googlesource.com/c/1481464 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#634477}
-
Bill Orr authored
Bug: 912978 Change-Id: Ic64fd90848811541bb487fc235926af44dca5bc7 Reviewed-on: https://chromium-review.googlesource.com/c/1475072 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#634476}
-
Mei Liang authored
Bug: None Change-Id: I0f58dd47a4c6186122239507f9fa3ac04686d774 Reviewed-on: https://chromium-review.googlesource.com/c/1479815 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#634475}
-
David Tseng authored
Some roles e.g. ignored (found copiously in Android apps) are never meant to be localized. This also enforces a valid message id for any given string and makes it obvious when coming across a missing msg id. Bug: 934512: Test: manual Change-Id: I6ac9650df4f3617836feef3999bfef6d1d58e449 Reviewed-on: https://chromium-review.googlesource.com/c/1478948 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#634474}
-
Antoine Labour authored
Part of the test uses R8 textures which are not guaranteed to be available. Skip that part if they're not. Bug: 929462 Change-Id: Ia57df90b9d6a997d3de1816f267b135bd8aee482 Reviewed-on: https://chromium-review.googlesource.com/c/1481605 Auto-Submit: Antoine Labour <piman@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#634473}
-
Joel Hockey authored
Bug: 928566 Change-Id: I71b926342738cbe3a44615b2f8c287308b552f8d Reviewed-on: https://chromium-review.googlesource.com/c/1481179 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#634472}
-
John Williams authored
This patch is a continuation on patch 1419204 to implement STOP_SESSION message. Bug: 809249 Change-Id: I86b897a793e17b7b3495f8103904af3697f224ae Reviewed-on: https://chromium-review.googlesource.com/c/1423425 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#634471}
-
Gyuyoung Kim authored
This CL replaces all uses of Blink's WaitableEvent with base::WaitableEvent in worker_scheduler_proxy_unittests.cc. To remove all uses of it, this CL needs change the type of |throtting_state_changed| from a reference to std::unique_ptr in order to apply the initial arguments, because Blink's WaitableEvent has used a different initial argument. Bug: 919388 Change-Id: I0f24c94f0a59a04e691f02a5a7ac7d0c2595ac7d Reviewed-on: https://chromium-review.googlesource.com/c/1481282Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#634470}
-
Ian Wells authored
Bug: 929306 Change-Id: I21488219963fad26e920bd84bd529762ea039d81 Reviewed-on: https://chromium-review.googlesource.com/c/1481959 Auto-Submit: Ian Wells <iwells@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#634469}
-
Gyuyoung Kim authored
This CL replaces all uses of Blink's WaitableEvent with base::WaitableEvent in thread_safe_script_container_test.cc. To remove all uses of it, this CL needs change the type of |writer_waiter_| and ||reader_waiter_| from a reference to std::unique_ptr in order to apply the initial arguments, because Blink's WaitableEvent has used a different initial argument. Bug: 919388 Change-Id: Ia4a3a44cddb654e8f04e09f8a98a80c189cc2593 Reviewed-on: https://chromium-review.googlesource.com/c/1481281Reviewed-by:
-
Robbie McElrath authored
This test is flaky on ChromeOS when the network service is enabled. Bug: 934583 Change-Id: Ib0a37e995a69555b5a5381bdef24f92fd19c12d9 Reviewed-on: https://chromium-review.googlesource.com/c/1482005Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#634467}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0e784189b200..12a4eb908a7b git log 0e784189b200..12a4eb908a7b --date=short --no-merges --format='%ad %ae %s' 2019-02-21 pprabhu@chromium.org config: Migrate {cyan,scarlet}-paladin to Skylab 2019-02-21 evanhernandez@chromium.org cros branch: Add link to design doc. Created with: gclient setdep -r src/third_party/chromite@12a4eb908a7b The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I8b44e3aa3be4b1ff1721b12ddbb89a276621d67f Reviewed-on: https://chromium-review.googlesource.com/c/1482050Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634466}
-
Miyoung Shin authored
- unsigned short -> int32_t for code consistency. - No logic changes. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929986 Change-Id: I787179e2cfdcae7e3fdd01c43ec0f4f5c2d44c2b Reviewed-on: https://chromium-review.googlesource.com/c/1478311Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
-
Pedro Amaral authored
Added a null check before trying to destroy the TabThemeColorProvider in ChromeActivity. Bug: 934183 Change-Id: If1a9de3664adc24d669f6208eb337e2837d38138 Reviewed-on: https://chromium-review.googlesource.com/c/1480723Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#634464}
-
bsheedy authored
Previously, the XR tests automatically ran JavaScript in the first tab opened in the browser. With this change, they will now automatically run in whatever the currently visible/active tab is. For most cases, this doesn't actually matter since there's only one tab open, but the new behavior is both more intuitive and more common. Also drive-by changes the more verbose way of opening Incognito tabs to the newer helper method in the test framework. Bug: 931420 Change-Id: I9e78aa0663bc432e4eb22f2461329aa82b017d91 Reviewed-on: https://chromium-review.googlesource.com/c/1479390Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#634463}
-
Alex Clarke authored
This leak was introduced by https://crrev.com/c/1462801/ where there was a confusion between MessageLoop and MessageLoopBase (surprisingly the former owns the latter). This patch fixes the leak and generally clarifies ownership. We still need to change base::Thread::Options::task_environment to be a std::unique_ptr but that's a larger refactor. Change-Id: Ic5380df2fb9dca5cb0818ce8e8b90e05192c6e9d BUG: 933925, 934088, 933014, 932857 Reviewed-on: https://chromium-review.googlesource.com/c/1480462 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#634462}
-
Dominic Mazzoni authored
Bug: 934145 Change-Id: I3d98f29a60bd8093b026c9f22d1c05964201b18c Reviewed-on: https://chromium-review.googlesource.com/c/1481133 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#634461}
-
Nate Fischer authored
This implements CookieManager#setCookie for the network service code path, plumbing SetCanonicalCookie through AwCookieManagerWrapper. Along with this change, this re-implements #setCookie for the legacy code path, to use SetCanonicalCookieAsync instead of SetCookieWithOptionsAsync (to share code between the new and old code paths). This splits apart a test, which I found to be useful when debugging (since the "good URL" and "bad URL" case are actually quite different). This removes a bunch of tests from the test filter, and adds in new breakages (mainly due to #hasCookies() not being implemented yet). This also updates some TODOs, to point at finer-grained crbugs I've filed since the last CL. Bug: 933460, 931641, 902641, 933462, 893580 Test: run_webview_instrumentation_test_apk -f=CookieManagerTest#* \ Test: --enable-features=NetworkService,NetworkServiceInProcess Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Change-Id: I3f29a209aa9a442d273b8673c01848801f298ee8 Reviewed-on: https://chromium-review.googlesource.com/c/1478470Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#634460}
-
Johann authored
BUG=chromium:911658 R=dalecurtis@chromium.org Change-Id: I14ba3e2ec67b2cfb0349507dfbf65480ef1b08ba Reviewed-on: https://chromium-review.googlesource.com/c/1481119Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#634459}
-
Maggie Cai authored
Currently there are some display issues for rtl ui direction in All Sites. This CL fixes the issues. BUG=835712 Change-Id: Id752009d822dc9cbab2d6fe47d1b4d6a59fea75b Reviewed-on: https://chromium-review.googlesource.com/c/1477621 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#634458}
-
Ryan Hansberry authored
The |authToken_| property needed to be explicitly bound. Bug: 933974 Change-Id: I7b0ec1d2d4750460f437137f8441ff1413a3345d Reviewed-on: https://chromium-review.googlesource.com/c/1481090Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#634457}
-
Yuwei Huang authored
This CL enables no_chromium_code and disables chromium_code on gRPC's fuzzer targets, so that we can later add the -Wextra-semi flag. R=thakis Bug: 926235,933949 Change-Id: I2b887774087992981a2eef69015ed529906015a9 Reviewed-on: https://chromium-review.googlesource.com/c/1481601 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#634456}
-
Eric Orth authored
Also: *Update deprecation comments on legacy API methods now that they are untested. *Added a new-API test for changing priority. Support was added a while back, but I must've forgotten to add a test. *Some minor TODO cleanups for tests that already exist. Will not commit this until confirming all non-test usage of the legacy API is gone (should just be waiting for crrev.com/c/1446780 to land). Bug: 922699 Change-Id: Ia5afe66883baaf3b321f3195e1fd4ff109e00ddf Reviewed-on: https://chromium-review.googlesource.com/c/1479750Reviewed-by:
-
Jinsuk Kim authored
ba412ea Fix -Wextra-semi warnings. 3e65e9d Use `uint32` instead of `uint` d4931c4 Fix unittest 3404a63 Merge pull request #9 from Baklap4/fix/warnings 5299bca Fixed warnings, removed unused variables / code Test=gclient sync, make Bug: 926235 Change-Id: Ibd9b7ded766be6c7b16f6b62c3140af624b5f715 Reviewed-on: https://chromium-review.googlesource.com/c/1481280Reviewed-by:
-
Jay Harris authored
Previously, the accessibility text for saturated badges (e.g. 99+ for badge values greater than 99) was the full number (e.g. 125). Accessibility recommended that we update the text to match what is displayed on the badge, as the consistency can be helpful to those with low vision. Bug: 719176 Change-Id: Ide81d0dd6f51b0ac2571944db05bd64c00682d90 Reviewed-on: https://chromium-review.googlesource.com/c/1480290Reviewed-by:
-
Tanya Gupta authored
Created a JNI layer (SendTabToSelfAndroidBridge) for SendTabToSelfBridge. SendTabToSelfAndroidBridge is called from SendTabToSelfShareActivity where it lives for the duration of the Activity. Bug: 921767 Change-Id: Ibf8da3fb1d192cb4c79b19dc0a0a98b66c49c4b1 Reviewed-on: https://chromium-review.googlesource.com/c/1449211 Commit-Queue: Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#634452}
-
Jun Mukai authored
The bug report looks like WindowTree calls CancelDragLoop with nullptr. This means GetWindowByTransportId returns nullptr -- I guess the window is gone during the drag&drop loop. Other methods in WindowTree (e.g. PerformDragDrop and PerformWindowMove) check this validity, so this CL adds the same validation on CancelDragDrop. Bug: 934260 Test: none Change-Id: I99fcc370b95ed49deee3ff031ed262ff6b52a655 Reviewed-on: https://chromium-review.googlesource.com/c/1481857 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#634451}
-
Kelvin Jiang authored
Bug: 932768 Change-Id: I5ac7d615ff5dfd84d94c1171dbe0176c3742aa58 Reviewed-on: https://chromium-review.googlesource.com/c/1478107 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#634450}
-
Yuwei Huang authored
wrap_memcpy.cc wraps the system memcpy function and breaks the Android trybots. We are not using old libc so I don't think we need to build this file. R=rsesek, joedow Bug: 934522 Change-Id: Iba0d4ef7727b24f7f23c68bab9aa5fb00cb3f277 Reviewed-on: https://chromium-review.googlesource.com/c/1481993 Auto-Submit: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#634449}
-
David Tseng authored
Change-Id: Id5bc5e4ad89882a10342b23a68db10d8b9872d4a Reviewed-on: https://chromium-review.googlesource.com/c/1481905Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#634448}
-
Anand K. Mistry authored
Some fileManagerPrivate APIs use a subclass of ChromeAsyncExtensionFunction to time and log long-running API calls. To help migrate off ChromeAsyncExtensionFunction, create another subclass that inherits from UIThreadExtensionFunction directly. BUG=934541 Change-Id: I1e715ca6a063ac186f73d45ce1eaa1fbf9825263 Reviewed-on: https://chromium-review.googlesource.com/c/1481131 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#634447}
-
