- 22 Jan, 2020 40 commits
-
-
Allen Bauer authored
This is a reland of fe842ad4 Original change's description: > Update and clarify view ownership for app-list views. > > Bug: 648382 > Change-Id: I0d000accee686dd67b2db1e14cea20ff893835c5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001399 > Commit-Queue: Allen Bauer <kylixrd@chromium.org> > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732019} Bug: 648382 Change-Id: I07aa57e7b497367fd5699bf997dc76c6f36f355c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012835Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#734244}
-
Patti authored
A bunch of countries were being enrolled into the root organisation during the online demo mode setup flow when they should be enrolled into their own suborganizations. Fix this for Belgium, Canada, Ireland, Italy, Luxembourg, Spain, and the United Kingdom. The corresponding organisational units and admins have been added already. Bug: 1039934 Change-Id: I4945eb89db95b95d1c10795390b04a14c74f36af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006900Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#734243}
-
Takashi Sakamoto authored
chrome/browser/devtools/protocol/page_handler.cc depends on //components/subresource_filter/browser:browser. c.f. https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/9894 [51956/72454] CXX obj/chrome/browser/devtools/devtools/page_handler.obj In file included from ../../chrome/browser/devtools/protocol/page_handler.cc:8: In file included from ../..\chrome/browser/subresource_filter/chrome_subresource_filter_client.h:13: ../..\components/subresource_filter/content/browser/subresource_filter_client.h(10,10): fatal error: 'components/subresource_filter/core/mojom/subresource_filter.mojom.h' file not found FAILED: obj/chrome/browser/devtools/devtools/page_handler.obj C: \b\s\w\ir\cache\goma\client\gomacc.exe ..\..\third_party\llvm-build\Release+Asserts\bin\clang-cl.e...(too long) Change-Id: I49d4fad36a3340fb0df6a758c64f49d9ac1efc54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007807 Auto-Submit: Takashi Sakamoto <tasak@google.com> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#734242}
-
Daniel Libby authored
DirectlyCompositedImages in blink has a dependency on having compositing information prior to the painting phase. This can't work the same way in CompositeAfterPaint. We'll be moving support directly to cc, in which we'll detect the situations under which we would have directly composited images (i.e. some specific sets of paint ops within a paint chunk) and adjust the raster scale appropriately. Blink's usage always matches layer size and image size, due to the usage of ReplacedContentTransform and directly setting the content layer bounds. This means we can reuse the code to detect and compute raster scale changes, where the current code is handling the case where (i.e. attempt to use raster scale of 1). A future change will add support for the paint op detection and set image sizes to non-matching values. This change generalizes the directly composited image code to use the image size rather than a boolean. Then use the ratio of layer bounds to image bounds to determine the raster scale. Bug: 875110 Change-Id: I4eb60f3f9b603b4e553104440695e13fc2fec43e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009368 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#734241}
-
Matt Mueller authored
Fixes downstream desugar error after https://chromium.googlesource.com/chromium/src/+/556c657dade824fd17dbb30bedbe002bc11ee9f9 Change-Id: I88e0f2661016129deb21dc49c91c91055f5fb94a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015668Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#734240}
-
John Budorick authored
Bug: 922145 Change-Id: I435dcb8084f92c4c253e9c8356411263076b5b59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003563Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#734239}
-
John Budorick authored
Bug: 1042757 Change-Id: I5e8bbe40e06176a5fb00d898b749074a1c3d65fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015785 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#734238}
-
David Benjamin authored
We currently have a C++ views object owning an Cocoa object which then owns a bridge back into some other C++ interfaces. We can simplify this by having the top-level C++ object handle those interfaces and leave the Cocoa object to purely manage the SFChooseIdentityPanel. This doesn't fix the https://crbug.com/987744 but is some cleanup along the way. Before we add more cases to that logic, reduce the number of places we spread that logic out. This does result in some RunUntilIdle() calls in the tests no longer quite waiting long enough, I suspect because the Cocoa event loop is involved. I've switched them to specifically wait for the relevant object to be destroyed, which seems more robust in general. It seems that was also the cause of the lifetime mismatch in https://crbug.com/1041175 so now we don't need a WeakPtr. Unfortunately the diff here is kind of hard to read. I had to reorder some of the classes so they could refer to each other. (Note the old bridge object was similarly interleaved between the @interface and @implementation.) Bug: 987744, 1041175 Change-Id: Icccc9e18cdfc64444a6496748dc106be6233896a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978946 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#734237}
-
Dale Curtis authored
The previous calculation was using rows / height when it needed to use SubsampleSize().height. See VideoFrame::visible_data() for the correct math. Fixed: 1027442 Change-Id: I152680d6f940cc08b612be7e6ba0c03aae01a895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013750 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#734236}
-
Jérôme Lebel authored
While the account is removed, AuthenticationService::IsAuthenticated() returns true while AuthenticationService::GetAuthenticatedIdentity() returns nil. This incoherent values make a DCHECK() in the UI failing. Both methods need to be called in order to make sure the UI knows how to update the view. This is a quick fix. The real fix will happen with crbug.com/1044270 Fixed: 1033901 Change-Id: If8eb0a03341fb48eb3c47b5e673ea9d70e899d4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012944 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#734235}
-
Manas Verma authored
Tracking the actual duration of WebAuthn’s IsUserVerifiablePlatformAuthenticatorAvailable() call. Supposedly extremely quick, but could be good to confirm as a non-MVP metric. Bug: 949269 Change-Id: Ia02cb8901830fc22c27378360972d3c91d1983b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993753Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#734234}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/527fd16079a5..c518c7f9fe9a Created with: gclient setdep -r src-internal@c518c7f9fe9a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1039877 Tbr: jbudorick@google.com Change-Id: I02caa3bbe4f7fd3ec14ba27b16de55836953089f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015022Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734233}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1e8486b1739d..f324fe10ca65 git log 1e8486b1739d..f324fe10ca65 --date=short --first-parent --format='%ad %ae %s' 2020-01-22 sugoi@google.com Improve 565 and 5551 precision Created with: gclient setdep -r src/third_party/swiftshader@f324fe10ca65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I68fbf3a9390f18c0798e5f5120214e5130c6de00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015544Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734232}
-
Ryan Hamilton authored
While ACK decimation is not currently enabled by default, it *is* enabled via experiments ubiquitously. This may cause a regression in some perf tests, but those tests are not running with the config used in production (with ACK decimation enabled). b/79972781 BUG=842677 Change-Id: Ie2729bd8c47f9d9781e5de6aa39379c740319976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015495 Commit-Queue: Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Auto-Submit: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#734231}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/a32acc1be500..9ad78aa7dba2 git log a32acc1be500..9ad78aa7dba2 --date=short --first-parent --format='%ad %ae %s' 2020-01-22 rharrison@google.com Start v2020.0 (#970) 2020-01-22 rharrison@google.com Fix the version string (#971) 2020-01-22 rharrison@google.com Finalize v2019.1 (#969) Created with: gclient setdep -r src/third_party/shaderc/src@9ad78aa7dba2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: Ia361fdd75bca63a2289eb72364aaba5ac8c446af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015447Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734230}
-
Hiroshige Hayashizaki authored
This CL updates generated files, reflecting changes in https://chromium-review.googlesource.com/c/chromium/src/+/1991066. Bug: 906850 Change-Id: I4dc79a2afc93e7a22c8c1cf83250d05876cc6103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993003Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#734229}
-
Tricia Crichton authored
For connections to localhost, ChromeDriver should test both IPv4 and IPv6 formats to resolve issue where DevTools may not be listening on the expected protocol. Bug: chromedriver:3316, b/147285732 Change-Id: Iecbf8f4f1c8df6138fd8ef8d908217e760e13923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013892Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#734228}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b19c78ebad84..4ca0dacbce51 git log b19c78ebad84..4ca0dacbce51 --date=short --first-parent --format='%ad %ae %s' 2020-01-22 kjlubick@google.com [canvaskit] Roll to 0.12.0 2020-01-22 kjlubick@google.com [canvaskit] Fix color opaqueness 2020-01-22 kjlubick@google.com [canvaskit] Fix colorType bug 2020-01-22 reed@google.com Revert "Revert "use SkM44 internally"" 2020-01-22 fmalita@chromium.org [skottie] Cleanup: convert shape layer adapters to new pattern 2020-01-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-01-22 bsalomon@google.com Fix usage enum with GL_NV_pixel_buffer_object. 2020-01-22 bungeman@google.com Glyph 0xFFFF is a valid glyph. 2020-01-22 bsalomon@google.com Disable Programs test on TecnoSparkPro3 Debug test bot 2020-01-22 egdaniel@google.com Reland "Reland "Pass in a SkColorType into SkImage_Gpu ctor."" 2020-01-22 michaelludwig@google.com Add GrQuad::bounds() benchmark 2020-01-22 reed@google.com Revert "use SkM44 internally" 2020-01-22 mtklein@google.com add --dylib to fm 2020-01-22 reed@google.com use SkM44 internally 2020-01-22 csmartdalton@google.com Add a tessellation mode that triangulates the inner polygon separately 2020-01-22 herb@google.com Reduce error control flow in addGlyphToAtlas 2020-01-22 scroggo@google.com Make SkImageInfo::validRowBytes consider alignment 2020-01-22 bsalomon@google.com Rework spefication of src/dst rects/translates throughout SkGpuBlurUtils. 2020-01-22 brianosman@google.com Clamp GrSkSLFP output to valid premul 2020-01-22 bsalomon@google.com Add functions for GL_NV_fence to GrGLInterface. 2020-01-22 robertphillips@google.com Revert "Add compressed backend textures to Metal" 2020-01-22 reed@google.com remove fun operator overloads 2020-01-22 mtklein@google.com split SkBBoxHierarchy into public/base types Created with: gclient setdep -r src/third_party/skia@4ca0dacbce51 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC benjaminwagner@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: benjaminwagner@google.com Change-Id: I5d3deef4748a5fec14d02d52f0107498a21d87be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015451Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734227}
-
Jesse Schettler authored
Update cros_healthd_probe.mojom to keep it in sync with the copy in Chrome OS. Bug: 1026848 Test: DeviceStatusCollectorTest.TestCrosHealthdInfo Change-Id: I7b35f6668f0f2627976c57f7a02cc22efeddbfd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013467Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Jack Rosenthal <jrosenth@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#734226}
-
Jay Harris authored
This reverts commit 6cf710fa. Reason for revert: This CL didn't cause the linked bug. That bug was a duplicate of crbug.com/1044520 which is now fixed. Original change's description: > Revert "WebApps: Implement unregistering file handlers on Linux." > > This reverts commit 32a1f8bf. > > Reason for revert: LocalNTPJavascriptTest failing on 7 builder(s) > Fixed: 1044497 > > Original change's description: > > WebApps: Implement unregistering file handlers on Linux. > > > > This will allow us to disable the file handlers for an app on Linux > > without uninstalling it. This is necessary preparation for the origin > > trial, as we need to be able to disable/enable the file handlers as > > the validity of the app's origin trial changes. > > > > Bug: 1028448 > > Change-Id: I63eb6582852ff75d3d88181ede07f0cbd010df2d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010234 > > Commit-Queue: Jay Harris <harrisjay@chromium.org> > > Reviewed-by: Alexey Baskakov <loyso@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#733859} > > TBR=loyso@chromium.org,harrisjay@chromium.org > > Change-Id: I67239e88d48df1d70ff1a432863b3be26d5d7bd4 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1028448 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014352 > Reviewed-by: Yoichi Osato <yoichio@chromium.org> > Commit-Queue: Yoichi Osato <yoichio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#733902} TBR=yoichio@chromium.org,loyso@chromium.org,harrisjay@chromium.org Change-Id: I5052bf84dc417f11325c51e9a584e13a585c46a0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1028448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015901Reviewed-by:
Jay Harris <harrisjay@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#734225}
-
Connie Wan authored
This follows a similar pattern to how tabs are moved left/right: https://cs.chromium.org/chromium/src/chrome/browser/ui/views/tabs/tab_strip.cc?l=1591&rcl=3e23198594e08a63cc5e091e1eefe79e3dd48454 I deliberately chose not to support MoveGroupFirst() and MoveGroupLast(), since the implementation seemed too finicky and the feature seemed very niche. We can return to it if we decide it's higher priority for accessibility. Bug: 1039921 Change-Id: Ifcd078d640a84fe96f15c41a38daa82a5090641c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006219 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#734224}
-
Alex Danilo authored
Removes the util to test for visual signals feedback panel feature flag being enabled and removes the ability to show the deprecated panels. Covered by existing unit tests. Bug: 1027012 Change-Id: Ia5d2d6536d51d2f31b702308eb5d4f91350b72f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014214Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#734223}
-
Andrew Moylan authored
This one part somehow escaped getting upgraded to the new Mojo names. Bug: None Test: Build Change-Id: Icb4cc5a4c65429a026866e847288a92d0542dc69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015900 Commit-Queue: Andrew Moylan <amoylan@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Auto-Submit: Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#734222}
-
Ulan Degenbaev authored
Some users of the script are not Chrome engineers and cannot build trace_processor_shell Bug: chromium:1044682 Change-Id: I40e904e3eccd6bc466241e66716683d7d4da6cc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015103 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#734221}
-
Sam Sebree authored
This change replaces the old time icon with the new material icon Bug: 1021339 Change-Id: I1ae90a44e01c477097c19f0b94e4e3437a709233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014153Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Sam Sebree <sasebree@microsoft.com> Cr-Commit-Position: refs/heads/master@{#734220}
-
Mike Wiitala authored
The Drallion (Wilco 1.5) keyboard has a slightly different layout than Wilco 1.0: 1. The toggle mirror mode button has moved from F12 to its own key without a corresponding F key. 2. F12 now shares a key with privacy screen toggle on devices with a privacy screen. BUG=b:147241224 TEST=build and deploy chrome to a Drallion DUT: autoninja -C out_drallion/Release chrome chrome_sandbox nacl_helper; deploy_chrome --build-dir=out_drallion/Release --to={DUT_IP}; Verify that top row keys map to expected key codes: Privacy Screen -> VKEY_PRIVACY_SCREEN_TOGGLE Privacy Screen + Fn -> VKEY_F12 Privacy Screen + Search -> VKEY_F12 Privacy Screen + Fn + Search -> VKEY_PRIVACY_SCREEN_TOGGLE Mirror toggle key always maps to VKEY_MEDIA_LAUNCH_APP2 with Control held down, regardless of Fn and Search key states. Change-Id: I8df3d28d7ea9445d736ec831b4423f2c224dd592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008063 Commit-Queue: Mike Wiitala <mwiitala@google.com> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#734219}
-
dalyk authored
Secure DNS will be disabled in these windows, allowing users to complete the captive portal resolution process. Future cls will add additional conditions that will trigger captive portal probes in secure mode. Change-Id: I441d17465a9c9d11567775321ed3ddd8532598ab Bug: 10161646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984663Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#734218}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b9cc8d75a2ad..bc9b29411747 git log b9cc8d75a2ad..bc9b29411747 --date=short --first-parent --format='%ad %ae %s' 2020-01-22 bsheedy@chromium.org Workaround CrOS root partition read-only Created with: gclient setdep -r src/third_party/catapult@bc9b29411747 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1043953 Tbr: nuskos@google.com Change-Id: I660987f0c6598ee82936ed502ed292ba108a607f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015542Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734217}
-
Henrique Nakashima authored
This is the first file to be moved into the new flags module. This is CL 3/3 to move ChromeFeatureList to chrome/browser/flags:java Bug: 1041468 Change-Id: Ie52917a32896d7ee721c4b2278fa7bc6884b417d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007315 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#734216}
-
Nicolás Peña Moreno authored
In ImageResourceContent, |observers_| and |finished_observers_| can both contain an |observer|. Therefore, in RemoveObserver(), if removing from |observers_|, it's only fully removed if it does not exist in |finished_observers_|. Bug: 1041707 Change-Id: Ia21f21627d62e19788216cfc010715646ee4842d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011137Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#734215}
-
Rayan Kanso authored
This is limited to bound WebAPKs. This is the first step to make WebAPKs discoverable via getInstalledRelatedApps. Bug: 1043970 Change-Id: I1cbb86159d15554c129894b6c405c1efefa42587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012287 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#734214}
-
Philip Rogers authored
We calculate clip rects for the underline intersections with glyphs to clip out the underline. These intercepts are calculated by Skia and can be infinite which results in an invalid clip-out paint op. This patch skips these degenerate clips-outs. This is not done for all clips because the common case is to clip from values from the layout system which will be finite. This is not done in the intercept calculation code because infinite values are correct for extreme glyph positions. Bug: 1043753 Change-Id: I0b63eb892840994537b7fec4fd9b2313f74a7d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014310 Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#734213}
-
John Lee authored
This CL fixes a use case when a grouped tab is added before an already grouped tab. Before, the tab would get appended to the end of the list because it was not updating the |elementAtIndex| variable to be the correct element. Bug: 1027373 Change-Id: I1eaec3b950576ac06fd7b927cb4f23ce7810cc36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013584 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#734212}
-
Tricia Crichton authored
Pass currentFrameId to cookie operations where missing so that Cookie operations run against the current execution context. This conforms with WebDriver spec. This cl will affect only cases where the main context url and the frame URL are different. Bug: chromedriver:3153 Change-Id: Idc4d14628ec5c00e153a3e75e38e3648cdc226a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987078Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#734211}
-
Dave Tapuska authored
Send the DidFinishDocumentLoad IPC directly from blink. The WebLocalFrameClient callback is still necessary because of RenderFrameObservers that need to listen for the load complete. BUG=1042831 Change-Id: I39a487268c90195c8dd94c9862e7a6bd695ba213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005376 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#734210}
-
Findit authored
This reverts commit d84a78f8. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 734144 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZDg0YTc4Zjg2MjY2ZmI5MTllZjU0NzU4ZDZhNzdmMGZjODVmZmUyYgw Sample Failed Build: https://ci.chromium.org/b/8890527503070869360 Sample Failed Step: content_browsertests Sample Flaky Test: BackgroundTracingManagerBrowserTest.PerfettoSystemBackgroundScenarioRuleId Original change's description: > Enable system perfetto producer on all posix builds. > > It remains disabled by default by the tracing flag > --enable-features=kEnablePerfettoSystemTracing, but when enabled will > attempt to connect to the result of GetProducerSocket(). > > This will be useful for people who want system wide tracing on linux > from crashed browser processes since the tracing service will be alive > even after Chrome dies. > > Bug: 1007310 > Change-Id: I62e67bcdc9ff720da2a59497a6d3ebf855413b8f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953718 > Auto-Submit: Stephen Nusko <nuskos@chromium.org> > Commit-Queue: Avi Drissman <avi@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734144} Change-Id: I1edd45928f698173aa53dc1d00f4229ef7a877d4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1007310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015774 Cr-Commit-Position: refs/heads/master@{#734209}
-
Michael Thiessen authored
This is a necessary pre-cursor to cleaning up scheme initialization. No GURLs should be created before schemes are modified/added and GURL is ready to use. Enforcement of this will come in a followup CL. See the bug for additional context. Replacing static initalizers with functions ensures the GURLs are only initialized when used, which happens after test setup. Bug: 783819 Change-Id: I1d0f3e81ce47903156937e5e8e58db49d287eaba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008008 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#734208}
-
Li Lin authored
Bug: 1044413 Test: Manual Change-Id: I59eb13ef6e80c72c49eb9c8271ed9f70c063a9aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014120Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#734207}
-
Stefan Zager authored
This patch caused a leak in IntersectionObserverController: https://chromium-review.googlesource.com/c/chromium/src/+/1774244 In particular, if an explicit-root IntersectionObserver was destroyed because it had no observations and no javascript references to it, then IntersectionObserverController would continue to track the root Element. This patch overhauls the way the tracking bookkeeping is handled for explicit-root observers, and guarantees two important cases: - If the observer dies, the root will no longer be tracked. - If the root element dies, any remaining observations will be disconnected. Change-Id: Ieb3822a4735850c7baae4ef32e7826f3eda10fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008528 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#734206}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/50d1a4aa725f..7763c888e0c0 $ git log 50d1a4aa7..7763c888e --date=short --no-merges --format='%ad %ae %s' 2020-01-21 jianj vp9: fix control for delta qp for uv 2020-01-17 jzern add static_assert.h 2020-01-16 bpfoley Validate data used by vpx_codec_control... 2020-01-16 jianj vp9: add delta q for uv channel. add tests. 2020-01-13 chengchen Add comments to frame counts. 2020-01-10 jzern vp9_encoder.c,cosmetics: fix some typos 2020-01-10 jzern simple_encode*.cc: add missing copyright 2020-01-10 johannkoenig trivial: fix spelling errors 2020-01-09 jianj Fix test failure with --size-limit 2020-01-02 chengchen Copy frame counts to the encode result. 2020-01-07 courbet Avoid reloads in vp9_read_mode_info. 2019-12-18 wonkap Add text to clarify the unit of variables for target bitrate Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: Ia6da9c7fa7239908ea95025290b420af37e123c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014984Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#734205}
-