GitLab

Quick Answers query might get rewritten based on the intent generated on
device. Some cases, the backend might not be able to fulfill the query,
We would like to use the title instead of the rewritten query in this
case.

Bug: b/158040239
Test: manual test
Change-Id: I5e9efc363498f535b6fb03e8f7743b4db613e223
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227689Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Li Lin <llin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774749}

This reverts commit c8232e7f.

Reason for revert: A current spike in iOS cq resource. This revert can help a bit. Can reland when resource gets better.

Original change's description:
> [code coverage] Enable 3% CQ experiment for ios-simulator-code-coverage
> 
> Will observe if there are issues from the experiment then set code
> coverage as default in iOS CQ builders.
> 
> Bug: 1090188
> Change-Id: I77e58aefbfc4964f63de61cef7bd7a351d11bfc7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227236
> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
> Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#774443}

TBR=gbeaty@chromium.org,zhaoyangli@chromium.org

Change-Id: Ifb20a8271a3f0ccc5b7830bbcfb2374d72848553
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1090188
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229328Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774748}

This changelist modifies accessibilityHitTest in AXPlatformNodeCocoa so
that it only recurses on child accessibility elements with frames that
contain the specified point for hit testing. Per the Apple Developer
Documentation for accessibilityHitTest, the method should only be called
when the specified point has already been determined to lie within the
accessibility element's frame.

Previously, the lack of child bounds checking sometimes resulted in web
content being unexpectedly returned by the hit test, even if the point
was actually over the browser chrome, e.g. a toolbar button.

AX-Relnotes: macOS accessibility feature Hover Text now works in the tab
             strip, toolbar, and bookmark bar.

Bug: 1090845
Change-Id: I649d902f8214387fe6e0930b637f2b0e85cc0649
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227865Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Brian Liu Xu <brx@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#774747}

https://android.googlesource.com/platform/external/perfetto.git/+log/84515482ba9a..6049cc3934c0

2020-06-03 treehugger-gerrit@google.com Merge "tp: switch merged metrics script to python3" am: 7d9cafd0df
2020-06-03 treehugger-gerrit@google.com Merge "tp: metatrace parser: fix counter track names" am: 84515482ba
2020-06-03 fmayer@google.com Merge "Do not associate incorrect symbol_set_id." am: 6279824654
2020-06-03 simonmacm@google.com Merge "Determine an overall view of when any wakelock was held by merging slices." am: c155bd14e3
2020-06-03 fmayer@google.com Do not use id as row number. am: fb2bd34e2d
2020-06-03 treehugger-gerrit@google.com Merge "Frame lifecycle MVP updates" am: d4d88908b1
2020-06-03 fmayer@google.com Fix RssHWM -> VmHWM in docs. am: 890735b8c8
2020-06-02 taylori@google.com Fix thread state UI bug am: 9d83693a5a
2020-06-02 treehugger-gerrit@google.com Merge "trace_processor_shell: don't quit on CTRL-C" am: a40746d976
2020-06-02 primiano@google.com Merge "ui/tp: fix race in trace-processor --httpd and improve performance" am: fc0efae149
2020-06-02 ddrone@google.com Fix a bunch of typos am: dad4850e5d
2020-06-02 simonmacm@google.com Merge "Fix time-in-state annotations." am: 09fe6260ed
2020-06-02 rslawik@google.com Merge "Handle exhaustive time_in_state snapshots" am: e6dfb1ad40
2020-06-02 treehugger-gerrit@google.com Merge "Add reached code trigger name metadata for chrome" am: 9f846603b0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I2390f7f25ce49fc0463cac834ae48fb1105cc1da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229109Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#774746}

In https://github.com/WICG/native-file-system/pull/174 the spec
for how sandboxed FS is exposed was change, this updates to
implementation to match the spec.

R=mek@chromium.org

Bug: 1081287

Change-Id: I0e381c873db98e30baed6679be048031b385cc50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220685
Commit-Queue: Hazim Mohamed <hazimmohamed@google.com>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774745}

References to assertNotReached() cause closure compilation to fail for
code using JS modules. This CL removes these generated calls at the
top of the files, and replace the calls serving as placeholders with
empty implementations.

Updates were generated using a script ./tools/json_schema_compiler/compiler.py extensions/common/api/bluetooth_private.idl --generator=interface > third_party/closure_compiler/interfaces/bluetooth_private_interface.js
and ./tools/json_schema_compiler/compiler.py extensions/common/api/bluetooth.idl --generator=interface > third_party/closure_compiler/interfaces/bluetooth_interface.js

Bug: 1045266
Change-Id: I339d41278d7390d457c94325b5be3eb9021ad2ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225816
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774744}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I02efd374b4157d332b359f821be7cee09db7dca9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229115Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#774743}

D3D12 requires that we use flip model swap chains. Flip swap chains
require that the swap chain be connected with DWM. DWM requires that
the rendering windows are owned by the process that's currently doing
the rendering.

To workaround this problem, we use gl::ChildWindowWin to create a window
that is reparented by the browser to be a child of its window.

Bug: 1071458
Change-Id: I212df12ec21f3fbc00e08b63a741b05b14771c04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223371
Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774742}

Bug: 1032584
Change-Id: Ieb33f3d457c86071ebb72b26e35281a26e27314d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214548
Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774741}

Bug: 1090818
Change-Id: I5b3d41d58ae9cfeb92582a0eae0a0abead6759cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229204Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774740}

This reverts commit 23d40ac9.

Reason for revert: https://crbug.com/1083585#c34

Original change's description:
> [geolocation] Hold queries to the mock until position is set
> 
> This is an alternate to crrev.com/c/2216317 to fix test flake in
> geolocation-api/watchPosition-page-visibility.html now that page
> visibility changes are asynchronous.
> 
> The original mock required a call to setGeolocationPosition() for every
> call by Blink to queryNextPosition(). This is a difficult invariant to
> maintain because Blink will always call queryNextPosition() after
> calling the success callback. Most tests avoided the error by marking
> the test passing during the watch position callback and so the error
> generated by the next "tick" was ignored.
> 
> The page visibility test is sensitive to this issue because the call to
> queryNextPosition() after state 2 races with the change in visibility.
> If it wins then there is no position available and the test fails.
> 
> This version of the mock allows queryNextPosition() and
> setGeolocationPosition() to be called in any order, matching up the
> request from Blink to the position update when it is available. In this
> case if queryNextPosition() is called before the visibility state change
> then it will wait for the position to be updated after the page is
> hidden. This position update will still be ignored by Blink because it
> has, at that point, already closed the Mojo connection to the
> geolocation service.
> 
> Bug: 1083585, 866140
> Change-Id: Ida2469738b19d0862c7af3870360c755c71f7e78
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219148
> Reviewed-by: danakj <danakj@chromium.org>
> Commit-Queue: Reilly Grant <reillyg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#774664}

TBR=danakj@chromium.org,reillyg@chromium.org

Change-Id: I4d53976d000322c6a6d79464181c05bfcfcf7bea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1083585, 866140
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228361Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774739}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2a1801d336fc..e18a2584ca06

2020-06-03 bmeurer@chromium.org [wasm] Use bytecode offsets instead of line numbers

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1071432
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ie8d215074446fac9d6eb3f3325930021a8236a6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229107Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#774738}

This change removes scripts from WebUI pages that aren't used anymore.

Bug: 41905
Change-Id: I9b7843e1de6402e9e1e21c7846f227d1feafb277
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224603Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#774737}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I130d9bdbc9e007522097951c5d676c883e124240
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227906Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#774736}

In https://crrev.com/751341, the DCHECK for which sequence
PrintDialogGtk::PrintDocument() runs on accidentally got negated.
As a result, it also posted a task for SendDocumentToPrinter() on the
wrong sequence.

Fix the DCHECK in PrintDocument() to match the comment right above it,
and post the SendDocumentToPrinter() task to the right sequence. To do
so, take advantage of the fact that PrintDialogGtk inherits from
base::RefCountedDeleteOnSequence(), so it already knows what sequence it
lives on. Thus it does not need a separate base::SequenceChecker.

Bug: 1082740
Change-Id: I632527fe7ae63c5ecb2bb954c50f3df62d398684
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228113Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774735}

Following bot results are included.
2384 2385 2388 2389 2390 2391 2392 2393 2394 2395 2396 2397
2398 2399 2400 2401 2402 2403 2405 2406 2407 2408 2411 2412
2414 2415

26 lines were removed and 14 lines were deflaked by consecutive
results since 2396.

TBR=yosin@chromium.org
NOTRY=true

Bug: 982194
Change-Id: I63773946c5958a4d713290d107ccd9505e738995
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217527Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774734}

The file is unused now.

BUG=b:154633986
TEST=arc.Boot[.vm]

Change-Id: I70b375feb99e47e8dc9a007265a8a2b1eca1eac0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219567Reviewed-by: Long Cheng <lgcheng@google.com>
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774733}

https://skia.googlesource.com/skia.git/+log/463d729cd6db..3fdc49f35718

2020-06-03 bsalomon@google.com Always call release procs on SkSurface GPU factories
2020-06-03 bsalomon@google.com Only set GL tex base/max MIP level if supported
2020-06-03 kjlubick@google.com [canvaskit] Speculative fix for flaky dommatrix test
2020-06-03 ethannicholas@google.com Revert "Revert "Omit dead SkSL functions""

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: tdenniston@google.com
Change-Id: Id46278d0815918a610a145e145011eecf1d74e8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229258Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#774732}

Fixes a minor copy/paste artifact in the string descriptions.

Bug: b:156774894
Change-Id: Ie1c42dd29ffbd917f3f11b575c4526e1cb56911b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228140
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Auto-Submit: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774731}

Because of crbug.com/1080691, WPT import constantly adds redundant
virtual expectations, and the warnings (though not errors) are
annoying to most developers.

Actually the virtual fallback feature was to relieve burden of
sheriffs and developers for adding duplicated virtual and base
expectations. Preventing redundant expectations is not the main goal.
Existing redundant expectations are not very harmful.

Bug: 1080691
Change-Id: Id0a4ac931d417a223d337cd260aba47ddd74395f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227454
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774730}

- Copies the clang asan library into iOS app bundles. This library is
  pulled from WebKitTestRunnerApp.app/Frameworks.

- Updates the iOS test runner to set DYLD_LIBRARY_PATH to pick up the
  clang asan library from its copied location.

- Fixes the macOS build to stop rewriting WK_API_AVAILABLE() calls, as
  this was causing compiler errors.

BUG=None

Change-Id: Ie30b40b01d3724b0d922f0edc1c39544bc251f2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228116
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774729}

TriChrome consists of {Library, Chrome, WebView}. Each of these units
can be an input to SuperSize. To get SuperSize to aggregate these into
one .size file with a common pool of symbols, we'd like to to abstract
these units as "containers", represented by the Container class, which
relates to other data structure by the following:
* A SizeInfo has 1 or more Containers.
* A Container consists of {metadata, section_sizes} (formerly in
  SizeInfo), and has a distinct name.
* Each Symbol belongs to a Container.

This CL adds the Container class to SuperSize, and rewire former usage
of {metadata, section_sizes} to go through it. Only the *single*
Container case (with name='') is handled, to simplify review and
commits.

The format of .size files is kept invariant. And as seen in .golden
file, very few changes to SuperSize-console output. A number of TODOs
are added to indicate upcoming code changes for multi-Container support.
Other changes:
* describe.py: Use itertools.chain.from_iterable() so that chained
  generators can be appended into array, instead of needing distinct
  local variables.
* diff.py: Add _DiffObj() to generalize diffing.

Bug: 1040645
Change-Id: I799c960d0510157f55876016726aa2eda25d55a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228169
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774728}

This CL deletes FakeTileProvider from java.

Bug: 1090140
Change-Id: I47c1e5a50ad8984aaf85d2f59605cef1756898d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219389
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774727}

Work is being done on shelf notification indicators as a separate
feature from context menu notifications, so create a new flag to
separate the two features.

Bug: 1080827
Change-Id: I9e6a2a20a30b692a5e9c185b904b0ff337eaad39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228189
Commit-Queue: Matthew Mourgos <mmourgos@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774726}

Using wpt-import in Chromium 66a4d901.
With Chromium commits locally applied on WPT:
f5fcca96 "Revert "[COOP access reporting] Preliminary WPT tests.""


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma@google.com

No-Export: true
Change-Id: I42faef3f10430cf6f443b0c2e8f0c2bbdffca4e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228941Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#774725}

It can be replaced with TestUkmRecorder::SetOnAddEntryCallback

Bug: 1057770
Change-Id: If49262570bfbfeb90b5d090c42ece84b804c1c5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216800Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774724}

After https://crrev.com/c/1861280 legacy supervised users are
deprecated, but some code about them was left in an unreachable clause.
Now this clause is removed.

Bug: 1090844

Change-Id: I3dc00348d659fc9231c6697d109dc7679da630d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219948Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Oleg Davydov <burunduk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774723}

The CL is fixing the issue where the IO-Thread was not receiving the
power manager notifications.

The observer list doesn't register observers without a sequence
being set.

  void AddObserver(ObserverType* observer) {
    // TODO(fdoray): Change this to a DCHECK once all call sites have a
    // SequencedTaskRunnerHandle.
    if (!SequencedTaskRunnerHandle::IsSet())
      return;

Previously, these observers were not registered and notifications
were not received.

Currently, the thread controller bind to the current thread but has
conditional code depending if the task runner is set.

  see: ThreadControllerWithMessagePumpImpl::BindToCurrentThread

  if (task_runner_)
      InitializeThreadTaskRunnerHandle();


The function InitializeThreadTaskRunnerHandle(...) is the place to make
the link between the PowerMonitor and the Controller since a
task_runner is required for power notifications.


Bug: 1074332
Change-Id: If3e652e6516fdc3df4e3ea8ace909389d668e690
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225627Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774722}

This CL fixes :
1 - A NPE in query tiles omnibox suggestions.
2 - Removed caching of TileProvider from java layer.

Bug: 1087750
Change-Id: I6977db9f862c62150d51d8a57d59a84602718df3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225515Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774721}

This completes a portion of a long-coming migration.

(TBR for mechanical changes outside of //base)
TBR=fdoray@chromium.org

Bug: 781352
Change-Id: Ia3a43684f0a5a496bd0eed30ecb49d6db1d7f96a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225921
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774720}

This CL removes the assumption that overlays are visible elements
that extend past 64px (the fixed bar height) because it does not account
for the push-down promo which can increase the height of the bar below
the 64px threshold.

This CL also removes the code that attempts to reduce the number of
overlays that are tracked by trying to find a common parent overlay that
houses child overlay elements.

Bug: b/157846704, b/157136561
Change-Id: Ibb872a4ee1c4d7f146676b124b578fe0ba80a358
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226634
Commit-Queue: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774719}

This feature flag improves support for WebXR on computers with more
than one GPU, particularly on Windows. This feature will be landed in a
series of changes.

The CL that will use this flag in Blink: https://crrev.com/c/2219780

Other relevant active CLs:
https://crrev.com/c/2216166
https://crrev.com/c/2225366
+ 1 more that will be uploaded and linked shortly

This change was also initially reviewed as one larger CL here:
https://crrev.com/c/2096778

Bug: 792657
Change-Id: Icc5b40e4d0b7aad702199ce2514573864d5e57f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226071Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Patrick To <patrto@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#774718}

Roll Chrome Mac PGO profile from chrome-mac-master-1591184865-5fd7e217cbf2739ffd4335727dd5978110d7b63d.profdata to chrome-mac-master-1591199990-53a8f554cee1144b8cf9ac7f99b06fbe1ec5521a.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:mac-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: I82f875a302543eecc40189fd9169f912826ae051
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229147Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#774717}

Previously only "PIN" was supported.

Fixed: 1090167
Change-Id: I7b1879769cebb3d3a8ab56ac67642d7ab3e799e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227510
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774716}

This reverts commit f11b606d.

Reason for revert: Did not fix the problem completely. Will check in a universal fix.

Original change's description:
> Fix spacing issue on hover cards.
> 
> Issue was caused by a previous fix for CrOS not taking hover card images
> into account. Now there is a uniform margin around preview images, as
> there was before.
> 
> Also removed a redundant SetProperty call that was overridden later in
> the same function.
> 
> Bug: 1087759
> Change-Id: I5d1ab7081f9e1195961ead27cfc365bb6e25ede8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225239
> Reviewed-by: Connie Wan <connily@chromium.org>
> Commit-Queue: Connie Wan <connily@chromium.org>
> Commit-Queue: Dana Fried <dfried@chromium.org>
> Auto-Submit: Dana Fried <dfried@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#774326}

TBR=dfried@chromium.org,connily@chromium.org

Change-Id: Ia3fa918d758687df80be358c79803413ecc9869d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1087759
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229320Reviewed-by: Dana Fried <dfried@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774715}

.... instead of WebMediaStreamTracker.

This is part of the effort to reduce the needless use of
public Blink APIs (wrappers) within renderer/modules.

BUG=704136
R=guidou@chromium.org

Change-Id: I8b89b7b715c98a3a0cf3e26707848de091732c64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228942
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774714}

Fixing the expectation so it covers all platforms where it is flaky.

Bug: 984467
Change-Id: I5daf2f5f02e6140163d659a75b74a39d24f7c3a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228137
Auto-Submit: Juanmi Huertas <juanmihd@chromium.org>
Reviewed-by: Yi Xu <yiyix@chromium.org>
Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774713}

This CL moves AccountManagerTestRule to the package of SigninTestUtil
so we can use SigninTestUtil.signIn/signOut methods in the rule later.

Bug: 1004418
Change-Id: I82204f8661ecda00ebbf1e741ce7ae5bec793a95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209214Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774712}

Generate UkmEventNameHash histogram enum automatically from ukm.xml if
and only if ukm.xml path is provided. Also, add some unit tests for the
merge_xml.py.

Bug: 1087533
Change-Id: Ibef6dc02644d49dcb3c9b132e93fd72c759f505d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224597Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Auto-Submit: Weilun Shi <sweilun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774711}

As a step towards improving spellcheck initialization performance,
with the ultimate goal of not loading the Windows spellcheck platform
DLLs until needed (e.g. when actually performing a spellcheck), this
CL adds a new feature flag allowing the initialization of the
spellcheck service on browser startup to be prevented. This should
allow addressing the rest of the performance issue in stages.

Since Chromium already by default initializes the spellcheck service
on startup for custom dictionary synchronization, the command line
for launching the browser with Windows hybrid spellchecking enabled
but no initialization of the spellcheck service is:

chrome --enable-features=
WinUseBrowserSpellChecker,WinDelaySpellcheckServiceInit
--disable-sync-types="Dictionary"

Downstream Edge has Windows spellcheck enabled by default and does
not perform a custom dictionary sync, so the corresponding command
line for Edge is:

msEdge --enable-features=WinDelaySpellcheckServiceInit

Bug: 1064351
Change-Id: I91559193918cce6895133a9e9c440513b55fdd65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227450Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Guillaume Jenkins <gujen@google.com>
Commit-Queue: Bruce Long <brlong@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#774710}