GitLab

For the record, the layout was broken due to the two changes:

http://src.chromium.org/viewvc/chrome?view=rev&revision=71836
caused each language name to have a weird button-like shadow.

http://src.chromium.org/viewvc/chrome?view=rev&revision=72085
broke the two-column layout.

BUG=crosbug.com/11241
TEST=on chrome os, open the language selection overlay. confirm that the layout is nice.

Review URL: http://codereview.chromium.org/6393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72472 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6134003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72471 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=tony.chromium,rniwa

Review URL: http://codereview.chromium.org/6371012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72470 0039d316-1c4b-4281-b951-d872f2087c98

Pass user agent to InvalidationClientImpl as client_info.

Pick up fix for bug that was causing increased server traffic.

BUG=70674
TEST=none

Review URL: http://codereview.chromium.org/6310015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72468 0039d316-1c4b-4281-b951-d872f2087c98

Currently chromeos::InputMethodMenuButton is derived from both StatusAreaButton and InputMethodMenu, which violates the Chrome coding guideline. This change removes the multiple inheritance by adding InputMethodMenu object to InputMethodMenuButton as a member variable.

BUG=chromium-os:7572
TEST=manually & try bot

Review URL: http://codereview.chromium.org/6262012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72467 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=tony.chromium,rniwa

Review URL: http://codereview.chromium.org/6248018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72466 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6268013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72465 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none



Review URL: http://codereview.chromium.org/6321019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72464 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tony,yuzo

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72460 0039d316-1c4b-4281-b951-d872f2087c98

BUG=67101

Review URL: http://codereview.chromium.org/6327017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72459 0039d316-1c4b-4281-b951-d872f2087c98

[SYNC] Speculative fix for autofill change processor destroying on the wrong thread. The data type manager should now tell any datatype controller that is not already stopping or not running to stop. Namely, this covers the MODEL_STARTING and ASSOCIATING cases, which weren't being covered before. Tests that can reproduce these race conditions still needed.

BUG=61804
TEST=unit,sync_integration,self

Review URL: http://codereview.chromium.org/6273011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72458 0039d316-1c4b-4281-b951-d872f2087c98

This CL assumes keyword query is always synchronous.

BUG=70527
TEST=See bug report.

Review URL: http://codereview.chromium.org/6281011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72457 0039d316-1c4b-4281-b951-d872f2087c98

[linux] When the user has the notification options menu, delay system-initiated closing of the notification.

BUG=51177
TEST=open the notification options menu on a notification which will be auto-closed by the page.

Review URL: http://codereview.chromium.org/6273010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72456 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:10180, chromium:70450, chromium:70451
TEST=Verified strings and link were changed.

Review URL: http://codereview.chromium.org/6314014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72455 0039d316-1c4b-4281-b951-d872f2087c98

Cached forms might not match submitted forms, but the logging code had been assuming that they always do.

BUG=70374
TEST=unit_tests --gtest_filter=AutoFillMetricsTest.SaneMetricsWithCacheMismatch

Review URL: http://codereview.chromium.org/6259017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72453 0039d316-1c4b-4281-b951-d872f2087c98

Disable IndexedDBBrowserTest.TransactionTest and IndexedDBBrowserTest.DoesntHangTest on all platforms because they're now causing crash and/or hang on Mac.

TBR=jorlow, japhet, andreip
BUG=70665

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72452 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=green tree
TBR=tfarina

Review URL: http://codereview.chromium.org/6264014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72449 0039d316-1c4b-4281-b951-d872f2087c98

(A second try after being reverted.)

Review URL: http://codereview.chromium.org/6279009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72445 0039d316-1c4b-4281-b951-d872f2087c98

time_slice_hrs is being used uninitialized at line 459, and this was causing a Run-Time Check failure and crash in Debug versions on Windows.

I don't know whether 0 is the the correct value in this case, but this fixes the crash. mirandac@ will need to review the behavior.

BUG=None
TEST=Run debug version of Chrome on Windows and wait a few seconds.
Review URL: http://codereview.chromium.org/6385004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72444 0039d316-1c4b-4281-b951-d872f2087c98

UI Layout tests are not flaky, so delete the FLAKY label from
linux and windows.

BUG=56364
TEST=test no longer marked flaky
TBR=scherkus

Review URL: http://codereview.chromium.org/6324010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72442 0039d316-1c4b-4281-b951-d872f2087c98

Page title can leak privacy information hence we don't really want it.

BUG=66716
TEST=Sent a report to confirm page title is no longer being sent.

Review URL: http://codereview.chromium.org/6366007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72441 0039d316-1c4b-4281-b951-d872f2087c98

Pritchard for suggesting these mappings.

Review URL: http://codereview.chromium.org/6372012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72440 0039d316-1c4b-4281-b951-d872f2087c98

Windows-native implementation of the TTS API.

BUG=none
TEST=manual testing

Review URL: http://codereview.chromium.org/6249014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72439 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70631
TEST=none

TBR=kkania@chromium.org

Review URL: http://codereview.chromium.org/6317013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72438 0039d316-1c4b-4281-b951-d872f2087c98

which would cause crashes if multiple instances were loaded.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=70602

BUG=70602
TEST=As described in the bug report.

Review URL: http://codereview.chromium.org/6373010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72434 0039d316-1c4b-4281-b951-d872f2087c98

BUG=65547, chromium-os:9559
TEST=none

Review URL: http://codereview.chromium.org/6269016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72433 0039d316-1c4b-4281-b951-d872f2087c98

It seems this file was left when all the other animation files were moved
to ui/base/animation/.

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/6376010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72432 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=NaCl SDK pi_generator example encounters this
Review URL: http://codereview.chromium.org/6384009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72430 0039d316-1c4b-4281-b951-d872f2087c98

Dropped the DCHECk since it seems some Windows version don't initialize the unused variable.

BUG=27400
TEST=none

Review URL: http://codereview.chromium.org/6242011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72429 0039d316-1c4b-4281-b951-d872f2087c98

The other layout files under views directory will be moved later.

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/6360014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72428 0039d316-1c4b-4281-b951-d872f2087c98

because they seem to be causing the entire browser test to hang or crash.

BUG=70665
Review URL: http://codereview.chromium.org/6339010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72427 0039d316-1c4b-4281-b951-d872f2087c98

45s until first TCP Keep-Alive and 45s in between keep alives.

BUG=27400
TEST=Run Wireshark, make sure TCP Keep-Alive packets are sent.

Review URL: http://codereview.chromium.org/6300013

TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/6371010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72426 0039d316-1c4b-4281-b951-d872f2087c98

This is to pick clang warning / miscompile fix in r760.

r756, 757, 758 were edits to the breakpad wiki, not code changes.

r759 added a new file to libreakpad.a on linux

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6357016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72424 0039d316-1c4b-4281-b951-d872f2087c98

flag in https://bugs.webkit.org/show_bug.cgi?id=53041 .
ENABLE_3D_CANVAS will be removed once we roll WebKit past the landing
of the upstream patch.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6256013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72423 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Test Cloud Print Proxy.

Review URL: http://codereview.chromium.org/6356007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72422 0039d316-1c4b-4281-b951-d872f2087c98

45s until first TCP Keep-Alive and 45s in between keep alives.

BUG=27400
TEST=Run Wireshark, make sure TCP Keep-Alive packets are sent.

Review URL: http://codereview.chromium.org/6300013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72421 0039d316-1c4b-4281-b951-d872f2087c98

Make new chrome UI security model the default.

allows us to update URL in chrome://settings when the user navigates within it.

BUG=57485
TEST=manual

Review URL: http://codereview.chromium.org/6277018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72420 0039d316-1c4b-4281-b951-d872f2087c98

Moved bodies of test functions into .cc files.

Remove sync_service() accessors from various model associators.

Renamed GetUserShareHandle to GetUserShare() and removed typedefs for its return types.

Added plenty of TODOs for future improvements.

BUG=None
TEST=unit_tests

Review URL: http://codereview.chromium.org/6375007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72419 0039d316-1c4b-4281-b951-d872f2087c98

Avoids throwing an exception when git isn't installed.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72418 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70344
TEST=See bug report.

Review URL: http://codereview.chromium.org/6380012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72417 0039d316-1c4b-4281-b951-d872f2087c98