- 25 Sep, 2019 40 commits
-
-
Julie Jeongeun Kim authored
This CL converts WebCachePtr and WebCacheRequest to new Mojo types using Remote, ReceiverSet and PendingReceiver. Bug: 955171 Change-Id: Ie26db230a04880aca1fe6be076ae43ae01dfc492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818881Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#699612}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I9755b9e01f3afb1cb7257d05dabf209084eedfe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824282Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699611}
-
Emircan Uysaler authored
vkGetDeviceQueue2 is the prefferred way to pass flags to queue creation. Bug: 982922 Change-Id: I6320c17b5b9d345b3d4a312f0b91c09618bfdb73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817098Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#699610}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6bb573380e0c..b079ab860152 git log 6bb573380e0c..b079ab860152 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 dberris@chromium.org Pinpoint: Query failovers not supported in transactions Created with: gclient setdep -r src/third_party/catapult@b079ab860152 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:1006888 Change-Id: I412d900850666d5ce3bdf626e56e250ff93ded7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824281Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I51308e06b84dcacd4e4f095f78e0f9240ebb1a67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824541Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699608}
-
rajendrant authored
These record http scheme specific histograms and are not neeed. Bug: 673609 Change-Id: I3351fe9b2432cd27f9111d104e26dbf6b443b105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817327Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#699607}
-
Kouhei Ueno authored
This CL adds RenderFrameHostImpl::dom_content_loaded() to query if the frame has reached and fired DOMContentLoaded event. Specifically: - FrameHostMsg_DidFinishDocumentLoad is now routed through RenderFrameHostImpl and dispatched to RenderFrameHostDelegate::DOMContentLoaded. Previously the message itself was intercept by WebContentsImpl. - RenderFrameHostImpl::dom_content_loaded_ is set to false at the start of loading, and flipped to true on receiving FrameHostMsg_DidFinishDocumentLoad. Bug: 1002345 Change-Id: If6069dc8486a3f86bb749a07f96cac9c8812644a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792517 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Lowell Manners <lowell@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#699606}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/c3b613296d26..05be0ff34815 git log c3b613296d26..05be0ff34815 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 jiawei.shao@intel.com Validate fragment output location doesn't exceed kMaxColorAttachments Created with: gclient setdep -r src/third_party/dawn@05be0ff34815 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: Ia3769eeb6050236215959e8a0a800694a007f573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824029Reviewed-by:
-
Maggie Cai authored
Currently the data_scheme entry is not parsed for the ARC intent filter. Parse it to get the scheme data from ARC. The reason for doing this is to allow the Chrome has all the scheme and url information so that we can handle the intent query in Chrome instead of sending them to ARC. This CL doesn't update the Match algorithm for the filters. Modifying the Match algorithm and the corresponding unit test in a follow up CL. BUG=853604 Change-Id: I93af12d0db4f48abd3017dbfb4a9e36a0214b7d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818002 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#699604}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d48cbf934536..7211cf64444c git log d48cbf934536..7211cf64444c --date=short --no-merges --format='%ad %ae %s' 2019-09-25 robliao@chromium.org Import gclient_utils for gclient_paths CheckCallAndFilter Created with: gclient setdep -r src/third_party/depot_tools@7211cf64444c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1007553 Change-Id: I5217718117ac8a7ea5e7270e051239c80b3a5073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823649Reviewed-by:
-
Brandon Maslen authored
In some scenarios a document's TopFrameOrigin may be empty. This change ensures that this case is handled correctly during hasStorageAccess() calls. Bug: 1005778 Change-Id: Ic00cf3fcca143e83e277ca43835480c8d31536ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814726 Commit-Queue: Brandon Maslen <brandm@microsoft.com> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#699602}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/af3fdc069d52..fc604aa990d5 git log af3fdc069d52..fc604aa990d5 --date=short --no-merges --format='%ad %ae %s' 2019-09-24 mellem@webrtc.org Unset sinks when deleting CompositeDataChannelTransport. 2019-09-24 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision ae812cd8..f24b5ede (699366:699513) 2019-09-24 mellem@webrtc.org Reland "Reland "Refactor SCTP data channels to use DataChannelTransportInterface."" 2019-09-24 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9f21b695..ae812cd8 (699240:699366) 2019-09-24 srte@webrtc.org Replacing bandwidth adaptation trial with stable target in Opus encoder. 2019-09-24 srte@webrtc.org Adds abs-send-time and size field outputs to event log parser. 2019-09-24 jakobi@webrtc.org Support 2 byte payload size DTX packets in NetEq simulation. 2019-09-24 kron@webrtc.org Remove deprecated method Created with: gclient setdep -r src/third_party/webrtc@fc604aa990d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None,chromium:none,chromium:None Change-Id: I71c6299f9b394e1ac3c98b51c2a402ae56113638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823904Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c38bb894..92a0888e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2495c89e03a5175d2ed6a57388e615f95646df71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824359Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699600}
-
Chih-Yu Huang authored
BUG=none TEST=autoninja video_decode_accelerator_tests on Eve and Kevin Change-Id: Ic0e4125335bc4e8cdb8baa8232d7b5c989d02c9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820919 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#699599}
-
Jiawei Shao authored
This patch is the first one to support creating GPUDevice with extensions. In this patch we implements requesting a WebGPU adapter with options. Now we only support "powerPreference" as an option to request an adapter. The option is treated as an enum and passed from Blink to the WebGPU command buffer to create a Dawn adapter. The "high-performance" adapter refers to the discrete GPU, and the "low-power" adapter refers to the integrated GPU. The default adapter will be the one that refers to the discrete GPU. BUG=chromium:996713 Change-Id: Iffb98410cf2a2d6d4eb127bdd09a0886099db127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794033Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Cr-Commit-Position: refs/heads/master@{#699598}
-
James Cook authored
https://chromium-review.googlesource.com/c/chromium/src/+/1815957 merged the Google Play Store settings into the top-level Apps section. This removed the ANDROID_APPS route, so the existing tests can't provide coverage. This CL rewrites the tests of the Android apps sub-page so they construct the sub-page directly, rather than trying to click to navigate to it. This avoids the problem with the ANDROID_APPS route, and may help with the flakiness that caused the tests to be disabled in the first place. Bug: 1004583, 1006662 Test: browser_tests Change-Id: I9e22a1c4a90163b1c3093e5ec1648e62f7e4a61f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824020 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#699597}
-
Gyuyoung Kim authored
This CL applies pending_receiver to CreateNetLogExporter in NetworkContext interface. StrongBindingSet is converted to UniqueReceiverSet in this CL. Bug: 955171 Change-Id: I72331247e92e6499b531a95c7f3dbd22ac97cc07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817998 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
-
Andrey Kosyakov authored
.. there's no reason to do it on IO and it lets us simplify things a bit. This removes DevToolsURLLoaderInterceptor::Impl and moves most of its methods and members to DevToolsURLLoaderInterceptor itself, resulting in former Impl methods being run directly on the UI thread. Bug: 1005281 Change-Id: I8193b43edbedcdfecad2541cd905c2c1ea2136ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815083Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Johannes Henkel <johannes@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#699595}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f050422f3285..e78a5c860aa4 git log f050422f3285..e78a5c860aa4 --date=short --no-merges --format='%ad %ae %s' 2019-09-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-24 fmalita@chromium.org [skottie] Disable skottie_tool on iOS 2019-09-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@e78a5c860aa4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: None Change-Id: I85585bcbb418c39ef02f516b8e33b5d8a04f4f0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823883Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium bb12635c. With Chromium commits locally applied on WPT: d4ca0e6e "Add missing worklet referrer tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I39145b8ae93db46efcd2c36be7455c21bf2e047f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823623Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699593}
-
Philip Rogers authored
This patch removes the pre-PaintNonFastScrollableRegion codepaths now that PaintNonFastScrollableRegions is shipping in M78. For more information, see the PaintNonFastScrollableRegion one pager: https://docs.google.com/document/d/1IyYJ6bVF7KZq96b_s5NrAzGtVoBXn_LQnya9y4yT3iw Bug: 864567 Change-Id: Ia73b79a57e4fa96b77433c48a266890135e6269b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822823 Commit-Queue: David Bokan <bokan@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#699592}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6c18ff9d2103..7628361f558a Created with: gclient setdep -r src-internal@7628361f558a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:996088,chromium:b/139510801,chromium:None,chromium:1000513 Change-Id: I8b1bfcaa9f906f42e089c881bb88c21af15a8592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824075Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699591}
-
Chris Palmer authored
This reverts commit 8ee0e773. Reason for revert: Performance regression (Bugs: 1006176, 1005678, 1005677, 1005248, 1005068, 1005066, 1006178, 1006071) Original change's description: > [Partition Alloc] Probabilistically poison memory on free. > > We do it unconditionally in DCHECK builds to catch bugs, but let's occasionally > do it in release builds too. Frequency is tunable. > > This is a re-land of > https://chromium-review.googlesource.com/c/chromium/src/+/1761578, which was > reverted in https://chromium-review.googlesource.com/c/chromium/src/+/1797642. > > Bug: 984742 > TBR: haraken > Change-Id: I8f9a36389b2d58f6a11b324b59dd47727e4b91fb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808181 > Reviewed-by: Chris Palmer <palmer@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Chris Palmer <palmer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697013} TBR=palmer@chromium.org,haraken@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 984742 Change-Id: Ica990f0b07ac74034e049bcd507cc7d515429057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824074Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#699590}
-
Nick Burris authored
Implement the newly proposed fragment directive delimiter :~:. This delimiter behaves the same as the previously implemented ## delimiter, but is valid by URL spec and thus should be a better option. For now, both delimiters are supported, but the ## delimiter will be removed for M79 once we confirm we want to use :~:. Bug: 1007016 Change-Id: Icd732d27ccc3a7591617735afee9d14d5d1c68f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822512 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
-
Manu Cornet authored
See the spec at https://guidelines.googleplex.com/crosux-spec/feature-specs/shelf-tablet.html#shelf-tablet-home ("in-app shelf"). Bug: 982512 Change-Id: Ie152168d734457ba735b73b4c1514c975ea15a4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824358 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#699588}
-
Luciano Pacheco authored
This reverts commit 589d0717. Reason for revert: We believe this is fixed on crbug.com/1004639. We'll monitor the bots. Original change's description: > Disable flaky PlatformUtil tests. > > When these two tests are run together, one always fails. MSAN reveals > that there is some use-after-free in these tests. Disable them for now. > > Recent flakiness: https://ci.chromium.org/p/chromium/builders/try/linux-chromeos-rel/384207 > Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=unit_tests&tests=PlatformUtilPosixTest. > > TBR=avi@chromium.org > BUG=1007240 > > Change-Id: I961d3ed160821bd82299944cba2e827887fad7bd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821700 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Commit-Queue: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#699316} TBR=avi@chromium.org,dominickn@chromium.org Change-Id: I4c11f5b55fbded03a1d2f1af4f3e0a4ed3fab590 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1007240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824518Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#699587}
-
Gavin Williams authored
-New public method for checking users in UsersPrivate API -Add a new private method just for checking if a user is part of the user list since two methods need the same functionality. -New test includes a negative test for not finding a user + a positive test after a user is added and searched for. Bug: 768798 Change-Id: I8ec2ca524549fbd8dd9a0813a7bf7777fe7ed2d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786862 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#699586}
-
Xida Chen authored
This CL make the frame sequence tracker reports an aggregated metric for both compositor + main thread. At this moment, it reports the worse throughput between the compositor vs main thread. Unit tests are added. Bug: 1002994 Change-Id: I777c68ea04929e287a91cf82160818be34e36f45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801921Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#699585}
-
Peter Kasting authored
As with ScrollBarViews, this can just size the thumb extra-large and rely on ScrollBar::Update() to do the real sizing. To facilitate this, override GetInsets() to convert GetContentsBounds() into the same thing as GetTrackBounds(), then use a FillLayout. Also reorders functions to match superclass order and access level. Bug: 1005568 Change-Id: Iad7fed5501adcf301ac66f9390c2545a6e00c827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824028 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#699584}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/88f927df3528..6bb573380e0c git log 88f927df3528..6bb573380e0c --date=short --no-merges --format='%ad %ae %s' 2019-09-25 dberris@chromium.org Pinpoint: Handle all Datastore errors in migration Created with: gclient setdep -r src/third_party/catapult@6bb573380e0c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:1006888 Change-Id: I8bacd1f6f6cb65ad9a229a0762ffd1f3b969b5f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823701Reviewed-by:
-
Yuwei Huang authored
This CL implements a notification client for mobile clients to fetch notification from gstatic. Currently it only has logic to match rules and select a notification. It isn't connected to gstatic or any UI component yet. Bug: 1001291 Change-Id: I2d58b53363b1db0b9bb836dfcfb5ec2a36126d19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812398 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#699582}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/10cf66556532..cc3f09861685 git log 10cf66556532..cc3f09861685 --date=short --no-merges --format='%ad %ae %s' 2019-09-24 nicolascapens@google.com Merge changes Ic33110f9,I538566c6 Created with: gclient setdep -r src/third_party/swiftshader@cc3f09861685 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: If09574b2664315f727afda70dd2acb06e788a723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824183Reviewed-by:
-
Ryo Hashimoto authored
WeakPtr must be dereferenced on the same thread/sequence. BUG=1003950 Change-Id: Ic6f69b3974ea3bca0f3af1ca0bb3cc051c7156fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821497Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#699580}
-
chrome://media-app-guestTrent Apted authored
https://crbug.com/1005726 requires us to use a GIT repo to host compiled assets rather than a CIPD package. The CIPD is installed to a subfolder of that GIT repo, so update the .grdp paths to point at this subfolder instead of the repo root. https://crrev.com/i/1835288 adds the DEPS change. Tested with MediaAppUIBrowserTest.GuestCanLoad and enable_cros_media_app = true. Bug: 996088 Change-Id: I2ab0395ed5b76faa47c23273d903d8dc68bf1761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824301Reviewed-by:
-
Dana Fried authored
WebContents are not immediate aware they're being deleted, so can still send updates for a short window between removal from the tabstrip and deletion. We need to not process updates on stale WebContents objects, however, and in fact that can cause a crash in TabStripModel. After some discussion (see attached bug) we have decided to apply this spot fix and create a longer-term issue to address the underlying cause (see crbug.com/1007379). Bug: 993739 Change-Id: Ia16a065edc7bba19f6b1314037e464a43e931c51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774959 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#699578}
-
Ella Ge authored
This CL adds support for pointerlock unadjusted movement on Windows behind flag. The api is added at crrev.com/c/1764943 behind flag. (design doc: https://docs.google.com/document/d/1vvnthXjzfZXiAx7ih-mVhGc_YJ8-_rtlAhIn8i6_6nM/) When entering pointer lock, if is requesting unadjusted movement, use |RegisterRawInputDevices| to listen to WM_INPUT messages, and set the |use_wm_input_| to true. When unlock, remove mouse as raw input device are reset the bit. When |use_wm_input_| is true(in lock and unadjusted movement mode), convert WM_INPUT messages into ET_MOUSE_MOVED events as they are representing mouse movements. The move/drag events from WM_MOUSE are suppressed. Since WM_INPUT messages do not have coordinates, use current mouse positions as the event coordinates so that there is no jump when switching between normal events and raw movement events. This CL adds a field movement_ in ui::MouseEvent to store the raw mouse movement info from the mouse raw input event. This field only valid if the event has EF_RAW_MOVEMENT flag set. Bug: 982379 Change-Id: Ia6e5969717917bbefc0579b5ed587a68df4b26ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769518 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#699577}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4fc8f1f8fe0e..8b16ac056b1a git log 4fc8f1f8fe0e..8b16ac056b1a --date=short --no-merges --format='%ad %ae %s' 2019-09-24 mikenichols@chromium.org chromeos_config: Move stable boards back to important Created with: gclient setdep -r src/third_party/chromite@8b16ac056b1a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I27bcdc2193d1c44604ff183d28a532babc987147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824003Reviewed-by:
-
John Budorick authored
Tbr: agrieve@chromium.org Bug: 1007403a Change-Id: I07cf5852dfcebbe2b0615cf361141ab2f4ea7eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822507 Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#699575}
-
Mohsen Izadi authored
VideoTestEnviroment sets up ozone for ui and gpu in the same process/thread. So, it should set InitParams::single_process to true. BUG=998113 TEST=./video_decode_accelerator_tests on eve Change-Id: Iad080267aa471c986721c471f2f5a1dd5b2f34d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822662 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/01f7e545a37e..273175cdf44e git log 01f7e545a37e..273175cdf44e --date=short --no-merges --format='%ad %ae %s' 2019-09-24 jmadill@chromium.org Fix Regex in DebugShaderPrecisionTest. 2019-09-24 jmadill@chromium.org Add SwiftShader to command line arguments. 2019-09-24 ianelliott@google.com Vulkan: Enable many GLES 3.1 Debug API tests to run/pass. 2019-09-24 jmadill@chromium.org Reduce logging in feature_support_util. 2019-09-24 jonahr@google.com Update GL state tracking on VertexArrayGL::streamAttributes 2019-09-24 jmadill@chromium.org Vulkan: Use ResourceUse to track object lifetime. Created with: gclient setdep -r src/third_party/angle@273175cdf44e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: None Change-Id: I4a62486b376b7bac4f303cc5e19fc91f77c4bba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823665Reviewed-by:
-
