GitLab

Bug: None
Change-Id: I4bff537460b3e34a95631691d708af959f90d6d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540091
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644484}

Removing out of date info in the change and will add the email lists once we figure out which ones to use.

R=benhenry@chromium.org

Bug: 909866
Change-Id: I06c559e430716b41af94859f1135e2fff10201e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540087Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Ushesh Desai <ushesh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644483}

Windows was not allowing copying of the temp file while it was still
open.  However, calling close by default causes the file to get deleted
automaticaly.  This defers that deletion.

Change-Id: I8ce712a4eb3de9d4d14f43389d341b016a64bae1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539871Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644482}

ChromeVox used a tree path based recovery strategy to work around issues on google.com
(see crbug.com/885244).
https://chromium-review.googlesource.com/c/chromium/src/+/1534283

As of
https://chromium-review.googlesource.com/c/chromium/src/+/1889165
the above issue seems to have been resolved without using tree path based recovery. Revert ChromeVox back to using ordinary ancestry recovery.

Bug: 945708
Change-Id: I6b8599d2daf42bc1bad036b911fa77d802e66451
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539262Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644481}

Opens the last tab when clicked. Uses the BrowsingHistoryBridge to
query the history for the last browsed to URL.

first launch/history clear:
https://screenshot.googleplex.com/k0WpTH5e0Vt.png

after click:
https://screenshot.googleplex.com/VrtPDrcQs9Y.png

Bug: 936052
Change-Id: Ia1c138d0a88d90ebe92589cc37e5e09ca7a6ade1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520884
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644480}

SkiaRenderer is ignoring the flag |force_anti_aliasing_off_| in
RenderPassDrawQuad and SolidColorDrawQuad. Check for this flag and turn
off AA if it is present.

The pixel tests also expect alpha blending to be disabled if this flag
is present, so use blend mode kSrc instead of kSrcOver.

This fixes the tests RenderPassDrawQuadForceAntiAliasingOff and
SolidColorDrawQuadForceAntiAliasingOff for SkiaRenderer, so enable them.
Also enable TileDrawQuadForceAntiAliasingOff and SolidColorDrawQuad,
which are passing after other changes.

Bug: 939442
Change-Id: Ifd4092bbeb9925f0db3a1b25a51785755e06b272
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529296Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644479}

Previously we created validation message overlay page during main page
lifecycle update, and Microtask::PerformCheckpoint() called when the
overlay page FinishedParsing would execute some micro task of the
main page in wronglifecycle state.

Now create validation message overlay page when the overlay is created.

Bug: 945451
Change-Id: I618cd7ffe8c59cfee0b45452dc8dd9c0ee2e2fd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536992
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644478}

Previously, we skipped the match classification process if
user_input_in_progress_ was false and we were not in Query in Omnibox
mode.

Actually, we can always skip the classification process if
user_input_in_progress_ is false.

This CL implements that slight optimization.

Bug: NONE
Change-Id: Iabde52481e199b60874434f034733f7275af8f92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534282Reviewed-by: Kevin Bailey <krb@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644477}

RenderPass's opacity need to be applied as last step. This is for
refection filter case where we expect the opacity to be applied to the
combination of original and reflected content. This is done by applying
the opacity as a color filter.

Bug: 908951
Test: layout tests compositing/reflections/reflection-opacity.html
Change-Id: I84226726b6cae0e294d6409d3e8e93f38648c867
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534140Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: weiliangc <weiliangc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644476}

Most thumbnail-related tasks are now CONTINUE_ON_SHUTDOWN to avoid the
case where, for example, a JPEG compression that we don't care about
could briefly hold up browser exit.

Bug: 928954
Change-Id: Ice6a100765be46dd555c38f0d2ce2043e85da340
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1537649Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644475}

When traversing down the AXTree, we expose the tree
- views::View
  - content::RenderWidgetHostViewCocoa
This tree is set up in the (strangely idiosyncratic) function
WebView::GetNativeViewAccessible, which directly adds the result of
RenderWidgetHostView::GetNativeViewAccessible as the accessibility
element for views::WebView.

When traversing up the AXTree, we expose a different tree
- views::View
  - content::WebContentsViewCocoa
    - content::RenderWidgetHostViewCocoa
This is from RenderWidgetHostViewCocoa having the default parent
value (its superview) and WebContentsViewCocoa returning the parent
specified by NativeViewHostMac::GetAccessibilityElement.

Make this consistent by removing WebContentsViewCocoa from the tree,
and moving all AXTree stitching code and tests over to
RenderWidgetHostViewCocoa.

While in the neighborhood, move SetParentUiLayer from
RenderWidgetHostViewBase to RenderWidgetHostViewMac.

Bug: 921109 (sort-of)
Change-Id: Iac4edd109f341f50d7327d3a5500d22594685ce3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538598Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644474}

Mark external/wpt/content-security-policy/frame-ancestors/frame-ancestors-nested-cross-in-same-star-allow.html as timeout on mac10.13

TBR=pkasting@chromium.org

Bug: 945774
Change-Id: I27fdc5ea15dd225b531b412a0cb73e689939a7a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540088Reviewed-by: Sahel Sharify <sahel@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644473}

This removes the need for ReportingServiceProxyPtrHolder altogether,
which is removed.

This is part of a larger effort to refactor the reporting code in Blink.

Bug: 931863
Change-Id: I1668ca1b6761ef2fd485bb06fe3743f29fde362b
TBR: foolip@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534573
Commit-Queue: Paul Meyer <paulmeyer@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644472}

https://skia.googlesource.com/skia.git/+log/e4ad58a4e2c1..b23aee3431c0


git log e4ad58a4e2c1..b23aee3431c0 --date=short --no-merges --format='%ad %ae %s'
2019-03-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-03-26 robertphillips@google.com Revert "Fix bug in GrResourceAllocator's intermediate flushing"
2019-03-26 robertphillips@google.com Fix bug in GrResourceAllocator's intermediate flushing
2019-03-26 brianosman@google.com Convert GrPorterDuff test from NullGL to Mock context
2019-03-26 brianosman@google.com Run GrTextureMipMapInvalidationTest on rendering contexts
2019-03-26 brianosman@google.com Convert some unit tests from NullGL to Mock context
2019-03-26 rmistry@google.com Detect and fail when invalid SKPs are created by RecreateSKPs bot
2019-03-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-03-26 rmistry@google.com Fix RecreateSKPs bot page sets


Created with:
  gclient setdep -r src/third_party/skia@b23aee3431c0

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:942538,chromium:942538
TBR=stani@chromium.org

Change-Id: I42e6e9fa8627b8fb8335b9dcd6063dae3d4cc3e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540041Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#644471}

Bug: 861752
Change-Id: Ie6cb88165e5aa4131ab6c387ff81017cca67eec4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539872
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Auto-Submit: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644470}

Bug: b/120907590
Test: Manual
Change-Id: I922288b91c476d8107fa4188a42e551da4716f33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531465
Commit-Queue: Junbo Ke <juke@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644469}

Will be used to implement a scrollview that does not extend beyond the
boundaries of a widget with rounded corners. Necessary because
scrollviews paint on a layer so they will paint over the parent view's
bounds. Also similar code creating rounded backgrounds happens in a
bunch of places in the codebase and could be simplified to use a single
common background factory method (example: bubble background code).

Change-Id: Ie885ca9f71f2722680e6fb709fe3091e71ad88fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524910
Commit-Queue: Sajad Maysam <sajadm@google.com>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644468}

When a page makes a 'POST' XHR request, and then sends a typed array as
binary data, there is no request content type.

If the user, then exports the contents of the network tool to a HAR
file, the postData section is missing the mimeType field. HttpWatch
requires the MimeType field, otherwise it treats the file as if its
incorrectly formatted.

The fix is to ensure we always generate the mimeType field for the
postData section.


Change-Id: Id110887fac50057ccab7a257a8de770a9d92b03c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535348
Commit-Queue: Mike Jackson <mjackson@microsoft.com>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644467}

Bug: 902349
Change-Id: Ie6289a5fb4331e68f8da840de11fd53aca0e2c51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539978Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644466}

This reverts commit 43d39c4b.

Reason for revert: Speculatively re-enable after  https://chromium-review.googlesource.com/c/chromium/src/+/1536801

Original change's description:
> Disabled BackgroundTracingManagerBrowserTest on Android.
> 
> Flaky on Android.
> 
> Bug: 945516
> Change-Id: I9566206394483cb11aebc029321d87f50ace1f29
> Tbr: dsinclair@chromium.org
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538882
> Reviewed-by: Justin DeWitt <dewittj@chromium.org>
> Commit-Queue: Justin DeWitt <dewittj@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#644052}

TBR=dsinclair@chromium.org,dewittj@chromium.org

Change-Id: I8bd035f487c59500ba9b8dd90e8901f81b2349b7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 945516
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540297Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644465}

https://chromium.googlesource.com/angle/angle.git/+log/da37e7f6759d..72cc2eaafdec


git log da37e7f6759d..72cc2eaafdec --date=short --no-merges --format='%ad %ae %s'
2019-03-26 ynovikov@chromium.org Suppress dEQP-GLES31.functional.atomic_counter.* on Win7 NVIDIA D3D11


Created with:
  gclient setdep -r src/third_party/angle@72cc2eaafdec

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:943312
TBR=jonahr@chromium.org

Change-Id: I53e6bc28c87c533606bb546683138151f4dd772f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1537653Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#644464}

The bug is marked closed. Remove the suppressions so we'll catch future
base::CommandLine races.

Bug: 334140
Change-Id: Ia5492467222cfcfb4508d62aef9136b932347171
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539787
Auto-Submit: David Benjamin <davidben@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644463}

Also use autoninja for the chrome target so that goma builds use
reasonably high parallelism.

R=robliao@chromium.org

Bug: 944686
Change-Id: Ie496983082273832172ee0f136781665aed4cb1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540078Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644462}

Chromium screenshot: https://drive.google.com/file/d/1uNLiVaDEFTHzU5_NFkzzVffwyr-x2FCq/view?usp=sharing

Bug: 931812
Change-Id: Ie5b821530bd15efeb7e9b30389fec8e74fdbfc0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530115Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644461}

TBR=tangltom@chromium.org,pkasting@chromium.org,droger@chromium.org

Bug: 945848
Change-Id: I9045c04fb7f0875f4c0a1225502a65d9581445ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540083Reviewed-by: Sahel Sharify <sahel@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644460}

This changes the trigger for key functions IPH from onPageLoadFinished
to onPageLoadStarted.

Related discussion: https://docs.google.com/a/google.com/presentation/d/1c-aVSZ_zsBuzCwQ4CrBJppmRQjiupa6PXmlC2OS-F-Q/edit?disco=AAAACv_xdz8

Bug: 924748
Change-Id: Ie0e0e20a9b2a92b32db3cd2ea240133dcac4f2cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539867Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644459}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=cmasso@chromium.org

Change-Id: Idadee32e58e1b25e999a143dd94b757fc2c59d93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540094Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644458}

/showIncludes causes clang-tidy to output a lot of unnecessary text to
the console.

BUG=944686

Change-Id: I9e8b2e0912d47c70aef9fae8919ab492a310fb29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538645
Auto-Submit: Robert Liao <robliao@chromium.org>
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644457}

install_attributes compilation unit is in chromeos/tpm.
stub_install_attributes compilation was still in old location:
chrome/browser/chromeos/settings.

This moves the test stub to the same place as the code it stubs.

The kDemoModeDomain constant is moved from demo_setup_controller to
the cloud_policy_constants, since the install_attributes component
cannot depend on demo_setup_controller.

Apart from these two moves, nothing is changed.

Bug: 836857
Change-Id: I36d56f108cc8a940af02b044f7f24d7582779801
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538417Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: A Olsen <olsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644456}

The former non-overloaded variants are deprecated.

This is a mechanical change; there is no intended behavior change.

Bug: 929827
Change-Id: If447171aabcc7e9e53fd889d3f41e68f02f7065b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1456745Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Raul Tambre <raul@tambre.ee>
Cr-Commit-Position: refs/heads/master@{#644455}

This is causing the test to flake when ChromePublicTest is somehow getting
set as the default.

TBR=beverloo@chromium.org
BUG=945961

Change-Id: I4ebcb88c98fce2d2f422e8e411cc5b0fbc05064f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539818Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644454}

https://chromium.googlesource.com/catapult.git/+log/b53068f358da..71c6104a1739


git log b53068f358da..71c6104a1739 --date=short --no-merges --format='%ad %ae %s'
2019-03-26 perezju@chromium.org [tracing] Delete some dead code in trace_data


Created with:
  gclient setdep -r src/third_party/catapult@71c6104a1739

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:928278
TBR=sadrul@chromium.org

Change-Id: Ic4d27c7397a919008b5220e066715366a69d2a98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539200Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#644453}

This change implements FormFetcher::GetBlacklistedMatches() and modifies
FormFetcher::GetNonFederatedMatches() to not return blacklisted entries
anymore. Furthermore, it changes FormFetcher::Consumer's interface to
simply notify consumers when the FormFetcher is done waiting.

Bug: 945295
Change-Id: Ie353233339c9ae496bbe52a1ad0312d4973d60d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538400Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644452}

This CL fixed an issue that all downloads on Q with content URI are
recognized as downloads on external SD card.


Bug: 945615
Change-Id: I3ddfb3305359e05e8a38ed17a1d413f8ebb8a529
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539181Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644451}

The result status is not currently used but will be required in order
to integrate with the custom v8 unwinder, to distinguish between
potentially-v8-unwindable state and non-unwindable state.

Bug: 909957
Change-Id: I3a66202ece42579da60d506b4956cf2aafa5c1d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532995
Commit-Queue: Mike Wittman <wittman@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644450}

We disabled the recording of the new keyword metrics fields in
https://chromium-review.googlesource.com/c/1481732 due to the
triggering of strange crashes and exceptions. We believe that
this was caused by an uninitialized field - bool from_keyword -
which has now been remedied.

Bug: 837395 934316
Change-Id: I6a3a9fc9582bb1df5c2c4e4b0f72dca324b3c9b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539856Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644449}

Refactors the cross-platform parts of the stack sampling into
the new StackSamplerImpl implementation of the StackSampler
interface. Platform-specific aspects of stack sampling are refactored
into the ThreadDelegate/ThreadDelegateWin interface/implementation.

Refactoring the Mac sampler to make use of StackSamplerImpl will be
addressed in the next change.

Bug: 931418
Change-Id: I204257fec31b23fc20c7beceddb81b3a38a9466d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530009
Auto-Submit: Mike Wittman <wittman@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644448}

git cl upload failed to upload these changes to the last CL, so my +2
landed the wrong patchset. By the time I noticed the change was already
merged.

Bug: chromium:943702
Change-Id: I8cd74c33f1e1e36e86188af9872f3a0e85039262
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534874
Commit-Queue: Peter Boström <pbos@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644447}

TBR=vasilii@chromium.org

Bug: 914765
Change-Id: Id318bd708fd718ebbec0bcd3fad245155eec5e5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539999Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644446}

AppListView's bounds are stored as the property called
kVirtualKeyboardRestoreBoundsKey when the search box is activated in
clamshell mode. When the tablet mode is turned on, this property
is still kept in AppListView's native window. As a result, when closing
the virtual keyboard in tablet mode, the native window's bounds are
restored. It explains why we can see that AppListView is moved downward
when dismissing the virtual keyboard.

In tablet mode, AppListView should not be moved because of the virtual
keyboard visibility. So in this CL, clear that property when tablet
mode is turned on.

Test: ash_unittests
Bug: 944133
Change-Id: I714ebd50448a995f77bae759f6282efc8adc6df1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538983
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644445}