GitLab

Setting height for Suggestion popup correctly for portrait
as well as landscape mode so that it is scrollable and does
not overlap with IME.

BUG=409619

Review URL: https://codereview.chromium.org/517403003

Cr-Commit-Position: refs/heads/master@{#292917}

Xcode 6 introduced behavior in the iOS Simulator where the software
keyboard does not appear if a hardware keyboard is connected.

This CL enables the software keyboard when a gtest app starts up.

BUG=392433

Review URL: https://codereview.chromium.org/514223002

Cr-Commit-Position: refs/heads/master@{#292916}

Cr-Commit-Position: refs/heads/master@{#292915}

https://skia.googlesource.com/skia/+log/eb2662c08f07764491a17e0a397cdbeb0e2c05c1..1cbc68f9659f15206d920dacd434ddf4b658ad1f

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/521823005

Cr-Commit-Position: refs/heads/master@{#292914}

https://chromium.googlesource.com/chromium/blink/+log/2856bb101929ce5d4253129818f8f2d9e981bba7..d61a485818c6e67e43934ccd3c6cd453994bebf9
TBR=hclam@chromium.org,tkent@chromium.org

Review URL: https://codereview.chromium.org/521903004

Cr-Commit-Position: refs/heads/master@{#292913}

1024 is the first port that doesn't require priveleged access and 32767 is the last port that isn't used as ephemeral.

BUG=409658

Review URL: https://codereview.chromium.org/529913003

Cr-Commit-Position: refs/heads/master@{#292912}

to correct profile.

BUG=409501,407373
TEST=manual

Review URL: https://codereview.chromium.org/531613002

Cr-Commit-Position: refs/heads/master@{#292911}

BUG=348487
TEST=manual

Review URL: https://codereview.chromium.org/534493002

Cr-Commit-Position: refs/heads/master@{#292910}

https://chromium.googlesource.com/chromium/blink/+log/134c73f37a69c2a294d8263fc7e103e75854ffed..2856bb101929ce5d4253129818f8f2d9e981bba7
TBR=hclam@chromium.org,tkent@chromium.org

Review URL: https://codereview.chromium.org/533613003

Cr-Commit-Position: refs/heads/master@{#292909}

To componentize sad_tab related code, move IDS_LEARN_MORE to outside of chrome.

BUG=402485
TBR=sky@chromium.org for include fix under chrome/browser

Review URL: https://codereview.chromium.org/530963002

Cr-Commit-Position: refs/heads/master@{#292908}

https://chromium.googlesource.com/chromium/blink/+log/105703b3eee3e0aa988ebc778fba8911fafa1195..134c73f37a69c2a294d8263fc7e103e75854ffed
TBR=hclam@chromium.org,tkent@chromium.org

Review URL: https://codereview.chromium.org/534483002

Cr-Commit-Position: refs/heads/master@{#292907}

BUG=387079

Review URL: https://codereview.chromium.org/440423003

Cr-Commit-Position: refs/heads/master@{#292906}

This CL removes the page switcher from the experimental app list's apps
grid view. The normal app list should be unaffected.

BUG=406222

Review URL: https://codereview.chromium.org/521823004

Cr-Commit-Position: refs/heads/master@{#292905}

BUG=405449

Review URL: https://codereview.chromium.org/524393002

Cr-Commit-Position: refs/heads/master@{#292904}

This is needed for std::sort.

I detected the issue when building against system protobuf-2.6.0.
Likely some header is no longer implicitly/indirectly #included.

BUG=none
R=miu@chromium.org

Review URL: https://codereview.chromium.org/528743002

Cr-Commit-Position: refs/heads/master@{#292903}

Followup to https://codereview.chromium.org/411973004

We haven't officially switched over to using c++11 everywhere
yet, so this patch replaces c++11 style enum scope with c++03 style scope.

BUG=392621

Review URL: https://codereview.chromium.org/526193002

Cr-Commit-Position: refs/heads/master@{#292902}

Cr-Commit-Position: refs/heads/master@{#292901}

They now come after the fixed pages (start page and apps grid).

BUG=406222

Review URL: https://codereview.chromium.org/526983002

Cr-Commit-Position: refs/heads/master@{#292900}

https://chromium.googlesource.com/chromium/blink/+log/ad26197593255ddf08b445e3862c804b11738dd4..105703b3eee3e0aa988ebc778fba8911fafa1195
TBR=hclam@chromium.org,tkent@chromium.org

Review URL: https://codereview.chromium.org/527133002

Cr-Commit-Position: refs/heads/master@{#292899}

BUG=None

Review URL: https://codereview.chromium.org/530873003

Cr-Commit-Position: refs/heads/master@{#292898}

Move the resources for the pdf plugin out of //content into //components. Also,
reuse the same code for getting the resource from PepperPDFHost and
PPB_PDF_Impl.

BUG=401242
R=blundell@chromium.org, jam@chromium.org, raymes@chromium.org

Review URL: https://codereview.chromium.org/506473003

Cr-Commit-Position: refs/heads/master@{#292897}

https://chromium.googlesource.com/chromium/blink/+log/2504b5ab42fcfdb91c782eabef1b1118b61d8749..ad26197593255ddf08b445e3862c804b11738dd4
TBR=hclam@chromium.org,tkent@chromium.org

Review URL: https://codereview.chromium.org/530863002

Cr-Commit-Position: refs/heads/master@{#292896}

BUG=404156
TEST=Manual, see bug
TBR=sadrul, oshima (TBRing because of DEPS file modifications)

Review URL: https://codereview.chromium.org/483363003

Cr-Commit-Position: refs/heads/master@{#292895}

https://chromium.googlesource.com/chromium/blink/+log/31d45bf6e4c602a8f3e231037bb4c7fe6865e614..2504b5ab42fcfdb91c782eabef1b1118b61d8749
TBR=hclam@chromium.org,tkent@chromium.org

Review URL: https://codereview.chromium.org/528873002

Cr-Commit-Position: refs/heads/master@{#292894}

ChromeOS does not release capture when starting a move loop either.
This CL fixes http://crbug.com/402301 as a side effect.

BUG=392480, 402301
TEST=None

Review URL: https://codereview.chromium.org/455553003

Cr-Commit-Position: refs/heads/master@{#292893}

https://chromium.googlesource.com/chromium/blink/+log/a437be840d7d26ff0cd4ee60d4cf048d78498de1..31d45bf6e4c602a8f3e231037bb4c7fe6865e614
TBR=hclam@chromium.org,tkent@chromium.org

Review URL: https://codereview.chromium.org/533483002

Cr-Commit-Position: refs/heads/master@{#292892}

The bug's root cause is SetState is called too early when screen is
unlocking and IMF thinks the current UI session is still LOCK screen so
it won't persist the active input method.

BUG=409500
TEST=Verified on Pixel.

Review URL: https://codereview.chromium.org/521463005

Cr-Commit-Position: refs/heads/master@{#292891}

As of Blink r180944, Blink is no longer notifying the embedder of its
GeolocationController reference going away (as there's no need.) Follow
up and retire the notification implementation on the embedder side.

R=mvanouwerkerk@chromium.org, jochen@chromium.org
BUG=

Review URL: https://codereview.chromium.org/526123002

Cr-Commit-Position: refs/heads/master@{#292890}

https://chromium.googlesource.com/chromium/blink/+log/1954c458067aaa54cbfdbaa644903809cdfd7588..a437be840d7d26ff0cd4ee60d4cf048d78498de1
TBR=hclam@chromium.org,tkent@chromium.org

Review URL: https://codereview.chromium.org/525423002

Cr-Commit-Position: refs/heads/master@{#292889}

MessageReceiver were given MessageWithHeader. This is incorrect as this
force validation code at the Connector level, while Connector should not
impose any format on the message it receives.

R=ppi@chromium.org

Review URL: https://codereview.chromium.org/525383002

Cr-Commit-Position: refs/heads/master@{#292888}

The timeout is now obsolete. The bubble stays infinitely if there is no user input.

BUG=394287

Review URL: https://codereview.chromium.org/520743002

Cr-Commit-Position: refs/heads/master@{#292887}

BUG=405016

Review URL: https://codereview.chromium.org/489183003

Cr-Commit-Position: refs/heads/master@{#292886}

Revert of Reland https://codereview.chromium.org/298333007/: Enable mac_strip_release under ASan on OSX. Remo… (patchset #1 id:1 of https://codereview.chromium.org/517803004/)

Reason for revert:
Breaks *lots* of browser_tests on Mac ASan. See e.g.:
http://build.chromium.org/p/chromium.memory/buildstatus?builder=Mac%20ASan%2064%20Tests%20%281%29&number=2036
http://build.chromium.org/p/chromium.memory/buildstatus?builder=Mac%20ASan%2064%20Tests%20%282%29&number=2600
http://build.chromium.org/p/chromium.memory/buildstatus?builder=Mac%20ASan%2064%20Tests%20%283%29&number=2424

Original issue's description:
> Reland https://codereview.chromium.org/298333007/: Enable mac_strip_release under ASan on OSX. Remove the .saves files.
>
> The reasons for reverting the CL hadn't been documented. I'm going to reland and update the bugs.
>
> Unce upon a time the ASan runtime library used to be statically linked into
> the executables on OSX.
> Because that library provided a number of API functions needed by the shared
> libraries, we had custom ASan-specific .saves files that told the `strip`
> utility to preserve those functions when stripping the executables.
>
> Then ASan switched to using dynamic runtime library, which instantly broke the
> stripping step, because the executables weren't necessarily referencing all the
> ASan API functions (issue 242503).
> As a result, stripping has been disabled, and we haven't had .dSYM debug info
> for ASan builds for more than a year now (issue 148383).
>
> Because the ASan API functions are now undefined in the executables, it's
> actually senseless to use the .saves files to preserve those functions.
> This CL deletes the .saves files and turns mac_strip_release on for ASan
> builds.
>
> BUG=148383, 242503, 170739, 166857
> TBR=mark@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/d5319a149964f953e7506c1ff2b33f90974d19ea

TBR=mark@chromium.org,glider@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=148383, 242503, 170739, 166857

Review URL: https://codereview.chromium.org/522743003

Cr-Commit-Position: refs/heads/master@{#292885}

ChromePasswordManagerClient::IsTheHotNewBubbleUIEnabled needs to return false on Android, because there is no bubble for Android.

Unintentionally, I (vabr) misinformed dconnelly in https://codereview.chromium.org/444603003/diff/20001/chrome/browser/password_manager/chrome_password_manager_client.cc#newcode357 that IsTheHotNewBubbleUIEnabled is not compiled on Android at all, whereas the truth is, it is only not compiled for Androd WebView.
As a consequence, IsTheHotNewBubbleUIEnabled started to return possibly true on Android after https://codereview.chromium.org/505123002 landed, causing a crash on the bots.

BUG=328847,409622

Review URL: https://codereview.chromium.org/529743002

Cr-Commit-Position: refs/heads/master@{#292884}

TBR=jarin@chromium.org

Review URL: https://codereview.chromium.org/521303003

Cr-Commit-Position: refs/heads/master@{#292883}

This CL adds policy indicators to show that a protocol handler is installed by policy.

BUG=384361

Review URL: https://codereview.chromium.org/518673003

Cr-Commit-Position: refs/heads/master@{#292882}

This migration int -> float was still missing.

BUG=380463, 394315

Review URL: https://codereview.chromium.org/485103006

Cr-Commit-Position: refs/heads/master@{#292881}

https://chromium.googlesource.com/chromium/blink/+log/0f13ba4c4b4529d1118c049259c2fbbcaee50e07..1954c458067aaa54cbfdbaa644903809cdfd7588
TBR=hclam@chromium.org,tkent@chromium.org

Review URL: https://codereview.chromium.org/530763003

Cr-Commit-Position: refs/heads/master@{#292880}

BUG=391005

Review URL: https://codereview.chromium.org/525493003

Cr-Commit-Position: refs/heads/master@{#292879}

Currently gamepad_seqlock_unittest.cc is not included in content_tests.gypi.
Also GamepadSeqLock was renamed to OneWriterSeqlLock some time ago as it
is used not only by the gamepad.
To rectify this situation this patch does the following:
- replace references to GamepadSeqLock
- include the unittest in content_tests.gypi

Review URL: https://codereview.chromium.org/507643002

Cr-Commit-Position: refs/heads/master@{#292878}