- 10 Mar, 2020 40 commits
-
-
Ulan Degenbaev authored
Bug: 1049093 Change-Id: I830afdbcd712e892053edd263170d67996be40a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095306Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#748606}
-
Fredrik Söderquist authored
Add a simple wrapper class for the Vector<SMILTimeWithOrigin> representation of an instance list, and move all list mutating operations to it. This will allow easier tracking of which "origins" are present in the list, and thus avoiding certain operations in some cases. This will be added in a follow-up CL. Bug: 1039243 Change-Id: Iac126f0f6628696fea436514dcab5d824c1dc588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089765Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#748605}
-
Koji Ishii authored
This patch rebaselines paint/invalidation/* where "geometry" or "full" are turned to "disappeared" and "appeared" because FragmentItem does not implement re-use yet. When we implement re-using, we will re-review them. For now, rebaselining these failures allows us to review other failures more carefully. TBR=yosin@chromium.org, wangxianzhu@chromium.org Bug: 982194 Change-Id: I0d324c6f51399401704940f01c2509557d4cae0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096317Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#748604}
-
Maria Kazinova authored
Initially a few iOS saving tests were based on checking the LogManager messages. Now more testing methods are mocked and implemented, so these tests can also be rewritten. Bug: 598672 Change-Id: Id0860d2946ea6b9912c1a95efb66ad1e2fb971f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094986Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#748603}
-
Monica Basta authored
As part of friendly settings, the 'Manage Data from chrome sync' title is changed. Bug: 1043128 Change-Id: I2b3a79e6adbf297fe853a151a4132db12af018e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095013Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#748602}
-
Gauthier Ambard authored
This CL is a Reland of crrev.com/c/2071938 This CL makes sure that the animations of the RecentTabs are disabled when the recent tabs aren't presented when BVC is contained. The original CL wasn't working because the updates weren't prevented when the class was instantiated. If the user is signed in, the first presentation is trying to update the TableView even if it wasn't shown yet. Fix it by preventing updates in -init. Bug: 1038034 Change-Id: Id2ec3e63dd78a014a87abf91ec99fe001b27df4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095116Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#748601}
-
Noel Gordon authored
Bug: 1035691 Change-Id: I63f075c71a288bc88455ff4f7ac5cccff9af7cae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094854Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#748600}
-
Kei Nakashima authored
|MoveTo| didn't work correctly when moving the target node before itself/its next node. Also added DCHECKs, which check if the target node is not anchor and if two given node is both in-use list. Change-Id: I60442f1d706a072eaeca9bc83eaaee9d60b0c853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096316 Commit-Queue: Kei Nakashima <keinakashima@google.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Hitoshi Yoshida authored
core/internals depended on modules/canvas. This CL fixes it. Bug: 839389 Change-Id: I8cad7dca6826e117f5c47e1cda45975da69d65aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094853 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
Anqing Zhao authored
After crash reports in telemetry API is enabled. We need to notify users that the related crash report metadata will be collected for privacy purpose on chrome://management page. PRD: go/cros-telem-crash DD: go/cros-telem-crash-dd Bug: 1040078 Change-Id: Ie7805138b31856a017f268c1aa9c21083937e5a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080428 Commit-Queue: Anqing Zhao <anqing@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#748597}
-
Takashi Toyoshima authored
As planned to stop supporting mitigation enterprise policies in m82, this patch introduces gates to hide the relevant enterprise policies and hide them by default. I will remove these gates and policy handling code in m83. Bug: 1053866 Change-Id: Ifeb7d09aeea0aa94e5b3919dec978c526af0fe21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063620Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#748596}
-
Domenic Denicola authored
Since origin policy is behind the "experimental web platform features" flag these days, we don't need a separate virtual test suite for it. Bug: 751996 Change-Id: Ia4efb77cd7c69b33be79cfd7967e0961c4fe439e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094211 Commit-Queue: Mike West <mkwst@chromium.org> Auto-Submit: Domenic Denicola <domenic@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#748595}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I8d60bd8d93eab36cf586be3680cf7d23dc49f7e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096199Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748594}
-
Lei Zhang authored
- Make some member variables const. - Initialize member variables in the header when possible. - Make GetLanguage() const. - Fix various nits. Change-Id: Ib508052f2491955cc41554204a2010299bc2d4ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092879Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Chris Hall <chrishall@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#748593}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a0a3e1a7..ed3bbe90 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iead0dc56b5d391ec5d80ac13186381bbc517bc92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094663Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748592}
-
rbpotter authored
Bug: 1026426 Change-Id: I91c0a2e574dc30f4f0a8bca5be5363393e7f7437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091227Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#748591}
-
Marc Treib authored
This involves implementing the methods inherited from PasswordStoreSync, and also inheriting from PasswordStoreSync::MetadataStore and implementing that as well. The reason for all this is to support browser tests that involve both Sync and the Password Manager. Bug: 1058339 Change-Id: I130a3d8985a5c35adfe5936f95073de5e5f5905b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088853 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#748590}
-
Ce Chen authored
relevances only for incognito. Note the existing flag OnDeviceSuggestMaxScoreForNonUrlInput is still kept for incognito such that the Incognito stable experiment will not blocked by this CL. I will remove the flag from incognito once this change is available in stable. Tested on iPhone X with chrome://flag option "Enabled incognito-only-relevance-1000". Bug: 925072 Change-Id: Ib4b5374d9409f731f3268b88093ec9d842a7fd9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091193 Commit-Queue: Ce Chen <cch@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#748589}
-
Matt Giuca authored
Jay is no longer on the project. Owners are removed, and in some cases, replaced with the people who will be speculatively taking over those areas. TODOs replaced with bug IDs. Change-Id: I51c7e2ce0be28e5457dd5a805ea4cbb3e04a6ff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067821 Auto-Submit: Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#748588}
-
Anand K. Mistry authored
Bug: None Change-Id: I028af5cfa3e1481d3b40852529f3b2aea0d38308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096065Reviewed-by:
-
Kent Tamura authored
This CL has no behavior changes. Bug: 1052232 Change-Id: I8ea8e3480edce7a34e06883c14692788c7868ce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094490 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#748586}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3e017d50fe09..a7f96787e8a3 Created with: gclient setdep -r src-internal@a7f96787e8a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1046223,chromium:1052460,chromium:1059996 Tbr: jbudorick@google.com Change-Id: I27c2761a674b3be315ba5b5d82d6a44651c7f178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096195Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748585}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Ic6353fb568faf30d87acf603b308df6756f08cce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094664Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748584}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c2d817317046..abcc536b6207 git log c2d817317046..abcc536b6207 --date=short --first-parent --format='%ad %ae %s' 2020-03-10 shrekshao@google.com Speculative fix for nullptr program in QueryProgramiv 2020-03-09 jmadill@chromium.org Revert "Vulkan: Fix store ops with linear command recording." 2020-03-09 b.schade@samsung.com Enabled GL_KHR_no_error 2020-03-09 tikuta@chromium.org use go isolate client in trigger.py Created with: gclient setdep -r src/third_party/angle@abcc536b6207 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1047115,chromium:991020 Tbr: jmadill@google.com Change-Id: Id843fb3bc664bab80160472f1d335c631e6caa69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095164Reviewed-by:
-
anina koehler authored
Bug: 980460 Change-Id: I1a6695afd602b41182216d249fbbb2c1cffe61ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090417Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Anina Koehler <aninak@google.com> Cr-Commit-Position: refs/heads/master@{#748582}
-
Luciano Pacheco authored
Bug: 1058549 Change-Id: I82c1f7f2ed7cf8cf84a7a86ea0b800cd9988283b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096157 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#748581}
-
Yoshifumi Inoue authored
This patch changes |LayoutInline::IsEmpty()| to handle |NGFragmentItem| to make |LayoutBox::ContainingBlockLogicalHeightForPositioned()| to return valid value for "top" property of |ComputedStyle|. Before this patch, |ContainingBlockLogicalHeightForPositioned()| always return zero for |LayoutInline| even if it has inline children. Note: This patch makes computed-style-percentage-top-with-position-inline.html to pass. Bug: 982194 Change-Id: Ic3a83d6b745966a38b86ceb5c899ea2d523b06a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094382 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1234c8aa625f..da7205379701 git log 1234c8aa625f..da7205379701 --date=short --first-parent --format='%ad %ae %s' 2020-03-09 treehugger-gerrit@google.com Merge "record_page: include two missing Android log buffer options" 2020-03-09 treehugger-gerrit@google.com Merge "traced_perf: allow slow proc-fd lookups to recover from expired state" 2020-03-09 treehugger-gerrit@google.com Merge changes I3010621d,I4f59d1b4 2020-03-09 treehugger-gerrit@google.com Merge "traced_perf: unwind queue type" 2020-03-09 taylori@google.com Merge "perfetto-ui: Handle resolution is Infinity" 2020-03-09 ilkos@google.com Merge "Fix joining at the boundary" 2020-03-09 ilkos@google.com Merge "Add task names metric" 2020-03-09 hjd@google.com Merge "trace_processor: Pass track_id constraint to generator" Created with: gclient setdep -r src/third_party/perfetto@da7205379701 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I9f2f1bfc87aac80430c1fb3e78c18be836352eb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095663Reviewed-by:
-
Anand K. Mistry authored
activate() is inconsistently called when a TreeItem is clicked, but is always called when the user navigates using the keyboard. Since activate() is meant to be called when the user activates an item, regardless of method, ensure this happens. Bug: 1060061 Change-Id: I3151576f380be6a370962710724c183e1b6f160d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094907Reviewed-by:
-
Takuto Ikuta authored
This is reland of crrev.com/c/1989300 But use dev instance of buildbucket/milo Bug: b/144318226 Change-Id: I6472fbb66ecbd882c62c523d803b7de66c7aad20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094434 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#748577}
-
Mike Dougherty authored
This metric is used on one of our dashboards, so extending the date to close to the end of the year to match other Stability.* metrics. Change-Id: Ic8bd51d401e95022678a0b30fc67a9f5ae439416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093162Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#748576}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f333272eb504..343d4f6f1870 git log f333272eb504..343d4f6f1870 --date=short --first-parent --format='%ad %ae %s' 2020-03-10 johnkslang@users.noreply.github.com Merge pull request #2109 from jeffbolznv/disable_escape Created with: gclient setdep -r src/third_party/glslang/src@343d4f6f1870 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,jmadill@google.com Change-Id: Id9440846339995828111e3d6d021f4b175ae1e42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095792Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a1ac244222a5..137991396d03 git log a1ac244222a5..137991396d03 --date=short --first-parent --format='%ad %ae %s' 2020-03-09 hta@webrtc.org Make a switch to disable DTLS 1.0, TLS 1.0 and TLS 1.1 downgrade in WebRTC. 2020-03-09 srte@webrtc.org Fix for out-of-bounds write in square test frame generator. Created with: gclient setdep -r src/third_party/webrtc@137991396d03 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I576c16b4a468787ffdd216e224b517e541231fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095162Reviewed-by:
-
Maksim Ivanov authored
Fix the a11y regression introduced in https://crrev.com/c/2030411, which was that the focus was lost after the wrong PIN is entered. The problem was caused by the fact that the whole PIN dialog, including the input field, gets hidden while showing the "progress bar" animation during PIN verification. The focus on the input field becomes lost when it's hidden, and it's not restored automatically when it's re-shown again. The fix is to programmatically set the focus every time the PIN dialog is updated, so that this happens after the PIN verification completes too. Note that this is done unconditionally, so that entering a wrong PIN is guaranteed to trigger the a11y event with the error message for the user. Bug: 1016839 Test: start smart card SAML login, enter wrong PIN, check that the focus stays on PIN input after the progress bar animation stops Change-Id: I6a712c79eedc961f7da26dacfbb6f3df5db01396 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087920Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#748573}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/abdb603cd140..9e5db26faa43 git log abdb603cd140..9e5db26faa43 --date=short --first-parent --format='%ad %ae %s' 2020-03-09 chonggu@google.com Remove bitmaptools.cc from Fuchsia builds. Created with: gclient setdep -r src/third_party/catapult@9e5db26faa43 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1058255 Tbr: nuskos@google.com Change-Id: I03c7544e6dedd8da84f6d50dcb3b8c6c6bcd1939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095661Reviewed-by:
-
Kunihiko Sakamoto authored
This CL adds a histogram to track occurrence of ERR_TOO_MANY_REDIRECTS error caused by Signed Exchange's fallback redirects. Bug: 1058314 Change-Id: I56fa7b2e0ef824152e3b0d2dbfec49f21ea725c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086367Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
-
Rakina Zata Amni authored
Currently we are using idle tasks for find-in-page tasks, which might lead to a very long wait for find-in-page matches when the page is rarely/never idle. This CL changes find-in-page to use non-idle tasks and also added FindInPageBudgetPoolController to help calculate budgets for find-in-page tasks, changing the priority when the budget is exhausted/replenished. See https://groups.google.com/a/chromium.org/d/msg/blink-dev/lqIezO-_ifg/vu7sF9eiBAAJ for context. Bug: 1045517 Change-Id: I32af393d0727006802a09882cc5a485793908c9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041711 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Ken Rockot authored
This is a reland of aa7438aa Unmodified from the original CL, as breakage was from a precursor that has since been fixed and relanded. Original change's description: > Convert some mojo_base typemaps to GN targets > > Uses new GN-based typemap definitions to replace some typemap files in > mojo/public/cpp/base. > > Bug: 1059389 > Change-Id: If1389c9ceec8ae90df753895af0abd9f72c704a0 > Tbr: dtapuska@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090723 > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#748056} Bug: 1059389 Change-Id: I5bbe5afff09493b3394f8922c3fe190e731305b7 Tbr: dcheng@chromium.org Tbr: tsepez@chromium.org Tbr: oksamyt@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095929Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
Mitsuru Oshima authored
This is a speculative fix for crbug.com/1041932 Bug: 1041932 Change-Id: I0dfe7479967729dc242f32eba4772107fcc3f7ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093073 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#748568}
-
Abhijeet Singh authored
Add a user-consent view informing the users about the Quick-Answers functionality. The quick-answers will only be enabled if the user grants her consent by acknowledging this view. The view will be shown to the users a maximum of 3 times or until an accumulated of 8 seconds it is impressed. Bug: b:148956341 Test: Tested locally on atlas device Change-Id: I46d0cfd5d82ced03ef610ab8624b909fa1403223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077589 Commit-Queue: Abhijeet Singh <siabhijeet@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#748567}
-
