GitLab

BUG=123939
TEST=launch GPU process by navigating to a page requiring it. open about:tcmalloc. refresh. see GPU process memory information


Review URL: http://codereview.chromium.org/10041017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133816 0039d316-1c4b-4281-b951-d872f2087c98

* Define GDataDB interface with methods to Put, Get and Delete. Also define a path-based iterator.
* GDataLevelDB implements GDataDB using leveldb. 
* Add methods SerializeToString and FromProtoString to serialize GDataEntry to strings and vice versa.
* GDataDBTests test Put, Get, Delete for files and directories.
* Iterator tests in GDataDBTests.
* GDataDBFactory class to create GDataLevelDB instance.

TODO:
* There is no integration with GDataRootDirectory/GDataFileSystem yet.

BUG=chromium-os:29232
TEST=unittests pass.
Review URL: https://chromiumcodereview.appspot.com/10168025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133815 0039d316-1c4b-4281-b951-d872f2087c98

Replace string copy code and scoped_arrays() with const_casts in MediaDeviceNotificationsLinuxTest. Explain why this is safe.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/10105037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133814 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133813 0039d316-1c4b-4281-b951-d872f2087c98

TBR=mnaganov@chromium.org
BUG=None
TEST=Tree is green


Review URL: http://codereview.chromium.org/10219001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133812 0039d316-1c4b-4281-b951-d872f2087c98

In some functions, we know that we are on UI thread, so we can
directly use ui_weak_ptr_.

BUG=chromium-os:28503
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10169041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133811 0039d316-1c4b-4281-b951-d872f2087c98

The "initial-exec" attribute is added to the ThreadCache::threadlocal_heap_
variable under normal compilation. This causes the linker to emit a
R_X86_64_TPOFF64 relocation in the _pyautolib.so shared object. This relocation
can cause python to error with:

cannot allocate memory in static TLS block

when it calls dlopen() on _pyautolib.so (when the import statement is
interpreted).

This only happens when the TLS section is large enough. Building Chrome with
-fprofile-generate to add some instrumentation-related data to the TLS is enough
to trigger this condition.

This CL encloses the function attribute in #if ! defined(PGO_GENERATE). When
Chrome is built with -fprofile-generate, we will also pass in -DPGO_GENERATE and
-ftls-model=global-dynamic so profile data can be collected without any errors.

BUG=none
TEST=Rebuilt chromeos-chrome in the chroot with -fprofile-generate
-ftls-model=global-dynamic -DPGO_GENERATE && ran pyautoperf autotests.


Review URL: http://codereview.chromium.org/10035012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133810 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/10216001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133809 0039d316-1c4b-4281-b951-d872f2087c98

enabled.

BUG=124112
TEST=Ran unittests


Review URL: http://codereview.chromium.org/10168017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133808 0039d316-1c4b-4281-b951-d872f2087c98

In favor of less things to have in gdata_file_system.h, which is
overly large.

BUG=chromium-os:29215
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10219006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133807 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/10209012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133806 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122749
TEST=None


Review URL: http://codereview.chromium.org/10173010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133805 0039d316-1c4b-4281-b951-d872f2087c98

Those special cases are handled in ImageLoadingTracker after r133657.

BUG=none.
TEST=No change.


Review URL: http://codereview.chromium.org/10212004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133803 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123288

Review URL: http://codereview.chromium.org/10217008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133802 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123295
TEST=none


Review URL: http://codereview.chromium.org/10066042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133801 0039d316-1c4b-4281-b951-d872f2087c98

Test fails on Mac due to keychain popup.

TEST=none
BUG=124913
Review URL: https://chromiumcodereview.appspot.com/10217012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133800 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manually verified appearance and functionality.


Review URL: http://codereview.chromium.org/10213008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133798 0039d316-1c4b-4281-b951-d872f2087c98

Added 'folder' column to virtual table required to pass Android CTS test.

BUG=
TEST=Add a new test.


Review URL: http://codereview.chromium.org/10162019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133797 0039d316-1c4b-4281-b951-d872f2087c98

My Metro/HiDPI change (r133613) broke the official build. The problem was that I was referencing the new 2x pak files but they aren't created by default yet.

mmoss is working on adding support for optional files. Until that is in I'm just removing the reference to the 2x pak files.

This means that for now 2x pak files won't be archived but that's not a big deal since we don't build with HIDPI_ENABLED anyways.

BUG=114311
TEST=

Review URL: https://chromiumcodereview.appspot.com/10207024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133796 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/10203004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133795 0039d316-1c4b-4281-b951-d872f2087c98

This function is not defined or used anywhere any more.

BUG=none
TEST=build


Review URL: http://codereview.chromium.org/10198008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133794 0039d316-1c4b-4281-b951-d872f2087c98

It's important to destroy the ResourceContext before we start destroying the URLRequestContext and the members it owns, because destroying the ResourceContext will cancel the pending URLRequests for that ResourceContext in the ResourceDispatcherHost. Those URLRequests may reference the URLRequestContexts in their destructors, so we need to make sure ResourceContext is destroyed first.

While doing this, I did some other cleanup:
  * discovered that we could eliminate HostContentSettingsMap from ProfileIOData, w00t!
  * reordered URLRequestContext after the members it points to, so it gets destroyed before they get destroyed
  * moved the virtuals in ProfileIOData::ResourceContext to be public, since the parent class changed them to be public

BUG=90971
TEST=none


Review URL: http://codereview.chromium.org/10174008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133793 0039d316-1c4b-4281-b951-d872f2087c98

before backoff starts due to failures, for use with captive
portal code.

R=joi@chroimium.org
BUG=87100, 115487

Review URL: http://codereview.chromium.org/10173005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133792 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/10207001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133791 0039d316-1c4b-4281-b951-d872f2087c98

The test fails on chrome-mac-10_7-qa. See bug for more info.

TEST=none
BUG=124886
Review URL: https://chromiumcodereview.appspot.com/10181014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133790 0039d316-1c4b-4281-b951-d872f2087c98

Now we ignore errors returned from FixupURLAndGetVisits() in all calls during ModelAssociation.

There is still a call in TypedURLChangeProcessor, but I haven't seen any errors reported from that one yet so I'm being conservative and letting that one continue to throw an unrecoverable error.

BUG=123219
TEST=Added new unit test.


Review URL: http://codereview.chromium.org/10140012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133789 0039d316-1c4b-4281-b951-d872f2087c98

Modified browser crash test. Used CrashBrowser from test_utils and RestartBrowser

BUG=none
TEST=This is a test

Review URL: https://chromiumcodereview.appspot.com/10134043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133785 0039d316-1c4b-4281-b951-d872f2087c98

Windows SendInput() API provides a flag callers can use to have the API do the conversion, which is more reliable than doing it manually with MapVirtualKeyEx().

BUG=124499
TEST=Manual. Verify that NumLock behaves as expected when connecting between two Windows hosts using Chromoting.

Review URL: https://chromiumcodereview.appspot.com/10162021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133784 0039d316-1c4b-4281-b951-d872f2087c98

See http://llvm.org/pr12645 for investigation / discussion.

TBR=cmp
Review URL: https://chromiumcodereview.appspot.com/10173013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133783 0039d316-1c4b-4281-b951-d872f2087c98

BUG=117186
TEST=


Review URL: http://codereview.chromium.org/10217006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133782 0039d316-1c4b-4281-b951-d872f2087c98

TEST=unit tests
BUG=none

R=vangelis@chromium.org


Review URL: http://codereview.chromium.org/10197002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133781 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124864
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10218002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133780 0039d316-1c4b-4281-b951-d872f2087c98

BUG=103480
TEST=unit_test --gtest_filter=MetricsLogTest.*


Review URL: http://codereview.chromium.org/9702015

TBR=isherman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10169039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133779 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133778 0039d316-1c4b-4281-b951-d872f2087c98

constructed GURLs, but lacked some code from the constructors.

BUG=123810 
TEST=see bug


Review URL: http://codereview.chromium.org/10212006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133777 0039d316-1c4b-4281-b951-d872f2087c98

The commit r133754 introduced some errors.  That change made the tests
delete the session a bit more frequently, while some of the tests
maintained more pointers to its internal structures.

This change fixes all the affected tests and adds a member function to
the test framework class to try to prevent this from happening in the
future.

BUG=122033,123270
TEST=

Review URL: https://chromiumcodereview.appspot.com/10212008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133776 0039d316-1c4b-4281-b951-d872f2087c98

BUG=103480
TEST=unit_test --gtest_filter=MetricsLogTest.*


Review URL: http://codereview.chromium.org/9702015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133773 0039d316-1c4b-4281-b951-d872f2087c98

Necessary to make it pass the try-bots, which don't support binary files.

When generating an android APK, it uses all the files in the res/ directory
and generates a R.java which contains resource IDs to be referenced in the
code, so a missing file will result in a missing ID reference and non-compiling
code.

BUG=118591
TEST=

Review URL: https://chromiumcodereview.appspot.com/10216003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133771 0039d316-1c4b-4281-b951-d872f2087c98

Forgot to remove them in crrev.com/133644

BUG=chromium-os:29813
TEST=compiles

Review URL: https://chromiumcodereview.appspot.com/10181013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133769 0039d316-1c4b-4281-b951-d872f2087c98

busted. Added the kTouchOptimizedUI switch to metro mode.

BUG=118641
R=cpu,sky
Review URL: https://chromiumcodereview.appspot.com/10211006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133768 0039d316-1c4b-4281-b951-d872f2087c98