- 22 Aug, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/88624993b0ee..b4a4611be4d7 2020-08-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I023a1a4c12fe81bd3d56e597c3e9a2d457d74392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370214Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800835}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e8dc820fbc1e..ce78ce2e2868 2020-08-22 cwallez@chromium.org Tiny cleanup of GetMappedRange. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ifd944a86dbcf90edec04324276f16c33cedd5917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370209Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I8c2fc6b69851868ead1b2020cc5a912cae2358c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370212Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fbb49b4f7f86..233cb555112c 2020-08-22 eladalon@webrtc.org Make RTCError::sctp_cause_code const If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iab407a80ea384d81f09662b780a80cef3a73a21f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370210Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/46b51582a581..2856a9b1a98f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I085d6599fc403e2df3fca2335240c741557ce1b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370206Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800831}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I2dcdf99e35414e9573578fa3a5be3a52c285811a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370184Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800830}
-
Xiaodan Zhu authored
Bug: 1116229 Change-Id: I583ea76360fcaab0d5a9ec55adf80ff6432a0b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368824Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Cr-Commit-Position: refs/heads/master@{#800829}
-
Sammie Quon authored
Requested in crrev.com/c/2354798. This will simplfy things down the line as we use more index lookup and remove const from some parameters in RootWindowDeskSwitchAnimator. Test: manual, existing tests Bug: 1111445 Change-Id: I7250d969b95f08da5819c73ca325bce2db0ea5bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369518Reviewed-by:
-
Mitsuru Oshima authored
This is a revised version of original attempt crrev.comc/c/2166804. Instead of creating a new layers, this clone and animate the window's layer, but makes sure that the animating layer is at the bottom of other layers within the window. * It adds a invisible view with a layer at the bottom of the non_client_view (no frame w/o this, so we can exclude such case). * Adds the animating layer as a child of this view, with "SetMasksToBounds(false)" so that it will not be clipped during animation. * Once animation is done, this animating, old layer will be removed. Bug: 1073685 Test: covered by unittests. Change-Id: Ib9ae60694fb461dda354fea4fd52e4e01186a6a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335811Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#800827}
-
Aya ElAttar authored
- Changed constructing the clipboard data endpoint, in case its type is a kUrl, from using GetLastCommittedURL of renderFrameHost to GetLastCommittedOrigin instead to avoid getting "about:blank" for Google Docs. Bug: 1116103 Change-Id: I0bea243358a995bad342afb63e9da55d3455e55b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362849Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#800826}
-
Rob Buis authored
Implement basic operator DOM and styling support. Map lspace, rspace, minsize and maxsize attributes to internal properties [1]. Since lspace is shared with mpadded the MathPaddedLSpace internal property is renamed to MathLSpace. Note that this CL does not have a visual effect yet, that will happen once we introduce the operator layout algorithm and operator dictionary. [1] https://mathml-refresh.github.io/mathml-core/#operator-fence-separator-or-accent-mo Bug: 6606 Change-Id: I0999f26ec7f5765715fdf7ceab5a91296e6463bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340919Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#800825}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Iaf5acebcf0b2845d26b81e43d048cb193a75cbe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370013Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800824}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/682f9141d174..1d331c9131bd 2020-08-22 cclao@google.com Vulkan: Use context staging buffer for copyImageDataToBuffer 2020-08-22 cnorthrop@google.com Capture/Replay: Fixes for PUBG:Mobile 2020-08-21 jmadill@chromium.org Feedback Loop Redesign 3/3: Remove feedback loop tracking. 2020-08-21 ianelliott@google.com Vulkan: Fix compilation error 2020-08-21 ianelliott@google.com Vulkan: do not end render pass when invalidating If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Test: Test: Capture first 2000 frames of PUBG:MobileTest: Test: PUBG MOBILE on AndroidTest: Test: angle_deqp_gles3_tests --gtest_filter=dEQP.GLES3/functional_fbo_invalidate_* --use-angle=vulkanTest: Test: angle_white_box_tests --gtest_filter=VulkanPerformanceCounterTest.InvalidatingAndUsingDepthDoesNotBreakRenderPass/* Change-Id: I53392122aac5c3d7f87fae1da8a43a79546f1505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369246Reviewed-by:
-
sauski authored
To support E2E testing of the HaTS Next implementation, logic is added to always launch a test survey when a tab is opened and the testing flag is enabled. Logic is also added to prevent multiple HaTS Next survey from opening at the same time, as these are not modal and not bound to a specific tab, displaying multiple survey simultaneously was previously possible. Bug: 1110888 Change-Id: I324c08460f468e5ba9281f7b18b763acd1d4a317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359031Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@chromium.org> Cr-Commit-Position: refs/heads/master@{#800822}
-
Brian Geffon authored
This CL is the equivalent for per-process reclaim for ARC++, which is also referred to as WorkingSetTrim (this is the name Windows used in Chrome). ARC++ apps can be reclaimed when the system is under memory pressure. The following tunables exist to control this behavior: - Limit the frequency at which we fetch the ARC process list. - Limit the frequency at which an individual ARC app may be reclaimed. - Specify the amount of time an app must have been inactive to be reclaimed. - Specify the maximum number of individual ARC apps which can be reclaimed per round. - Control whether both system processes or apps are reclaimed. Again this only applies when the system is under moderate memory pressure, when there is no memory pressure we will never reclaim ARC apps. BUG=chromium:973963 Change-Id: I211590b123dfff5aaa5738d3025d1eb830fac427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335816 Commit-Queue: Brian Geffon <bgeffon@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#800821}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I4aed042e0fea2c394d169135274053272c8680fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369247Reviewed-by:
-
Lei Zhang authored
- Add a base chrome_pdf::InputEvent class. - Switch pp::InputEvent usage to chrome_pdf::InputEvent in PDFiumEngine. - Switch PPAPI input modifiers to chrome_pdf::InputEventModifier equivalents. With these changes, PPAPI input event usage is limited to just input_event_conversions.cc, out_of_process_instance.cc, and pdfium_assert_matching_enums.cc. Bug: 1091834 Change-Id: If62f82746ed86da913a5ba77771112ddce45bf41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367119 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by:K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#800819}
-
kouhei authored
Bug: None Change-Id: I4c9d95eef2f96b03e89d9cac08711b9e47c50784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367258Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#800818}
-
Lei Zhang authored
It works around a problem that is not applicable to Chromium. Change-Id: I8eaaf8ed1340e9892461e89535b3d896c822ce0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369504 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#800817}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f6b801a1d036..88624993b0ee 2020-08-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I592abafb175aeea0187bff9b45842dacd4ecb6ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369245Reviewed-by:
-
Julie Jeongeun Kim authored
This CL moves PrintHostMsg_ScriptedPrint_Params to print.mojom to pass it to Mojo interfaces. Bug: 1008939 Change-Id: Ib8f84db7fbb2881f1a0cc2c2156a45f9ee88b946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345784Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#800815}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6821f818e6f5..46b51582a581 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xhwang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1114451,chromium:1117077 Tbr: xhwang@google.com Change-Id: I70edcbbb24843680e68e3d3c89136c6d66e3b867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369241Reviewed-by:
-
Dylan Cutler authored
Before this change it was ukm_parameters(), which is against Blink naming convention. Also have the functions return a const ref. Bug: None Change-Id: Ie527e69712be37ac5b362d462acf9b2e376e7a29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366115 Commit-Queue: Dylan Cutler <dylancutler@google.com> Reviewed-by:
-
Gang Wu authored
Bug: 1119955 Change-Id: I2b5b3e6f14e96f24d5f21e08cddbae97ebf72c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369502Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#800812}
-
Yan, Shaobo authored
Current fast path for webgl uploading video frame is to render YUV planars to a RGBA8 intermediate gl texture and than do gpu to gpu copy to update the dst webgl texture. It is possible to further optimize this progress by drawing the content from YUV planars to dst webgl texture directly. This will save the extra gpu-gpu texture copy which may hurt performance when uploading large resolution video (e.g. 4k/8k video). BUG=1108154 Change-Id: I0abb269944f9eac9fb77e13b01860152a918ad95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319543Reviewed-by:
Brian Salomon <bsalomon@google.com> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Shaobo Yan <shaobo.yan@intel.com> Cr-Commit-Position: refs/heads/master@{#800811}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: If97cca0ca10a4f3293e05a3ce48068faa477e3c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369421Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800810}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/bb85de36d277..fbf13333b426 2020-08-22 tsepez@chromium.org Remove core/fxge/fx_ge_fontmap.cpp 2020-08-22 thestig@chromium.org Switch from check_targets to no_check_targets. 2020-08-22 thestig@chromium.org Sync gtest/gmock with Chromium's copy. 2020-08-21 tsepez@chromium.org Remove virtual method SystemFontInfoIface::GetFaceIndex(). 2020-08-21 tsepez@chromium.org Nest CFWL_EventTarget inside CFWL_NoteDriver. 2020-08-21 tsepez@chromium.org Make CXFA_FFApp::m_pFontMgr be a pointer 2020-08-21 tsepez@chromium.org Mark CFWL_Event and its subclasses stack-only types. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I0aa1c7e9e79e1aaf1dc317fca1d0c75354aa18bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369716Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1598032222-bdae3e34bfdfdc02a739bd58b074dbcf46af85d4.profdata to chrome-mac-master-1598054321-87d797542a8415d31d407f7b135c9596dfac4588.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: Icf770efc46f19343a08e1bd1cafb1b9572888b3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370088Reviewed-by:
-
Daniele Castagna authored
When the root contents color usage changes between frames the renderer might reshape the output surface, increasing the damage to the whole frame. If SurfaceAggregator ignores quads outside the damage we might end up with a renderer that can't draw the full frame after reshaping the surface. This CL increases the damage in SurfaceAggragtor to the full frame when the color usage changes. Bug: b/158777601 Test: Youtube HDR video, no artifacts when it starts playing. Change-Id: Ibce88f6f4375567c1bbab1761ab7aea53f84c226 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369441 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#800807}
-
Nick Burris authored
When the merchant requests a shipping address but doesn't specify any shipping options, all shipping addresses are invalid. On desktop, an error is shown when any address is selected, but on Android there is no error so the invalid state isn't obvious to developers. The discrepancy is that on desktop, RecomputeSpecForDetails is called even if the payment details are not updated by the merchant, which results in the error being set in UpdateSelectedShippingOption. This patch makes the Android implementation also recompute spec and display the error if necessary. Bug: 1082630 Change-Id: Idff32f2c2b51a617609381fee49a4ac5bd78206b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280990 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#800806}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ea8d6a46aad5..e6244ccef917 2020-08-21 rmhasan@google.com typ: Include tags in Expectation instance returned when querying for If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1120189 Tbr: zhanliang@google.com Change-Id: Ic8ccfdd481eae070e84dd697f34e8b98cd4cdcca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369350Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1d0b25f6. With Chromium commits locally applied on WPT: 3b705a74 "WPT: Service Worker: Add unexpected state check to wait_for_state()" 9f52c7e4 "COOP: add reporting to redirects" f3b221b0 "[COOP] access reporting: Extend report.body.type values." 5da0ed1e "Allow range requests to pass through a service worker" 3514ff91 "Audio|VideoDecoderBroker: more weakptr, keep callbacks on main thread." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: Ia036e83e6dad3829dc901552613206c4d3f22e7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368775Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800804}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0a98cc54ea0d..f6b801a1d036 2020-08-21 kahinds@microsoft.com Fix primary button color contrast on hover If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1072064 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3325a37648fcb7eef37f45d813fc46fd658a9b56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370003Reviewed-by:
-
Collin Baker authored
Bug: 1106523 Change-Id: I1876b84f2d24a4a664a9aaf5f19eb126d3543e3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360503 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#800802}
-
David Grogan authored
When an aspect-ratio item has a definite cross size, we are supposed to compute the flex base size by multiplying those two. Blink did this when the item had a computed definite cross size, but not when the item had a definite cross size due to stretching. Firefox has the same bug. The modified canvas test relied on the buggy behavior. The tests we now fail also assert the buggy behavior, but are only one-way synced from mozilla's repository, so we can't change them. This fix is behind a flag. Bug: 704294 Change-Id: Ie17c451c7ec81ccb36fb96ff1543885bd7352bcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368321Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#800801}
-
Chris Cunningham authored
Bug: 1120745 Change-Id: Idd2721941fee38a3ad4c6beb30ed1b39ff7759c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368284Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#800800}
-
Arthur Wang authored
Bug: 1060399 Change-Id: Ice41c7ef4154a07c6078a66bda05283161e1c13b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316624 Commit-Queue: Arthur Wang <wuwang@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#800799}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/13c4dbe2ef24..bf7acb2707b8 2020-08-21 egdaniel@google.com Set input usage flag on all internally created vk RTs. 2020-08-21 reed@google.com remove unused enums for picture-recorder If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: stani@google.com Change-Id: Idc88f20545988d8f0ebe9316ecc62b5d65b700eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369713Reviewed-by:
-
Collin Baker authored
This reverts commit 81bbe1e6. Reason for revert: compile error https://ci.chromium.org/p/chromium/builders/try/linux-chromeos-rel/654323? seems to conflict with this recent change: https://chromium-review.googlesource.com/c/chromium/src/+/2355015 Original change's description: > Browser Clipboard: Implements read and write SVG on the browser side > > Implements the SVG format for the clipboard on all blink platforms. The > implementation is very similar to HTML and plain text. Initially we will > put this feature behind a flag before it is exposed to the Web Platform. > > Design Doc: https://docs.google.com/document/d/1jq8QSCQRdNy99rnPusmW8is62c22PVuq-Sk-tMT2tRk/edit# > > Bug: 1110511 > Change-Id: I6d405a9704c431a31995bb50a17dfc309b49b74b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313961 > Reviewed-by: Jarryd Goodman <jarrydg@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Darwin Huang <huangdarwin@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Darwin Huang <huangdarwin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800774} TBR=sky@chromium.org,dcheng@chromium.org,jarrydg@chromium.org,huangdarwin@chromium.org,dsleeps@google.com Change-Id: I0e550072698323d9a7e0754548821e2c765e3162 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1110511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369419Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#800797}
-
Chris Harrelson authored
This reverts commit 60b63538. Reason for revert: failing test was marked as failing in issue 1120106 for a different root cause. Original change's description: > Revert "Don't trigger main-thread overlay scrollbar animations if composited" > > This reverts commit f5cdac12. > > Reason for revert: This might be the cause of test failure virtual/threaded/external/wpt/feature-policy/experimental-features/vertical-scroll-disabled-scrollbar-tentative.html for https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/48699 (and some builds after this). Revert to see if this fixed the test. > > Original change's description: > > Don't trigger main-thread overlay scrollbar animations if composited > > > > There are already hit tests and animations entirely in the impl thread > > for such scrollbars. > > > > Bug: 1116800 > > > > Change-Id: I2714258717c89e0ea41232eb86abe12570526d28 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364972 > > Commit-Queue: Chris Harrelson <chrishtr@chromium.org> > > Reviewed-by: David Bokan <bokan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#800302} > > TBR=bokan@chromium.org,chrishtr@chromium.org > > Change-Id: Ided42e8aa3339e93f85d9f73f3737197864b493d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1116800 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369076 > Reviewed-by: Maggie Cai <mxcai@chromium.org> > Commit-Queue: Maggie Cai <mxcai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800529} TBR=bokan@chromium.org,chrishtr@chromium.org,mxcai@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1116800,1120106 Change-Id: I1f88a6c521618dc1d0b4d7e0d97c44acfc224214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368490 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#800796}
-
