- 16 Jun, 2020 32 commits
-
-
Jimmy Gong authored
- Ongoing print jobs are dynamically updates. - The app updates as soon as a print job is complete. - Includes browsertests for this new capability. Bug: 1053704 Test: browser_tests Change-Id: Ia24ea6298b1907acdc0df687e3f9fcdc6824a88d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224346 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#778599}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bde6ff28cf3d..1f3176b05891 2020-06-15 joselea@microsoft.com Devtools: Open a closed tab via quary param 2020-06-15 jalyn@microsoft.com Add browser test for forwarded key whitelist changes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1094648,chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I638fcd5b0678bab5aa286e5a2f67fb7a0493f636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245194Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778598}
-
Fabrice de Gans-Riberi authored
A channel for chromium.cast.ApplicationContext was created in both PendingCastComponent and CastComponent. This sometimes caused issues in agents that make use of ScopedServiceBinding to handle the server-end of this channel. These agents could get into a state where they never got a signal on the second client disconnect. Bug: 1095217, b/158684780 Change-Id: I06e8e1dd35516bb88ea4929e9f43fb4cd862cd1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246794 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#778597}
-
Kuo Jen Wei authored
Shorten the distance from center of video shutter button to center of video snapshot and pause button from 100px to 84px. Bug: 1054314 Test: None Change-Id: Ic772a79146ad97e8c6ce8efadef23729d06d9407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246358Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#778596}
-
Hiroki Sato authored
This CL tries to make linear navigation order of ChromeVox on ARC++ similar to TalkBack. For example, imagine a11y tree in Android is like this: ++ nodeA container (focusable clickable) (name is empty) ++++ nodeB static text (not focusable, not clickable) (name X) ++++ nodeC button (focusable clickable) (name Y) TalkBack's navigation order is as below: 1. nodeA, announce a name of nodeB. 2. nodeC, announce a name of nodeC. Currently ChromeVox skips nodeA. With this CL, ChromeVox firstly focus on nodeA and nodeB is skipped because it's ignored. This CL introcues 'screen reader mode' in ARC accessibility, which is enabled when SwitchAccess or ChromeVox is enabled. The focusability change added in this CL is applied only when the screen reader mode is enabled so that we don't break text location API for Select-to-Speak. Note that this change adds a few TODOs, which will be resolved in follow up CLs. AX-Relnotes: n/a. Bug: b:157441336 Bug: b:150344900 Bug: b:150344310 Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*" Test: manually confirmed with PlayStore and Android Settings. Change-Id: I700cbbd348c9eb7bf71a7995994c926b1c839979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222068 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#778595}
-
Antoine Desbois authored
This prevent a user from adding a callback and discarding the return value which in turns causes the callback not to be called later on. Merge-With: eureka-internal/407264 Change-Id: I4b1fb4570c6709297f783d488f5505b4102573ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240294Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Antoine Desbois <antoinedesbois@google.com> Cr-Commit-Position: refs/heads/master@{#778594}
-
Bill Carr authored
Add the DXGI_SWAP_CHAIN_FLAG_FULLSCREEN_VIDEO flag to the decoder swap chain in swap_chain_presenter. This makes the decoder swap chain a candidate for full screen optimizations in DWM (so long as other full screen criteria are met). If the swap chain is not fullscreen there are no adverse effects of the flag being present. Bug: 1027046 Change-Id: I413f84a050e45409c4e00e7f2f08fe5eeed7657f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246978Reviewed-by:
Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: William Carr <wicarr@microsoft.com> Cr-Commit-Position: refs/heads/master@{#778593}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f773e05e5d7c..6923f653bfd4 2020-06-15 bsheedy@chromium.org [Telemetry] Reduce unhandled inspector message verbosity If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1085222 Tbr: skyostil@google.com Change-Id: I0addef71b242bf7cd384e6cc2ce6cc7d4d721ae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247260Reviewed-by:
-
Kyle Horimoto authored
Fixes build for Clang 10 and libstdc++. Suggested by mike@fireburn.co.uk on https://chromium-review.googlesource.com/c/chromium/src/+/2227721. Change-Id: I110768027e4887be9566a965d62989f7e21ccdf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242749 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#778591}
-
Sammie Quon authored
Details/mocks are linked in the linked bug. Test: manual Bug: 1095140 Change-Id: Ic8dc25d686355b80dc5f537eda67836e6c97f172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225978 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
-
Xinghui Lu authored
Currently, about 1% of requests takes more than 1 second on desktop. About 2% of requests takes more than 1 second on Android. For better user experience, we should move to the next step without waiting for the token in this case. Source: Desktop: http://screen/KiwRQhLVhjp Android: http://screen/aS2zHNmsMYs Bug: 1070324 Change-Id: I7e95e14d837ef8210c3b78c87e571359456e6d6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246943 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#778589}
-
Alice Boxhall authored
This reverts commit f4240b29. Reason for revert: Unfortunately, this seems to have caused a UAF: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8877395395161584064/+/steps/unit_tests/0/logs/Deterministic_failure:_ServiceDiscoveryClientMacTest.ServiceWatcher__status_CRASH_/0 Original change's description: > mac: Simplify the local_discovery ServiceWatcher and ServiceResolver. > > This removes the inner Container classes by moving the logic into the > ObjC classes that already exist. > > Bug: 1072841 > Change-Id: If22d2d90ce3235ce160a0b740337fd71353a7ef7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243995 > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#778341} TBR=ellyjones@chromium.org,rsesek@chromium.org Change-Id: I3b2a26c44c52d2fb4ef3b3323c0c82c85db9239c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1072841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246125Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#778588}
-
Shakti Sahu authored
This CL fixes a bug where query tiles suggestion was disappearing after the view is recycled, since we didn't bind the view correctly. Bug: 1081130 Change-Id: I6bc98d547ae851a662ed26f772e3ea7a7dfb519b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245693Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#778587}
-
Bettina authored
Also add more tests in phishing_url_feature_extractor. Bug: 1069793 Change-Id: Iebc588915d1fcd003bd942419fae9c20323f25ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242228Reviewed-by:
-
Sunny Sachanandani authored
Fix getImageData for swap chain backed low latency 2d canvas on Windows by using the back buffer instead of front buffer for bitmaps. Also, add synchronization necessary for using the back buffer after present. Fix putImageData for low latency canvas by adding missing GrContext flush before present. Also, add a pixel test for this and consolidate the low latency pixel tests across platforms and enable low latency drawImage tests which were left disabled by accident. Bug: 1085559, 1085015 Change-Id: Iaed508d0ad96cb5618b0d9834d2e109c2b7124f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238413 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#778585}
-
Jesse McKenna authored
This change changes the command-line single-argument switch, used for launches from the Windows shell, from `--single-argument=` to `--single-argument `. This fixes an issue where users who have updated but not restarted Chrome are unable to open shell links (due to the mismatch between the just-updated open command in the registry and the expectations of the now-obsolete running browser). crrev.com/c/21165961 changed the command line used by the Windows shell (and set in the registry) from `"chrome.exe" "%1"` (where %1 is replaced by the argument to launch by the shell) to `"chrome.exe" --single-argument=%1` to enforce a limit of one argument on shell-based launches. This caused old versions (those which have updated but not restarted Chrome) to receive `--single-argument=<arg>` when Chrome is invoked from the shell, but be unable to interpret it. Because this change replaces the `=` with ` `, it is more backwards-compatible with old versions. They will simply ignore the `--single-argument` switch and interpret the space-delimited <arg> as the argument until the user restarts Chrome to launch the new version. Bug: 1092913 Change-Id: Iba734fe290944176f7ad38d36e670a1bea04623b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238270Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#778584}
-
nancylingwang@google.com authored
This is the preparing for the adaptive icon feature. There will be a new type, adaptive icon, to fetch the background and foreground, so modify the current boolean for compress or uncompress to use the enum. BUG=1083331 Change-Id: I35d27a6bc4bc9263dcc0dd1ec5af5a57a271f199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244811Reviewed-by:
Long Cheng <lgcheng@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#778583}
-
Lukasz Anforowicz authored
Before this CL, tests/affected-expr test would fail to append |.get()| to an argument passed to a constructor. After this CL, the test passes. See also https://bugs.llvm.org/show_bug.cgi?id=46287. Bug: 1069567 Change-Id: Ie0660fec164938a0cfd18d64ac02a405f947f5c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242478Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#778582}
-
Lukasz Anforowicz authored
After this CL, the rewriter will no longer unconditionally skip fields in the following scenarios: - Overlapping fields (e.g. |SomeClass *field1, *field2;|). - Char pointer fields (e.g. |char* field| or |wchar_t* field|) - Fields expanding in macro scratch space Instead, the rewriter will emit such fields as candidates for the --field-filter-file blocklist - in the following section of the output: ==== BEGIN FIELD FILTERS ==== MyStruct::const_char_ptr # char MacroTest1::ptr_field # macro my_namespace::MyStruct::overlapping_1a # overlapping ==== END FIELD FILTERS ==== Bug: 1069567 Change-Id: If91b02d35a1239aff464e97493ae5cf930a759a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213450 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: -
Nate Fischer authored
This is a follow-up to https://crrev.com/c/2103040 to update markdown docs. This is mostly mechanical, with minor rewording to Safe Browsing docs. This leaves one URL unmodified, since it's pointing to a CL which predates the "allowlist" renaming. Bug: 842296 Test: tools/md_browser/md_browser.py Test: Upload to gerrit > open file > click "gitiles" Change-Id: Ib6dc325968084bfdf61119dbad7897311e39892d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246792 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#778580}
-
Raymond Toy authored
The main processing loop for the k-rate Oscillator is updated to use SSE2 instructions to speed up processing. Four tests fail because we have slightly reduced accuracy. Testing shows that the loss of accuracy is due to using a float for virtual_read_index in the loop instead of a double as previously. A implementation using a double passes all the original tests but does show that it does lose performance. I think the change in accuracy is acceptable. WebAudio Bench results from a linux machine. In summary, the SIMD version is about 60% as much time (about 1.75 times faster). Without CL: TEST μs MIN Q1 MEDIAN Q3 MAX MEAN STDDEV Baseline 713 713 748 757 766 877 760.25 18.35 Oscillator 949 949 972 990 1005 1132 990.78 24.35 With CL: TEST μs MIN Q1 MEDIAN Q3 MAX MEAN STDDEV Baseline 728 728 747 756 763 908 757.46 16.81 Oscillator 521 521 549 564 581 874 566.87 27.77 Bug: 1013118 Change-Id: Ic5445cc152e960b41817f245ac306691f7c57f90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246831Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#778579}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592179115-ce9d3833511cd09c1a658f7526d2bf0aece0f3f3.profdata to chrome-win64-master-1592254457-49e6f7cc818263441b4a68ab874369702506c19f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I095199dd3c2b38e31fc15de65c845bb8fe475af9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247218Reviewed-by:
-
Chris Harrelson authored
It never shipped and was last edited maybe 8 years ago [1] [1] https://chromium.googlesource.com/chromium/src/+/fc39a1d8142609506e134df58a3f9ebee8e34dcf Change-Id: Ic349defec813588642d184ff8d99350695dd3478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240391 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#778577}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I439a99f31eb8dac81e55bb7b0836b88085bf4bd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247102Reviewed-by:
-
Ian Kilpatrick authored
... and also border_padding_, border_scrollbar_padding_. This patch is in preparation for moving the relative position calculation into NG, but may have some value by itself. The relative position calculation needs to know about the initial child_available_size_ to resolve percentages against. This moves the child_available_size_, border_padding_, and border_padding_scrollbar_ into the container builder. Change-Id: Ifa0a9f307c0943cb1f4e1dade948980d46abc10f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225457 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#778575}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e95e2c3c48a4..1a455f4e54b0 2020-06-15 m.maiya@samsung.com Vulkan: Set external image's usage flags based on AHB usage flags 2020-06-15 shrekshao@google.com Fix baseVertex and baseInstance with streaming attributes 2020-06-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from a60f89ffcba2 to bfa95c7ad8b7 (7 revisions) 2020-06-15 geofflang@chromium.org Revert "Remove redundant BlendStateArray tracking" 2020-06-15 geofflang@chromium.org Don't expose pixmap support from DisplayEGL. 2020-06-15 m.maiya@samsung.com Vulkan: Addition of ImageRespecificationTest If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1078330,chromium:1085996,chromium:1094634 Tbr: courtneygo@google.com Test: Test: angle_end2end_tests.exe --gtest_filter=ImageRespecificationTest* Change-Id: I8e7d0dbe7d9b8efb6c378ab3def4441d515b0161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247040Reviewed-by:
-
Daniel Rubery authored
Enterprise scans update the string used during deep scanning to explicitly refer to "your organization". This is not appropriate for Advanced Protection users, who do not have an organization. So this CL reverts the string used by Advanced Protection deep scans back to "file.exe is being scanned." Screenshot: https://screenshot.googleplex.com/SAoUW1MNcx8.png Bug: 1020418 Change-Id: Ib038b4c65511df3e650bdd14b0e1d75d24e78a1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247118Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#778573}
-
Sergey Ulanov authored
This reverts commit a6bb85c6. Reason for revert: Broke accessibility_unittests Original change's description: > Emit accessible text-attribute-changed events > > * Add TEXT_ATTRIBUTE_CHANGED event so platforms can distinguish this > event from the more generic OTHER_ATTRIBUTE_CHANGED event that was > being fired. > > * Fire TEXT_ATTRIBUTE_CHANGED from the AXEventGenerator for: > - kBackgroundColor > - kColor > - kFontFamily > - kFontSize > - kFontWeight > - kMarkerTypes (e.g. for spelling and grammar errors) > - kTextDirection > - kTextPosition > - kTextStyle > - kTextOverlineStyle > - kTextStrikethroughStyle > - kTextUnderlineStyle > > * Fire state-change event for ATK when ATK_STATE_ENABLED changes. > (Detected as a side effect of debugging an issue with the above) > > * Eliminate some extraneous accessibility events resulting from the > ignored state being changed on an element. > > Bug: 904977, 1062063, 1085481 > > AX-Relnotes: > > Windows and Linux assistive technologies are now notified when text > attributes have been changed. This allows them to update any cached > information they may have so as not to present stale/inaccurate data > about text appearance. > > In addition, because a notification is emitted when a newly-typed word > has a spelling or grammar error, the Orca screen reader now announces > when the error indicator appears. > > Change-Id: I6a070154304f185dcd6343baadb728b0a4beec35 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211224 > Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> > Reviewed-by: Benjamin Beaudry <benjamin.beaudry@microsoft.com> > Reviewed-by: Javier Fernandez <jfernandez@igalia.com> > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> > Cr-Commit-Position: refs/heads/master@{#778437} TBR=dmazzoni@chromium.org,jfernandez@igalia.com,rego@igalia.com,nektar@chromium.org,kschmi@microsoft.com,iapres@microsoft.com,jdiggs@igalia.com,benjamin.beaudry@microsoft.com Change-Id: I96a6bb5b811263dd77c262a62673ec76243c2dd2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 904977, 1062063, 1085481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246193Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#778572}
-
Jinsuk Kim authored
This CL ensures that the back history popup (longpress on back button) will use NavigationSheet regardless of gesture navigation variation option which can turn on or off Navigation sheet. NavigationPopup will be used for Tablet back/forward history UI only. Bug: 1006111 Change-Id: If5be3d04d34b36d0e203c8750c88bde607058411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245151Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#778571}
-
Jacques Newman authored
Introduces the following: class GridBlockTrackCollection: Builds ranges given specified tracks, implicit tracks, and an auto repeat value. class GridTrackList: Aids in accessing list of repeaters. class GridTrackRepeater: Container for repeated tracks. Bug: 1045599 Change-Id: I929e12dd5c4fcd1e98b3e0e43d6f4a26c4b1a574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237722 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#778570}
-
Luciano Pacheco authored
The error dialog in in the CWS (Chrome Web Store) shows an icon as background image. Currently this icon is cut off by the dialog title and it's off center because the image has empty space at the right hand side. This CL positions the image in the center with margin-inline-start and sets the height to push the dialog title below the icon. See crbug.com/992827#c47 for screenshot with this changes. Bug: 992827 Change-Id: I70b871cd7b3a54e5043ef624f6861c3dc5f43c63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246086 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#778569}
-
Qiran Gong authored
Add gpu::CommandBuffer::State to handle the following message: GpuCommandBufferMsg_SignalAck. Add content::ScreenOrientationValues, viz::LocalSurfaceIdAllocation, viz::LocalSurfaceId to handle the following message: FrameHostMsg_SynchronizeVisualProperties. Add gfx::SwapTimings, gfx::SwapResult, gfx::SwapResponse, gpu::SwapBuffersCompleteParams to handle the following message: GpuCommandBufferMsg_SwapBuffersCompleted. Change-Id: I01c98664cb18996c4298fb726233ecab60b4d692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245238 Commit-Queue: Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Cr-Commit-Position: refs/heads/master@{#778568}
-
- 15 Jun, 2020 8 commits
-
-
Abhijeet Singh authored
When focused, Quick Answer's primary text should be announced when the Chrome Vox screen reader is active. Bug: b:152059023 Test: Tested on Atlas test device. Change-Id: I4c2ccbe7e86ad98bd7100d80acdba1da1ae465b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247239Reviewed-by:
-
David Vallet authored
Bug:1044763,1056890 Change-Id: I324aa1f94495d54383caa9bf00ff6aeaa1f51e6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241103 Commit-Queue: David Vallet <dvallet@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#778566}
-
Meilin Wang authored
This CL extends the |Assistant.SetDspHotwordLocale| UMA for a year. Bug: none. Test: manally. Change-Id: Ib6f48b7835077c0c88fff18807331aa551869249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238419Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#778565}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome TBR=chrome-os-gardeners@google.com Change-Id: I37571a3d9e9243a4aa51cc120c4a29ee6dc030fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245175Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778564}
-
Chris Lu authored
Bug: 1071914 Change-Id: Ifcec136f6297da09582e978ac587f397a8830f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246985 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#778563}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I4f622dc4a1250b48f95db6bd858099e293cc324a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246954Reviewed-by:
-
Stephanie Kim authored
This reverts commit 79472ed7. Reason for revert: Forgot mb configs Original change's description: > android-binary-size-generator ci bot setup > > Bug: 1078460 > Change-Id: I4a78617ef3ccfe2fa9bad06f8eb6bedcefaf2391 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245677 > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Commit-Queue: Stephanie Kim <kimstephanie@google.com> > Cr-Commit-Position: refs/heads/master@{#778536} TBR=martiniss@google.com,agrieve@chromium.org,martiniss@chromium.org,kimstephanie@google.com Change-Id: If0dae60ce2f000a5fc46f34a0c209919844f3cd9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1078460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247144Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#778561}
-
Andrew Xu authored
This issue has never been reported and is exposed by my CL in progress. When setting hotseat bounds without animation, hotseat widget may have the running bounds animation. Setting bounds will interrupt the running animation and it'll progress to the end. As a result, hotseat widget'll be caught in an intermediate state where the old target bounds are set right before updating with the new target bounds. In this CL, the running hotseat animations are aborted before setting hotseat bounds. Bug: 1095055 Change-Id: I2adfc87c10c1e0a120758ee7a1d12f03c34e90ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247141Reviewed-by:
-
