- 16 Dec, 2020 40 commits
-
-
Leonard Grey authored
Bug: 1152274 Change-Id: I99302b180a5b71e89738598b8746e66bda34eba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593869 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#837625}
-
Ian Wells authored
Bug: 1152187 Change-Id: Ibd26b985f98dc5b5ea60dff4f48d53fc7c806fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593157 Commit-Queue: Dan H <harringtond@chromium.org> Auto-Submit: Ian Wells <iwells@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#837624}
-
Leonard Grey authored
Also changes a few one-off binds in DevToolsFileHelper Bug: 1152274 Change-Id: Ibed34dd02d8a28c0d47b66951c04fd04e9a83393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593751Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#837623}
-
Frédéric Wang authored
After [1], blink::network_utils::IsOriginSecure is strictly equivalent to network::IsUrlPotentiallyTrustworthy. This CL removes IsOriginSecure, performs corresponding replacements and optionally adjusts DEPS files. Some conditions webauth_request_security_checker.cc and mixed_content_navigation_throttle.cc are also simplified, because checks are already included in network::IsUrlPotentiallyTrustworthy. There is no behavior changes, although uses of IsOrigin vs IsUrl may need to be reviewed in follow-up CLs [2]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2563683/1 [2] https://bugs.chromium.org/p/chromium/issues/detail?id=1158302 Bug: 1153336 Change-Id: Ibd1828c14d92c33291095174dbeb466259cc4530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563883Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#837622}
-
Jan Wilken Dörrie authored
TBR=karandeepb Bug: 1159418 Change-Id: I6974cc4a21b1bd89a3fd7124ec33e5f7812b26c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595367Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#837621}
-
David Maunder authored
This reverts commit 4e9b4c26. Reason for revert: To determine if this causes crbug.com/1159422 Original change's description: > Allow GetInstance() to scale to multiple protos > > Currently GetInstance() does not scale to multiple protos. This is > because the function is generated for each template. For example if > there were instantiations ProfileProtoDB<Foo> and ProfileProtoDB<Bar> > each would generate a GetInstance(). It is not possible to create one > templated function which will be expanded out to two different return > types. We must use template specialization instead. > > Bug: 1159157 > Change-Id: I5879b768ed55179b17a7c58a3d12bde87fb20f81 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593219 > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > Commit-Queue: David Maunder <davidjm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#837349} TBR=yusufo@chromium.org,davidjm@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I675683e53d23801001e4356a9968618efe5453a8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1159157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595970Reviewed-by:
David Maunder <davidjm@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#837620}
-
Bartek Nowierski authored
This is to check if the selected tests pass under a normal configuration Bug: 1121427 Change-Id: I3a23c18d51ec7e51ae290d10a649c09491c2015a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592855Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#837619}
-
Theresa Wellington authored
Change HistoryActivityTest#testOpenSelectedItems and #testOpenItem to capture the intents sent when items are clicked, preventing ChromeTabbedActivity from actually starting (which is not needed as part of the validation in these tests). BUG=1157189 Change-Id: I46cc42ecdff320944e42a608c142bdc852734344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594312 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Auto-Submit: Theresa <twellington@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#837618}
-
Brian Salomon authored
Bug: skia:11019 Change-Id: I536d9bdf428300fa4334735e755f3af17b716b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595608 Commit-Queue: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com> Auto-Submit: Brian Salomon <bsalomon@google.com> Reviewed-by:
Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#837617}
-
Eric Orth authored
Threw in all the parameters we're now using to attempt to stop the automated complaints in the experiment config. Change-Id: I8a102b50f5f1aad0e1171627046d6d4eb4b5adf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593566 Commit-Queue: Eric Orth <ericorth@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#837616}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a298431a1370..6e110c89ed50 2020-12-16 nifong@google.com dump value from DrawAnnotation commands 2020-12-16 egdaniel@google.com Revert "Fix crash on windows viewer when starting in vulkan." 2020-12-16 bsalomon@google.com Revert "Add GrSurfaceFillContext" 2020-12-16 egdaniel@google.com Fix crash on windows viewer when starting in vulkan. 2020-12-16 csmartdalton@google.com Reland "Disable HW tessellation shaders by default" 2020-12-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from fa44979d90aa to 1ca6504eb7bb (1 revision) 2020-12-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from cb8903b14336 to 328f72ae21cb (15 revisions) 2020-12-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 7d81a268 to cdbef3e3 (476 revisions) 2020-12-16 bsalomon@google.com Make backend allocation tests avoid alphatype conversions 2020-12-16 csmartdalton@google.com Tessellation bug fixes 2020-12-16 csmartdalton@google.com Don't tessellate paths that have user stencil settings 2020-12-15 brianosman@google.com SkSL: Only allow 'discard' in fragment shaders 2020-12-15 johnstiles@google.com Avoid creating unnecessary scopes during inlining. 2020-12-15 egdaniel@google.com Refactor beginRenderPass in vulkan. 2020-12-15 csmartdalton@google.com Revert "Disable HW tessellation shaders by default" 2020-12-15 michaelludwig@google.com Top and base device are always non-null 2020-12-15 mtklein@google.com sketch Half in skvm 2020-12-15 bsalomon@google.com Add GrSurfaceFillContext 2020-12-15 csmartdalton@google.com Disable HW tessellation shaders by default 2020-12-15 bsalomon@google.com Remove SK_IGNORE_GPU_CLAMP_BLUR_FIX guard If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1156804 Tbr: tdenniston@google.com Test: Test: Test: Manual verification with angle_end2end_testsTest: Test: angle_perftests --gtest_filter="*whatsapp*" Change-Id: I78eee6f5ccbe7b416e19c9379b5bd6b8375c858c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595211Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837615}
-
Jeffrey Young authored
Notify users that ambient mode will keep their screen on while device is charging. https://screenshot.googleplex.com/8wECcddEPBgB3kD.png BUG=b/175660129 Change-Id: I3d1f1fc96e36bee5f0153303ff442da9c76f3e2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592140 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#837614}
-
Bruce Dawson authored
If you disable the allocator shim while partition alloc is enabled then you will get cryptic linker errors. This change detects these incompatible settings earlier to give a clearer error message. Change-Id: Ifb03d8fccd7c12e89ef62222b34ba3d8dfdd704b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594122Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#837613}
-
Shengfa Lin authored
Only increase retry count when retry has failed. Also increase the max retry count number to 5. Bug: chromedriver:3681 Change-Id: I03fdf89179f7486a96b3cf5c88f1d612805974b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594091Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#837612}
-
Stephen McGruer authored
Test is flaking heavily on chromeos-amd64-generic-rel Bug: 1156795 TBR=jkarlin@chromium.org Change-Id: I8f627f24f01654fe2845aad2cc7629365d9b77fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595589Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#837611}
-
Nohemi Fernandez authored
Chrome will re-generate missing GAIA cookies when the user takes an explicit action that requires user sign-in. For example, if the user clicks on the "Sign in" button in google.com or "Your Data on Maps" in the iOS Maps app. Bug: 1157475 Change-Id: I8c6011959cd90c2ff5b651a831c9570baf559f3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587066 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#837610}
-
Yuki Shiino authored
Cleans up make_steps_of_ce_reactions after https://crrev.com/c/2586019 Change-Id: I1429f49bdedaad27b9aa1c9a2d49528dc2bb1a29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592238Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#837609}
-
Illia Klimov authored
This CL adds AbusiveOriginNotificationPermissionRevocation study into fieldtrial_testing_config.json. Bug: 1159417 Change-Id: Id33d0876d7f6085d3a144a564d8564bc888a7743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595287Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#837608}
-
Clark DuVall authored
ModuleUtil.initApplication() ends up calling SplitCompat.install() with the application context. We need to make sure the application context ClassLoader has been replaced by the chrome ClassLoader at this point, otherwise SplitCompat may not be able to load fake installed splits. This is a bit unfortunate since ModuleUtil.initApplication() is pretty expensive, and the chrome module will no longer be able to preload in parallel, but not sure if there's much that can be done about that. Bug: 1158024 Change-Id: Ie81f7b85100707ed1e8273f57553812918c08a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593518Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#837607}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_chromeos_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: Idce96e9c4e774c1d75f86b5524863c34b3e062d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593851 Auto-Submit: Yuta Hijikata <ythjkt@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#837606}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202012160600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/vut0tWjt1yQoJk5vrwYDcHtYQKjr64przVZjYeqRU6EC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/162466284,b/174321021,b/175249082 Tbr: help-app@grotations.appspotmail.com Change-Id: I965b3bc6157182764a7aced065cc2e5fb8aacc34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595187Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837605}
-
Al Muthanna Athamina authored
This CL was created automatically with tools/perf/update_wpr script R=johnchen@chromium.org Bug: chromium:1158374 Change-Id: Icdd4c45ab0ccfbffe0b4800079f983b0a8229320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593123Reviewed-by:
Tamer Tas <tmrts@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Almothana Athamneh <almuthanna@chromium.org> Cr-Commit-Position: refs/heads/master@{#837604}
-
David Schinazi authored
https://quiche.googlesource.com/quiche.git/+log/875334114827..cfb206c8b386 $ git log 875334114..cfb206c8b --date=short --no-merges --format='%ad %ae %s' 2020-12-15 ianswett Change the return value of CheckBandwidthGrowth to an enum from a bool. No functional change. 2020-12-15 wub Change TlsServerHandshaker::SetTransportParameters to return a SetTransportParametersResult instead of a boolean. 2020-12-15 ianswett gfe-relnote: Change QUIC BBRv2 to reduce bandwidth_lo when the BBQ6, BBQ7, BBQ8, and BBQ9 connection options are present. 2020-12-15 renjietang Allow QUIC applications to access path validation context and explicitly cancel path validation. 2020-12-15 dschinazi Move enforcement of single RETRY from QuicConnection to QuicFramer 2020-12-15 bnc Internal QUICHE change 2020-12-15 dschinazi Make QUIC interop runner print version 2020-12-15 bnc Internal QUICHE change 2020-12-15 bnc Add PRIORITY_UPDATE frame and implement serialization. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=vasilvv@chromium.org Change-Id: Ia9ef8effb9d5d29f7dc58e52c9742fa78055198c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595014 Commit-Queue: David Schinazi <dschinazi@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#837603}
-
Bruce Dawson authored
Window creation is failing occasionally for some users for no clear reason. There appear to be guarantees that the atom parameter is valid but it seems worth getting the data into crash dumps just in case it reveals anything. Bug: 1158704 Change-Id: Ia9ad80d9b3af90298cd7ee1f139362d953362261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593595Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#837602}
-
David Schinazi authored
Change-Id: I7533673833cae9e9356fd9b0589d8a8f9b2da0b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593388 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#837601}
-
David Bokan authored
This CL converts BluetoothEventRouter's methods: - StartDiscoverySession - StopDiscoverySession - SetDiscoveryFilter from base::Closure to base::OnceClosure. The call stack never stores either the |callback| or |error_callback| and each is only ever called once; hence, it's safe to convert these to OnceClosure. BluetoothEventRouter::OnSetDiscoveryFilter is never referenced so is removed. Bug: 1152268 Change-Id: I9a38a87cd029c7009a9fab52b91efd98c9b91d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592187Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#837600}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1608087498-7951485823b3a2725f3c6d796de85103e94919f6.profdata to chrome-win32-master-1608097529-a53990c96ba4fe0e9c85a726eccdb7c47db8df34.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I73612b59d495c07d36809238f5b395ba342ad6c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594873Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837599}
-
Stephen Chenney authored
Bug: 841364 Change-Id: Ibacd58d44e208aa42e85d964c8344519de4e88f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594014 Auto-Submit: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#837598}
-
Roman Aleksandrov authored
Move classes related to text styles inside the dialog. Use host-context to check the orientation so the minimum number of CSS vars are set outside of the object. Bug: 1151292 Change-Id: Ic372098d24dc4af123d5b6ee737b970d3959ae34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593631Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#837597}
-
David Bokan authored
The ConsistencyChecker callback is only ever invoked from DeclarativeRule::Create and never stored so this should be a OnceCallback. Bug: 1152268 Change-Id: I6148ce40bc0a04d25e5ab9c936fd8f83fa7e5b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593936Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#837596}
-
David Bokan authored
The callback in ClearData is either called immediately or passed to other async code that does the same so this callback is only ever called once. Bug: 1152268 Change-Id: I11a0d565a11503955e1224c4e370437c6dba9a35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593877Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#837595}
-
David Bokan authored
ExecuteScript already takes a OnceCallback so this is a trivial change. Bug: 1152268 Change-Id: Ie077677c529ec9a2186aa9b5d97e1405b74f3440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593763Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#837594}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/e07510293160..181d8baf8f01 2020-12-16 dsinclair@chromium.org Add helper for function creation. 2020-12-16 dsinclair@chromium.org Add helper to create StructMember nodes. 2020-12-16 dsinclair@chromium.org Rename Index and Member builder helpers. 2020-12-15 sarahmashay@google.com fix gcc error: changes meaning of Transform 2020-12-15 bclayton@google.com reader/spirv: Fix permissive GCC warning 2020-12-15 dneto@google.com spirv-writer: Exit gracefully when bad inst outside function 2020-12-15 dsinclair@chromium.org Add symbol to member name. 2020-12-15 bclayton@google.com ast: Make all non-semantic fields const 2020-12-15 bclayton@google.com Start cleaning up tests (5/N) 2020-12-15 bclayton@google.com Start cleaning up tests (4/N) 2020-12-15 bclayton@google.com ast::Builder: Remove zero-init Source constructors If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: Ic192628f25b759b48f5d8a3163b73db4d7fc1cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595210Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837593}
-
Jan Wilken Dörrie authored
TBR=poromov Bug: 1159423 Change-Id: I4172f2f1fa777d12e2d2f845a12b3eba41214f3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595527Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#837592}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/a7bb5a5b74f5..455dbfdd428f 2020-12-16 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from e07510293160 to 8b40a67cf792 (9 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: I6471bbab26e20d940e1c0bb50cae78665b986665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595209Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837591}
-
Hans-Filip Elo authored
The file idle_linux.cc contains some precompiler macro statements for non-X11 builds which assumes that the macro NOTREACHED from base/notreached.h is available. When not building with ozone or X11, this macro is not available. This CL adds an include for non X11 builds so that builds not using ozone or X11 succeeds. Change-Id: I1092e4eb8fcab7c326a6e48ca8890b990d6a652a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593116Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#837590}
-
Hiroki Nakagawa authored
The mode is deterministically kPrefetchOnly. It's not necessary to propagate it. Bug: 755921 Change-Id: Ib297fba318436d78d72be3c1f2507bb86a372ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592273Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#837589}
-
Nate Fischer authored
This updates the styleguide to recommend androidx.annotation.Nullable because android.support.* is generally deprecated. We've already migrated chromium to the AndroidX imports, so this just updates the styleguide to be in line with our current practices. This deletes the word "other" from the section header because this is the only reference I could find to Java annotations. Test: tools/md_browser/md_browser.py styleguide/java/java.md Test: Upload to gerrit > open file > click "gitiles" Change-Id: I84a78e3396fc05eeabda1114aab1658593a9be66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593182 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#837588}
-
Robbie Gibson authored
crrev.com/c/2136232 added the ability to block the web content area when an HTTP auth dialog from a different host is displayed. However, in this case, the tools menu site info item is still enabled and shows the incorrect url. This disables that info when the content area is blocked. Bug: 1157800 Change-Id: I0004c0ce608303e41e970f4389481ad31bcd050d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592998 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#837587}
-
Yuta Hijikata authored
This is a mechanical change that renames deprecated macro replacing: - BUILDFLAG(IS_{ASH,LACROS}) with BUILDFLAG(IS_CHROMEOS_{ASH,LACROS}), - gn var is_{ash,lacros} with is_chromeos_{ash,lacros}. There is a section about the renaming on http://go/lacros-macros. Bug: 1052397 Change-Id: If5bf960d24f9b860647288759a411dfd687c3e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593852 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#837586}
-