GitLab

Revert of Scroll interruption tests for CSSOM View smooth scroll (https://codereview.chromium.org/398043005/)

Reason for revert:
fast/scroll-behavior/listbox-interrupted-scroll.html times out on Mac:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fscroll-behavior%2Flistbox-interrupted-scroll.html

Original issue's description:
> Scroll interruption tests for CSSOM View smooth scroll
> 
> This adds a SmoothScrollInterruptionTest class and tests using
> this class.
> 
> BUG=243871
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178387

TBR=vollick@chromium.org,ajuma@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=243871

Review URL: https://codereview.chromium.org/400763003

git-svn-id: svn://svn.chromium.org/blink/trunk@178394 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is split from https://codereview.chromium.org/373503002/.

This call was added back in 2007 in
https://src.chromium.org/viewvc/blink?revision=21093&view=revision. All of the
layout tests continue to pass with the call removed.

BUG=391288

Review URL: https://codereview.chromium.org/397333002

git-svn-id: svn://svn.chromium.org/blink/trunk@178393 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The partial layer invalidation logic that was added in r176815 was not
properly transforming the invalidation region from the layer's local
frame of reference to the layer's content area.  The proper logic
already existed for non-accelerated 2d canvases, but we were short-
circuiting it whith acceleration enabled because we did not
support partial invalidations in the past.  This fix makes
accelerated 2D canvases use the same invalidation code path as
non-accelerated canvases.

TEST=fast/canvas/canvas-partial-invalidation-zoomed.html
BUG=393192
NOTRY=true

Review URL: https://codereview.chromium.org/402613006

git-svn-id: svn://svn.chromium.org/blink/trunk@178392 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This contains fixes for the following sorts of issues:
* Possibly-uninitialized local variable
* Assignment inside conditional
* Signedness mismatch

This also contains a small number of other cleanups to nearby code.

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/383153007

git-svn-id: svn://svn.chromium.org/blink/trunk@178391 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=vsevik

Review URL: https://codereview.chromium.org/397273005

git-svn-id: svn://svn.chromium.org/blink/trunk@178390 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=v8:2948

Review URL: https://codereview.chromium.org/323523004

git-svn-id: svn://svn.chromium.org/blink/trunk@178389 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch reorganizes the flakiness dashboard to group results by
blink revision so that regressions are easier to spot.

With patch:
http://head-and-shoulders.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=svg%2Fbatik%2Ffilters%2FfeTile.svg

Without patch:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=svg%2Fbatik%2Ffilters%2FfeTile.svg

This patch works by creating an array of the unique builds. In the
simplest case this array will have a blink revision corresponding to
each unique build, and each column in the flakiness results will
correspond to one of these blink revisions. Because a bot can run a
test multiple times for the same blink revision (e.g., if the chrome
version changed), blinkBuildRevisions can return multiple
entries with the same blink revision.

htmlForTestResults has been updated to use the new unique revisions.

To make the results easier to understand, we "interpolate" results
for revisions that were not tested. For example, if r123 passed and
r126 passed, r124 can be an interpolated result which probably passed.
These interpolated results use a lighter color.

NOTRY=true

Review URL: https://codereview.chromium.org/359533004

git-svn-id: svn://svn.chromium.org/blink/trunk@178388 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This adds a SmoothScrollInterruptionTest class and tests using
this class.

BUG=243871

Review URL: https://codereview.chromium.org/398043005

git-svn-id: svn://svn.chromium.org/blink/trunk@178387 bbb929c8-8fbe-4397-9dbb-9b2b20218538

SPEC: http://dom.spec.whatwg.org/#dom-node-textcontent

Current spec describes to use new text node
on setting Node.textContent
However, current implementation added early return
for optimization purpose.

So this CL added a note as well as crbug pointer
to describe those explicitly.

TEST=LayoutTests/fast/dom/Node/textContent.html

Review URL: https://codereview.chromium.org/383163003

git-svn-id: svn://svn.chromium.org/blink/trunk@178386 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Check that we have an ExecutionContext to deliver a process event to
before dispatching.

R=haraken@chromium.org
BUG=394718

Review URL: https://codereview.chromium.org/398573005

git-svn-id: svn://svn.chromium.org/blink/trunk@178385 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/402633002

git-svn-id: svn://svn.chromium.org/blink/trunk@178384 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=361045

Review URL: https://codereview.chromium.org/391373008

git-svn-id: svn://svn.chromium.org/blink/trunk@178383 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=jochen@chromium.org

Review URL: https://codereview.chromium.org/399953002

git-svn-id: svn://svn.chromium.org/blink/trunk@178382 bbb929c8-8fbe-4397-9dbb-9b2b20218538

MS Shell Dlg is the aliased font name that means "the one font that
shall always be available" per http://msdn.microsoft.com/en-us/library/windows/desktop/dd374112(v=vs.85).aspx
DirectWrite doesn't like that name, but we add the two fonts that it
can map to so that we can be very certain to succeed on retreiving a
font, even if Arial has gone missing.

R=eae@chromium.org
BUG=383542

Review URL: https://codereview.chromium.org/402503003

git-svn-id: svn://svn.chromium.org/blink/trunk@178380 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This should fix a couple of the crashes we are seeing in the debug oilpan builds for websockets.

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, tyoshino@chromium.org, vegorov@chromium.org, yhirano@chromium.org, zerny@chromium.org
BUG=

Review URL: https://codereview.chromium.org/405453002

git-svn-id: svn://svn.chromium.org/blink/trunk@178379 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We have to force a GC to ensure the registered event handler are removed. This happens during weak processing with oilpan.

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, jochen@chromium.org, oilpan-reviews@chromium.org, rbyers@chromium.org, skyostil@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=

Review URL: https://codereview.chromium.org/391373009

git-svn-id: svn://svn.chromium.org/blink/trunk@178378 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Makes ConsoleBase, instead of its subclasses, inherit from ScriptWrappable.

BUG=235436

Review URL: https://codereview.chromium.org/396803011

git-svn-id: svn://svn.chromium.org/blink/trunk@178377 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change removes "Timeline tracing mode" and "Timeline flame chart" experiments. The latter is merged into "Timeline on trace events".

BUG=361045

Review URL: https://codereview.chromium.org/396803008

git-svn-id: svn://svn.chromium.org/blink/trunk@178376 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=178354

BUG=234871
TBR=keishi@chromium.org

Review URL: https://codereview.chromium.org/399933003

git-svn-id: svn://svn.chromium.org/blink/trunk@178375 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=apavlov

Review URL: https://codereview.chromium.org/400673002

git-svn-id: svn://svn.chromium.org/blink/trunk@178374 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=392793
R=apavlov, dgozman

Review URL: https://codereview.chromium.org/403493003

git-svn-id: svn://svn.chromium.org/blink/trunk@178372 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=394587

Review URL: https://codereview.chromium.org/402563003

git-svn-id: svn://svn.chromium.org/blink/trunk@178371 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=394313

Review URL: https://codereview.chromium.org/403523005

git-svn-id: svn://svn.chromium.org/blink/trunk@178370 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I've found that requests in network panel are not refreshed,
because detached nodes ignore refresh request.

BUG=

Review URL: https://codereview.chromium.org/398263003

git-svn-id: svn://svn.chromium.org/blink/trunk@178369 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now all invocation of {,un}setPendingActivity is gone!
Removing them from ActiveDOMObject.

The default implementation of hasPendingActivity is still left, as there
are some classes deriving from ActiveDOMObject to receive suspend() and
resume() notifications.

BUG=354845

Review URL: https://codereview.chromium.org/401603003

git-svn-id: svn://svn.chromium.org/blink/trunk@178368 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It turns out that flakes happen only in tests that use
ViewportControl.forceScrollItemToBeLast method. This patch starts using
ViewportControl.forceScrollItemToBeFirst instead.

BUG=390204
TBR=vsevik

Review URL: https://codereview.chromium.org/399753003

git-svn-id: svn://svn.chromium.org/blink/trunk@178367 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When a Node is about to get deleted from the Document, we should always
remove any event handlers it has registered to the EventHandlerRegistry
-- regardless of whether the Node has EventTargetData or not. This is
because native code may register nodes as having handlers without
actually inserting any handlers in in the node's event target data.

BUG=393312,393154
TEST=WebViewTest.DeleteElementWithRegisteredHandler

Review URL: https://codereview.chromium.org/392283002

git-svn-id: svn://svn.chromium.org/blink/trunk@178366 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken@chromium.org, oilpan-reviews@chromium.org, wibling@chromium.org
BUG=382557

Review URL: https://codereview.chromium.org/402433005

git-svn-id: svn://svn.chromium.org/blink/trunk@178365 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=yurys,loislo

Review URL: https://codereview.chromium.org/399873002

git-svn-id: svn://svn.chromium.org/blink/trunk@178364 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since it is allowed now to hold a reference on dead target, this test isn't actual anymore

BUG=390513
TBR=vsevik

Review URL: https://codereview.chromium.org/403523004

git-svn-id: svn://svn.chromium.org/blink/trunk@178363 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now that we have a private script isolated world, map.size() is not guaranteed to be equal to isolatedWorldCount(). We can just remove the ASSERT (rather than inventing a more complicated ASSERT condition).

BUG=394230

Review URL: https://codereview.chromium.org/404473003

git-svn-id: svn://svn.chromium.org/blink/trunk@178362 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=lushnikov
BUG=394665

Review URL: https://codereview.chromium.org/399883002

git-svn-id: svn://svn.chromium.org/blink/trunk@178361 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use the existing getter for the top element and do the ancestor test
in a more direct manner.

BUG=383813
R=falken@chromium.org

Review URL: https://codereview.chromium.org/392913002

git-svn-id: svn://svn.chromium.org/blink/trunk@178360 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This test makes sure that many service workers can work simultaneously without
any crashes.


BUG=392735
TEST=run_webkit_tests.py --details --debug http/tests/serviceworker/

Review URL: https://codereview.chromium.org/394133002

git-svn-id: svn://svn.chromium.org/blink/trunk@178359 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=178350

BUG=392724
TBR=dominik.rottsches@intel.com

Review URL: https://codereview.chromium.org/400533005

git-svn-id: svn://svn.chromium.org/blink/trunk@178358 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove unneeded break because the return makes it unreachable.

Review URL: https://codereview.chromium.org/392403003

git-svn-id: svn://svn.chromium.org/blink/trunk@178357 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change will be used in an other CL to resolve the attached bug.

BUG=170021

Review URL: https://codereview.chromium.org/392383005

git-svn-id: svn://svn.chromium.org/blink/trunk@178356 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Passed v8::Context can be empty in some cases, for example, when checking
an execution context to resolve/reject a promise after a window object
(v8 context) is gone.


BUG=n/a
TEST=n/a

Review URL: https://codereview.chromium.org/398223004

git-svn-id: svn://svn.chromium.org/blink/trunk@178355 bbb929c8-8fbe-4397-9dbb-9b2b20218538

User visible behavior changes.
- Old listbox could only scroll in itemHeight increments but now we have smooth scroll.
- Mouse events need to be dispatched on the option element, not select element.
- Select element height is determined based on the height of the first item, not the font size.
- Spatial navigation now draws a black dashed outline around the active selection instead of a focus ring.

We can no longer let RenderListBox draw the focus ring for spatial navigation mode because the items are drawn on another RenderLayer.
I added a user agent stylesheet only :-internal-spatial-navigation-focus pseudo type so a style can be applied to the spatial navigation active element.
If we add the default focus ring on the option element, it gets clipped to the select element so I changed it to a black dashed outline.

Option and optgroups were represented as AXListBoxOptions but now only options are AXListBoxOptions and optgroups are represented by the optgroup-label AXNodeObject. We let AXRenderObject handle hit testing so we can remove the custom hit testing.

BUG=234871

Review URL: https://codereview.chromium.org/347773002

git-svn-id: svn://svn.chromium.org/blink/trunk@178354 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken@chromium.org, oilpan-reviews@chromium.org, wibling@chromium.org
BUG=382557

Review URL: https://codereview.chromium.org/398793002

git-svn-id: svn://svn.chromium.org/blink/trunk@178353 bbb929c8-8fbe-4397-9dbb-9b2b20218538