- 04 Oct, 2019 40 commits
-
-
Christian Biesinger authored
R=thakis@chromium.org Bug: 941669 Change-Id: Ib54429dcbebf65b6274ec294e862deaf77c32194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842311 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#702979}
-
gogerald authored
This is the second patch of splitting the bigger one https://chromium-review.googlesource.com/c/chromium/src/+/1797069 It depends on https://chromium-review.googlesource.com/c/chromium/src/+/1817106 Screenshots https://drive.google.com/file/d/1FBGZygqGDlFA2e1Mr_81HAVWpzn_1-yc/view?usp=sharing Additional design discussion context: https://docs.google.com/document/d/1Igy8tZll_WtZyg7c5lxWzOYuxb3OGzJ39YcBW_em37s/edit?usp=sharing Bug: 982018 Change-Id: Ib93ae336cd77eb89296ed5cb68b2b62f5b45b94d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822820 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#702978}
-
danakj authored
This is a reland of 8f0dc968 Original change's description: > Don't PostTask the RenderWidget::Close() call. > > The post task in RenderWidget was in order to keep IPC receipt of > destruction of a frame-based RenderWidget (ie a RenderView in the past) > from happening while the RenderWidget was already closing due to the > renderer-side detaching, but running a nested message loop. > > The RenderView destruction now already does a PostTask hop in > RenderThreadImpl before starting destruction of the RenderViewImpl > and its frame tree and RenderWidgets. A RenderWidget for a frame closes > when the frame detaches, and that is built to be consistent even if > it occurs inside of unload. The RenderWidget does not need to be kept > around after the blink frame and RenderFrame and WebWidget associated > with it are all gone. > > Popups and pepper RenderWidgets can close during a frame unload without > a consistency problem. > > R=dcheng@chromium.org > > Bug: 419087 > Change-Id: Ia5f7ca07395f8a5bd2c60a974a0fb4fb5092d872 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832612 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702868} TBR=dcheng Bug: 419087 Change-Id: I0f68df454e2873d7e6f3eeb38ff41563c16f6a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841942Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#702977}
-
Maksim Ivanov authored
Fix a few errors in the KeyRotationDeviceCloudPolicyTest.Basic browser test - some of them were presumably causing the flakiness that led to the test being disabled, some of them were accidentally added during later refactorings: 1. Correctly pipe through LocalPolicyTestServerMixin the needed settings of policy_testserver: the usage of signing keys bundled into the Python server and the automatic rotation of the signing key with every policy request. 2. Fix misplaced calls in the test's SetUp() phase: everything needs to be done *before* calling the parent SetUp() in order to run before the test. 3. Make the test less fragile by doing two explicit fetches of policy inside the test body and checking that the key got rotated in between (instead of relying on the device policy stack making the first policy fetch during its initialization and on the right parity of the PolicyBuilder's policy key version). Bug: 900631 Test: run the test 10'000 times (browser_tests --gtest_filter="KeyRotationDeviceCloudPolicyTest.Basic") Change-Id: I5eaa4f6e03a54dcc26319d39323f5edf51904c65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829383 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#702976}
-
Eric Stevenson authored
This CL is based on http://crrev.com/c/1014739. Locally tested that the SubresourceFilterTests run since they're currently disabled on master (3 failed, 2 passed). Bug: 1010218 Change-Id: I03f63e7b852d69d82db11feb4bae5278a0139316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838632Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#702975}
-
Omer Katz authored
This reverts commit f4e68ca6. Reason for revert: applying asan to WTF::Vector still causes failures (e.g. https://crbug.com/993415) Original change's description: > Enable asan on WTF::Vector for x86 > > Bug: 461406 > Change-Id: I239725947a9fa39a9089af29a68a85c3b7c238df > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803147 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Omer Katz <omerkatz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#696359} TBR=haraken@chromium.org,omerkatz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 461406 Change-Id: Ia14e4d0f1cc75127c15d6188bbc7ac9d11181990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841555 Auto-Submit: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#702974}
-
Yusuke Sato authored
BUG=b:139752657 TEST=try Change-Id: I296a6f056f1f6197c25b5fe5a8d2ce4a768975da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836993Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#702973}
-
Shakti Sahu authored
InfoBarContainerLayout is a FrameLayout, which seems to keep references to its children after onMeasure call, even if they might have been removed. This causes DownloadProgressInfoBar to leak memory, if we move to another tab and keep downloading, while in theory we close the infobar of the background tab. OptimizedFrameLayout actually clears the references after onMeasure, hence using that seems to fix this issue. Bug: 1008906 Change-Id: I292331d3315728005fe7e81d03a08b00c2bcfab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838912Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#702972}
-
Maksim Sisov authored
This is a very X11 specific method. Thus, move it to X11 space. Bug: 990756 Change-Id: I69ee7b59f62c3bd3f2f4fd6af5a5a3183e04743d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834090 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#702971}
-
Brandon Wylie authored
Reverting crrev/c/1818604, which caused a crash. Replacing the logic introduced in that change here in a way that doesn't rely on the the ordering of the callback. Bug: 1004903, 1009832 Change-Id: Ie8e34325648704aa7068113e60aac74d8d685d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835177Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ender <ender@google.com> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#702970}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/6fff5122a23e..a580e2d761c1 git log 6fff5122a23e..a580e2d761c1 --date=short --no-merges --format='%ad %ae %s' 2019-10-04 capn@google.com Remove Vulkan project from Visual Studio solution 2019-10-04 pjackson@google.com Support LLVM 8+ with Reactor Created with: gclient setdep -r src/third_party/swiftshader@a580e2d761c1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/139189696,chromium:b/139412871 Change-Id: I88112da1f92eaa123bdf08088117958e38245e2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841693Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702969}
-
Manas Verma authored
On Android, ensuring that if user unchecks checkbox for WebAuthn offer, it remains unchecked. Bug: 949269 Change-Id: I7214abc01d40d916ba14b2b6d3bb55faa871608c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825796Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#702968}
-
Steven Bennetts authored
Bug: 996418 Change-Id: I3d0dc82c0bbd9f4e9891058afd7766e8eb6a4494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838052 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#702967}
-
Andrew Grieve authored
Chrome's many GN args make this check more trouble than it's worth. Change-Id: Id2fac9e67398c6b4b788fb36b2404248a8ca8357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838545Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#702966}
-
BUG=762641 TBR=rkc@chromium.org Change-Id: I6e25edb1a996a65d4e77261e327cf865605f92f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841936Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702965}
-
Matt Wolenetz authored
Coverage and inspection revealed a method in SourceBufferStream and several test helpers in SourceBufferStreamTest to be obsolete and unused. Change-Id: I663c822d30811b882068b19c1335cee51d266cc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838682Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#702964}
-
Andrew Grieve authored
md5_check.py is useful only when not all inputs are generated. For the main dex list builder, all inputs are generated. Change-Id: Ied81917b719d55785bad89ef8d3e6e232274125a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838309Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#702963}
-
Nate Fischer authored
No change to logic. std::function is banned by the style guide. This replaces its use in FileMetricsProviderTest with base::OnceCallback. This resolves a presubmit warning. Bug: 1010369 Test: out/Default/metrics_unittests --gtest_filter=*FileMetricsProviderTest.* Test: git cl presubmit --upload Change-Id: I681c9309940e29814c4369d3a16d09f6d00e1ec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838398 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#702962}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5a42da564fbe..6b60dfd80e3d git log 5a42da564fbe..6b60dfd80e3d --date=short --no-merges --format='%ad %ae %s' 2019-10-04 cnorthrop@google.com Vulkan: Remove image views forced to one mip level 2019-10-04 geofflang@chromium.org GL: Update RenderbufferGL to use ANGLE_GL_TRY. 2019-10-04 geofflang@chromium.org GL: Fix support for glCopyTextureCHROMIUM with source rectangle textures. Created with: gclient setdep -r src/third_party/angle@6b60dfd80e3d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Bug: chromium:990368 Change-Id: Icb5a13f09e5db77d285c5fd38776e766131b2b64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841714Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/666d4144..35874570 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8191957d965c659258d5e398cd90fe2c1270d6cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841533Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702960}
-
Ioana Pandele authored
This is a reland of 3dd37620/ The previous CL was reverted since it was thought to have broken http/tests/credentialmanager/credentialscontainer-get-with-virtual-authenticator.html on Win10 Tests x64. Relanding since it's an iOS-only CL, which couldn't have broken windows layout tests. TBR=vasilii@chromium.org Original change's description: > Reland "[iOS] Make the leak detection backend available on iOS" > > This is a reland of 74640a89 > > TBR=vasilii@chromium.org > > Original change's description: > > [iOS] Make the leak detection backend available on iOS > > > > Bug: 986317 > > > > Change-Id: I9d799cd24551f13bc58eac91c843d2da19aa7851 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832267 > > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > > Commit-Queue: Ioana Pandele <ioanap@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#702059} > > Bug: 986317 > Change-Id: I490b8d96074e1786b74905a083f0554fe914b4c8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840771 > Reviewed-by: Ioana Pandele <ioanap@chromium.org> > Commit-Queue: Ioana Pandele <ioanap@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702835} Bug: 986317 Change-Id: I4d48f378e44677d02c4f316cc406209195dabc6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841553Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#702959}
-
Gabriel Marin authored
BUG=b:142130923 Change-Id: I2401c97b6e00b849a41c6cfe71007d7ab31fe3a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842119Reviewed-by:
Gabriel Marin <gmx@chromium.org> Reviewed-by:
George Burgess <gbiv@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#702958}
-
Avery Musbach authored
When you are dragging from overview in split view and you rotate the screen while a snap preview is shown, the bounds of the snap preview shall update for the new screen orientation. Test: manual Bug: 1011391 Change-Id: I21f6946d7e31bd19551a69b28126e9af2f443c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842171Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#702957}
-
Daniel Rubery authored
The BrowserURLLoaderThrottle now checks the current BrowserContext to determine whether real-time checks are enabled at all, then passes that information to the SafeBrowsingUrlCheckerImpl. Bug: 991394, 963165, 1001566 Change-Id: I5dbff848a4ea5a6ae3ac5c76e5d5624596ee3616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825482Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#702956}
-
chrome://sandboxAlex Gough authored
There should be no functional changes. Existing js will now have its types checked by the closure_compile target on builds. Bug: 997273 Change-Id: Ieb9d06b4260238b72381863d5efae49840b61122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836136 Auto-Submit: Alex Gough <ajgo@chromium.org> Reviewed-by:
-
Josh Karlin authored
Change-Id: I7b724df7fcd92ee7cb0f400cc03937987241e0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717909Reviewed-by:
-
John Emau authored
This will be useful if the progress bar does not start at 0 or if the value set is not 0-100 such as a text value. Bug: 963183 Change-Id: Idc00352a2663629041d1ea30b0bebf27cbf31085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1701633Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: John Emau <John.Emau@microsoft.com> Cr-Commit-Position: refs/heads/master@{#702953}
-
Eric Stevenson authored
Hit this in crbug.com/1011149: moving a file without changing its contents doesn't cause it target to appear stale, so an incremental build could pass even if there are issues (ex. didn't update package to match the new file path). Bug: 1011149 Change-Id: I280f27deaf2d5e4f8cebe464d7f3afb6965cdbbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841814Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f77a4786a334..f0d7ef8e4fe6 git log f77a4786a334..f0d7ef8e4fe6 --date=short --no-merges --format='%ad %ae %s' 2019-10-04 primiano@google.com gen_android_bp: use gn_utils Created with: gclient setdep -r src/third_party/perfetto@f0d7ef8e4fe6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:132880619,chromium:115873049 Change-Id: I9698d66535e61d56f2dd8f50c85ba1d7d809c64c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841653Reviewed-by:
-
Alex Chau authored
- Wire up SharingSyncPreference and LocalDeviceInfoProvider - Added RefreshLocalDeviceInfo to update SharingInfo in sync Bug: 991971 Change-Id: Ic03a9d3f276b37eebe1eebd4d3afb52b5d5644ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816503Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#702950}
-
Jesse McKenna authored
This change enables PWAs registered as file handlers to appear in the "Open With..." menu with a custom icon on Windows 8 and later. On Windows 8 and later versions, when an application is registered as a handler for a file type, the icon that is displayed in the "Open With..." menu next to the application's name is controlled by registry value HKCR/<application ProgID>/Application::ApplicationIcon. This value can be a reference to an executable or .ICO file, and has the syntax ".../my_icon.ico,0". This change extends ShellUtil::AddFileAssociations(), which will soon be used to register Progressive Web Apps (PWAs) as file handlers on Windows, to set ApplicationIcon. Bug: 960245 Change-Id: If9ef55d21d71b00b47ce3246b333efa38c2965cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832464Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#702949}
-
Dmitry Gozman authored
This moves the call up from DocumentLoader to FrameLoader, so that we can combine it with other client calls (like DidStartProvisionalLoad). DocumentLoader::InstallNewDocument has been split into two parts (InstallNewDocument and CreateParserPostCommit) - before and after DidCommitLoad. Old call hierarchy: - DocumentLoader::StartLoading - DocumentLoader::StartLoadingResponse - DocumentLoader::FinishNavigationCommit - DocumentLoader::InstallNewDocument part1 - DocumentLoader::DidCommitNavigation - Client::DispatchDidCommitLoad - DocumentLoader::InstallNewDocument part2 ... loading response New call hierarchy (note that order is the same): - DocumentLoader::StartLoading - DocumentLoader::FinishNavigationCommit - DocumentLoader::InstallNewDocument part 1 - DocumentLoader::DidCommitNavigation - Client::DispatchDidCommitLoad - DocumentLoader::StartLoadingResponse - DocumentLoader::CreateParserPostCommit equals InstallNewDocument part2 ... loading response This corresponds to the step 7.d from the doc linked to the bug. Bug: 855189 Change-Id: Ifb6fb8f732f4f4250c2879268c2c3c083101aec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818292Reviewed-by:Camille Lamy <clamy@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#702948}
-
Francois Doray authored
content::LockObserver is notified when a frame starts/stops holding lock, i.e. when the number of locks it holds switches between zero and non-zero. The observer interface will be used by Chrome to avoid freezing tabs that hold Web Locks. See discussion for context: https://groups.google.com/a/google.com/d/msg/chrome-catan/kwOKhvrMGfU/gEUTPUtUAwAJ Bug: 980533 Change-Id: Ie94929f739200d7afaca6b25e5db9bed0625b40c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815729Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#702947}
-
kylechar authored
SkiaOutputSurfaceImpl did not handle the color space changing after it was created previously. The SkSurfaceCharacterization color space was only set during the first time Reshape() ran when the charactization is returned from the GPU thread. If the color space was changed later the SkSurface and SkDDL color spaces no longer matched and draw failed. Bug: 1009452 Change-Id: Ib6d2083efc7e7eb6f94782342e92a809b69d6fdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841811Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#702946}
-
Ryan Sturm authored
We experimented with this feature on Android only, and determined it is worth launching. We will explore this space more in the future (especially Desktop experiments). The launching arm is slightly different than what was in fieldtrial_testing_config.json as HTML+CSS+SyncScript performed best in Stable. Bug: 934466 Change-Id: Id5d4e5ea9558133704639a5cc902e520a2bf6370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838756Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Auto-Submit: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#702945}
-
David Benjamin authored
See https://boringssl-review.googlesource.com/c/boringssl/+/37944 for the rationale. Bug: 950706, 958638 Change-Id: I221b0e7f6f626968fc38e0bce84260e4141c5e44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838456Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#702944}
-
Toni Barzic authored
Test fixes: AppListPresenterDelegateZeroStateTest.ClickSearchBoxInTabletMode * test was incorrectly calculating search box bounds in midst of an animation - fixed by making animations non zero length after initial test state was set up AppListModelFolderTest.FolderItem * tests behavior expected when the feature is off AppListViewTest.AppsGridViewVisibilityOnReopening * with the new feature, apps grid is shown faded in the background on search results page - updated the expectation BUG=976947,976954 Change-Id: Ia571dc6026b5d0c0dd512e6dc69e2d22492343ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838928 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#702943}
-
Koji Ishii authored
This patch eliminates the call to |HandleOverflow| when the |NGLineBreaker| state is 'overflow'. r701601 (crrev.com/c/1826063) added the 'overflow' state to |NGLineBreaker|. This state makes the `trailing' state more efficient, but when multiple text runs appear without any break opportunities in the 'overflow' state, the change added a call to |HandleOverflow| on each text run. Bug: 1010487 Change-Id: I608b704a9b65f905e6b57c245ea8f5dac7194c64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838791Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#702942}
-
Mario Sanchez Prada authored
This CL eliminates the need for having those versions of these templated methods available by migrating the few references to the old Mojo types in those places that interact with them, so we can remove them along with such migrations, all in one go. Bug: 955171, 978694, 936482 Change-Id: I42925b0fc504c00a9ce419f9b7d7298c7a33766a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832810Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#702941}
-
Mikhail Khokhlov authored
Skipped stories may have traces and metrics defined but it doesn't make sense to run metrics computation on them. Bug: 981349 Change-Id: Id1453a9d00a83c12975ccacb45f2c8ffcd9815d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841334 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#702940}
-
