GitLab

Per https://crbug.com/795110#c3, newer fontconfigs are threadsafe.
https://bugs.chromium.org/p/skia/issues/detail?id=1497 suggests the relevant
version is 2.10.91. third_party/fontconfig is newer than that now, so remove
the suppression.

Bug: 795110
Change-Id: Ib9297814d682e75278c6d9d78d6c7d5315b5fce1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643027
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665931}

This CL makes the implementation match the changes in the explainer:
https://github.com/WICG/element-timing. In particular, name is now set
to "image-paint" for image entries, and url is added.

Bug: 879270
Change-Id: Id02e5305ac1e9bf9fa1fc18efe63d8cc280c5f4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635733Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665930}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d4e26bda..9672bf6d

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I42687ecf102ef2ede57e7ed98e97653261f29d57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643309Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#665929}

Add enum option for Skia Vulkan, and enable filters pixeltests that are
passing on X11 with vulkan Swiftshader.

Bug: 963446
Change-Id: I31541555ef0123a3dd894180898d251720b807fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641382Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665928}

Enable size reductions:

* HB_NO_UCD ensures that UCDN is not built-in to avoid a size increase
  of around 60k
* HB_NO_MATH to disable OT MATH table parsing until we need it,
* HB_NO_NAME, since we currently do not use HarfBuzz' OT name table
  parsing,
* HB_NO_BUFFER_SERIALIZE" since we are not making use of HarfBuzz buffer
  serialization, usually used by tools such as hb-view/hb-shape or for
  debugging.

https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/c73d7ba75d45..97b926857759

$ git log c73d7ba75..97b926857 --date=short --no-merges --format='%ad %ae %s'
2019-06-01 ebrahim [ci] Downgrade Travis distribution upon Behdad request
2019-06-01 ebrahim [ci] Install ragel on appveyor mingw bots
2019-06-01 ebrahim [dwrite] Replace REPLACEME with release version the symbol had
2019-05-31 behdad 2.5.1
2019-05-31 behdad [docs] Fix dist
2019-05-31 behdad Fourth try at building VS bots
2019-05-31 behdad [ci] Disable VS 2013
2019-05-31 behdad Third try at fixing VS build
2019-05-31 behdad Second VS fix try
2019-05-31 behdad Try fixing VS builds
2019-05-31 behdad [ci] Enable other versions of Visual Studio
2019-05-31 behdad Whitespace
2019-05-31 rsheeter [subset] Correct calculation of max offset; fixes bug where loca would erroneously be short
2019-05-31 behdad [gsub] Minor
2019-05-31 behdad [gsub] Porting serialize to iterators
2019-05-31 behdad [serialize] Pass offset to serialize_subset()
2019-05-31 behdad [serialize] Pass offset to serialize_copy()
2019-05-30 behdad [math] Rename HB_MATH_GLYPH_PART_FLAG_EXTENDER
2019-05-29 ebrahim [ci] Clean up and add disabled bots of other msvc versions (#1733)
2019-05-28 bruce.mitchener Fix some typos.
2019-05-28 ebrahim [test] minor, fix copyright
2019-05-28 ebrahim [test] minor style improve
2019-05-26 corbett.dav [use] Allow U+1A60 TAI THAM SIGN SAKOT after vowel
2019-05-27 behdad [atomic] Fix warning, second time
2019-05-25 behdad [ucd] Update for latest packTab
2019-05-25 behdad [ucd] Update for recent packTab
2019-05-25 ebrahim [ci] minor
2019-05-25 ebrahim [ci] minor
2019-05-25 ebrahim [ci] Store dist-win result instead
2019-05-25 behdad [atomic] Fix warnings
2019-05-25 behdad [mingw] Update instructions
2019-05-25 behdad [mutex] Prefer pthread over windows
2019-05-25 behdad Look for pthread even if win32
2019-05-25 behdad [mingw] Some more tweaks
2019-05-25 behdad [mingw] Add "make dist-win" to toplevel Makefile
2019-05-25 behdad [mingw] More
2019-05-25 ebrahim [ci] Remove --without-icu now that we have it in ./mingw{32,64} scripts
2019-05-25 behdad [mingw] Force off ICU
2019-05-25 ebrahim [ci] Build mingw on Fedora and store .exe outputs
2019-05-25 behdad [ming2] Update instructions
2019-05-25 behdad [mingw] Rename README.wine
2019-05-25 behdad [mingw] Update for recent change
2019-05-25 behdad [mingw] Update for Fedora mingw installation location
2019-05-25 nwillis Usermanual; minor.
2019-05-24 behdad [win] Add mingw-ldd.py
2019-05-24 behdad 2.5.0
2019-05-24 behdad Put back Since: tags for hb_color_get_*
2019-05-24 nwillis Usermanual-buffers-chapter: trim out fallback-of-ufuncs talk and just mention that stuff exists if you care to go find it.
2019-05-24 qxliu Fix fuzzer crash testcase
2019-05-24 nwillis Usermanual-buffers-chapter: explain ICU fallback for Ufuncs.
(...)
2019-05-15 behdad Use hb_map(hb_add(this)) to dereference OffsetTo<>'s
2019-05-15 behdad [algs] Rename hb_bind to hb_partial
2019-05-15 behdad [algs] Change hb_bind parameter number to be from one
2019-05-15 behdad Add back symmetric OffsetTo<>::friend operator+
2019-05-15 behdad [algs] Partialize all operators
2019-05-15 behdad [algs] Rewrite bind API
2019-05-15 behdad [algs] Add hb_bind0 and hb_bind1
2019-05-15 behdad Fix clang build
2019-05-15 behdad Fix clang build
2019-05-15 behdad [algs] Remove pair copy constructor
2019-05-15 behdad Whitespace
2019-05-09 grieger [subset] Switch SingleSubst to use iterators in serialize.
2019-05-15 behdad Reduce captures of lambdas
2019-05-15 behdad Fix tests
2019-05-15 behdad Remove variadic form of hb_min/hb_max
2019-05-15 behdad Add arithmetic operators
2019-05-15 behdad Add hb_bitwise_* ops
2019-05-15 behdad [array] Adjust operator!=
2019-05-15 behdad More adjustment to OffsetTo<>::friend opeator+
2019-05-15 behdad [iter] Simplify operator!= of iterator filters
2019-05-15 behdad Add all pair_t comparison operators
2019-05-15 behdad [iter] Use default operators instead of redefining empty ones
2019-05-15 corbett.dav Convert Consonant_Initial_Postfixed to CONS_MED
2019-05-15 corbett.dav Fix record-test.sh on machines without sha1sum
2019-05-15 ebrahim [ci][test] Ignore other gcov symbols also
2019-05-15 ebrahim [ci][travis] Update its distribution
2019-05-15 behdad Another try
2019-05-15 behdad Completely revert the thing back
2019-05-15 behdad Another try at fix
2019-05-15 behdad Ugh.  How was the Travis bot happy before, but isn't now?! :(
2019-05-15 behdad Move OffsetTo operator+ back out of class
2019-05-15 behdad Revert "Revert symmetric OffsetTo overloads"
2019-05-15 behdad Revert symmetric OffsetTo overloads
2019-05-15 behdad Use implicit lambda return type
2019-05-14 behdad Add symmetric friend operator+ for OffsetTo
2019-05-14 behdad Move OffsetTo<> deref operators in-class as friends
2019-05-14 behdad Whitespace
2019-05-14 behdad [iter] Remove sort categorization
2019-05-14 behdad Start of gen-ucd.py, to replace UCDN
2019-05-13 qxliu [subset] retian nameids from STAT and fvar tables
2019-05-14 behdad Hopefully last warning fix
2019-05-14 ebrahim [ci] add HB_TINY to asmjs builder
2019-05-14 ebrahim Fix -Wunused-function on HB_NO_SHAPE_AAT
2019-05-11 nwillis Usermanual, fix up userfeatures example code in OpenType features section of shaping chapter.
2019-05-11 nwillis Usermanual, minor: flesh out invisible-glyph discussion in buffers chapter.
2019-04-30 nwillis [Docs] Usermanual; update XML manifest for new chapters.
2019-04-30 nwillis [Docs] Usermanual; add Utilities chapter.
2019-04-30 nwillis [Docs] Usermanual; add Shaping, Features, and Plans.
2019-04-30 nwillis [Docs] Usermanual; add Fonts And Faces chapter.
2019-04-30 nwillis [Docs] Usermanual; fill out Buffers chapter.

Created with:
  roll-dep src/third_party/harfbuzz-ng/src
R=bashi@chromium.org,behdad@chromium.org,bungeman@chromium.org,drott@chromium.org,eae@chromium.org,jshin@chromium.org

Bug: 969685
Change-Id: I1adff3c14741145ef228ff3990435928dd04c1ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640414
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665927}

Bug: 968928

Change-Id: I0d52b73349711cd85a930b35ae659662e18a899c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640827Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665926}

- Adds new net::CacheType values so the JS code cache can be distinguished
  from the WASM code cache. GENERATED_BYTE_CODE_CACHE refers to Javascript,
  GENERATED_NATIVE_CODE_CACHE refers to WebAssembly.
- Changes SimpleBackendImpl::MaxFileSize to allow PNACL and WASM cache
  entries to take up to 1/2 of the cache. The previous limit was 1/8 of
  the cache.

This CL makes it possible for apps with large WASM modules (150 MB) to
benefit from code caching on desktop. The limit of 1/2 the cache size is
somewhat conservative. PNACL entries are also native code and can occupy
the entire cache (see BackEndImpl::MaxFileSize).

Bug: chromium:719172
Change-Id: Id177862f00c138034d43a5256d317928a48aa467
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636648Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Mythri Alle <mythria@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665925}

This CL is adding a test that will fail when the system doesn't have the
default UI settings. Chrome unittests often rely on these default values.

Previously, the EXPECT were running into:
  static void SetUpTestSuite() { ... }
which does not make the test suite to fail on any error.

We are proposing to add a separate test only for testing the computer
states.

R=tapted@chromium.org

Bug: 963868
Change-Id: I08fc33e0fb35d278562e4bcbb977e5376f3d415e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637670Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665924}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5e67c8e8ef64..886d9e9f735a


Created with:
  gclient setdep -r src-internal@886d9e9f735a

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=harringtond@google.com,orphis@google.com,shend@google.com

Change-Id: I20083d4a75cd2a4b9f6f6af2f87bdc2784540335
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643494Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#665923}

CSSPaintImageGeneratorImpl::InputArgumentTypes required an extra case
for off main thread CSS Paint to uses MainThreadDocumentPaintDefinition
instead of DocumentPaintDefinition.  This required
MainThreadDocumentPaintDefinition to have an addition member to include
the input argument types.

An extra parameter was added to
PaintWorklet::RegisterMainThreadDocumentPaintDefinition and its
references were also changed to accommodate the extra member for the
input argument types.

Unit testing was added.

Bug: 946519
Change-Id: I038e5146a5bb6f2d2cec96799f32eae9eb6f5dfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635732Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Adam Raine <asraine@google.com>
Cr-Commit-Position: refs/heads/master@{#665922}

Add a check for signin time limit being reached while the device was in sleep mode.

Bug: 871109
Change-Id: I463f8e344c443105ee128acb2383b89d2267357a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640556Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665921}

In my client, some devtools URLs have just "devtools://" scheme.
This change filters those URLs from jank tracker debug logs.

Change-Id: I48e5e63634e1f73fb2b1e9f70cb596f9a5d7a91d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642393Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665920}

The Device Service needs to clean up parts of its internal state as part
of browser shutdown, notably, BatteryStatusService. However, it also
needs to run on the UI thread, and embedded services that run on the UI
thread are not guaranteed to be destroyed as part of browser shutdown
(tasks to destroy these services are posted from the IO thread by
ServiceManagerConnectionImpl::ShutDownOnIOThread, but the UI thread is
typically shut down before these posted tasks are run).

To solve this issue we discussed adding plumbing wherein embedded
services could inform //content that they wanted to be notified when
shutdown was occurring on the main thread. However, on investigation
this plumbing would be painful to implement: it is only
EmbeddedInstanceManager that has direct information of these service
instances, and that object lives far away from //content's
ServiceManagerContext, the object that knows when shutdown is occurring
on the main thread.

This CL takes an alternative approach of having the BatteryStatusService
object be stashed in a SequenceLocalStorageSlot to ensure that it is
destroyed on browser shutdown. I have verified that its destruction is
triggered on shutdown of content_shell.

This CL is conceptually a reland. The original CL (which had the Device
Service directly observe destruction of the UI thread) was reverted for
the following reason:

"crbug.com/856771 presents a crash that it introduced on ChromeOS: the
Device Service instance is now shut down after the DBusThreadManager
global instance, on which it implicitly depends."

However, crbug.com/794105 has continued to be a problem on Windows,
and there aren't active engineering resources for an alternative solution
to this one.  Hence, this CL relands an approach that is similar to the
original fix with the shutdown not being applied on ChromeOS to avoid
triggering crbug.com/856771. As I wrote in the revert, "this is all
sad-making, but c'est la vie."

The usage of SequenceLocalStorageSlot rather than direct observation of
MessageLoop is thanks to a suggestion from rockot@.

Bug: 794105, 856771
Change-Id: I85709113299ae329ed560e00b78303fe0beecad9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605906
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#665919}

This fixes a crash that was caused by tapping on the cookies toggle
in site settings.

Bug: 968842
Change-Id: I5e57f2e3f201500ce79d4bda4dc2bf2ae2456186
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640803Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665918}

The remaining tests appear sufficiently stable (ie haven't failed in the
past dozen or so builds).

R=jbudorick, martiniss

Bug: 932269
Change-Id: I1c70981c0baba2da1bd7ef40ada22c69daaa8cdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642132Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665917}

We need to traverse into display:none subtrees in DetachLayoutTree on
removal to clear hover/active state properly. We use to do this
unconditionally before Squad. Fixes regression.

Bug: 967548
Change-Id: I8fc7e2824e0be8724cfd6173eab3dad5304a5d82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642555Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665916}

https://chromium.googlesource.com/catapult.git/+log/e5eebb43fb04..f8aef9991ba9


git log e5eebb43fb04..f8aef9991ba9 --date=short --no-merges --format='%ad %ae %s'
2019-06-04 bikineev@chromium.org Update metrics for Blink GC


Created with:
  gclient setdep -r src/third_party/catapult@f8aef9991ba9

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:967258
TBR=charliea@google.com

Change-Id: I387b8a7e0a3dd9c11d778e44d638ab3a33746358
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643489Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#665915}

Viz hit testing launched on all platforms as of M74. Delete browser and
unit tests that cover the SurfaceHitTest path. Most of the parameterized
tests were no longer testing the intended code anyways.
features::IsVizDisplayCompositorEnabled() always returns true on some
platforms which forces on viz hit testing regardless of
features::kEnableVizHitTest status.

Bug: 810128
Change-Id: Ie10957a7cfbc58b763bef085759a6fc950d0b5e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638283Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665914}

This was the problem:
ArcPackageSyncableService::UninstallPackage hands out a reference to
|sync_item->package_name|. That ends up in
ArcAppListPrefs::OnPackageRemoved which notifies its observers, passing
on the reference. However, one of the observers is
ArcPackageSyncableService itself, which now actually destroys the
|sync_item|, so the reference becomes invalid. If there are any other
observers in the list, they get a bad reference -> crash.

The fix is to make a copy of the string in
ArcPackageSyncableService::UninstallPackage and hand out a reference to
that.

This problem was exposed by TwoClientArcPackageSyncTest.Uninstall
after https://crrev.com/c/1538285 landed (the link to that change isn't
entirely clear to me, it might just be incidental). This CL also
re-enables that test.

Bug: 970063
Change-Id: I4c82fd3423e5ae5d241e11f4027d47a61ca85d63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642731
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665913}

These were addressed in:
https://skia.googlesource.com/skia.git/+/8b50ac242bc3a41cf81d5d9bbc24d49b9f85d834
https://skia.googlesource.com/skia.git/+/a5cf665997d73169e2f5260eaf9643af1f309762

Remove the corresponding suppressions.

Bug: skia:3294, 258499
Change-Id: Ib1fa1e4769dc76b81eac6ffd7389f9f6a6504ce0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643028
Commit-Queue: Mike Klein <mtklein@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665912}

This reverts commit 29109c84.

Reason for revert:
Causes compilation failure on android-kitkat-arm-rel bot.
Error message:

ld.lld: error: undefined symbol: content::WebContentsDelegate::RequestMediaAccessPermission(content::WebContents*, content::MediaStreamRequest const&, base::OnceCallback<void (std::__1::vector<blink::MediaStreamDevice, std::__1::allocator<blink::MediaStreamDevice> > const&, blink::MediaStreamRequestResult, std::__1::unique_ptr<content::MediaStreamUI, std::__1::default_delete<content::MediaStreamUI> >)>)

Sample failed build: https://ci.chromium.org/p/chromium/builders/ci/android-kitkat-arm-rel/18085

Original change's description:
> Remove redundant enum defined in both mojom and .h: MediaStreamRequestResult
>
> This CL removes the redundant enum MediaStreamRequestResult, defined in [1],
> in favor of the mojom existing variant in [2].
>
> [1] third_party/blink/public/common/mediastream/media_stream_request.h
> [2] third_party/blink/public/mojom/mediastream/media_stream.mojom
>
> The associated typemap [3] and traits declarations [4][5] are also removed.
>
> [3] third_party/blink/public/common/mediastream/media_stream.typemap
> [4] third_party/blink/common/mediastream/media_stream_mojom_traits.cc
> [5] hird_party/blink/public/common/mediastream/media_stream_mojom_traits.h
>
> TBR=haraken@chromium.org
>
> BUG=923394,919392
> R=​guidou@chromium.org, haraken@chromium.org
>
> Change-Id: I371a5cac053597a73207598774a6a22ed0c73236
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639237
> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#665431}

TBR=haraken@chromium.org,guidou@chromium.org,tonikitoo@igalia.com

Bug: 923394, 919392, 970206
Change-Id: Ie71c98d9059932f2374641e37d8add3cf2c26bf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643507Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#665911}

https://webrtc.googlesource.com/src.git/+log/c8501f7ae392..961407f5e86f


git log c8501f7ae392..961407f5e86f --date=short --no-merges --format='%ad %ae %s'
2019-06-04 nisse@webrtc.org Delete unused method RtpRtcp::GetRtpPacketLossStats
2019-06-04 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 1070231d..f8c14c53 (665750:665857)
2019-06-04 magjed@webrtc.org Android SurfaceTextureHelper: Avoid crashing if size hasn't been set
2019-06-04 danilchap@webrtc.org in test/scenario pass TaskQueueFactory explicitly


Created with:
  gclient setdep -r src/third_party/webrtc@961407f5e86f

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I1fa5c0b7565711a51e7cbcf5c5fcb184b6670b6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643488Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#665910}

Replace refcounting with deliberate lifetime management.

Bug: 964948
Change-Id: I016de4c4a1ff246d46b5d0a8b099aff6a57311eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619819
Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665909}

This CL changes ProfileDataCache so it always scales the avatar, making
sure the size of the image within DisplayableProfileData always matches
the size passed to ProfileDataCache ctor.

Bug: 963077
Change-Id: I9cbb8a25035f9a4d89c16c6d262dfb575aac0993
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628756
Auto-Submit: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665908}

It regressed and wasn't tested.

Previous CL adds a regression test:
https://chromium-review.googlesource.com/c/chromium/src/+/1631399

This CL fixed the issue and enables the regression test
NavigationMhtmlBrowserTest.IframeDataUrlFound
NavigationMhtmlBrowserTest.IframeDataUrlNotFound

Bug: 967307, 936696, 969696
Change-Id: Ibfbaf9fd121b7149b5b377d01af3ecbe0fa83326
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635469
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665907}

R=alexclarke@chromium.org

Change-Id: I4c0aa2178c4776cb1ca0bd99f59eb4fda114e99e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642733
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665906}

Using wpt-import in Chromium e0949be5.
With Chromium commits locally applied on WPT:
e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo"
abf2ac5e "webrtc wpt: avoid race conditions"
1bbbd106 "Add feature policy for client hints, used for third-party subresources."
ab94a58b "Add the remaining Client Hints to Feature Policy."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=foolip

No-Export: true
Change-Id: I557397276dee057be4ceebecdf657a5e7bb748bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643308Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#665905}

Change-Id: Ibfe20b2a54bf86b3c483f21c172acc1b5373266b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635683
Auto-Submit: Peter Beverloo <peter@chromium.org>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665904}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.

The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: Ic08dfb2e335906771968147060ddd0ff83cbedb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643493Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#665903}

Uses of base::Callback<...> is deprecated in favor of either
base::OnceCallback<...> or base::RepeatingCallback<...> (the
former is preferred if possible).

This is part 7 of a multi-CL refactoring and does:

-   remove uses of RunWithFaviconResults and RunWithFaviconResult
    helper function from HistoryService implementation and use
    PostTaskAndReplyWithResults, thus allowing to naked "new" and
    subtle uses of base::Unretained() and base::Owned to pass the
    value to both callbacks

-   change HistoryBackend methods called from those HistoryService
    methods to return their result by value instead of via an out
    parameter

Bug: 812523, 714018
Change-Id: I8a458f47073d61cfeb2ded1ae2fc8bb74a32e6b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634850
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665902}

Bug: 965955
Change-Id: Iccb9004cc519dfd493a532b9061d1745988e629e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640369
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665901}

This CL adds a "NewClearBrowsingDataUI" experiment to the field trials under
test for ios.

Bug: 627147
Change-Id: I8545f942ac731a1736a3a51276443c3aa668a7a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641282Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Huanzhong Huang <huanzhong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665900}

Change-Id: I831192ae4d928137486098272df4969a5a7463bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643547Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: A Olsen <olsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665899}

After recent changes, SigninManager exposes no public API surfaces
over SigninManagerBase. This CL eliminates nearly all usage of
signin_manager.h and in particular eliminates the no-longer needed
SigninManager::FromSigninManagerBase() method.

The remaining usage is for sites that *construct* SigninManager
instances. These sites will need to remain as such until SigninManager
is actually merged into SigninManagerBase.

This is a step in eliminating the inheritance relationship between
SigninManager and SigninManagerBase, as motivated in this design doc:

https://docs.google.com/document/d/15y-Db27BV08vrIyelHB-3CwiAfDYh-FigNKGXrqSWto/edit#heading=h.8jjdy95t6p7x

and described concretely here:

https://docs.google.com/document/d/15y-Db27BV08vrIyelHB-3CwiAfDYh-FigNKGXrqSWto/edit#heading=h.mbkrv9nkb93w

TBR=rohitrao@chromium.org

Bug: 952766, 883648
Change-Id: Icb114b11dc2c74d8b49cfd77baba33b707a4157e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565316
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665898}

Following bot results are included.
20678 20690 20695 20706 20716 20724 20730 20736 20743 20757
20769 20782 20787 20794 20798

0 lines were removed and 2 lines were deflaked by consecutive
results since 20706.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Change-Id: I5b1fd09607b9f68295b83f5a9573a4998c28451e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640140Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665897}

This reverts commit 631cf612.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 665876 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzYzMWNmNjEyZTg4YmUzZWIyMWQ0MmY2ZTFjYzYxZjk3NDlmYWY3OGUM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Mac%20ASan%2064%20Tests%20%281%29/53748

Sample Failed Step: content_browsertests

Original change's description:
> Test: MHTML document loaded inside a data-URL parent.
> 
> In an MHTML document, blink::DocumentLoader::archive_ is transmitted
> from parent to children. data-URL aren't loaded from the MHTML archive.
> In this case, does it means children of data-URL aren't able to be
> loaded from the MHTML archive? Hopefully, it is currently working. They
> are able to load from the MHTML document, because |archive_| continue to
> be transmitted.
> 
> This CL adds a test to ensure this continue to work in the future.
> 
> Bug: None.
> Change-Id: Icb51dc48691112cf9e45dfe8cb81d389544a0c41
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635669
> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#665876}


Change-Id: Iab5a838b789e845537a3a81a8f87cd54516b1162
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643089
Cr-Commit-Position: refs/heads/master@{#665896}

This reverts commit 7d714d6a.

Reason for revert: Makes NotificationImageLoaderTest.TimeoutTest
 fail on a couple of bots

Original change's description:
> Reland "Remove time overrides from TestingPlatformSupportWithMockScheduler"
> 
> This is a reland of f75182ab
> 
> TBR=jbroman@chromium.org, dcheng@chromium.org
> 
> Original change's description:
> > Remove time overrides from TestingPlatformSupportWithMockScheduler
> >
> > TestingPlatformSupportWithMockScheduler used time overrides to control time in
> > tests. Time overrides are removed as part of the OnionSoup effort. Tests should
> > use the mock clock from the TestTaskRunner provided by the platform.
> >
> > Bug: 919383
> > Change-Id: Idf3d44ed2aeff8c73de09671b50b779419146d3b
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591634
> > Reviewed-by: Jeremy Roman <jbroman@chromium.org>
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Commit-Queue: Sergio Villar <svillar@igalia.com>
> > Cr-Commit-Position: refs/heads/master@{#665724}
> 
> Bug: 919383
> Change-Id: I76d14136b8f239b90dde32442af3cca0c4efe044
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642554
> Reviewed-by: Sergio Villar <svillar@igalia.com>
> Commit-Queue: Sergio Villar <svillar@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#665888}

TBR=dcheng@chromium.org,jbroman@chromium.org,svillar@igalia.com

Change-Id: I38e49a621387933b03ed228ccdb3ca8f62e084ba
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 919383
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643468Reviewed-by: Sergio Villar <svillar@igalia.com>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#665895}

This reverts commit 197a1362.

Reason for revert: Unable to add card entries under chrome://settings/payments

Original change's description:
> Send only 1 event from AutofillPrivate to the JS
> 
> OnAddressListChanged, OnCreditCardsChanged
> Instead it should have a single OnPersonalDataChanged call
> 
> Bug: 923868
> Change-Id: Ie6bc51cf71f82228df32db551489bf66168a54e6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631451
> Commit-Queue: sebsg <sebsg@chromium.org>
> Reviewed-by: sebsg <sebsg@chromium.org>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Auto-Submit: Jaeyong Bae <jdragon.bae@gmail.com>
> Cr-Commit-Position: refs/heads/master@{#664246}

TBR=stevenjb@chromium.org,sebsg@chromium.org,jdragon.bae@gmail.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 923868, 968426
Change-Id: Idfcee169a82c3836b70173d8669b29a45cd47c5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643408Reviewed-by: sebsg <sebsg@chromium.org>
Commit-Queue: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665894}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/60695f091d91..5e67c8e8ef64


Created with:
  gclient setdep -r src-internal@5e67c8e8ef64

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=harringtond@google.com,orphis@google.com,shend@google.com

Change-Id: I70d453b95fe2e3633d6588d41a471ba461dc1537
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643487Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#665893}

https://skia.googlesource.com/skia.git/+log/12818515b5a3..525aa0ca60c8


git log 12818515b5a3..525aa0ca60c8 --date=short --no-merges --format='%ad %ae %s'
2019-06-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src f75363e4..ce989eac (360 commits)
2019-06-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 98f2167125a8..2dd40a44d1a6 (8 commits)


Created with:
  gclient setdep -r src/third_party/skia@525aa0ca60c8

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jcgregorio@google.com

Change-Id: I08a8a84740235cd33d1d7314dd6c40dda2adbd19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643077Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#665892}