- 08 Jun, 2020 40 commits
-
-
Dominic Mazzoni authored
This test is a follow-up to this patch: http://crrev.com/c/2226300 It ensures that if the server request uses a different language than the language passed with the original request, the annotation still succeeds. Also adds a log to make it more clear if we were ever to hit this case in the future. Previously it was a silent failure. AX-relnotes: N/A Bug: 1090234, 1070505 Change-Id: I6c728a859bfa4c9a182ea4dd446b3b54c1836014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233482Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#776131}
-
Sujie Zhu authored
Add WithNickname suffix to Autofill.StoredCreditCardCount.Local and Autofill.StoredCreditCardCount.Server.Masked to get what percentage of cards has nickname. Bug: 1082013 Change-Id: I979209fe5681f43fd9e89c00537c7df788e83b48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232835Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Sujie Zhu <sujiezhu@google.com> Cr-Commit-Position: refs/heads/master@{#776130}
-
Anna Malova authored
Bug: 1085115 Change-Id: I0c720e23190fa7482ff08a03c579416719267fcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230474Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#776129}
-
Matt Menke authored
A bunch of tests check cases where alt service info should not be added. All of these tests send an alt service frame that advertises QUIC without actually enabling QUIC, so even if the logic they're trying to test doesn't work, no alt service info would be added, as QUIC is disabled. Fixed: 1092521 Change-Id: I46f7f26780b48bb5796f85349b91077cee8e2b46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236018 Commit-Queue: Matt Menke <mmenke@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#776128}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/593e6a423883..08a16c09bcf3 2020-06-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d96e9f16..5177dd56 (775897:776000) 2020-06-08 danilchap@webrtc.org Add av1 scalability structures for 2 spatial and 2 temporal layers. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5db6eec596ff1419a54f533f9432f3d6ca2711fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235961Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776127}
-
Nate Chapin authored
This reverts commit 9c1d622a. Reason for revert: Crash reports: https://bugs.chromium.org/p/chromium/issues/detail?id=1092287 Original change's description: > Remove Document::IsFeatureEnabled, use the ExecutionContext variants instead. > > Bug: 1029822 > Change-Id: I59716b1450eee66261c7786ee408e37360689920 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231596 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Nate Chapin <japhet@chromium.org> > Cr-Commit-Position: refs/heads/master@{#775600} TBR=haraken@chromium.org,japhet@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1029822, 1092287 Change-Id: Ie60e587042fc1fcc28352229911c67460db388f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236094 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#776126}
-
Avi Drissman authored
Provide the keystone install script with a list of names that might be the names of the updated Chrome app. Update handling of brand codes by allowing side-by-side Chromes their own brand codes. Bug: 1061486 Change-Id: Ia1bcc1bf1326e7a35c332a61e9569ece32396662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233599 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#776125}
-
Dan Harrington authored
The first time a slice is 2/3rds visible, we call reportSliceViewed() on FeedStreamSurface. This is done by adding an onPreDrawListener for the recyclerView, and then checking geometry for slices in the viewport. Bug: 1044139 Change-Id: I7b1f07711fd0347574e3bd9b80875dbb068a230d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233598Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#776124}
-
Mugdha Lakhani authored
This CL moves prerender_messages.h into components/prerender/common. Existing components/prerender files are moved into components/prerender/browser, and references updated. Bug: 1057771 Change-Id: I696da61f22ded71959e0c6442de63cf70a4548d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231044 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#776123}
-
Lexi Stavrakos authored
Change-Id: Idca9f2622f94635a3117c2b5c46d5029f6a670b3 Bug: 1090879 Change-Id: Idca9f2622f94635a3117c2b5c46d5029f6a670b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230933 Commit-Queue: Lexi Stavrakos <astavrakos@google.com> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#776122}
-
dpapad authored
These were discovered, after having to edit this file to fix type errors revealed when rolling to the latest Closure Compiler version. Bug: 1081815 Change-Id: I0e20714b747950e24db28a2c6c180be19b716cc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233496Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#776121}
-
Rohit Rao authored
BUG=None Change-Id: I05221c63e878ff30ebcea9cf65ba2d812dd4a450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231126 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#776120}
-
yjliu authored
Relanding: Surface Aggregator Prewalk Optimization (Hackweek Project) Summary: This is a Hackthon week project and I reworked the PrewalkTree function to be more streamlined. Please see the design doc at the following link for purpose of the project and other details. https://docs.google.com/document/d/1D1MTNTaJnZjbmMZGMz0u150N3u5evEFSmJU-ou2vcFw/edit#heading=h.c0uts5ftkk58 In short, the original PrewalkTree() is as follows: --------------------- // Returns the damage rect of the surface gfx::Rect PrewalkTree(Surface* surface) { ...... // Gather all the embedded child surfaces into a flat_map FindChildSurfaces(&child_surfaces, ...) // Iterate through the child surfaces to accumulate damage gfx::Rect damage_rect; for (child_surface : child_surfaces) { damage_rect += PrewalkTree(child_surface); // apply quad transform here } // ...do some other stuff return damage_rect; } ----------------- I modified it to: ----------------- // Returns the damage of a surface gfx::Rect PrewalkTree(Surface* surface) { ...... RenderPass* root_pass = surface->GetActiveFrame()->render_pass_list.back(); return PrewalkRenderPass(root_pass); } // Returns the accumulated damage of a render pass gfx::Rect PrewalkRenderPass(RenderPass* render_pass) { gfx::Rect damage_rect; for (DrawQuad* quad : render_pass->quad_list.reverse()) { // in reverse order if (quad is SurfaceDrawQuad) damage_rect += PrewalkTree(quad_surface); // apply quad transform here else if (quad is RenderPassDrawQuad) damage_rect += PrewalkRenderPass(quad_render_pass); // apply quad transform here } return damage_rect; } ---------------- Bug: 158254077 Change-Id: I687dde2d1e5ae194680ab94cc35fd00f6ebfa97a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234099 Commit-Queue: Jun Liu <yjliu@chromium.org> Auto-Submit: Jun Liu <yjliu@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#776119}
-
Xianzhu Wang authored
This helps track failures caused by null LayoutObject in production. The extra runtime cost of the CHECKs is trivial. Bug: 1086968 Change-Id: Ie4b2ec3a5384e5465f32dbac27f8d87a8aebfcdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233479 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#776118}
-
David Bertoni authored
was disabled for flakiness. The SearchPauseResumeCancelGetFileIconIncognito test was disabled a while back for flakiness, but is no longer flaky on the bots. Bug: 874946 Change-Id: I859b05e760ca95f9d1e80ef776b43424c17cc5cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229332Reviewed-by:
Archana Simha <archanasimha@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#776117}
-
Mohamed Heikal authored
Using android_aar_prebuilt for an aar that does not contain a classes.jar will fail gn with unused variables. Only define those variables if needed. Change-Id: I6d3776271e7bc817329af7f8976fd5719f581bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236036Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#776116}
-
Harald Alvestrand authored
Bug: chromium:1091885 Change-Id: I227750422e785867f6510b7dfdee3704dac64e0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234261Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#776115}
-
Victor Hugo Vianna Silva authored
This CL fixes one typo in the BUILD file for this class and enables type-checking. Bug: None Change-Id: Ie6e6fa959acd0800c1efbde634065ab06de832f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233023 Auto-Submit: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#776114}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/ee0516e3989f..f5657af110a6 2020-06-08 cwallez@chromium.org Fix use of bytesPerRows=0 in CppHelloTriangle 2020-06-08 xinghua.cao@intel.com Reland "Check FP16 support on vulkan backend" 2020-06-08 jiawei.shao@intel.com Add validations on the texture-to-texture copies within same texture If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1087896 Tbr: cwallez@google.com Change-Id: I251734d6eebb7d638c5fd8976acc84a9a791f46e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235962Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7fa78b7965fb..47e79f83dec0 2020-06-08 lalitm@google.com Merge "docs: add note that --txt doesn't work on P" 2020-06-08 hjd@google.com Merge "Fix typo in docs" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I354187cadd263f6ae9ccf787c60906d7aad871f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235956Reviewed-by:
-
Joe DeBlasio authored
This tiny CL just changes the period that we cache engaged sites from 5 minutes to 1 minute. Fetching engaged sites isn't that expensive, and this limits the amount of time that we can serve an out-of-date (and thus unexpected) result. Change-Id: Idf415f883f5ae1f155299d4354098ef119435094 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236057Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#776111}
-
Corentin Wallez authored
Bug: 1069302 Change-Id: Ib8c2e8c3f38ccaf1699f7f368b34f39c1be41d90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225406Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#776110}
-
Peter Wen authored
Since android_lint is only run for android_apk and android_app_bundle targets, there is no longer a need for a project-wide override. Targets that specify their own lint suppressions file can specify it as a gn variable when they use the android_apk or android_app_bundle templates. Also support embedders passing their own lint_suppressions_dep if their lint suppressions file is generated. See: https://crrev.com/c/2232580 Passed through the necessary args so that embedders using chrome_public_apk can easily pass in lint_suppressions_* variables. Bug: 1082743 Change-Id: Idcb2f40d1fa529398a6f942e1c0687608c5dffb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235463 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
-
Juan Pablo de Lima authored
$ can be defined differently depending on this file's execution and cannot guarantee consistency. Bug: 1083145, b:157634877 Change-Id: I3b5d0577f7abaf6f58a3c6715e93537456ec8414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235932 Commit-Queue: Juan Pablo De Lima <jpdelima@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#776108}
-
Becca Hughes authored
Disables Media Feeds on Android because they are desktop only and caused a large binary size regression. BUG=1070720 Change-Id: If7afe1f62524d84b93951c1dc8bf4c955c5128a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231701Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
-
David Bertoni authored
The DownloadExtensionTest_Download_UnsafeHeaders test was disabled for flakiness on Windows. It passed 3000 iterations on the bots without any issues. See run results here: https://ci.chromium.org/p/chromium/builders/try/win10_chromium_x64_rel_ng/575382 https://ci.chromium.org/p/chromium/builders/try/win_chromium_dbg_ng/3267 Bug: 248438 Change-Id: Ide364a95ee8818f413b81fe82a992c28a02bb61a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227389Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#776106}
-
Evan Stade authored
Bug: 1007826 Change-Id: I5f12d7453fd7a5f8c3ea7bb756a6f735ec7759aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225789 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#776105}
-
Aya ElAttar authored
Added another PolicyMap::Set to override the old one to switch from passing value as unique_ptr to base::Value. Bug: 1092469 Change-Id: I3b87af2302ce7009e73d910d59bef1c9d4931fc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235792 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Auto-Submit: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#776104}
-
Antonio Gomes authored
... instead of WebMediaStreamTracker. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. Note that an explicit conversion to WebMediaStreamTrack is added because the call crosses the Blink API boundary. BUG=704136 R=guidou@chromium.org Change-Id: I1d9d5473bab5d1e0254b1992c248d1c517c8c2df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236034 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Joshua Pawlicki authored
Background: there are two extension updaters in Chrome: the update_client updater (new) and the extension_downloader client (old). Prior to this change, changing the extension updater URL would effectively disable the update_client-based updater and the extension_downloader client would take over. This makes it impossible to use the update_client updater with non-prod or local copies of CWS. A user/attacker with control over Chrome's command line can redirect the extension update check to a server of their choice. Furthermore, CUP is disabled for this transaction (because the target server presumably does not have the pinned CUP private key). This is not expected to have any tangible security impact, because: 1 - Prior to this change, the extension_downloader updater would still redirect the request, and extension_downloader doesn't use CUP anyways. 2 - Activating this feature requires attacker presence on-disk or a confused user. 3 - A MITM attacker must also compromise TLS to subvert the update check. 4 - The updater will still only accept properly-signed CRX files as update payloads, even if an attack establishes control of the update check. Bug: 1077122 Fixed: 1077122 Change-Id: I4a9169f2741900906bfa63da40196aa0f887e70a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2180862 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#776102}
-
Jian Li authored
Bug: none Change-Id: Ia397468378c7a94d04024fb3f444995c1003efea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234548Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#776101}
-
Alexander Dunaev authored
This CL introduces the unified drag image support, so any Ozone platform that can provide absolute coordinates during the drag can use it. Bug: 1014860 Change-Id: I2abb6bf6ce5851611c0163a4f41ba9bc50b9eadc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2195245 Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#776100}
-
Ben Wagner authored
Skia is moving the code about to make it easier to manage. There should be no functional changes. Change-Id: I4f7284fa278638ad05f1fd4772a0abc12ddd4f83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232883Reviewed-by:
Mike Klein <mtklein@google.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#776099}
-
Christian Dullweber authored
The views appear in the order they are defined in this list. The list doesn't quite match the UI, so it looks a bit weird if many items fade in. Change-Id: Ibcc1325af5e5a83107c4d3dc7b494accc4955f58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235813 Auto-Submit: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#776098}
-
David Bertoni authored
The DownloadExtensionTest_AcceptDanger test was disabled on MAc for flakiness, but passed 3000 iterations on the bots. The test remains disabled on debug builds, where it still times out occasionally. Bug: 180759 Change-Id: I354d24e3f07406ead9e64a49da968d0e0efea60f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229460 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
-
Martin Kreichgauer authored
Bug: 1087158 Change-Id: Id8bcbe5d4e806264521ffaffddb3457b075102d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229336Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#776096}
-
Nina Satragno authored
Deflake AuthenticatorDialogTest.InvokeUi_inline_bio_enrollment. If the timer fired between the dialog being destroyed and the test being destroyed, we had a use-after-free of the raw pointer to the model. Solve this by using a WeakPtr. Additionally, if the current step changed by e.g. a user running the test interactively, we hit a DCHECK on OnSampleCollected since the current step was no longer inline bio enrollment. Fix this by checking the current step before running the callback. This fix is okay since the main point of this test is to run interactively to try the UI and as a basic sanity check. Fixed: 1092314 Change-Id: I5cec125de3a921df8b7e7a44d5cb1feedf634f4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235979 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#776095}
-
Elly Fong-Jones authored
This change: 1) Introduces a convenience method on WidgetDelegate: SetHasWindowSizeControls(), which sets whether a window has maximize, minimize, and resize controls. 2) Removes many overrides of CanMaximize, CanMinimize, and CanResize, replacing them with uses of explicit setters 3) Removes two now-unnecessary WidgetDelegate subclasses :) Bug: 1075649 Change-Id: Ib8b4fea3080627b8292c784d932b742ce7dd9682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228988 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#776094}
-
Daniel Rubery authored
This CL changes the word GetThreatTypeStringForInterstitial to match the discussed strings. Fixed: 1088075 Change-Id: Ic512b40aa6fcc8c928617c56e793e00f7f3d008a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233197Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Marc-André Decoste <mad@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#776093}
-
Sigurdur Asgeirsson authored
This is a followup to http://crrev.com/c/2231265, where I missed Chris' comment on this staleness in the PageNode declaration. Change-Id: I9e678a3f9f27c5b9afc5357985b59f8d947a9b4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236012 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#776092}
-
