GitLab

This fixes a regression by Blink r153039.
We should not focus on "Edit" button in autofill setting by mouse press.
We call preventDefault() in mousedown event handler of the button.

BUG=268031

Review URL: https://chromiumcodereview.appspot.com/22124002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215809 0039d316-1c4b-4281-b951-d872f2087c98

This patch renames:
- "Autohide launcher" to "Autohide shelf"
- "Launcher position" to "Shelf position".

BUG=263531
TEST=out_cros/Debug/chrome --disable-setuid-sandbox --ash-use-alternate-shelf --show-launcher-alignment-menu
R=jamescook@chromium.org,sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22007003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215808 0039d316-1c4b-4281-b951-d872f2087c98

This CL allocates a creates unique instance id for each
<webview> in an embedder RenderView/shim instead of in BrowserPlugin. In a subsequent CL, this will permit
usage of the WebRequest API prior to attachment to the DOM.

This CL also fixes a potential crash on edit commands if the instance ID passed did not exist: Perhaps open two <webview> apps and then close the first one, then send edit commands to the second one.

BUG=178663
Test=WebViewTest.*, WebViewInteractiveTest.*
TBR=cdn@chromium.org for deleted field in browser_plugin_messages.h

Review URL: https://chromiumcodereview.appspot.com/21930006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215807 0039d316-1c4b-4281-b951-d872f2087c98

Calling DriveAppRegistry::Update() results in being ignored when there is an ongoing one already.
Add FakeDriveService::app_list_load_count()

BUG=268707
TEST=unit_tests
R=hidehiko@chromium.org, kinaba@chromium.org

Review URL: https://codereview.chromium.org/22297004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215806 0039d316-1c4b-4281-b951-d872f2087c98

Reverse the ordering of these Widget::Init operations.
BubbleFrameView uses title/close presence for sizing.
(requires title/close to be set before bounds init)

DialogDelegate::CreateNewStyleFrameView did this explicitly.
(that changed in http://crrev.com/214637, seems less hacky)

Add a unit test, and cleanup a related test.

BUG=267343
TEST=Dialogs are sized properly, especially non-tab/content-modal dialogs (add wifi, import lock, screen sharing, etc.); see the bug and its dups for examples.
R=sky@chromium.org,ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/21967002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215805 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org
BUG=264396
TEST=compilation succeeds

Review URL: https://chromiumcodereview.appspot.com/21966005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215804 0039d316-1c4b-4281-b951-d872f2087c98

This CL clears composition data in IME in InputMethodBridge::OnBlur.
The cause was that ConfirmComposition called in InputMethodBridge::OnBlue doesn't clear IME's composition, and it will be committed again in host_->SetFocusedTextInputClient(NULL) in case of IMM32.

BUG=265928
TEST=Test manually.

Review URL: https://chromiumcodereview.appspot.com/21874003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215803 0039d316-1c4b-4281-b951-d872f2087c98

flip_in_mem_edsm_server should have unittests.

BUG=267354
R=rch@chromium.org

Review URL: https://chromiumcodereview.appspot.com/21743003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215802 0039d316-1c4b-4281-b951-d872f2087c98

GetUploadStatus for an unusable URL always results in an error.
Upload location should be discarded to initiate new upload in such cases.

BUG=267452
R=kinaba@chromium.org

Review URL: https://codereview.chromium.org/21790002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215801 0039d316-1c4b-4281-b951-d872f2087c98

These just test same basic operations with a LatencyInfo.

Review URL: https://chromiumcodereview.appspot.com/21447003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215800 0039d316-1c4b-4281-b951-d872f2087c98

native_app_window.h -> apps component
platform specific implementations of this are now in c/b/ui/xxx/apps.

The platform specific implementations should also move to apps/ but
they would currently bring some unwanted dependencies with them; that
can happen later.

BUG=159366

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215753

Review URL: https://chromiumcodereview.appspot.com/21344002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215799 0039d316-1c4b-4281-b951-d872f2087c98

Now that Blink isn't including webkit_support_gfx directly, this moves
it to live next to its only user (the image_diff tool).

R=dpranke
TBR=joth (for android_webview/tools/third_party_files_whitelist.txt)

Review URL: https://chromiumcodereview.appspot.com/21202003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215798 0039d316-1c4b-4281-b951-d872f2087c98

    
WebRTC measures the decoding time and control the timing of the Decode()
calls. In the current implementation, we call decode done callback when
the browser process gets the frame. In order to get frames constantly
from WebRTC, this fix drops the decode done callback.
    
BUG=264585

Review URL: https://chromiumcodereview.appspot.com/20646003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215797 0039d316-1c4b-4281-b951-d872f2087c98

> [telemetry] Add a webdriver backend with support for IE.
> BUG=none
> TEST=tools/perf/run_measurement --browser=internet-explorer octane & kraken
> 
> Review URL: https://chromiumcodereview.appspot.com/20672002

TBR=chrisgao@chromium.org

Review URL: https://codereview.chromium.org/22336006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215796 0039d316-1c4b-4281-b951-d872f2087c98

> Support synchronous mode in WebFileWriterImpl
> 
> BUG=257349
> TEST=no behavioral change yet
> R=tzik@chromium.org
> 
> Review URL: https://codereview.chromium.org/21902002

TBR=kinuko@chromium.org

Review URL: https://codereview.chromium.org/22300004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215794 0039d316-1c4b-4281-b951-d872f2087c98

> Don't assume that widgets of TYPE_CONTROL are parented to the RootWindow.
> This was causing the SadTabView to be drawn at the wrong origin.
> 
> BUG=262051
> 
> Review URL: https://chromiumcodereview.appspot.com/21504003

TBR=zturner@chromium.org

Review URL: https://codereview.chromium.org/22356003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215792 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215789 0039d316-1c4b-4281-b951-d872f2087c98

BUG=257349
TEST=no behavioral change yet
R=tzik@chromium.org

Review URL: https://codereview.chromium.org/21902002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215787 0039d316-1c4b-4281-b951-d872f2087c98

The files included in nacl.gypi were already moved. Since nacl_linux_helper is not moving until its dependencies are moved, break off the target nacl_linux_helper and move it to chrome_exe.gypi.

This is part of an effort to componentize NaCl code.

BUG=244791

Review URL: https://chromiumcodereview.appspot.com/21020004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215786 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=tools/perf/run_measurement --browser=internet-explorer octane & kraken

Review URL: https://chromiumcodereview.appspot.com/20672002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215785 0039d316-1c4b-4281-b951-d872f2087c98

They currently remain until expiration which could be forever in the
case of webkit notifications.  TODO: chromeos.

R=mukai@chromium.org, stevenjb@chromium.org
TBR=johnnyg@chromium.org
BUG=233752

Review URL: https://chromiumcodereview.appspot.com/19027005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215784 0039d316-1c4b-4281-b951-d872f2087c98

BUG=133416

Review URL: https://chromiumcodereview.appspot.com/12669004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215783 0039d316-1c4b-4281-b951-d872f2087c98

> Fix crash when reloading packaged app. 
> 
> When a shell window was closed, it wasn't removed from the registry immediately 
> (it was removed in a callback from OnNativeClose, which happens a bit later.) 
> This meant that when the app was loaded again, the window was still in the 
> registry with a stale pointer to the old extension. ExtensionSettingsHandler 
> was tickling this by iterating shell windows on extension load.
> 
> BUG=174250
> TEST=On chromeos, enable the 'Enable debugging for packed apps.' flag. Then
> open chrome://extensions. Then open a packaged app, and reload it. Chrome
> should not crash.
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214844
> 
> Review URL: https://chromiumcodereview.appspot.com/20243003

TBR=benwells@chromium.org

Review URL: https://codereview.chromium.org/22356002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215782 0039d316-1c4b-4281-b951-d872f2087c98

> Move native_app_window code to apps areas
> 
> native_app_window.h -> apps component
> platform specific implementations of this are now in c/b/ui/xxx/apps.
> 
> The platform specific implementations should also move to apps/ but
> they would currently bring some unwanted dependencies with them; that
> can happen later.
> 
> BUG=159366
> 
> Review URL: https://chromiumcodereview.appspot.com/21344002

TBR=benwells@chromium.org

Review URL: https://codereview.chromium.org/22355002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215781 0039d316-1c4b-4281-b951-d872f2087c98

> linux_aura: Implement the static part of the dbus menu for Unity.
> 
> In GTK, we get a menu in the Unity bar for free as long as we have a
> GtkMenuBar object in our GtkWindow. linux_aura doesn't use gtk widgets
> in the interface. So opportunistically dlopen libdbusmenu-glib and
> manually construct a hidden DbusmenuMenuItem* object tree.
> 
> This only ports the static parts of the menus; it doesn't port the
> History menu, which changes based on user actions.
> 
> BUG=265560
> 
> Review URL: https://chromiumcodereview.appspot.com/21187006

TBR=erg@chromium.org

Review URL: https://codereview.chromium.org/22326003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215780 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/21955003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215779 0039d316-1c4b-4281-b951-d872f2087c98

The class name is longer needed for namespacing now that the code is in the
autofill:: namespace

R=estade@chromium.org
TBR=aruslan@chromium.org
BUG=none
TEST=compiles

Review URL: https://chromiumcodereview.appspot.com/21947003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215778 0039d316-1c4b-4281-b951-d872f2087c98

BUG=265583

Review URL: https://chromiumcodereview.appspot.com/21884004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215777 0039d316-1c4b-4281-b951-d872f2087c98

When tests are run multiple times (e.g. to test callback types), only
the first invocation runs.

BUG=

Review URL: https://chromiumcodereview.appspot.com/21833005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215776 0039d316-1c4b-4281-b951-d872f2087c98

Having "file_manager" in the file name is redndant as the file is in
"file_manager" directory.

Along the way, rename FileManagerEventRouter to EventRouter as the
class is in "file_manager" namespace.

BUG=268248
TEST=none
R=hashimoto@chromium.org

Review URL: https://codereview.chromium.org/22150005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215775 0039d316-1c4b-4281-b951-d872f2087c98

BUG=262203

Review URL: https://chromiumcodereview.appspot.com/21149003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215774 0039d316-1c4b-4281-b951-d872f2087c98

This was introduced in a style fix in
https://chromiumcodereview.appspot.com/22001002/

TBR=jhawkins@chromium.org
TBR=dpolukhin@chromium.org
BUG=None

Review URL: https://chromiumcodereview.appspot.com/22283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215773 0039d316-1c4b-4281-b951-d872f2087c98

This was causing the SadTabView to be drawn at the wrong origin.

BUG=262051

Review URL: https://chromiumcodereview.appspot.com/21504003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215772 0039d316-1c4b-4281-b951-d872f2087c98

Tests need both sets of entry point functions, ContentClient embedder
pointers, etc. Now in gyp, the three targets are content_app_browser for
browser-only, content_app_child, which is child-only, and
content_app_both which contains both.

TBR=joth@chromium.org, grt@chromium.org
R=jam@chromium.org
BUG=237249

Review URL: https://chromiumcodereview.appspot.com/21453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215771 0039d316-1c4b-4281-b951-d872f2087c98

In GTK, we get a menu in the Unity bar for free as long as we have a
GtkMenuBar object in our GtkWindow. linux_aura doesn't use gtk widgets
in the interface. So opportunistically dlopen libdbusmenu-glib and
manually construct a hidden DbusmenuMenuItem* object tree.

This only ports the static parts of the menus; it doesn't port the
History menu, which changes based on user actions.

BUG=265560

Review URL: https://chromiumcodereview.appspot.com/21187006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215769 0039d316-1c4b-4281-b951-d872f2087c98

Profiles should only be created on the UI thread. Previously the DCHECK did not
work due to http://crbug.com/251191.

BUG=251191

Review URL: https://chromiumcodereview.appspot.com/19482003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215768 0039d316-1c4b-4281-b951-d872f2087c98

We will add TextInputMode to InputScope member.

BUG=244688

Review URL: https://chromiumcodereview.appspot.com/21130010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215766 0039d316-1c4b-4281-b951-d872f2087c98

BUG=258563

Review URL: https://chromiumcodereview.appspot.com/20651004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215765 0039d316-1c4b-4281-b951-d872f2087c98

Load the recover virtual table as part of sql::Recovery::Begin(), and
implement basic unit tests that it correctly recovers valid and
corrupt tables.

BUG=109482

Review URL: https://chromiumcodereview.appspot.com/20022006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215764 0039d316-1c4b-4281-b951-d872f2087c98

The test framework doesn't really need to load resources and translations. This removes loading and changes the odd test that wasn't working anymore due to this change.

BUG=

Review URL: https://chromiumcodereview.appspot.com/18429012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215763 0039d316-1c4b-4281-b951-d872f2087c98