- 19 Jan, 2021 10 commits
-
-
Maggie Cai authored
This reverts commit ddd08c52. Reason for revert: This CL is likly the cause for test failure DemoSetupArcSupportedTest.OnlineSetupFlowErrorDefault in builder Linux Chromium OS ASan LSan Tests (1) starting from https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/39313/blamelist Original change's description: > OOBE: Arc-ToS Improvements > > Migrate ArcToSScreen to multistep behavior. > Get rid of display: none; and display: block; > > Bug: 1156667 > Change-Id: I4c2fc425edd4883c5edfceb0a5a9f67a6227de7b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603744 > Commit-Queue: Ossama Mahmoud <osamafathy@google.com> > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844554} TBR=antrim@chromium.org,rsorokin@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,osamafathy@google.com Change-Id: I62973f98fccb5086b852879395d04f4a3050c244 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1156667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636099Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#844643}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dabd9655278a..13466d016b58 2021-01-19 tikuta@chromium.org autoninja: use pure python3 to get build id and for post_build_ninja_summary.py If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ib94499c48d057bfffe9f1041dafa59528d7c3042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636496Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844642}
-
https://chromium-review.googlesource.com/c/chromium/src/+/2633748Nico Weber authored
Change-Id: I027a493f129021059ef8a7b51ca1d5bee01e65ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635076 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#844641}
-
Maggie Cai authored
This reverts commit ce17e926. Reason for revert: This CL is likely the cause of crash for test MessagePortProviderBrowserTest.PostMessage in builder Linux MSan Test starting from https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20MSan%20Tests/27063/blamelist Original change's description: > PostMessage hookup to allow payment request delegation. > > This CL adds fields to postMessage data structures that convey > the sender Window's intention to delegate a capability to the > receiver Window. The change is behind two runtime flags: one flag > ("CapabilityDelegation") enables the parsing of a new postMessage > option for delegation, while the other flag > ("CapabilityDelegationPaymentRequest") enables transmission of > payment request delegation information to the receiver Window. > > Bug: 1130558 > Change-Id: Ifad482bc9629ea69b9bd802d5f0f7df7c24645f5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568627 > Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844548} TBR=dcheng@chromium.org,flackr@chromium.org,mustaq@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I9a6ac999124984ca5ddff2a64f6c4f4eebd56e97 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1130558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636098Reviewed-by:
-
Xianzhu Wang authored
Previously the maximum animation scale functions returned kInvalidScale if any keyframe in any animation of the element couldn't calculate a scale. Now return kInvalidScale only if none of the keyframes can calculate a scale. Change-Id: Id982445e68fe862c3f2ac1c93d11cb2a49aadcea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631347 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#844639}
-
Maggie Cai authored
This reverts commit c065ff54. Reason for revert: This CL is likely to cause the test failure in multiple builders. compositing/squashing/remove-from-grouped-mapping-on-reassignment.html Some builders: https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/7566/blamelist https://ci.chromium.org/ui/p/chromium/builders/ci/Win7%20Tests%20(1)/113061/blamelist https://ci.chromium.org/ui/p/chromium/builders/ci/Win10%20Tests%20x64/52902/blamelist https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Win10/79230/blamelist https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Win10/79230/blamelist Original change's description: > Not clamp up setTimeout(..., 0) to 1ms for single_shot > > setTimeout(..., 0) is clamping up to 1ms for historical reasons: > crbug.com/402694, and the issue has been open for years which was > blocked by the challenge of updating all test expectations accordingly. > > Chrome doesn't need the clamp for anything in particular and no 1ms > clamp in the spec, moreover, we found Speedometer2 performance can boost > ~1% on Windows without it based on Pinpoint perf. > > Most failure tests failed with this change had been fixed in separated > CLs. > > Bug: 402694 > Change-Id: I46196584b887513ca520221be68099116931d4f2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578703 > Reviewed-by: Philip Jägenstedt <foolip@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Commit-Queue: Wanming Lin <wanming.lin@intel.com> > Cr-Commit-Position: refs/heads/master@{#844459} TBR=skyostil@chromium.org,wanming.lin@intel.com,foolip@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I0148f4b5cd39d4e1bea66f753c91aaf7da537fb5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 402694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636078Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5cf0ef0022c7..29bd8638adb0 2021-01-18 asapersson@webrtc.org Add field trial for allowing cropped resolution when limiting max layers. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I8f5671490cd3e3d71004b256fb3445e990045eae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636495Reviewed-by:
-
Bartek Nowierski authored
Names like |ptr| or |address| don't convey the intention for the pointer to point to the beginning of a slot, and |slot_start| does it. Improve comments while at it. The renaming made it obvious that in one case SlotSpan::FromPointer could be used instead of FromPointerNoAlignmentCheck. Change-Id: I17cc44bcbbfad57e17477bf64d54d140ad279c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631719Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#844636}
-
Philip Rogers authored
For the transition to garbage collected LayoutObjects, non-stack-allocated objects need to opt in to tracing [1]. PaintInfo should be stack allocated and this patch marks it as such. To do this, DirectionFlippingScope needed to be marked as stack allocated as well. With this patch, PaintInfo should work as-is during the transition to garbage collected LayoutObjects. [1] https://chromium.googlesource.com/chromium/src/+/master/third_party/blink/renderer/platform/heap/BlinkGCAPIReference.md#stack_allocated Bug: 1030176 Change-Id: Ifddaaf53eedb9f36bfb050cbb1c3edd84daa3780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633642Reviewed-by:
Yuki Yamada <yukiy@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#844635}
-
Luciano Pacheco authored
Remove incorrect .bind(this) because rollup fails because `this` is null in that context. These callbacks don't use `this` so it's safe to remove the binding. Import webui_command_extender.m.js to add the method setHidden() in cr.ui.Command when running as JS modules. Bug: 1133186 Change-Id: Iac70f1364a2bf77bfbdf6eb4d3d453786519c2e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636006 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#844634}
-
- 18 Jan, 2021 30 commits
-
-
Luciano Pacheco authored
When running as JS modules the `cr.ui` namespace is removed causing the name conflict. Bug: 1133186 Change-Id: Id52659090df89e67f9b0a3cf44d01b4a0747584b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636076Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4ce36a5a3764..f2a99e868d8f 2021-01-18 andoli@chromium.org [module.json extensions] help views If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134103 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7ee585380074376569a2b9bd2e4be6696e688da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636261Reviewed-by:
-
Xianzhu Wang authored
Previously the maximum scale of a translation animation was unknown in cc, making it indistinguishable from animations whose scale was not computable. We used the native scale (page_scale * device_scale) for such animating layers, which may be too small or too big if the element has very big or small accumulated scale from ancestors. See crbug.com/1153428. Now let MutatorHost::MaximumScale() return 1 (instead of kNotScaled which is renamed to kInvalidScale) for translation animations. Accordingly modify PropertyTrees::MaximumAnimationToScreenScale() which depended on kNotScaled for non-scale animations to avoid combination of maximum scales of multiple scale animations. Now check if the maximum scale is 1 (which may be for translation animation, or a scale animation with with maximum scale == 1, but we don't need to distinguish them) for the purpose. Also optimize PropertyTrees::MaximumAnimationToScreenScale() by caching the current to-screen scale of non-animating parent to avoid multiple calculation of when the parent has multiple animating children. Bug: 1161586 Change-Id: If269fd003f77daf1239184e62aa75291c400bfc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605415 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
Jarryd authored
Bug: 1165232 Change-Id: I6849113b9988536a2742f17d9f0da13b68d58ed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632778Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#844630}
-
Luciano Pacheco authored
Bug: 1133186 Change-Id: I9a26f72fc24f4fe49c160120ebca3f4cf22f0ce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636005 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Dominik Röttsches authored
My intention was to do that already in [1] but I somehow missed adding my own email address. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2590037 Bug: 1158389 Change-Id: I6c2ddb4a9e8e62ae3a83487d27a19c1ab8c2f439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636353Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#844628}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e02dfe6c..ee927aaa Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie3d8bfbd97b45b9f48d691f8f35561e5cbfc0ecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636374Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844627}
-
Sara Kato authored
Bug: 1159562 Test: build Change-Id: I48f18f8d345e34c219c58f5e5599f8e8fa7f1420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616052Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#844626}
-
Mike Reed authored
One repercussion of this is that SkPaint no longer controls how images are sampled -- that is done explicitly with a SkSamplingOptions parameter to drawImage calls, and the same parameter passed to image-shader factories. To address this (ignoring paint's filter-quality), OpacityCanvas now has to override more draw calls. This is fragile, and not the best direction, but is necessary (it seems) at the moment. See skbug.com/11126 Bug: skia:11126 Bug: skia:7650 Change-Id: I6562ca834ddde34c533e68fe4a5abb8c2fae22b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605650 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#844625}
-
Joshua Berenhaus authored
To manually test metrics in Chromium, this needs to return true to ensure UMA client id logic behaves correctly. Bug: 1160364 Change-Id: Icc413159e5f5f4674d6beb40804c10dc249b841e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610957 Auto-Submit: Joshua Berenhaus <joshber@microsoft.com> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#844624}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/12971a22d265..5cf0ef0022c7 2021-01-18 nisse@webrtc.org Stricter compile-time thread annotations in JsepTransportController 2021-01-18 philipel@webrtc.org Remove unused function VideoDecoder::PrefersLateDecoding. 2021-01-18 alessiob@webrtc.org Remove unused code in APM 2021-01-18 danilchap@webrtc.org Delete unused.h include from api as unused 2021-01-18 nisse@webrtc.org Move deprecated code to their own build targets. 2021-01-18 philipp.hancke@googlemail.com fix variable naming in ReportSdpFormatReceived 2021-01-18 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision da248227..18311e27 (844357:844473) 2021-01-18 philipp.hancke@googlemail.com payload type mapper: use media constants 2021-01-18 nisse@webrtc.org Update pc/ to use C++ lambdas instead of rtc::Bind 2021-01-18 danilchap@webrtc.org Delete RTC_WARN_UNUSED_RESULT as no longer used 2021-01-18 hta@webrtc.org Reland "Improve structuring of test for audio glitches." 2021-01-18 nisse@webrtc.org Update SCTP test to use C++ lambdas instead of rtc::Bind 2021-01-18 mbonadei@webrtc.org Remove deprecated //rtc_base:async_resolver. 2021-01-18 tommi@webrtc.org Remove lock from RtpStreamReceiverController. 2021-01-18 tommi@webrtc.org Reduce redundant flags for audio stream playout state. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:857004 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Id422e48c8889fa1dc4dca523d1e8446269e6c6b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636477Reviewed-by:
-
Kevin Ellis authored
Prior to the patch, the validity of the execution context was only checked on entry to the method; however, the execution context can be invalidated during the course of parsing keyframes or options. The parsing of options is upstream of Animatable::animate and caught by the existing check, but invalidation during keyframe parsing could fall through triggering a crash. Bug: 1161739 Change-Id: Ic0fc927d1d6ce902592bf92261fd4c506e96afac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636213 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
-
Henrique Ferreiro authored
The class DictationChromeos already lives in a ChromeOS-only directory: chrome/browser/ash/. Remove its suffix. This CL is part of the Chrome OS source code directory migration: https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE. Bug: 1164001 Change-Id: I28ff84b527e3eebc7584b22a7f99a9acdbe4cf04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627371 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Owners-Override: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#844621}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610981979-8f34756a4da6cb018f171d5c6603852477d6e4b4.profdata to chrome-win32-master-1610992290-682e9bbbdeeb2e8d01a84d67f327a574b1495751.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic72ee725b81807e3d184e601258cb7f4f9f944cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633440Reviewed-by:
-
Jonathan Backer authored
This CL copies https://skia-review.googlesource.com/c/skia/+/312056 and uses coherent memory on mobile GPUs, which demonstrated a significant CPU saving on Android. Change-Id: I3ca13695a168e7b998b9ebffddab06d21f10983b Bug: 1167904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636380Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#844619}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610981979-6557ac3082422cce80dd82b8ef29d8213086e8c3.profdata to chrome-win64-master-1610992290-a2bb9ab0a72f07714d6834315a5f80b743087bf7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I527fff2ad672983e847e3ab0071fe403e007a166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636478Reviewed-by:
-
Luke Zielinski authored
Turns out there are two flavours of this test in similar directories. Bug: 1167318 Change-Id: I8684f093b7eb74d9912a53d1050fffb6a2526e1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633938 Commit-Queue: Luke Z <lpz@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Luke Z <lpz@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#844617}
-
alanlxl authored
1. Add a task_runner_ to ServiceConnectionImpl, it's initialized when ServiceConnection::GetInstance() is first called. All the calls to top-level ml service interfaces will run on this task_runner_. Now they can be called from any sequence. 2. Add BindMachineLearningServiceReceiver, customers can use it to bind their own remote and call ml service interfaces via it. Eventually clients should all use this method, rather than any of existing public methods, which will become deprecated. Bug: chromium:916760 Test: pass the unit_test Change-Id: I7e6e693289cd8d29bbb4bde8a949af7374855139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626950Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Honglin Yu <honglinyu@chromium.org> Commit-Queue: Xinglong Luan <alanlxl@chromium.org> Cr-Commit-Position: refs/heads/master@{#844616}
-
Victor Costan authored
Bug: 1163048 Change-Id: If05d0b84f98fa4969b670f1e80d5bb2d0699925d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627942 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#844615}
-
Peter E Conn authored
This is the first step in a three sided patch: 1. Create empty build targets. 2. Have downstream depend on the empty build targets. 3. Move upstream files into the build targets. Change-Id: I81c636dca974b5561e717ce46e5a83922fddc238 Bug: 1164866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632652Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#844614}
-
Geoff Lang authored
Rename the WebGL2 compute context type to ES3.1 for testing and disallow creating contexts of this type except through explicitly passing version 3.1 to context creation. Add a command decoder fuzzer bit which enables running against ES 3.1 command decoders. Bug: 1166743 Change-Id: Ifee885db02c3617f252900aa0ef4e2c3fc99e811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627885 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#844613}
-
Guillaume Jenkins authored
Extends the IOS.SiriShortcuts.Count histogram by 5 months. The histogram is periodically used to determine the importance of Siri Shortcuts in iOS 14 and whether richer integration would be valuable. Bug: 1167772 Change-Id: Ia9374d20e2bb550f601949fe1b0352cb5e8fd5cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636295Reviewed-by:
-
Vincent Boisselle authored
Tested: Tested the integration with the new synchronous reporter that runs on the UI thread. Important: Do not submit until the new internal renderer lib is rolled out. Change-Id: If9d23ebe16f3e5a72a315e8af547c2a0cc6daf60 Bug: 1117586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367643 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#844611}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/765e4f6f0ef4..8da0f82baf35 2021-01-18 amaiorano@google.com VulkanBenchmarks: improve and clarify resource ownership If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I143dc63d06afe30d944f6e022e706bf6810d39cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635685Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b434291562fd..4ce36a5a3764 2021-01-18 andoli@chromium.org [module.json extensions] Wrap localizable fields in anonymous functions 2021-01-18 andoli@chromium.org [module.json extensions] issues views If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134103 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7f1b63f6cdeb22787ce5c9f9db937d3a7ed06238 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636475Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/297e1ae19685..679d118787e7 2021-01-18 cwoffenden@gmail.com Fix to build with VS2019 2021-01-18 james@clarkezone.io Add support for building in Flutter Windows UWP configuration If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: Ia46a02c45d409d059548dc5ca1f0b37f59486700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635691Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/61649cc4962e..73b54fac553a 2021-01-18 rharrison@google.com Deprecate WebGPU SPIRV support (#1167) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: I980f0bbd17ff5adb0706e9d78514f749d1c4f246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635234Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I63e121897ba566106fbe95de674667782812c928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633937Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844606}
-
Henrique Ferreiro authored
Code in //chrome is not supposed to be in any namespace, so remove the chromeos namespace from this code. To avoid having to make namespace changes twice, code that will be eventually moved to namespace ash or having its chromeos namespace removed is changed to additionally export its symbols in the newer namespace. This CL is part of the Chrome OS source code directory migration: https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE. The CL skips presubmit to allow "using namespace" declarations that are banned by the style guide. These are temporary, and will be removed after the migration. No-Presubmit: true Bug: 1164001 Change-Id: Ibd43e52cadd6a2ae75e93bb752b1fe3332a2a40c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627314 Commit-Queue: James Cook <jamescook@chromium.org> Owners-Override: James Cook <jamescook@chromium.org> Reviewed-by:
-
Chrome Cunningham authored
This reverts commit 4a8451e4. Reason for revert: The issue wasn't fixed by [1], so lets reinstate the defensive fix. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2626920 Original change's description: > Revert "Defensive fix for crash in MediaWebContentsobserver" > > This reverts commit 79de0d4b. > > Reason for revert: We expect another CL may be the correct fix. https://chromium-review.googlesource.com/c/chromium/src/+/2626920 > > Original change's description: > > Defensive fix for crash in MediaWebContentsobserver > > > > This defensive fix until MediaSession owners return from vacation. > > Reverting is challenging given the long string of CLs. > > > > GetMediaPlayerRemote(player_id) is crashing for failing to find the > > remote with that ID. The stack shows the call coming from > > MediaSessionController, which should have the same lifetime as its > > associated mojo::Remote<media::mojom::MediaPlayer>. So far, I have not > > found how those lifetimes are getting out of sync. > > > > Ownership looks like this (read -> as "owns", MWCO as MediaWebContentsObserver): > > MWCO -> MediaSessionControllersManager -> map<MediaPlayerId, MediaSessionController(s)> > > MWCO -> map<MediaPlayerId, mojo::Remote<media::mojom::MediaPlayer>> > > > > I've combed through all the places where MWCO removes from its map of > > MediaPlayer remotes, and looked for a failure to call > > MediaSessionControllersManger::OnEnd(Id) to remove the associated > > MediaSessionController. There are 3 cases where we remove from the > > map... > > 1. MediaWebContentsObserver::RenderFrameDeleted() > > 2. MediaWebContentsObserver::WebContentsDestroyed() > > 3. media_player_remotes_[player_id].set_disconnect_handler(base::BindOnce(... > > > > The only case where I don't see a call to > > MediaSessionControllersManager is #2. But that shouldn't matter since > > MWCO's destructor is called shortly (synchronously) after > > WebContentsDestroyed(). Its destructor will tear down the > > MediaSessionControllersManager. > > > > The defensive fix does not address the root lifetime issue. It is > > probably the case that the MediaSessionControllers are being leaked. > > > > Bug: 1161551, 1039252 > > Change-Id: I85337eae106d8b56b7d48fc9759702dc579855ca > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607579 > > Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> > > Commit-Queue: Frank Liberato <liberato@chromium.org> > > Reviewed-by: Frank Liberato <liberato@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#839818} > > TBR=dcheng@chromium.org,mlamouri@chromium.org,chcunningham@chromium.org,liberato@chromium.org,beccahughes@chromium.org,mario@igalia.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1161551 > Bug: 1039252 > Change-Id: Id12ba170758a4479342c0eb3b2c64bb1243f34b1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632919 > Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> > Reviewed-by: Frank Liberato <liberato@chromium.org> > Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844208} TBR=dcheng@chromium.org,mlamouri@chromium.org,chcunningham@chromium.org,liberato@chromium.org,beccahughes@chromium.org,mario@igalia.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1161551 Bug: 1039252 Change-Id: I6ff223f67ce4c45bf1a49722f98e0a3dc8eef8bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636377Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#844604}
-
