GitLab

This change:
1. Adds braces for all control structures according to the Google
JavaScript style guidelines: http://go/js-style.
2. Access the phase member variable (this.phase_) when checking
the current phase. The previous code was confusing because
sometimes we would check the tree walker phase using the getter
(this.phase) and other times we would directly check the member
variable (this.phase_).

Change-Id: Id2288716d7b1bb1a08fb8c06760a17a753be8081
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880178
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#714702}

Bug: 997885
Change-Id: I93bda4028f5dc1b59d29b8f26aa30f050e6b3eae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909284
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714701}

Since interruption is raised and caught in a separate thread,
it may take some time to get interrupted exception on the test thread.
Also, we should not feed data since the task may be executed even
before it gets interrupted.

Test: I was able to reproduce this issue when I add some delay in the
      test thread, which proves my point. With the changed logic I could
      not reproduce the issue.

Bug: 1022954
Change-Id: I48899279d5bc678a75f40b21b6adf3faf2efe2f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906639
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714700}

This CL re-implements the named test so that it is meaningful in the
context of OOPIF-based PDFs. The test (i) verifies that the embedder loads
correct boilerplate <embed> tag, and (ii) that the extension loads.

Bug: 1019367
Change-Id: I79193923d2b0572bd49bf75cb462f2db8768a901
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906181
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714699}

The test used to navigate to chrome://settings, which may take
a long time causing the test to flake. The test's intent is to
verify correct WebPrefs applied when switching to tablet mode
for internal pages; doesn't have to be the settings page.
Use chrome://version instead.

BUG=1023903
TEST=Run test locally with no flakes

Change-Id: I5bc62a1eb9d67e1d0ca62693110081d4fd512974
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913020
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714698}

https://chromium.googlesource.com/openscreen/+log/729798cc3be6..21b5adc8409a

$ git log 729798cc3..21b5adc84 --date=short --no-merges --format='%ad %ae %s'
2019-10-25 jophba Fix chrome build, add unit testing in Chrome
2019-11-06 mfoltz [Open Screen] Consolidate BUILD.gn for cast/
2019-11-05 mfoltz Roll buildtools/ cf454b247..140e4d7c4 (2 commits; 1 trivial rolls)
2019-11-05 mfoltz [Open Screen] Move mDNS code to discovery/mdns.
2019-11-05 btolsch Add virtual connections for cast socket
2019-11-05 rwkeane DNS-SD: Add new TxtRecord method
2019-11-05 rwkeane DNS-SD: More Conversions
2019-10-31 rwkeane DNS-SD: Conversions From mDNS
2019-10-30 rwkeane DnsSd: Querier Skeleton
2019-10-29 yakimakha MdnsService base interface
2019-10-25 miu Cast Streaming: Add RTP Payload Type hacks for AndroidTV.
2019-10-25 rwkeane DNS-SD: TxtRecord implementation
2019-10-25 rwkeane DnsSd: More Operators for Constants
2019-10-24 rwkeane DNS-SD: Instance Record

Created with:
  roll-dep src/third_party/openscreen/src

Change-Id: I64f4e8d5ac63657c1bac61d012321c80c5f90b7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906125Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714697}

The status area collapse/expand animation is currently unspec'd, so skip the
animation for now.

TEST=manually verified with --force-status-area-collapsible flag
BUG=982511

Change-Id: Idaa95fd9a2393d668ad7d154663fc1e876c184d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903937Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714696}

This is a reland of
https://chromium-review.googlesource.com/c/chromium/src/+/1903934
with missing deps added.

This adds a PermissionWizard::Delegate implementation which runs the
Me2Me or IT2Me binary with a command-line for checking permissions.

This can be used to create a PermissionWizard which checks the
permissions on either the ME2ME or IT2ME host.

TBR=garykac@chromium.org

Bug: 1015201
Change-Id: Ie704ff1a7c6c90c33b614f042a19c81e9ad6e2d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912917Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714695}

It already has two timeout mitigations - one on the size of output, one
on the size of the input, but they're not enough. This CL replaces them
with a single limit on the number of reads, which should hopefully mean
we don't have to invest any more time dealing with silly timeouts.

Bug: 1006309
Change-Id: I50c6c52b26c43826efd5071ce0b345cd9782ca84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912142Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714694}

From the overview page of the fingerprint enrollment dialog for
chrome://settings/securityKeys, drop the table's header and top-most separator
line. Also align the page's subheader ("Fingerprints on this security key")
with the dialog title ("Manage fingerprints"), and align the right-hand sides
of the dialog body and button container (in order to align the secondary "Add"
button, table and "Done" button visually).

Also change the dialog title while enrolling a new fingerprint to "Add
fingerprint".

Demo: https://drive.google.com/open?id=1xmJj3XA9Vzz0Dx5G9a822HJdGDKC12WM

Bug: 974046
Change-Id: I77aa2d45a3d3a98a1472cd1865d2ac8a8488db48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907548
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714693}

The android framework does not require an extension to parse image
drawables correctly (only that they do not have the .xml extension).
This cl removes all image extensions from the APK to reduce binary size.

Bug: 1014555
Change-Id: I2100d8d008543a4cd36672d80a8a9a2ceaa98dda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902231
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Auto-Submit: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714692}

Also use it SVGSMILElement::SvgAttributeChanged(...).

Change-Id: Ic3352bf30eda7b86736858e7f68c50a6ce8a628c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912240
Commit-Queue: Philip Rogers <pdr@chromium.org>
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714691}

It is no longer used.

Change-Id: Ie73e71cd135f4005b2d66c80fc4fa8d90c349243
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912200
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714690}

Also move it be protected access.

Change-Id: I763a8112079ca3fb567b20a89c69bbfc0e420f13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912299
Commit-Queue: Philip Rogers <pdr@chromium.org>
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714689}

This CL removes the DECHECK_EQ for the unique_ptr because this is
a C++20 feature.

BUG=957519, 980914, 853604

Change-Id: I87c3213788ac4447aad2f3d46f8af2876ebf0053
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910821Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Maggie Cai <mxcai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714688}

Update FilledButton styles to adhere to the design spec. See
go/clankdictionary and go/clankcolors.

This change improves button accessibility by increasing the contrast
ratio.

Bug: 994365
Change-Id: I9fd61bdcde706c5ad6d27093a618807228ff0025
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910868Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714687}

Bug: 1012567
Change-Id: I0ab6f4144cc5ac4bfe2712ed272b1565cddfcda6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909285Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Auto-Submit: Bailey Berro <baileyberro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714686}

Saves 15kb of dex and 300 dex methods by removing the <clinit>()
from them.

While it is sometimes a good idea to cache instances of inner
classes, there are several reasons why having it be automatic
is not a good idea:
* Since caching happens only for stateless lambdas, it is
  too subtle. I don't think most devs are mindful of stateful
  vs. stateless lambdas when creating / modifying them. The
  syntax is the same for both.
* Many lambdas are used only once. Adding in a <clinit>() adds
  synchronization overhead & an extra function call.

Bug: 952833

Change-Id: I9ab1474c93b2732954b6df5159ac89049f1bfcf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902476
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714685}

DiscardableSharedMemory::Purge() attempts to proactively discard pages
to prevent slow-to-respond clients from keeping the pages live longer.

If the instance is in-process then these kernel calls are unnecessary
since the memory is about to be unmapped anyway.

Bug: 1023693
Change-Id: I2bc19eb64f3fdc009c5bf8c4ed6369b2b5081045
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911487
Auto-Submit: Wez <wez@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714684}

This test seems to be flaking more frequently as of late. Disabling it
to reduce jank on the bots.

TBR=tgupta@chromium.org

Bug: 1023950
Change-Id: Iad61dfb317f4bec5b0278c038c1e44c6b912e9e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913104Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714683}

Currently, the 'Set up' Messages button has no margin-inline-end.  It's
corresponding toggle button does, however, have a margin
(see "After screenshot" of
https://chromium-review.googlesource.com/c/chromium/src/+/1879445).

This is because CL 1879445 removes padding when the .no-padding class is
applied, which is the case for the settings-box ancestor of the button,
a feature-controller slot. As a result, bookend children of settings-box
must account for the padding loss via a .margin-matches-padding class.
CL 1879445 should have applied margin-matches-padding class around the
slot instead of only applying the .margin-matches-padding class to the
toggle contained within the slot.

Before screenshot--
https://screenshot.googleplex.com/WDtZVWyZDbB

After screenshot--

https: //screenshot.googleplex.com/ZgLoy8DPEYq
Bug: 1008361
Change-Id: I6583795757f4bf3685132a2543481e777f64a898
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910873
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714682}

Feature flag remains for Finch control should we need to switch it off.

Bug: 930812
Change-Id: I23701f27d5352d563b16ca4cda9fa796587c348e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913021
Auto-Submit: Adam Langley <agl@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714681}

To clarify that ChromeOS is now supported.

Change-Id: I2ef92ac00baad6407cedd39b8ba173f1c7a47845
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910767Reviewed-by: Sajjad Mirza <sajjadm@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714680}

This CL adds exception for VizCompositorThreadRunnerWebView to use base
sync primitives to allow blocking UI/Android Renderer thread on viz
thread for viz for webview implementation.

Bug: 805739
Change-Id: I25d6b7494d6b722f1f1d1c6faaff84b552279d06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911386Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714679}

crrev.com/c/1885219 broke SwitchToNonLayerBlur.

Bug: 1015886
Test: manually tested.
Change-Id: I831be4daa0c97596963a1603343f6735724423c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911225Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714678}

This serializes the values returned from parsing structured headers,
according to https://tools.ietf.org/html/draft-ietf-httpbis-header-structure-13.

Bug: 1011101
Change-Id: I33c0a80bd7cbe17c96bf9ef9803af32a1a7506ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872940
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714677}

In order to make more sense for a variety of device form factors, update
the OS Settings Power Page strings to use "Cover" rather than "Lid"


Bug: 997473
Change-Id: I9f36aed5dcaab03cc25d8f68b18a89a23306598d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913057
Auto-Submit: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714676}

What: Add a feature to cause AdTagging to only tag a v8 stack as an ad
stack if the top of the stack is an ad script. E.g., ignore the
bottom.

Why: Because sometimes an event on an ad script is used to create
content (e.g., the ad finishes showing so now reveal the page
content by calling content script).

Bug: 1022802
Change-Id: I54ef3f0930f886df01320a714e72e8e4554a0357
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906467Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714675}

Roll airmont AFDO profile from 80-3945.13-1572864139-benchmark-80.0.3961.0-r1 to 80-3945.24-1573469012-benchmark-80.0.3964.0-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_EXTRA_TRYBOTS=
TBR=c-compiler-chrome@google.com

Change-Id: I167cc8b42def818ecc91cca5601f1c144a2086c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913380Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#714674}

Add a target for merging the manifest file where a launcher icon is
added for WebView dev UI. This removes manifest merging from
"dev_ui_resources" definition and consequently from
"//android_webview:apk:apk_java". This makes it safe to depend on
"apk_java" target without triggering any manifest merging for targets
like WebView instrumentation tests.

Fixed: 1020444
Test: `webview_devui_show_icon=true` and bin/run_webview_instrumentation_test_apk
Test: Manually verify launcher icon after building SystemWebView, MonoChrome and Trichrome
Change-Id: Iba7e714ddb0b525828445565696e94327c9dfd84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904674
Commit-Queue: Richard Coles <torne@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Auto-Submit: Hazem Ashmawy <hazems@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714673}

- Unify multiple |focus(); return;| in SetFocusForDialog() into one.
- Add origin check and FinalizeAutofocus() call to SetFocusForDialog().

Bug: 985637
Change-Id: Ibb9a7161f384c9d15452dd2559c69cb0d458b9da

Experimental implementation for https://github.com/whatwg/html/pull/4918

Bug: 985637
Change-Id: I321736d512d6d8c76095f0f6de8751cd0a5e44e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911061Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714672}

This patch adds a CSS version of render-subtree into the css properties.

This doesn't use the new property in any way yet, just adds tests to
ensure that parsing is correct.

R=futhark@chromium.org, chrishtr@chromium.org

Change-Id: Icbd89b4d5d99977861e797d31e963b1c605e0778
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906937
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714671}

Append a new field to the initial settings sent to the print preview UI
to disable the 'Save as PDF' destination option. Currently, the option
can be disabled with the |isInAppKioskMode| initial settings field, but
that field also controls other behavior. Now the destination option can
be hidden if either |isInAppKioskMode| or |pdfPrintDisabled| is set to
true in the initial settings.

Remove ChromeOS only flags in parts of the UI code that handle the
state in which there are no destinations.

Bug: 487875
Change-Id: I92729e0a05860f3ab50c04fe2ad1ad1750818d25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904094
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714670}

This CL updates the a11y popup type for the media toolbar button to fix
an issue where JAWS would tell the user to use arrow keys instead of
the tab key.

Bug: 1022971
Change-Id: I6523bdd9380ec61cfbb05a86923c654877e818e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906636
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714669}

Bug: 927411
Change-Id: Ia2fabf76ef8faa3b8d875b8625572c81eef20946
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911488
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714668}

Bug: 1020450
Change-Id: Ic865cbaf3c38b39c1dc840510fb5ad5190deb7fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898808
Commit-Queue: Dan Beam <dbeam@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714667}

This reverts commit 85bd68c7.

Reason for revert: for transitions from Child to Regular account, and
from Regular to Child account all secondary accounts are going to be
removed from Chrome OS Account Manager (so we don't need to remove the
accounts from ARC).

Original change's description:
> Disallow secondary accounts in ARC for Child users
>
> Project Beaker on Chrome OS is going to allow child users the addition
> of secondary accounts, but it's going to be limited to web only.
>
> - If user has transitioned from child account to regular -
> TriggerAccountsPushToArc will add accounts to ARC on startup.
> - If user has transitioned from regular account to child -
> HandleSupervisionTransition will remove all secondary accounts from
> ARC.
>
> Update is going to be executed on startup, since to transition to
> another type, user need to sign-out and sign-in again (I think).
>
> ARC CL: http://ag/9615344
>
> Bug: 1017160
> Change-Id: I323a18aca9c9f63e6a3869d9b9dd4dd34432c31c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876089
> Reviewed-by: Mattias Nissler <mnissler@chromium.org>
> Reviewed-by: Yury Khmel <khmel@chromium.org>
> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#711171}

Bug: 1017160
Change-Id: Ie44780d372a2c4b9a85327e93be29a2ede0ad9e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904073Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Kush Sinha <sinhak@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714666}

Fix a typo when setting the property to control whether the dialog's cancel
button should be disabled. This lead to the cancel button being disabled in
certain states where it should have been enabled instead.

Bug: 974046
Change-Id: I1ad70ce61e68f45d1998b9837b02137256c2d2aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900571
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Auto-Submit: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714665}

Currently, AutocompleteResult doesn't really support the no-default-match
case. The first match is set to be the default match, even if none of the
matches are |allowed_to_be_default_match|.

This is problematic, because there's three known cases where there's
genuinely no default match:
 - NTP ZeroSuggest
 - Enterprise policy where there's no default search provider
 - ChromeOS launcher

ChromeOS launcher already supports the no-default-match case properly.
The other two are subtly broken.

This CL does two things:
 - It updates AutocompleteResult to set default_match() == end() when
   there's no valid default match.
 - It updates a bunch of logic OmniboxPopupModel (runs on Views and iOS)
   to support the no-default-match case.

Bug: 1016845, 363656
Change-Id: Ib684efba92b05cb677bdabf9265e35e2bfbeab56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906882
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714664}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Ia561e98b6a504e25237453cd3ac210721c2fa64d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912921Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#714663}