- 17 Jul, 2020 30 commits
-
-
dpapad authored
<dialog> instances by default are absolutely positioned with respect to the <html> element. Moreover, it seems that setting "position: relative" on any of its parents does not have any effect. Using "position: fixed" fixes both issues (scroll position flashing and action menu scrolling away after opening). Fixed: 1105643 Change-Id: I1b0a5ca653b37b5455c237b2917ca79e4556af1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302747 Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#789302}
-
Justin DeWitt authored
Client is responsible for closing the menu when it system-back is pressed, but our configuration of the bottom sheet swallows the back event and does nothing. Bug: 1106425, b/161381371 Change-Id: Ide491bd1f59cfd15e148ee9454e93a0785b33e07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300882 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#789301}
-
Cammie Smith Barnes authored
Currently, the AdsPageLoadMetricObserver only records the FCP of the root ad frame in FrameData and ignores FCP of any child frames except for an ephemeral check while computing the Creative Origin Status. This can lead to an situation where a child frame receives an First Eligible to Paint and then an FCP, allowing calculation of the Creative Origin Status, but the root ad frame has not yet received an FCP, so the FrameData's timing object still holds a null value for the FCP. Then, if a request to nullify the First Eligible to Paint value for the frame tree arrives, under the current setup it will succeed, and then a DCHECK for a non-null FEtP will subsequently fail. Further changes to fix the related bug in the FCP ads metric will be in a follow-up CL. Bug: 1103610,1103782 Change-Id: I4234ada8a6d0d98e2cf153522bd15e0d86efd8dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290775 Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#789300}
-
Michael Spang authored
We can't use GPU compositing without a GPU process. This fixes a problem in cast_shell_internal_browsertests that's occurring after 966e62f6 ("[scheduler] Enable prioritize until begin main frame by default."). Change-Id: I36eb9f615775e19f81fe24f8a532085fb9483ed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303874 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#789299}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia028635352bd4b9893718049b659fcb669d1bc8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303870Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789298}
-
Fletcher Woodruff authored
Adds the DocumentScan.SaneBackend enum, as well as the DocumentScan.{ScanRequested,ScanSucceeded,ScanFailed} metrics. These are used to track which SANE backend a user requested when a scan is started, as well as the backend used when a scan finished successfully or unsuccessfully. Metrics are added by https://crrev.com/c/2281282 Obsoletes the ScanResult metrics since it is superseded by the new metrics. Bug: b:160472550 Change-Id: I5eae8fb99ee7d09ce39688648a6b6828d9122190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281207 Commit-Queue: Fletcher Woodruff <fletcherw@chromium.org> Reviewed-by:Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#789297}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ifbf63c8eb210128226b78c64e569e28c8f64732b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303776Reviewed-by:
-
Federico Paredes authored
This CL[1] removed the logic that allowed screen readers to focus into menus. This[2] other CL re-added functionality for generic menu items. However, buttons within menu items (like those in the Zoom MenuItemView) weren't fixed. This CL fixes hot button focus with screen readers. This only fixes the issue with keyboard navigation, and not with mouse navigation. If you use your mouse to navigate to a button, it will still select the entire container. Bug: 1105917 Change-Id: I3ab23364f2e63f8429e4bc8eba2ace4467a0dd91 [1] c22c3a2a [2] 7750c6d5 Change-Id: I3ab23364f2e63f8429e4bc8eba2ace4467a0dd91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295787Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#789295}
-
Nate Chapin authored
Change-Id: I8587d4d75a36b83c8fd38ec43d5f3cbcbc15ed90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297715 Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#789294}
-
Ben Pastene authored
This is the 2nd reland of 8f372d5f Reason for reland: - Fixed yet-another DEPS-parser in crbug.com/1106435 - No changes in this CL. Original change's description: > Split the cros_boards gclient var into two for fetching QEMU images. > > This will help with the TODO at: > https://source.chromium.org/chromium/chromium/src/+/master:build/config/chromeos/rules.gni;drc=ded9eb5153bb13b3f8821a6fa6fac6b3f0f590fd;l=22 > > It will also remove the need for hard-coding the names of all these > QEMU-compatible boards. > > Bug: 937821 > Change-Id: Iab180fc012bd694b4908ba0654da93d42e2274fa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265498 > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Cr-Commit-Position: refs/heads/master@{#786005} Bug: 937821, 1106435 Change-Id: Ia1d47740c4061739f4ad4dfe403f755fd68fdc4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303377Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#789293}
-
Peter Wen authored
Remove //{base,remoting,third_party,ui,weblayer}* from allowlist. Allow depending on androidx_media_media_java. LICENSE updates are from upstream, automated by fetch_all.py. Bug: 1080903,1082904 Change-Id: I20240ab7f065670eb283e16dd32e278750729105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303022 Auto-Submit: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#789292}
-
Michael Hansen authored
This adds a row in the Nearby Share settings subpage for the "Device name" setting, as well as the dialog which appears when the user clicks the row. The dialog will be wired up to load and save the device name in a future CL. Screenshot of the row in the subpage: https://screenshot.googleplex.com/nvHGBot2bWr Screenshot of the dialog: https://screenshot.googleplex.com/p8esPTUpQ5p Spec in Carbon: https://goto.google.com/czcfm Bug: b:154863679 Change-Id: I1c79f6059fe926ed945ec77754088e07af783a54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292789 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#789291}
-
Zhongyi Shi authored
A bunch of other components now need explicitly include the dependency. Bug: 1104380 Change-Id: Ia272d1cae50fdc13f4a38c3448e3abf71bb9cceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298724Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#789290}
-
Brian Sheedy authored
Targets Mac 10.15.5 in addition to 10.14.6 for the GPU Mac Intel Stable mixin in preparation for the OS upgrade. Submitting with no-try due to crbug.com/1106559 blocking submission otherwise. TBR=ynovikov@chromium.org No-Try: true Bug: 1078489 Change-Id: I4d0dd92d805a2a2cf6e5355012b6f4b4e83884ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302923 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#789289}
-
Tom Anderson authored
X11 cursor handling is annoyingly all handled client-side, so we need to reimplement libxcursor, including reading and parsing the cursor images from disk. Since new usages of base::ReadFile() are added, cursor reading cannot be done on the UI thread like it was previously. This means every cursor needs to be async, which adds quite a bit of complexity. BUG=1066670 R=nickdiego,sky Change-Id: If63be11bda34c04c56c52085453abbda0ef553bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293616Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#789288}
-
Tom Anderson authored
BUG=1066670 R=sunnyps Change-Id: Icc189028b7d7630d398b1efe7ff55110913d0e48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302735 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#789287}
-
Andrew Xu authored
This CL applies a special rule on Files Manager to ensure that its first context menu item is "New window". A browser test is created to protect this feature. Bug: 1102781 Change-Id: I5de587e6d15f377d2b43fffd8d963437f8f41640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295931Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#789286}
-
W. James MacLean authored
The third CL in implementing origin-/site-keying of SiteInstances. https://crbug.com/1085275/#c2 lists the sequence of CLs and what each will accomplish. This CL replaces uses of site URL as map keys with SiteInfo in BrowsingInstance and RenderProcessHostImpl. As a result, maps will be able to distinguish SiteInfos based on additional criteria, such as site vs origin keying. Bug: 1067389, 1085275 Change-Id: Iae821dfb6314968fbe059732ff3c97e84add4212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261216 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#789285}
-
Wei Li authored
Also fix the section title style in theme_aware.md to be consistent. Original Author: tluk@ Bug: none Change-Id: I54b113efb27ec2e98026765c2b11c0bb6e3d2385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297736 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#789284}
-
Alexander Cooper authored
The BrowserList::CloseCallback is potentially called multiple times (for each browser window that is closed), and thus it is explicitly converted to a RepeatingCallback. Note that this change is working towards cleaning up the files at the root of chrome/browser, and as such it does *not* fully convert either BrowserList nor other items that pass in CloseCallbacks, except for unload_browsertest which is at the root of chrome/browser. Bug: 1007635 Change-Id: I81525c00814c59db6b0aceee0e31588062b2775c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302937 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
-
Arthur Wang authored
Bug: 1060399 Change-Id: I05e41fa3b48352ddc37b7ccb39d73ac481cf1c47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302917 Commit-Queue: Arthur Wang <wuwang@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#789282}
-
Nate Chapin authored
Change-Id: I7abee88a5214a4e7a0a0680e4e46f80ece3f9182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298174 Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
Scott Violet authored
This test is still mildly flaky. The issue is that while it waits for a non-empty paint, this is not always enough. This makes the test additionally wait for loading to complete and more importantly, waits for a visual update. The latter is a good signal the renderer will actually process events. BUG=1091129 TEST=test only change Change-Id: Iabc6d2dce83985086c56db916c8cc273e3ed65f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303554Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#789280}
-
Nodir Turakulov authored
Update both metadata-exporter and linux_chromium_component_updater builders to NOT be tree closers. Update metadata-exporter builder to be triggered by commits (contiuously), as opposed to periodically. Remove all default notifications from these builders because these are very specific builders and the people notified by default don't have the context. Bug: 1106554 Change-Id: Ib5068ff16b6be2c3f00e354b7c9b2dda6162e8b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303600 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#789279}
-
Mohsen Izadi authored
This enum value is not set anywhere (I believe since r414750) except in some tests. Bug: 1100977 Change-Id: Ib643ca350704ba240057b097379b415b299a0afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274168Reviewed-by:
-
Xing Liu authored
This CL fixed an issue in download location prompt status metrics, also adds a metrics for download later prompt status. Bug: 1106094,1078454 Change-Id: I17af189721e840a5e29ee7fc89e02506b2b9b689 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300806 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#789277}
-
wutao authored
Bug: b/160753530 Test: manual Change-Id: I4edae4b329f17919ad25aca3800adf79861e6f1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287273Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#789276}
-
Mark Yacoub authored
Put all config requests into a vector and move them together. Change the callbacks to handle all displays configured together rather than one display at a time. BUG=1082882 TEST=no changes enabling and disabling displays, display_unittests. Change-Id: I36859414e1e31e8411f67bac0c3609696cabeece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237653Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Auto-Submit: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#789275}
-
Alexander Cooper authored
The ActiveModalDialogListener outer callback is explicitly called multiple times, thus requiring conversion to RepeatingCallback. the inner closure is also stored as a RepeatingClosure by the only place that creates an ActiveModalDialogListener, so is similarly converted. This change also converts chrome_browser_main's base::Binds, as the only consumer of ActiveModalDialogListener. Bug: 1007635 Change-Id: I49e4a2ba9772919e57c448e08bba57e6c8a32b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299191 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#789274}
-
Jeff Yoon authored
iOS14 tests to execute on chromium.tests.ios14. Bug: 1101531 Change-Id: I8fee379d472ed05c73eeed75b8bf6f50b83a1694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295788Reviewed-by:
-
- 16 Jul, 2020 10 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic84fbe38d12071933410a43d4ca63b64d07e02c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303561Reviewed-by:
-
Jonah Ryan-Davis authored
This was fixed within ANGLE Bug: chromium:1099763 Change-Id: I4398cc7178ceaa05e9000668b04c5501daeea55e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302411Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#789271}
-
Sven Zheng authored
Bug: 1104291 Change-Id: If1535212a0a931b0e7477ff91b60d5a3ecbd0efd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303456Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#789270}
-
Guillaume Jenkins authored
Refactors the SetAndroidAppInfos method out of ReportGenerator and into a new delegate class, in preparation for moving ReportGenerator to components. Note that the ReportGenerator constructor uses the desktop factory directly, because the base factory can't be used until ReportGenerator is moved to components. #Squeegee Bug: 1092425 Change-Id: Iff4a273f752cc286ac5654c3520c00cd1c31f14e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296578Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#789269}
-
Dirk Pranke authored
We no longer have separate test-type-handling logic for CTS tests and instrumentation tests; instead, they emulate and are treated as gtest-based tests by the infrastructure these days. This CL updates the //testing/buildbot/README.md documentation and the generator code accordingly. Bug: 816629 Change-Id: I56d646cab293dcd9e59209d80d6fa016fd1d5ffd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303773 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#789268}
-
Christian Biesinger authored
R=ikilpatrick@chromium.org Bug: 1098475 Change-Id: Ibe99426f1737841957b7f6611bcab70228724786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261875 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#789267}
-
Hesen Zhang authored
UnifiedAutoplaySettingBrowserTest.Block Failed on several bots. List of failed builders: Builder: Win10 Tests x64 https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64 First failing build: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/b8874594547915853472 -------------------- Builder: Win10 Tests x64 https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64 First failing build: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/b8874585376703011824 TBR=sergeyu@chromium.org Bug: 1106521 Change-Id: I55eaa23c2bd01d4dc03cdfbef6fe4090866d6f49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303457 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
-
Chris Lu authored
Bug: 1100696 Change-Id: I44136dfd61e8ab7d1fc64020d51854adaad68377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283893Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#789265}
-
Sahel Sharify authored
Flake Portal: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyUAsSBUZsYWtlIkVjaHJvbWl1bUBicm93c2VyX3Rlc3RzQFNTTFVJVGVzdElnbm9yZUNlcnRFcnJvcnMuU3ViZnJhbWVIYXNDZXJ0RXJyb3IM TBR=estark@chromium.org Bug: 1106370 Change-Id: Ibee02ba23881f78b28c27e3652ccbf60fa7a6f86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303055Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#789264}
-
Clark DuVall authored
Follow up to https://crrev.com/c/2289191. This callback is only used in tether code as an error callback. This change moves the callback to TetherDelegate and renames to StringErrorCallback. Even though this is mostly used in chromeos/components/tether, it can't be defined there since chromeos/network can't include code from there. Bug: 1007660 Change-Id: I882d25857afdcc2b86a9cae4f146032603b6d40f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303871Reviewed-by:
-
