GitLab

This adds two new preferences for controlling Certificate Transparency
configuration, intended for use within an Enterprise. In a follow-up,
these will be wired up to Enterprise Policies for enterprise-wide
configuration.

- certificate_transparency.excluded_spkis

  For organizations that are issuing organizationally-bound certificates
  (either OV or EV), they can disable Certificate Transparency for their
  organization by specifying SPKI hashes. Certificate Transparency will be
  disabled if the validated certificate chain contains one of these SPKI
  hashes, and the certificate associated with the SPKI hash meets one of the
  following conditions:

  1) The hash matches the leaf cert's SPKI
  2) The hash matches a CA certificate that has a nameConstraints extension
     with a permittedSubtrees tree, which contains one or more directoryName
     nameConstraints, and there is a directoryName nameConstraint that
     restricts the O field and the leaf cert also has one or more O fields
     in the Subject.
  3) The hash matches a CA certificate, and the CA certificate has one or
     more O fields in the Subject, and these are equal to the Leaf cert in
     ordering, value, and number of values.

- certificate_transparency.excluded_legacy_spkis

  For organizations which are relying on trust anchors that have been removed
  by default by newer versions of the trust store, but were present in older
  versions (and thus subjected to CT requirements), they can disable
  Certificate Transparency for certificates under these CAs by specifying the
  SPKI hash. The SPKI hash must be one which appears in
  //net/data/ssl/root_stores and must not be presently trusted on Android or
  Chrom[e/ium]OS.

Bug: 824184
Change-Id: I0098bf7c28ac5201f9ba0f171f55a43a7fe3e073
Reviewed-on: https://chromium-review.googlesource.com/987513
Commit-Queue: Doug Turner <dougt@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548318}

Instead of passing an ExtensionPrefValueMap to
ExtensionPrefs::InitExtensionControlledPrefs(), just use the member
variable directly.

Similarly, instead of passing `this` and the value map to the
anonymous free function LoadExtensionControlledPrefs(), just
make LoadExtensionControlledPrefs() a member function and use
the ExtensionPrefs members directly.

Bug: None

Change-Id: Ifd036983e83a4ecc9b95144cb87c986b68c2fa12
Reviewed-on: https://chromium-review.googlesource.com/996499
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548317}

The PORTALLOCATOR_DISABLE_COSTLY_NETWORKS flag isn't reliable on mobile
network and may remove networks that shouldn't be removed. Given that we
never had this flag set on the old app and we hadn't got any complain so
far, we may just disable this flag for now.

Bug: 829117
Change-Id: Ic33cc19998ce259c60227e020e1ca1264e4c7fab
Reviewed-on: https://chromium-review.googlesource.com/996613
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548316}

The code to log the collected data using ukm.

Bug: 820883
Change-Id: I5359427153fdb3f9b7f56a26e7238d9d45260f89
Reviewed-on: https://chromium-review.googlesource.com/967909
Commit-Queue: Paul Dyson <pdyson@chromium.org>
Reviewed-by: Jia Meng <jiameng@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548315}

We can ask RenderWidgetHostViewMac for its FrameSinkId/SurfaceId when
the BrowserCompositorMac is already gone there; early out in those
cases and return invalid FrameSinkId/SurfaceId. When GetCurrentSurfaceId
returns invalid SurfaceId, we are going to send the event to the parent
root_view of the now-invalid view [1].

[1] https://cs.chromium.org/chromium/src/content/browser/renderer_host/render_widget_host_input_event_router.cc?type=cs&l=330

Bug: 828304
Change-Id: I009e51e9c1cfd31dad8efd4a7b504ba63dd49b18
Reviewed-on: https://chromium-review.googlesource.com/996304Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548314}

Consistently failing on WebKit Linux Trusty (dbg).

TBR=mstensho@chromium.org

No-Try: true
No-Presubmit: true
No-Tree-Checks: true

Bug: 829181
Change-Id: If082269d6d58848efa3d7c7c756c774e050cdd79
Reviewed-on: https://chromium-review.googlesource.com/996773
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548313}

FrameSinkVideoCapturer returns a full-resolution snapshot of the page,
but DevToolsEyeDropper expects the snapshot to be scaled to the page's
dip size. This is problematic for the current configuration of
FrameSinkVideoCapturer if device scale factor is anything other than 1.
Make sure FrameSinkVideoCaptuerer also scales the snapshot to the
expected size.

TBR=caseq@chromium.org

Bug: 813929
Change-Id: I324c6dccfd7db69e07d2283f826a613946c0bf07
Reviewed-on: https://chromium-review.googlesource.com/986291
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548312}

Bug: 824774
Change-Id: Ib6be40e0b6b7b215e64035f5ff4ae65531ce7198
Reviewed-on: https://chromium-review.googlesource.com/996433Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548311}

Bug: none
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2a125825faf342373faa4b957788c6e90692a71b
Reviewed-on: https://chromium-review.googlesource.com/996801Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548310}

BUG=787020
TBR=dpranke

Change-Id: I5d7fbbbee13a356ea7b53c577441fbf1c922ccb8
Reviewed-on: https://chromium-review.googlesource.com/996755Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548309}

Assertion at RenderWidgetHostViewAndroid::StopObservingRootWindow
called via |Destroy| failed, since WebContentsViewAndroid::SetContentViewCore
was passing a valid ViewAndroid instead of nullptr when cvc is destroyed.
This kept RWHVA observing root window, while the view tree was already
torn down by WCVA dtor, leaving RWHVA in inconsistent state where it
couldn't get WindowAndroid any more. This CL fixes the bug. Previously
WCVA passed null CVC to RWHVA before https://crrev.com/c/958646, so
this fix is the correct behavior.

Bug: 828211
Change-Id: I79463cd0dce94c5f8d81417208cd313871c4f5d7
Reviewed-on: https://chromium-review.googlesource.com/991002Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548308}

https://webrtc.googlesource.com/src.git/+log/448f4d50dc75..76d9bd5b459b

$ git log 448f4d50d..76d9bd5b4 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=chromium:None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I3159a9d10ee4a24536429f89a91df9bdde933cbe
Reviewed-on: https://chromium-review.googlesource.com/996306Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#548307}

This CL completes the refactoring of the ArcNavigationThrottle to be
app-platform agnostic by moving the callback run when the user responds
to the intent picker from ArcNavigationThrottle to
AppsNavigationThrottle. This will enable a future CL where the
AppsNavigationThrottle can insert non-ARC++ apps into the intent
picker, and then launch those apps if the user selects them.

There should be no functional changes from this CL. Two implementation
changes include:

1) the intent picker UI now returns an app-platform-generic CloseReason,
   and a boolean indicating if the user wanted to persist their choice.
   The AppsNavigationThrottle passes these to the ARC++ code, which
   interpolates them to the existing histogram buckets for metrics
   (which were formerly returned directly by the UI). This simplifies
   code in the UI layer, and moves responsibility for computing
   histogram values into the app-platform-specific code.

2) IntentPickerResponse is changed to be a OnceCallback, which removes
   some book-keeping in the UI layer for enforcing that it is only run
   once.

BUG=824598
TBR=sky@chromium.org

Change-Id: I1de4fd85c30e9ed09622ead11b709b9d6cdcfa98
Reviewed-on: https://chromium-review.googlesource.com/983197
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: David Jacobo <djacobo@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548306}

1. Remove the OnClientConnectionClosed() IPC from GPU to browser.  The
   browser never used the IPC so it wasn't necessary.
2. Destroy CompositorFrameSinkImpl when the client connection is closed.
   The object is useless after that point so it can be cleaned up.
3. Don't destroy RootCompositorFrameSinkImpl when the client connection
   is closed. The display compositor will continue to produce frames.

Bug: 814475
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ie9a96ee504013435c23b05cf6dbaa3fda4e0fd33
Reviewed-on: https://chromium-review.googlesource.com/993993Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548305}

For support navigation change by gesture, we need to populate scroll
phase event from Direct Manipulation. We add a new flag
PrecisionTouchpadScrollPhase for this in case we want to turn off
this CL.

Bug: 647140
Change-Id: Id815d3d0b5ee09bc13aaa1c99423364fef04c310
Reviewed-on: https://chromium-review.googlesource.com/967103Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Sahel Sharifymoghaddam <sahel@chromium.org>
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548304}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=amineer@chromium.org

Change-Id: Ie4c4e791eb4e4fd74f234f147c0942d092e2a851
Reviewed-on: https://chromium-review.googlesource.com/996854Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548303}

Fixed jumping during mouse wheel zoom.
Fixed jitter in network flamechart panning when main flamechart is panned with the mouse.
Fixed misplaced hover/selection after zooming.

Change-Id: I75bce65f8392922fa3e32f72731eebbce52b5450
Reviewed-on: https://chromium-review.googlesource.com/994285
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548302}

This reverts commit 52d81474.

Reason for revert: This causes display settings crash. crbug.com/829190

Original change's description:
> Actually check whether extension is in kiosk mode
> 
> Add the missing check for actually being in kiosk mode, but keep the
> autotest bail to simplify testing of the feature.
> 
> BUG=chromium:826568
> TEST=Ran autotest, verified that extension can't access edid.
> 
> Change-Id: I8f93e29d8d977b0977b3eb597ce2aae263b4e9b9
> Reviewed-on: https://chromium-review.googlesource.com/982619
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Commit-Queue: Felix Ekblom <felixe@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#548147}

TBR=stevenjb@chromium.org,felixe@chromium.org

Change-Id: I0c72734b027c4920eb4ab341ca0813c645870f6c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:826568
Reviewed-on: https://chromium-review.googlesource.com/996933Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548301}

No logic changes. Just a spelling fix in a comment.

TBR=blundell@chromium.org

Bug: None
Change-Id: Ice5f572a695706850fb1a1e88d91a229ab7034df
Reviewed-on: https://chromium-review.googlesource.com/996895Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548300}

Copy the current members of API_OWNERS to //third_party/WebKit/OWNERS.
This CL has no behavior changes.

Change-Id: Ia82002c5a266c951ed80b63721fc35a952071390
Reviewed-on: https://chromium-review.googlesource.com/987592
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548299}

The individual bridges can always convert from Profile* to profile id
easily, but the reverse is not true. This is an issue when the profile
manager is shutting down because the reverse lookup depends on the
profile manager still being operational.

Unlike when the bridge is handling interactions with a notification,
the profile must already be loaded when Display(), Close() or
GetDisplayed() is called.

This is blocking fixing some bugs in NotificationPlatformBridgeChromeOs:
https://chromium-review.googlesource.com/c/chromium/src/+/979268

Bug: none
Change-Id: Ibcb2b61cf2f03408a432edfd0a252ec01e9fe30b
Reviewed-on: https://chromium-review.googlesource.com/982648
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548298}

PopupWindow.showAtLocation takes the window token from the view passed
in, and AnchoredPopupWindow passes in the root view. This all means that
it's very unlikely that there is a mistake in set up that can cause
BadTokenException. So the only explanation is that the Activity actually
is gone or hidden, which is a real edge case. So just swallow the
exception instead.

Bug: 826052
Change-Id: Ib966d8900530a25b93849ff17b91431df5e38c43
Reviewed-on: https://chromium-review.googlesource.com/996561
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548297}

This patch adds support for some grid properties.

We add a new <flex> CSS value object, which meant rebaselining all the tests.

We're failing some tests because the 'grid', 'grid-template' and
'grid-gap' shorthands don't serialize to anything [1], so Typed OM
can't create an unsupported style value from it. Not sure if this is
a bug...

[1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp?type=cs&l=406

Bug: 820299
Change-Id: I8ff871fffed2977ca20a623bd283d7cbdc247870
Reviewed-on: https://chromium-review.googlesource.com/984756
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548296}

This patch introduces an infinite deadline as a possible DeadlinePolicy
choice. This would be used in the future when a forced surface
synchronization is requested.

R=fsamuel@chromium.org, piman@chromium.org

Bug: 667551
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iad25d2fd7a8c65e5b53034b448029f463ed717a3
Reviewed-on: https://chromium-review.googlesource.com/996762Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548295}

This patch adds launcher items for Crostini apps, which launch apps via
a D-Bus call to concierge (the D-Bus client code is also added in this
patch).

There are of course a lot of things missing, e.g. proper icons, name
localization, the context menu for app icons, and updating the launcher
when the registry is updated.

Bug: 821662
Change-Id: I12f9be995a56a29ed438a54c38d8f55cd140dffb
Reviewed-on: https://chromium-review.googlesource.com/995113Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548294}

BUG=none
TEST=none
TBR=estade

Change-Id: Ida938109e9ce253f9c496be144c3ca5828f609a6
Reviewed-on: https://chromium-review.googlesource.com/996919Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548293}

Creating a set of RootFrameSinks which will be updated at every
registering/unregistering of support if it's a root support. Also adding
a method to get the children FrameSinkIds by parent. Both of these will
be used to build a FrameSink tree. We intend to track all the FrameSinks
that are created/destroyed, even those that correpond to tooltips,
options menu, etc. Since we create a RootCompositorFrameSink for a
tooltip or the options menu we keep all the RootFrameSinkIds in a set and
insert into this set or erase from the set when RootFrameSink is created
or destroyed respectively.

Adding a method to get a FrameSinkSupport by id. This will be used for
CSS properties and additional attributes (like LastBeginFrameArgs).

Bug: 816802
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I41a69716a591a7f8c57cd7785a45036730b731c8
Reviewed-on: https://chromium-review.googlesource.com/984035Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Illia Martyniuk <illiam@google.com>
Cr-Commit-Position: refs/heads/master@{#548292}

Create an origin trial for WebXR and a separate one for exposing controllers as Gamepads.
Controllers will still be exposed as Gamepads by default for WebVR origin trial, but must be
enabled separately for WebXR.

Bug: 779691

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I639b259ea2a583bdbd3f18b6d30b7e107cdb21c1
Reviewed-on: https://chromium-review.googlesource.com/982679
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548291}

- Add MRDialogControllerViewsImpl stub
- Rename MRDialogControllerImpl to MRDialogControllerWebUIImpl
- Factor out parts that are common across WebUI and Views into
  MRDialogControllerImplBase
- MediaRouterDialogControllerImplBase::GetOrCreateForWebContents() is
  implemented in two places: mrdc_views_impl.cc for builds with Views,
  mrdc_webui_impl.cc for builds without.

Bug: 826091
Change-Id: I276d46ba870b837c5b35f48a4921a3df356aa565
Reviewed-on: https://chromium-review.googlesource.com/990572Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Adam Parker <amp@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548290}

VR wants to support autofill popup behind a flag.
We can remove the check completely when the flag is removed.

Bug: 819881
Change-Id: I390a6fd425b81238f255d85dc84f18e41291828e
Reviewed-on: https://chromium-review.googlesource.com/992889Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548289}

This CL checks VEA flush behavior by adding two states: CS_FLUSHING
and CS_FLUSHED. Now the encoding flow becomes:

- Set state from CS_ENCODING to CS_FLUSHING
  when the client sends the last frame and calls VEA::Flush(flush_cb)
- Set state from CS_FLUSHING to CS_FINISHED
  when the client receives the last encoded frame
- Set state from CS_FINISHED to CS_FLUSHED
  when flush_cb(success=true) is called
- Set state to CS_ERROR if either of situation is true:
  - flush_cb(success=false) is called before last encoded frame is
    received
  - flush_cb(success=true) is not called in a period of time
    (e.g 200 ms) from VEA::Flush() is called.

BUG=chromium:820313
TEST=Run video_encode_accelerator_unittest at scarlet device

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2a83b0e7f902575b084ae4ccf85f3ba7d5f74819
Reviewed-on: https://chromium-review.googlesource.com/908370Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
Commit-Queue: Chih-Yu Huang <akahuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548288}

Notifications can be disabled for a number of
reasons. This logs those reasons with UMA.

This is a retry of my earlier CL, but does
not abort if getting settings failed (not
a fatal failure anyway).

Bug: 734095
Change-Id: I9a04f666e8181d87fd945fcdcac0c3a0371aa2f0
Reviewed-on: https://chromium-review.googlesource.com/995536Reviewed-by: Xi Cheng <chengx@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548287}

In https://chromium-review.googlesource.com/c/chromium/src/+/957645, I
accidentally introduced a crash (crbug/828814) which could occur if
content verification was running as Chrome was shutting down.

According to |KeyedServiceBaseFactory::AssertContextWasntDestroyed|,
service getting (ExtensionRegistry is a service) should only be done on
the main thread.

This CL stores the data which was read from the extensionregistry
(the extension's background scripts, page and content script file_paths)
in the ContentVerifierIOData instead.

Bug: 828814,809088
Change-Id: I7d2a326c5ea609f996bd0af2a6d490108a99e772
Reviewed-on: https://chromium-review.googlesource.com/996489
Commit-Queue: proberge <proberge@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548286}

When panning, rather than only waiting for a mouse move event before
switching to the hand cursor, check for middle mouse up/down events in
non-link areas and switch from/to the hand cursor immediately.

BUG=234933

Change-Id: I29661a7f60ccafdc710c639ab1206a566705272e
Reviewed-on: https://chromium-review.googlesource.com/996384Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548285}

After the user clicks on details on the page info dialog always dismiss
the page info dialog. By doing so, the dialog disappears in VR before
showing the user the exit VR request. That is consistent with what
happens when the user clicks the site settings button.

Bug: 829043
Change-Id: Id51477f08cf693107d11044c7ca2ec477c0118f8
Reviewed-on: https://chromium-review.googlesource.com/996305
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548284}

ExtensionTestMessageListener::WaitUntilSatisfied() is used to wait for
a specific message from an extension and return a result.
WaitUntilSatisfied() returns a bool indicating success, but this can be
false (i.e., failure) in certain circumstances. Add WARN_UNUSED_RESULT
so that callers must handle the returned bool, rather than only waiting
for the listener to be satisfied.

Bug: None
TBR=benwells@chromium.org (apps/, c/b/apps/)
TBR=stevenjb@chromium.org (c/b/chromeos, c/b/ui/ash/launcher/)

Change-Id: Ied7b2cd5e5006531a117158812dad5d39b673786
Reviewed-on: https://chromium-review.googlesource.com/989278
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548283}

On all other platforms //device/usb uses a custom backend. This patch
ensures that we are not including libusb in unexpected build
configurations.

Change-Id: Ia1b68e86048af7ed98d27b19f46f74ceba50097b
Reviewed-on: https://chromium-review.googlesource.com/996407Reviewed-by: Jun Cai <juncai@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548282}

Also, dropped the word "container" from AXPosition::Create...PositionInContainerObject for better readability and faster typing.
R=dmazzoni@chromium.org, aleventhal@chromium.org

Bug: 639340
Change-Id: I75c10bb35435a7cad9988e30a54af60f525bb29c
Reviewed-on: https://chromium-review.googlesource.com/995639
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548281}

This relaxes the check for the Samsung workaround landed in
http://crrev/c/924115, so that the workaround applies for Samsung's
other mail app which also reproduces this behavior.

Although the other mail app is referred to as
"com.samsung.android.email.provider" in our communication with them, its
implementation is actually split among 5 different APKs, and it is
"*.composer" which actually exhibits the bug.

As it turns out, the bug reproduces under the exact same sequence of
URL navigations as the other app (a file:// URL followed by
loadDataWithBaseURL("email://")).

As with http://crrev/c/924115, this is also meant as a temporary
workaround.

Bug: 781535
Test: Use both Samsung apps, test the 3 repro conditions listed in b/70696775.
Change-Id: Ic897a33dc52b78e83eaada5b4b66c555a0eb3679
Reviewed-on: https://chromium-review.googlesource.com/981691
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548280}

This allows a target to include private headers it wouldn't otherwise be
able to include. A target can provide a list of patterns of friend
targets that allow dependent targets to bypass public header checking.

A proper dependency path is still required, this applies only to the
concept of public/private headers on a target. Without this, it's
difficult to make a target be explicit about its public headers while
also allowing that target's own tests to use internal headers.

BUG=732993

Change-Id: I1cb94c7ac0db6f74cdcd49d08bcabedf70ea3eb0
Reviewed-on: https://chromium-review.googlesource.com/994453
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548279}