GitLab

This reverts commit bcbd1740.

Reason for revert: The bug that prompted disabling of the state-preserving firmware update feature has been fixed per https://chromium-review.googlesource.com/1123830 so we can re-enable the feature.

Original change's description:
> Disable state-preserving TPM firmware update.
> 
> The test team found an issue where cryptohomed fails to deal with the
> state the TPM is in for the case when the update installation gets
> interrupted and recovery is invoked to retry and complete the update.
> Disable device-state preserving updates for now until the issue is
> resolved.
> 
> BUG=chromium:854576
> TEST=Triggering TPM firmware update via chrome://chrome will not invoke the device state preserving update flow.
> 
> Change-Id: I4ac4d325bfbf953cfa14a501e871a3f9f59c699c
> Reviewed-on: https://chromium-review.googlesource.com/1111998
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Commit-Queue: Mattias Nissler <mnissler@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#570020}

TBR=stevenjb@chromium.org,mnissler@chromium.org

Bug: chromium:854576
Change-Id: Iab59dc64130792b92071d45b82a77ddbd4553aa4
Reviewed-on: https://chromium-review.googlesource.com/1127539Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Commit-Queue: Mattias Nissler <mnissler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578570}

- This doNothing() is not actually needed for the tests to pass; I
suspect it's a hangover from when these tests were instrumentation
tests.

R=mlamouri@chromium.org

Bug: 772027
Change-Id: Ia2b2103d2bdf6962c065ed5e34ecb1333d8300f5
Reviewed-on: https://chromium-review.googlesource.com/1151320Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578569}

SecurityOrigin::CanAccess distinguishes file://host/ from file:///
(empty host), however, the security tokens for file: scheme were
always "file://" regardless of host.  This makes Blink think two
origins are cross origin but V8 think the two are the same origin.

This patch changes the security tokens in case of file: scheme to
null string (will fallback to the default security token and V8
will always ask Blink to perform a security check).

Bug: 858990
Change-Id: If305a994d6150984e8dd41b964003ce1eafb8b99
Reviewed-on: https://chromium-review.googlesource.com/1133105Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578568}

We now set AvailableSize and PercentageResolutionSize on the
ConstraintSpace properly. And also now give the flex layout algorithm
more accurate offsets and main axis size.

Bug: 845235
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ia24778ffd24a6f1122e778919686a082a63d4b06
Reviewed-on: https://chromium-review.googlesource.com/1142729
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578567}

TBR=pmonette@chromium.org, pennymac@chromium.org

Bug: 868233
Change-Id: I526e832c16daa533ce53d03be717d265a67576e9
Reviewed-on: https://chromium-review.googlesource.com/1152726Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578566}

The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org, fdegans, sergeyu

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I6499e133cd71503143426575ead473bb973be2ea
Reviewed-on: https://chromium-review.googlesource.com/1151096
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578565}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

The AutoRoll server is located here: https://afdo-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: I0e2795dd7c8b4fb1a9ec58bc56a019eb8b2bbafd
Reviewed-on: https://chromium-review.googlesource.com/1152699Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578564}

This CL turns on the DesktopPWAWindowing flag on by default for
Windows and Linux.
We are targeting M70 for this so since M69 recently branched
we're flipping the flag so this feature can start baking before
next branch point.

Bug: 851845
Change-Id: Ib0f6232aacfa753054791419ed694687fa3b5671
Reviewed-on: https://chromium-review.googlesource.com/1152339Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578563}

This CL introduces an appearance change for the tab grid when tabs are being reordered. It adds a second collection view layout to make all of the non-moving cells slightly transparent, and to make the moving cell slightly larger.

Bug: 804593
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I6ba416844281aa7a106552c24ef1d9c854bff567
Reviewed-on: https://chromium-review.googlesource.com/1151297Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578562}

A follow up to CL https://chromium-review.googlesource.com/c/chromium/src/+/1141349

TBR=yusukes@chromium.org

Bug: NONE
Change-Id: I120dde78eeab5f35a8edc5fbcb021abbe8f2f535
Reviewed-on: https://chromium-review.googlesource.com/1152693Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578561}

BrowsingDataRemoverBrowserTestP.SessionStorageDeletion and
BrowsingDataRemoverBrowserTest.StorageRemovedFromDisk were flaky when
MojoSessionStorage was temporarily disabled.

This CL enables the tests again and forces the kMojoSessionStorage flag
to be enabled during the test.

Bug: 865802
Change-Id: I1f3b0b2bad792089f624a33271600ecf23875b29
Reviewed-on: https://chromium-review.googlesource.com/1150532Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578560}

ThreadableLoadingContext has been used for encapsulating
ExecutionContext-dependent things for loaders. Thanks to recent
off-the-main-thread efforts, now most of resource loading can run
off-the-main-thread and this abstraction is no longer necessary.

In addition to removing unnecessary code, this cleanup is useful for removing
WorkerShadowPage for installed service workers (issue 820329), and introducing
FetchClientSettingsObject in loaders (issue 845285).

Bug: 820329, 845285
Change-Id: Id6e329c9c783057ba68abab78a2e86054a3b0c29
TBR: haraken@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1150957
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578559}

This reverts commit c7c6a230.

Reason for revert: Findit identified the culprit r578404 with confidence 70.0% in the config "chromium.linux / Linux Tests"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVywgELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKLAWNocm9taXVtLmxpbnV4L0xpbnV4IFRlc3RzLzcxMzQ0L3Zpel9icm93c2VyX3Rlc3RzL1YyVmlVblJqUkdWemEzUnZjRU5oY0hSMWNtVkNjbTkzYzJWeVZHVnpkQzVTZFc1elUyTnlaV1Z1YzJoaGNtVkdjbTl0VDI1bFZHRmlWRzlCYm05MGFHVnkMCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA

Original change's description:
> [NTP] Add ability to add/delete/reset custom links from the New Tab Page
> 
> Added functionality for adding/removing links and restoring the Most
> Visited tiles. If the URL is not valid, the link will not be added. The
> blacklist button now opens the edit dialog (editing links is currently
> not functional and will be added in a later CL).
> 
> Also added hover/pressed/focus styling to the input fields and the
> buttons.
> 
> Design Doc: go/chrome-ntp-custom-links
> 
> Video: https://screencast.googleplex.com/cast/NTQyNDU2OTc1ODI1MzA1NnwwMjFkODAwYi1kMg
> 
> Bug: 851293
> Change-Id: Ic92e46ba93a4abcb375467a1d047cbb573f231ba
> Reviewed-on: https://chromium-review.googlesource.com/1149458
> Commit-Queue: Kristi Park <kristipark@chromium.org>
> Reviewed-by: Marc Treib <treib@chromium.org>
> Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
> Reviewed-by: Mathieu Perreault <mathp@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578404}

TBR=bauerb@chromium.org,mathp@chromium.org,treib@chromium.org,kristipark@chromium.org

Change-Id: Ibd93fac9b68c14b68c4dd26a174818bb10b1a719
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 851293, 868237
Reviewed-on: https://chromium-review.googlesource.com/1152594Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578558}

This reverts commit 2094f015.

Reason for revert: viz_browser_tests failing on chromium.memory/Linux Chromium OS ASan LSan Tests
https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/28406

Original change's description:
> chromeos: Support a11y caret highlight in shortcut viewer app and mash
> 
> The existing code updates the text input caret highlight by observing
> input method state. This works in classic ash because the input method
> is shared globally across ash and browser code. This doesn't work with
> remote apps because ash can't see the input method in the remote
> process. The caret doesn't work in mash because the ash process can't
> see the browser's input method.
> 
> Add support for a11y to observe the input method objects created by the
> browser's input method driver / bridge. Explicitly forward the
> text caret bounds to ash, which then updates the highlight.
> 
> Bug: 867110
> Test: added to ash_unittests and browser_tests
> Change-Id: I27058e091ad5a597de4ab644654df8d535e95b72
> Reviewed-on: https://chromium-review.googlesource.com/1151897
> Commit-Queue: James Cook <jamescook@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578473}

TBR=jamescook@chromium.org,xiyuan@chromium.org,tsepez@chromium.org

Change-Id: I8d2ed52affae2063d705f1ded9a2eca5dfdbda13
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 867110
Reviewed-on: https://chromium-review.googlesource.com/1152593Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578557}

This reverts commit b4956c1f.

Reason for revert: Test Failure on win.
Findit found culprit 578445 with 87% confidence

Original change's description:
> Roll src/third_party/webrtc e4db6a151806..ed1dcf9f2327 (1 commits)
> 
> https://webrtc.googlesource.com/src.git/+log/e4db6a151806..ed1dcf9f2327
> 
> 
> git log e4db6a151806..ed1dcf9f2327 --date=short --no-merges --format='%ad %ae %s'
> 2018-07-26 mbonadei@webrtc.org Enable clang::find_bad_constructs for call/ (part 1).
> 
> 
> Created with:
>   gclient setdep -r src/third_party/webrtc@ed1dcf9f2327
> 
> The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
> 
> If the roll is causing failures, please contact the current sheriff, who should
> be CC'd on the roll, and stop the roller if necessary.
> 
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
> TBR=webrtc-chromium-sheriffs-robots@google.com
> 
> Change-Id: I8ee83b94330beb6325018cb012ba3ff22c674eb9
> Reviewed-on: https://chromium-review.googlesource.com/1151847
> Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#578445}

TBR=webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com,webrtc-chromium-sheriffs-robots@google.com

Change-Id: I4348447e61897960a4453e8c7e6c32af00b6c208
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/1152592Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578556}

This reverts commit 66add30d.

Reason for revert:
Looks like the build failure was caused by the flaky build system, not the original CL:
https://bugs.chromium.org/p/chromium/issues/detail?id=853069&desc=2

Original change's description:
> Revert "PlzWorker: Teach a precreated AppCacheHost's ID to SharedWorkerWebApplicationCacheHostImpl"
> 
> This reverts commit c00da2be.
> 
> Reason for revert: Compile failed on linux x64
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20x64/70577
> 
> Original change's description:
> > PlzWorker: Teach a precreated AppCacheHost's ID to SharedWorkerWebApplicationCacheHostImpl
> > 
> > On PlzWorker, AppCacheHost is created before starting worker script loading from
> > a renderer process. This CL teaches the precreated AppCacheHost's ID from the
> > browser process to the renderer process in order to associate worker script
> > loading with the host.
> > 
> > This fixes DCHECK failures on appcache-worker.https.html caused by host
> > mismatch, the test still times out though.
> > 
> > DesignDoc:
> > https://docs.google.com/document/d/1Jtn33bvqkqWxq6K7HIA4uU6HLWPTmOD7vFviacfTmhM/edit?usp=sharing
> > 
> > Bug: 715632
> > Cq-Include-Trybots: luci.chromium.try:linux_mojo
> > Change-Id: I16c17447bbb0f4b154c5a7e9393afdea2d0e29d6
> > Reviewed-on: https://chromium-review.googlesource.com/1150941
> > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> > Reviewed-by: Matt Falkenhagen <falken@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#578547}
> 
> TBR=falken@chromium.org,kinuko@chromium.org,nhiroki@chromium.org
> 
> Change-Id: I2911bb7adaf8ac6be3dde96e5908a0e80e7ebc2e
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 715632
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Reviewed-on: https://chromium-review.googlesource.com/1152590
> Reviewed-by: Yoichi Osato <yoichio@chromium.org>
> Commit-Queue: Yoichi Osato <yoichio@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578548}

TBR=falken@chromium.org,kinuko@chromium.org,nhiroki@chromium.org,yoichio@chromium.org

Change-Id: I5921c0865fe6b4a3c216061c33c39002e293f69f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 715632
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1152591Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578555}

When the contents of a plugin element (<embed> and <object>) are to be
handeld externally inside an extension (most notably PDF) we currently
use browser plugin. BrowserPlugin is used to render GuestView contents
in another process.

However, BrowserPlugin-based guest views have been deprecated and all
guest views except for MimeHandlerViewGuest are not implemented on top
of cross-process frames.

This CL introduces the first steps in fully replacing BrowserPlugin with
corss-process frames.

Different mechanisms for this project have already been discussed in the
design doc:
https://docs.google.com/document/d/10g7Y9cprYKkch9JZ0TBUWaEnHBJT1nzhskQIt1nHbWM/edit#heading=h.ue5a8s290yhk

Bug: 659750, 330264
Change-Id: If273fbbab3e9f4a4591c61b19d54e4cca73c3464
Reviewed-on: https://chromium-review.googlesource.com/1101161Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578554}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/17f184f10975..3fff4ff38701


git log 17f184f10975..3fff4ff38701 --date=short --no-merges --format='%ad %ae %s'
2018-07-27 vapier@chromium.org lint: fix ungrouped-imports warnings
2018-07-27 vapier@chromium.org lint: fix using-constant-test warning
2018-07-26 vapier@chromium.org DebugSymbolsStage: fix & improve handling of failed uploads
2018-07-26 vapier@chromium.org lint: disable consider-iterating-dictionary class
2018-07-26 vapier@chromium.org cros lint: update to work w/pylint-1.5


Created with:
  gclient setdep -r src/third_party/chromite@3fff4ff38701

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ic1e6641d4d8eba8c900d1527b756574d8137e5b6
Reviewed-on: https://chromium-review.googlesource.com/1152612Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578553}

https://pdfium.googlesource.com/pdfium.git/+log/2daa06ab9596..aa418e541589


git log 2daa06ab9596..aa418e541589 --date=short --no-merges --format='%ad %ae %s'
2018-07-27 thestig@chromium.org Roll DEPS for testing corpus to 48945a35.
2018-07-26 tsepez@chromium.org Use moar ToXMLElement() in place of static_cast<>.
2018-07-26 thestig@chromium.org Roll DEPS for testing corpus to d2389ab3.
2018-07-26 tsepez@chromium.org Be more careful casting to widget subclasses.


Created with:
  gclient setdep -r src/third_party/pdfium@aa418e541589

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Iba3069c00f54da484e6282a76799e254b6fbb7e4
Reviewed-on: https://chromium-review.googlesource.com/1152610Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578552}

Otherwise, when computing a clip between an descendant and the root layer, the fragment
clip of the root layer from its local border box properties will be wrong, and clip
out the painted output.

Bug:860682

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I04653f18441becc4557ceca5a68bf513a9908283
Reviewed-on: https://chromium-review.googlesource.com/1149517Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578551}

This reverts commit aa28143d.

Reason for revert: 
Sorry, I did not review this, let revert this one and discuss.
I have few questions. I asked to add description in order to understand what you going to achieve.
Let talk about possible solutions and reland new one.

Original change's description:
> Fix folder location & ordinal for Crostini Apps on update
> 
> Currently, when updating an existing Crostini App, the
> associated CrostiniAppItem's ordinal and folder id are not
> preserved. This is because a new CrostiniAppItem is added
> to replace the old one. This leads to icons which users
> had previously removed from the Linux Apps folder to return
> to the folder, for example. This CL saves the item ordinal
> and folder id from the old app item, and re-sets them on
> the new app item.
> 
> This CL also changes process for inserting a newly
> installed app so that it removes the app before adding
> it. This is needed for the case that the user reformats
> their Chromebook without uninstalling Crostini, which
> leaves residual app info in their preferences.
> 
> Bug: 822488
> Change-Id: Id7442c6563851ad4997578da65340a5c2eeef3f5
> Reviewed-on: https://chromium-review.googlesource.com/1150955
> Commit-Queue: Renée Wright <rjwright@chromium.org>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578541}

TBR=stevenjb@chromium.org,rjwright@chromium.org,khmel@chromium.org

Change-Id: Idf60204ad9bb6cc6dc215537dcab5520649fbfa4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 822488
Reviewed-on: https://chromium-review.googlesource.com/1152273Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578550}

Addresses the visibility of NTP icon text by adding a white pill underneath the text. Also, because we no longer need the textshadow, we use the css function to implement the ellipsis instead of writing our own function.

Before:
https://screenshot.googleplex.com/8N6m2yLinvo.png
https://screenshot.googleplex.com/3uCW3TsFzyN.png
After:
https://screenshot.googleplex.com/SbwT1GmCR5W.png
https://screenshot.googleplex.com/xrMjBTji41t.png

The setting doesn't affect the older version mv-tiles:
https://screenshot.googleplex.com/DWtC5dUPqW5.png

Bug: 850718
Change-Id: I002bc972edf2a69d4092b37193ee2fe932ab66f2
Reviewed-on: https://chromium-review.googlesource.com/1148891Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578549}

This reverts commit c00da2be.

Reason for revert: Compile failed on linux x64
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20x64/70577

Original change's description:
> PlzWorker: Teach a precreated AppCacheHost's ID to SharedWorkerWebApplicationCacheHostImpl
> 
> On PlzWorker, AppCacheHost is created before starting worker script loading from
> a renderer process. This CL teaches the precreated AppCacheHost's ID from the
> browser process to the renderer process in order to associate worker script
> loading with the host.
> 
> This fixes DCHECK failures on appcache-worker.https.html caused by host
> mismatch, the test still times out though.
> 
> DesignDoc:
> https://docs.google.com/document/d/1Jtn33bvqkqWxq6K7HIA4uU6HLWPTmOD7vFviacfTmhM/edit?usp=sharing
> 
> Bug: 715632
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Change-Id: I16c17447bbb0f4b154c5a7e9393afdea2d0e29d6
> Reviewed-on: https://chromium-review.googlesource.com/1150941
> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Matt Falkenhagen <falken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578547}

TBR=falken@chromium.org,kinuko@chromium.org,nhiroki@chromium.org

Change-Id: I2911bb7adaf8ac6be3dde96e5908a0e80e7ebc2e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 715632
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1152590Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578548}

On PlzWorker, AppCacheHost is created before starting worker script loading from
a renderer process. This CL teaches the precreated AppCacheHost's ID from the
browser process to the renderer process in order to associate worker script
loading with the host.

This fixes DCHECK failures on appcache-worker.https.html caused by host
mismatch, the test still times out though.

DesignDoc:
https://docs.google.com/document/d/1Jtn33bvqkqWxq6K7HIA4uU6HLWPTmOD7vFviacfTmhM/edit?usp=sharing

Bug: 715632
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I16c17447bbb0f4b154c5a7e9393afdea2d0e29d6
Reviewed-on: https://chromium-review.googlesource.com/1150941
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578547}

The layout test was introduced to verify the ability to select
text on certain elements (*). Incidentally, it hit tests the 1px
gap between two lines on Linux, which results in different behaviors
between legacy and NG due to different line box sizing.

This patch explicitly sets font metrics and line-height to stablize
its behavior.

(*) crrev.com/20a8d9a8

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I44918bf049607110572fc479548f3c958770c8ba
Reviewed-on: https://chromium-review.googlesource.com/1152216
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578546}

https://chromium.googlesource.com/catapult.git/+log/ac8c0c3138b7..a1e31db3c6b7


git log ac8c0c3138b7..a1e31db3c6b7 --date=short --no-merges --format='%ad %ae %s'
2018-07-27 nednguyen@google.com Regenerate startup args for each time trying to start the desktop browser


Created with:
  gclient setdep -r src/third_party/catapult@a1e31db3c6b7

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:865895
TBR=sullivan@chromium.org

Change-Id: I9666a5d8bd09b8eb2765b4f407b5e1c2f2fc77fb
Reviewed-on: https://chromium-review.googlesource.com/1152608Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578545}

If Clear Browsing Data is presented when History attempts to dismiss itself, nothing will happen. Need to dismiss Clear Browsing Data First.

Video: https://drive.google.com/open?id=1KUKsgv8OSQc_1301ff2XMgK2_hi6dd1-

Bug: 867329

Change-Id: I1cd5f242ef410267ed5d4ab0e006884a3288eafe
Reviewed-on: https://chromium-review.googlesource.com/1150620
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578544}

Switch from double to float in color_utils.cc. The HSL struct and
CalculateBoringScore still use double in their API because changing
those requires enough changes to justify being done in a different CL.

Note that SkColorToRgbaString intentionally uses a double precision
constant for 255 so that the calculation is done to double precision
so that spurious rounding in the result string is avoided.

Bug: 863135
Change-Id: Id5b678ed6e1c40475ec516bde2c902ba27bb783d
Reviewed-on: https://chromium-review.googlesource.com/1135550
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578543}

Update test expectations of PDFExtensionLoadTest.Load since one pdf doesn't crash anymore after r577739

Bug: 856161
Change-Id: I68207ae97c8b0e863169991e541126f0854264cf
Reviewed-on: https://chromium-review.googlesource.com/1152532Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578542}

Currently, when updating an existing Crostini App, the
associated CrostiniAppItem's ordinal and folder id are not
preserved. This is because a new CrostiniAppItem is added
to replace the old one. This leads to icons which users
had previously removed from the Linux Apps folder to return
to the folder, for example. This CL saves the item ordinal
and folder id from the old app item, and re-sets them on
the new app item.

This CL also changes process for inserting a newly
installed app so that it removes the app before adding
it. This is needed for the case that the user reformats
their Chromebook without uninstalling Crostini, which
leaves residual app info in their preferences.

Bug: 822488
Change-Id: Id7442c6563851ad4997578da65340a5c2eeef3f5
Reviewed-on: https://chromium-review.googlesource.com/1150955
Commit-Queue: Renée Wright <rjwright@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578541}

Using wpt-import in Chromium 7af2637c.
With Chromium commits locally applied on WPT:
7dad0f17 "Added new Sec-Metadata Web Platform Tests."
408f60ca "Remove Shared Worker WPT for WebUSB"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21754

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
eroman@chromium.org, rsleevi@chromium.org:
  external/wpt/WebCryptoAPI
jsbell@chromium.org:
  external/wpt/resources
mcasas@chromium.org:
  external/wpt/mediacapture-record
meade@chromium.org:
  external/wpt/web-animations
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

TBR=lukebjerring

No-Export: true
Change-Id: If2941ba3b50e2d16da967b93f9d7beecbb2d4223
Reviewed-on: https://chromium-review.googlesource.com/1152529
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578540}

This reverts commit 365f6904.

Reason for revert: UkmBrowserTest.SingleSyncSignoutCheck is Flaky
Findit identified the culprit r578386 with confidence 74.4%.

Original change's description:
> Migrate gcm to network service's socket APIs
> 
> With network service, net:: C++ socket access will need to be changed to using
> network service's socket APIs. This CL changes gcm to using
> proxy_resolving_socket.mojom instead of the C++ ProxyResolvingClientSocket.
> 
> GCM files that are changed:
> - google_apis/gcm/engine/connection_factory_impl.cc
>   This will request and own a network::mojom::ProxyResolvingSocketPtr
> - google_apis/gcm/engine/connection_handler_impl.cc
>   This will pass the mojo read/write pipes to socket streams.
> - google_apis/gcm/base/socket_stream.cc
>   SocketInputStream/SocketOutputStream will read from/write to mojo data pipes
>   instead of the C++ socket.
> 
> Network service changes
> - services/network/public/mojom/proxy_resolving_socket.mojom
>   Peer address is surfaced directly when connection is established. This is
>   needed to support GCM's use case. They need the peer address synchronously
>   when connection is done.
> 
> Browser changes:
> - NetworkContext raw mojo pointer has to be queried on the UI thread on demand.
>   Therefore changes are added to pass through a callback and ui task runner.
> 
> Bug: 862608
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: Ic0c72c8ee7d9bc7deb6e8109234227f80ea3bbe3
> Reviewed-on: https://chromium-review.googlesource.com/1142344
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Maks Orlovich <morlovich@chromium.org>
> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
> Reviewed-by: Peter Beverloo <peter@chromium.org>
> Commit-Queue: Helen Li <xunjieli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578386}

TBR=dcheng@chromium.org,peter@chromium.org,jam@chromium.org,sdefresne@chromium.org,xunjieli@chromium.org,morlovich@chromium.org

Change-Id: I5951169891854c5d441d897dcb2e849f1ef7ace9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 862608, 868220
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1152589Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578539}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/079812cefdd9..f12600a8ba80


git log 079812cefdd9..f12600a8ba80 --date=short --no-merges --format='%ad %ae %s'
2018-07-27 vadimsh@chromium.org [cipd] Update cipd and vpython to v2.2.3.


Created with:
  gclient setdep -r src/third_party/depot_tools@f12600a8ba80

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:821194
TBR=agable@chromium.org

Change-Id: Iaed9e09a7529bea16abd810add67b3b61484b48c
Reviewed-on: https://chromium-review.googlesource.com/1152269Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578538}

ModelLoader is a ref counted type, and its first reference used to be
taken in its constructor through base::BindOnce. The reference was
passed to a task runner, and released after the task has run.

However, if the PostTask failed or the posted task ran soon before the
construction had completed, the ModelLoader instance can be destroyed
before another reference is made on the original sequence. So,
`new ModelLoader` can return a stale pointer.

This CL adds a static constructor to ModelLoader, and makes the first
reference on the original sequence before passing a reference to the
other sequence.

Bug: 866456
Change-Id: I4d3c954ca39b7187fbd651c498e17273024c9968
Reviewed-on: https://chromium-review.googlesource.com/1151173
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578537}

This increase is temporary and should be reverted once LXD startup code
has been edited to remove unnecessary crypto calculations. These take much
longer on Kevin than Eve at present.

Bug: 863190
Change-Id: Ib2a004c46ecbf45c097bf3d6843e930b5edec7f9
Reviewed-on: https://chromium-review.googlesource.com/1152334Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578536}

This changes IsUserVerifyingPlatformAuthenticatorAvailable to return
false in incognito mode, and disable platform authenticator
instantiation for MakeCredential/GetAssertion in incognito.

Also change IsUVPAA to not return true on platforms where Touch ID is
enabled but the embedder does not not provide a configuration.

Bug: 678128
Change-Id: I2fc6b0182fcb9ae718acd842f1247baee81c5281
Reviewed-on: https://chromium-review.googlesource.com/1149115
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578535}

Following bot results are included.
8340 8342 8347 8355 8360 8368 8379 8387 8389

0 lines were removed and 4 lines were deflaked by consecutive
results since 8322.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Iba47345c85b9ae81c4229ac137f0757b1393c219
Reviewed-on: https://chromium-review.googlesource.com/1150956
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578534}

Now prefer to show that the group policy is disabled instead of saying
that the feature is disabled

Change-Id: Ibcfa4a72bce47ad6a98ea6c1fb120117b6705aa8
Reviewed-on: https://chromium-review.googlesource.com/1151544Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578533}

https://chromium.googlesource.com/angle/angle.git/+log/203b26f27d00..dbd1612782f5


git log 203b26f27d00..dbd1612782f5 --date=short --no-merges --format='%ad %ae %s'
2018-07-26 geofflang@chromium.org EGL: Implement EGL Image extensions.


Created with:
  gclient setdep -r src/third_party/angle@dbd1612782f5

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: Ie36028e0842e1ee560ece98ece793c7b9458577a
Reviewed-on: https://chromium-review.googlesource.com/1151209Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578532}

This is a follow up path for https://chromium-review.googlesource.com/615144
The original patch adds scrollbar flashing logic in the first two cases but
skips the last case:
1- All scroll updates other than the first one in a seuqence (the case
that scroll node exists).
2- The first GSU while scrolling viewport.
3- The first GSU while scrolling on anything but viewport.

This cl covers the third case.

Bug: 746342
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I62aafdc68df361fee56b3513a2a09250e3092b32
Reviewed-on: https://chromium-review.googlesource.com/1150436Reviewed-by: Jianpeng Chao <chaopeng@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578531}