GitLab

R=sullivan@chromium.org

Bug: 731091
Change-Id: Ie48518b6fdc4d9e5b671f117943978ee18ed5d0d
Reviewed-on: https://chromium-review.googlesource.com/688742Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504882}

Bug: 
Change-Id: Id6f22d5af556186494514527a353c9b71b9c66fd
Reviewed-on: https://chromium-review.googlesource.com/688684Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504881}

The file is written to on another thread, and the data pipe is also
read from off the consumer's thread, so this should be save to use on
named threads without causing significant jank.

Bug: 746977
Change-Id: I8e38945a569e4cd97ff4381ecf43acc73c731cea
Reviewed-on: https://chromium-review.googlesource.com/673043Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504880}

TBR=anantha@chromium.org

Change-Id: I42ca2c03b865d33bebf74523ba5c45f396e266ef
Reviewed-on: https://chromium-review.googlesource.com/688583Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504879}

This patch removes calls to RuntimeEnabledFeatures::Set*Enabled and
instead uses scoped settings setters to ensure test settings are not
used in future tests.

Bug: 769541
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I9411afa2e7522748e9f1446f515cae07e220738d
Reviewed-on: https://chromium-review.googlesource.com/688817
Commit-Queue: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504878}

When a target window is already known, e.g. capture window, we simply
convert point to be in the coordinate space of that target window
without targeting.

Bug: 758062
Test: viz_unittests
Change-Id: Ia727be8b00fdccad6fc78621e96a42413d856c88
Reviewed-on: https://chromium-review.googlesource.com/668164
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504877}

There's always only one notifier group in ash. As NotifierSettingsView
is moved to ash/, we can safely remove notifier group support.

TEST=ash_unittests
BUG=768734

Change-Id: I1b018cf25c31e8549922e25f83f341bd26542ec8
Reviewed-on: https://chromium-review.googlesource.com/684099Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504876}

NOTRY=true

Bug: 769502
Bug: 769508
Change-Id: Ib894feba443f5bbfbcd133f0ad73b9dd12e962ab
Tbr: alexmos@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/688223Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504875}

Bug: 682236
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2614bf5a86df25a3b9c08fb5fc69c7afdd0ff5b2
Reviewed-on: https://chromium-review.googlesource.com/675368
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504874}

Using wpt-import in Chromium 0c120f94.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/2510

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
hta@chromium.org:
  external/wpt/webrtc
phoglund@chromium.org:
  external/wpt/mediacapture-streams
tyoshino@chromium.org, yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

TBR=qyearsley@chromium.org

No-Export: true
Change-Id: Iae5d0ea2b6e5d981dc3842bda67b379ac13a04a6
Reviewed-on: https://chromium-review.googlesource.com/688576
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504873}

This CL does a number of things. It introduces vr::Model, which is
owned by vr::Ui. The model does not contain much yet (just a bit of
state related to the loading indicator), but the goal is for it to
house all our browser state).

In order to have vr::Ui poke the model rather than having the
BrowserUiInterface calls get routed directly to the UiSceneManager, I
also made the vr::Ui implement both BrowserUiInterface and UiInterface.

Given that we have rounded rects as a primitive, this change also
allowed us to avoid using textures at all for the loading indicator.

Bug: 768512
Change-Id: I2c5ff1bba6be7280aeadb53b000e0acb30fdc502
Reviewed-on: https://chromium-review.googlesource.com/682773
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504872}

Bug: 763208
Change-Id: I13138fb65c7f8071838f99b9297086edd2ea8415
Reviewed-on: https://chromium-review.googlesource.com/660995Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504871}

We may clean up cache if there is not enough space to install WebAPK.

Bug: 736457
Change-Id: Iaaf2e3d7b456bc08576b958eadb5af07bcc4fc62
Reviewed-on: https://chromium-review.googlesource.com/679276
Commit-Queue: Ran Ji <ranj@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504870}

With CL 669444, if a primary SurfaceInfo is specified on a layer
and no fallback is specified, then SurfaceAggregator will use an
embedder provided default background color to fill the space of the
primary Surface if the primary Surface is unavailable at surface
aggregation time.

Previously, SurfaceAggregator reported this case as an error and
logged UMA for a missing surface. Given this state is no longer considered
an error, there is room for simplifying code in BrowserPlugin and
RenderFrameProxy.

The default background color is set to SK_ColorTRANSPARENT to match the
current behavior. The primary surface is set as soon as it can be and
doesn't wait for the first fallback surface to become available.

Bug: 672962
Change-Id: I0ec6153356978e8994b50bfd4a024369e6f320d7
Reviewed-on: https://chromium-review.googlesource.com/686354
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504869}

This reverts commit 4229f25c.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 504862 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzQyMjlmMjVjMzQ3YWE2NGYwMWQ5MzJkZDIzODU2ZTQ0ZWFlNmQ3YTYM

Sample Failed Build: https://luci-milo.appspot.com/buildbot/chromium.win/Win%20x64%20Builder/38179

Original change's description:
> Removing WebContents::GetRenderProcessHost() method.
> 
> WebContents::GetRenderProcessHost is an API that doesn't behave as
> expected with out-of-process iframes, as multiple processes can be
> associated with a single WebContents.  This CL removes this API
> altogether.
> 
> This CL was started by using an ad-hoc clang-plugin that replaced
> existing callsites of WebContents::GetRenderProcessHost() with a call to
> something like wc->GetMainFrame()->GetProcess().  This was followed-up
> by manually adding an include of render_frame_host.h and git cl format
> and git cl lint and then a self-review with small tweaks (e.g. sometimes
> using a wc->GetRenderViewHost()->GetProcess() is more appropriate).
> 
> For the record, below is a list of existing bugs that have been
> uncovered or highlighted during the review of this CL:
> - https://crbug.com/715924: Headless OOPIF support
> - https://crbug.com/767519: Android WebView code duplication
> - https://crbug.com/767526: Handling of unresponsive renderers
> - https://crbug.com/767539: TabSpecificContentSettings
> - https://crbug.com/767557: ExtensionMsg_UpdateTabSpecificPermissions
> - https://crbug.com/767563: chrome.processes.getProcessIdForTab
> - https://crbug.com/769385: WebViewInternalAddContentScriptsFunction
> - https://crbug.com/769461: BrowserTag/WebView owner tracking
> - https://crbug.com/769479: PrintPreviewDialogController
> 
> Bug: 666525
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
> Change-Id: Idcb70a8c3928f0631a38a61b7029876fdaf921cb
> Tbr: alokp@chromium.org, boliu@chromium.org, derat@chromium.org, dvallet@chromium.org, haraken@chromium.org, lazyboy@chromium.org, lfg@chromium.org, raymes@chromium.org, rdsmith@chromium.org, tapted@chromium.org, tedchoc@chromium.org, thestig@chromium.org, treib@chromium.org
> Tbr: asvitkine@chromium.org, bartfab@chromium.org, bengr@chromium.org, benwells@chromium.org, dewittj@chromium.org, dsinclair@chromium.org, jkarlin@chromium.org, jsbell@chromium.org, meacer@chromium.org, mmenke@chromium.org, nparker@chromium.org, sergeyu@chromium.org, sky@chromium.org, stanisc@chromium.org, tommycli@chromium.org, wjmaclean@chromium.org
> Reviewed-on: https://chromium-review.googlesource.com/673124
> Reviewed-by: Justin DeWitt <dewittj@chromium.org>
> Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
> Reviewed-by: Stanislav Chiknavaryan <stanisc@chromium.org>
> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
> Reviewed-by: Nathan Parker <nparker@chromium.org>
> Reviewed-by: David Vallet <dvallet@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Lucas Gadani <lfg@chromium.org>
> Reviewed-by: Bo <boliu@chromium.org>
> Reviewed-by: Dan Erat <derat@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Nick Carter <nick@chromium.org>
> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#504862}

Change-Id: I389fcfe03f5ed41366855d1340f767d89592408c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 666525
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Reviewed-on: https://chromium-review.googlesource.com/688759Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504868}

This reverts commit d1c5cff3.

Reason for revert: <INSERT REASONING HERE>
Causing compile error:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/39878

Original change's description:
> Send ThreatDetails report after user done interacting with modal warning
> 
> Bug: 761114
> Change-Id: I8904520f027a6dba423da4002df5191683e95ae0
> Reviewed-on: https://chromium-review.googlesource.com/683245
> Reviewed-by: Luke Z <lpz@chromium.org>
> Commit-Queue: Jialiu Lin <jialiul@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#504842}

TBR=jialiul@chromium.org,lpz@chromium.org

Change-Id: I74ae33870d0c100c4944a1775ca4f3f0cb8da2fd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 761114
Reviewed-on: https://chromium-review.googlesource.com/688758Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504867}

This reverts commit d1c5cff3.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Send ThreatDetails report after user done interacting with modal warning
> 
> Bug: 761114
> Change-Id: I8904520f027a6dba423da4002df5191683e95ae0
> Reviewed-on: https://chromium-review.googlesource.com/683245
> Reviewed-by: Luke Z <lpz@chromium.org>
> Commit-Queue: Jialiu Lin <jialiul@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#504842}

TBR=jialiul@chromium.org,lpz@chromium.org

Change-Id: I173227275848903f32f1bd25a90a129d27c45d53
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 761114
Reviewed-on: https://chromium-review.googlesource.com/688645Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504866}

Adds in the dimension set, to make sure we run on our bot. Also fixes
the compile target, which might fix Linux Builder not generating the
proper isolate.

NOTRY=true

Bug: 758630
Change-Id: I1f837b1c8854bce0de1bee9c4abd2103aefb661a
Reviewed-on: https://chromium-review.googlesource.com/688217
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#504865}

Apps added via the install banner were being installed with an empty
manifest URL. The correct manifest URL is now passed through to
BookmarkAppHelper::OnDidGetManifest so the share target is recorded
correctly.

Bug: 762388
Change-Id: I705c1f067946d3e7349c0d3be8e06c77b096be72
Reviewed-on: https://chromium-review.googlesource.com/686084Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504864}

This test has been flaky for many cycles:
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29

Disabling it for now is probably the best option.
This CL disables it according to the instruction here:
https://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/handling-a-failing-test

TBR=dgn@chromium.org
NOTRY=true

Bug: 769265
Change-Id: Ieeeeb6e3bd56b5878ce4cc7e687c9f69abc08bdd
Reviewed-on: https://chromium-review.googlesource.com/688582
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504863}

WebContents::GetRenderProcessHost is an API that doesn't behave as
expected with out-of-process iframes, as multiple processes can be
associated with a single WebContents.  This CL removes this API
altogether.

This CL was started by using an ad-hoc clang-plugin that replaced
existing callsites of WebContents::GetRenderProcessHost() with a call to
something like wc->GetMainFrame()->GetProcess().  This was followed-up
by manually adding an include of render_frame_host.h and git cl format
and git cl lint and then a self-review with small tweaks (e.g. sometimes
using a wc->GetRenderViewHost()->GetProcess() is more appropriate).

For the record, below is a list of existing bugs that have been
uncovered or highlighted during the review of this CL:
- https://crbug.com/715924: Headless OOPIF support
- https://crbug.com/767519: Android WebView code duplication
- https://crbug.com/767526: Handling of unresponsive renderers
- https://crbug.com/767539: TabSpecificContentSettings
- https://crbug.com/767557: ExtensionMsg_UpdateTabSpecificPermissions
- https://crbug.com/767563: chrome.processes.getProcessIdForTab
- https://crbug.com/769385: WebViewInternalAddContentScriptsFunction
- https://crbug.com/769461: BrowserTag/WebView owner tracking
- https://crbug.com/769479: PrintPreviewDialogController

Bug: 666525
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Idcb70a8c3928f0631a38a61b7029876fdaf921cb
Tbr: alokp@chromium.org, boliu@chromium.org, derat@chromium.org, dvallet@chromium.org, haraken@chromium.org, lazyboy@chromium.org, lfg@chromium.org, raymes@chromium.org, rdsmith@chromium.org, tapted@chromium.org, tedchoc@chromium.org, thestig@chromium.org, treib@chromium.org
Tbr: asvitkine@chromium.org, bartfab@chromium.org, bengr@chromium.org, benwells@chromium.org, dewittj@chromium.org, dsinclair@chromium.org, jkarlin@chromium.org, jsbell@chromium.org, meacer@chromium.org, mmenke@chromium.org, nparker@chromium.org, sergeyu@chromium.org, sky@chromium.org, stanisc@chromium.org, tommycli@chromium.org, wjmaclean@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/673124Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Stanislav Chiknavaryan <stanisc@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Reviewed-by: David Vallet <dvallet@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504862}

In notification settings, there was no defualt icon for notifier
without favicon. As a result, the notifier texts are not aligend.

Before: http://screen/Dm5RpJ42F98
After: http://screen/0tx8h9G9GPb

TEST=manual
BUG=768736

Change-Id: Id0e1ebc674c39acac63036bee7d1fa91f0817e86
Reviewed-on: https://chromium-review.googlesource.com/686086Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504861}

For PaintRecord backed shaders, the rasterization is done internally in
skia, which means images present in these shaders are not pre-decoded
by compositor's decode cache. This change ensures that we capture these
images during discardable image analysis, and replace them with decoded
images from the compositor's cache.

Replacing of these images requires transforming the PaintRecords in
these shaders to SkPictures with decoded images before executing the op
with the shader.

Bug: 735741, 728359
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ie9314e566eaeb1a393c7490e6309d1315ec3733e
Reviewed-on: https://chromium-review.googlesource.com/673826
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504860}

1. mark images/cross-fade-invalidation.html as flaky
   (based on bot results and https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests%20(with%20patch)&tests=images%2Fcross-fade-invalidation.html)

2. rebaseline paint/invalidation/video-mute-repaint.html and
   video-unmute-repaint.html. Their actual results changed some time ago
   by some non-spv2-related change. This doesn't break the spv2 bot
   because they fail with and without patch, but this makes the bot
   slow especially with the smarming resource problem.

This is landed without CQ to unblock SPv2 bots.

TBR=wangxianzhu@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Icb38531dd35267f10138f89ec2a192d23d185032
Reviewed-on: https://chromium-review.googlesource.com/688644Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504859}

Bug: 756270
Change-Id: I589379ba311844caefecef0b1464808bdc537d1f
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/688819
Commit-Queue: smut <smut@google.com>
Reviewed-by: smut <smut@google.com>
Cr-Commit-Position: refs/heads/master@{#504858}

Prevent the focus to be moved into the system tray, so that user could
use tab key to change focus between buttons.

BUG=b/64535533

Change-Id: Id9bbf89c06fe970db011bb42ee684367bb96e6aa
Reviewed-on: https://chromium-review.googlesource.com/686062
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504857}

Bug: 649017
Change-Id: I7196aeafa9674dfd5e25cb828d4acb464f4c0a2e
Reviewed-on: https://chromium-review.googlesource.com/686043Reviewed-by: Matt Mueller <mattm@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504856}

This CL fixes some bugs in the cert selction logic and adds some
code cleanup:
* Caches 'type_' which can not change.
* Associates connect/save enable with a new isConfigured_ property.

Bug: 380937
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I84c714b0a28eb552ee923feb6db20da2f69a7e2c
Reviewed-on: https://chromium-review.googlesource.com/687877Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504855}

Previously MojoAndroidOverlays could only be created on the GPU main
thread. Now we can create them on any thread, and specifically the media
service thread, so that MediaCodecVideoDecoder can use them.

Also, they now embed an optional ServiceContextRef so that if they're
used from the media service, they can extend the lifetime of the thread
their mojo interface is bound to. This is necessary because they will
be jointly owned by both MCVD and CodecImages. 

Bug: 660942
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I6497b81eeb7205a4893ef6c4de4ee5af571ac90a
Reviewed-on: https://chromium-review.googlesource.com/684005Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Chris Watkins <watk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504854}

Add support for text decoration (underline, overline, and strikethrough)
painting for LayoutNG. Shares most of the line position resolution logic
and paint implementation with legacy layout.

Correctly supports roman underlines while the under (element edge) style
isn't fully supported due to missing baseline and decorating box data.

Edit

Bug: 714962
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ie493469d7846605626c395645017e7214ae5224e
Reviewed-on: https://chromium-review.googlesource.com/686091Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504853}

This reverts commit b123ea27.

Reason for revert: <INSERT REASONING HERE>
Causing build failure here:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/92442

Original change's description:
> applist-focus: Handle arrow key focus traversal
> 
> Changes:
> 1. Enable arrow key focus handling in FocusManager.
> 2. Handle arrow up/down in SearchBoxView to move focus to the first/last
>    focusable element in ContentsView.
> 3. Handle arrow up/down in AppsGridView. AppsGridView has three states:
>    Peeking, Fullscreen all apps (outside folder) and Fullscreen all apps
>    (inside folder). Do separate handling for them, since they have
>    different layout.
> 
> Design Doc: go/applist-focus
> 
> BUG=766810
> TEST=AppListViewFocusTest.*
> 
> Change-Id: I2ace4b3b21a69f10011eba2ed0079e1f7aee48d0
> Reviewed-on: https://chromium-review.googlesource.com/687818
> Commit-Queue: Weidong Guo <weidongg@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#504818}

TBR=xiyuan@chromium.org,weidongg@chromium.org

Change-Id: I571e6f941401c34cc996395d933b1d4478307e27
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 766810
Reviewed-on: https://chromium-review.googlesource.com/688838Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504852}

This reverts commit b123ea27.

Reason for revert:
This CL causes a compile error.
The error log was:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/92442
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2FLinux_ChromiumOS_Builder__dbg_%2F92442%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout

 LINK ./app_list_unittests
(snip)
../../ui/app_list/views/app_list_view_unittest.cc:609: error: undefined reference to 'app_list::AppsContainerView::IsInFolderView() const'
../../ui/app_list/views/app_list_view_unittest.cc:718: error: undefined reference to 'app_list::AppsContainerView::IsInFolderView() const'
../../ui/app_list/views/app_list_view_unittest.cc:777: error: undefined reference to 'app_list::AppsContainerView::IsInFolderView() const'
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Original change's description:
> applist-focus: Handle arrow key focus traversal
> 
> Changes:
> 1. Enable arrow key focus handling in FocusManager.
> 2. Handle arrow up/down in SearchBoxView to move focus to the first/last
>    focusable element in ContentsView.
> 3. Handle arrow up/down in AppsGridView. AppsGridView has three states:
>    Peeking, Fullscreen all apps (outside folder) and Fullscreen all apps
>    (inside folder). Do separate handling for them, since they have
>    different layout.
> 
> Design Doc: go/applist-focus
> 
> BUG=766810
> TEST=AppListViewFocusTest.*
> 
> Change-Id: I2ace4b3b21a69f10011eba2ed0079e1f7aee48d0
> Reviewed-on: https://chromium-review.googlesource.com/687818
> Commit-Queue: Weidong Guo <weidongg@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#504818}

TBR=xiyuan@chromium.org,weidongg@chromium.org

Change-Id: Ic30e4ea6aea5c5c57c145be2aad0dc1d83edc777
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 766810
Reviewed-on: https://chromium-review.googlesource.com/688874Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504851}

This patch connects intervention reports to the ReporingServiceProxy mojo
interface.

Notes on testing: 
1) The test for this patch's new functionality is added to reporting-api.html,
where the mock reporting class there can be reused.
2) This patch also factors out the intervention-generating code to a
function in intervention.js, so it can be used in both reporting-api.html
and intervention.html tests.

Bug: 731810, 564071
Change-Id: I9ea961f6672ece81712c657ee7d9350b0520bb29
Reviewed-on: https://chromium-review.googlesource.com/685992Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Paul Meyer <paulmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504850}

This change adds getters to several classes that make adding
animations easier.

BUG=750381

Change-Id: Id82b8337ef66a614aebe0aaeb7e08eca59bc7beb
Reviewed-on: https://chromium-review.googlesource.com/676263
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504849}

Bug: 767849
Change-Id: Iaa02ed396dd0fde720bebcc276029326b20445a5
Reviewed-on: https://chromium-review.googlesource.com/684098Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504848}

This CL adds metrics to track exceptions and default setting for the
sound content setting.

Bug: 769376
Change-Id: Ic13dbcba4f3d958dadc61ecb64db102c15b845f2
Reviewed-on: https://chromium-review.googlesource.com/688154Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504847}

This CL sets user-select: none; on icon buttons. There doesn't appear to
be a need/reason to do selection of a icon button (when drag selecting
for example). This change is primarily to make the context menu (right-
click menu) show options for a button rather than selected text.

Bug: 769209
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I64013d3f087ff6cd3c33b513acc2c2d340406202
Reviewed-on: https://chromium-review.googlesource.com/688499Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504846}

Temporary hack to avoid OOPIFs for the most visited tiles on the NTP,
until the underlying bugs are fixed to make them work.

BUG=566091
TEST=Most visited tiles work on the NTP in --site-per-process

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I9559f6a98e5cbbbe9ca699fae7b96c71553022c1
Reviewed-on: https://chromium-review.googlesource.com/686067
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504845}

Current Smart Selection workflow:

1) When receiving showSelectionMenu() call in SelectionPopupController,
it asks SmartSelectionClient to do classification and suggestion.
2) A callback onClassified() in SelectionPopupController is called when
received classification/suggestion result.
3) onClassified() will call adjustSelectionByCharacterOffset() if
necessary.
4) When selection range expands, SelectionPopupController will receive
a onSelectionEvent() call, then it triggers selection menu if
SELECTION_HANDLES_MOVED event comes.

This workflow has one flaw since SELECTION_HANDLES_* events are not
very reliable for this use case. Because under certain condition the
original long press caused selection and the later selection expansion
event can be draw at once. In this case, there is only one
SELECTION_HANDLES_SHOWN event without a following
SELECTION_HANDLES_MOVED event will happen.

This CL changed 4), let adjustSelectionByCharacterOffset() triggers
another showSelectionMenu() call and handle the last selection menu
event from that point. It removes the dependency on
SELECTION_HANDLES_* events, therefore resolved the bug.

Bug: 763201
Change-Id: I3688fbb0a31e3794486cc9eab162f4392ab6ff80
Reviewed-on: https://chromium-review.googlesource.com/669881
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Donn Denman <donnd@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504844}

This should minimize disruption when a user is writing/sketching
while accidentally holding down the stylus button.

Bug: 767441
Test: ash_unittests --gtest_filter=PaletteTrayTest*
Change-Id: I155d6c7b0997dd56680aaae8a005fba074a15865
Reviewed-on: https://chromium-review.googlesource.com/688486
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504843}