- 19 Feb, 2020 40 commits
-
-
Xianzhu Wang authored
- Adjust CHECK and DCHECKs - Let LinkHighlightImpl not hold Persistent<Node> - Fix the test added in crrev.com/c/2063770. Change-Id: Icfd99c5d9ebd5f2b09eb0d7ee619014fb80564ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060821Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#742758}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 72b091b4. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ia79c43baf16621a5d6ef8429120dd31da33dba91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064470Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742757}
-
Lei Zhang authored
Consistently expire them in M90. Bug: 1036986 Change-Id: Ic1270ac0228dc5045d1e9222d24a8f6603e58c0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055561Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#742756}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7e63268dc86c..638948939287 git log 7e63268dc86c..638948939287 --date=short --first-parent --format='%ad %ae %s' 2020-02-19 treehugger-gerrit@google.com Merge "Remove inaccurate information from log." 2020-02-19 taylori@google.com Merge "perfetto-ui: Fix stale heap profile viewing option" 2020-02-19 treehugger-gerrit@google.com Merge "cts: add perf profiler e2e tests for apps" Created with: gclient setdep -r src/third_party/perfetto@638948939287 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I818ea3073929ad351a9484d7290796dc89fd0a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064434Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742755}
-
Robert Ogden authored
Checks that the user has allowed pre* actions before prefetching a link. Bug: 1023486 Change-Id: Ie1f6c2315124c3cfcdc13f41ae9cf1d126fa733e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064462Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#742754}
-
Peter Wen authored
Speeds up java compilation. According to go/project-turbo's metrics, updating dagger speeds up compilation from 55.6s to 54.1s (by 1.5s). This speedup comes purely from reduction of annotation processing time previously used by dagger, which is O(seconds), thus it is an impressive feat by the dagger team. Bug: 906803 Change-Id: I792e5cdaf879112c6822dacd3f228ed01460df9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050741 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Conley Owens <cco3@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#742753}
-
Yue Zhang authored
Since fixes http://crrev.com/c/2036874 and http://crrev.com/c/2048988 don't eliminate all crashes caused by recycling detached item in popup tab strip, this CL block the crashing path by disabling the item animation for Duet-TabStrip integration to get rid of the crash. Note that this CL is a band-aid fix in sacrifice of animation. Bug: 1045944 Change-Id: I3301deed92e40f4fe2306d1ef1ff5ceadc3edbc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064453 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#742752}
-
Daniel Clark authored
When accessibility is enabled, the date/time picker popup icon inside of a date/datetime-local/week/month/time control is focusable (this dates back to https://codereview.chromium.org/577553002). However, the refreshed controls were not drawing a focus rect for the icon. With this change we now draw a focus rect. The change moves some of the padding-inline-start for these icons to margin-inline-start so that the focus rect is centered instead of surrounding a bunch of empty space to the left of the icon. This padding difference affects the appearance of the controls in high-contrast mode -- see the images baseline updates with this change -- but I believe these differences are reasonable. I haven't been able to include a test here because PickerIndicatorElement::DidNotifySubtreeInsertionsToDocument() has an early return before applying focusability to the icon when running in a test environment. Fixing this is outside of the scope of this bugfix but I've filed crbug.com/1054048 to follow up. Bug: 1053326 Change-Id: I2e3a2b42398b04187eeddd94d28ffafdd745d260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062679 Commit-Queue: Dan Clark <daniec@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#742751}
-
Clark DuVall authored
This required moving all the strings and icons that are referenced in PermissionRequestImpl as well. kProductIcon which is used for the PROTECTED_MEDIA_IDENTIFIER on ChromeOS was left in //chrome since kProductIcon is different depending on chrome branding. The IDR_* resources used on Android were moved in a way that still works with chrome's ResourceMapper. WebLayer will need a similar system to map the native IDR_* constants to Android drawable resources. Bug: 1025609 Change-Id: I21724ce14a006b89e30f027971165a40fce85177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055888Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#742750}
-
Luke Zielinski authored
Previously we'd ask typ for all "Skip" expectations and then loop over all tests to look up their baselines. In a future CL we'll need to look at other (non-Skip) expectations for all tests as well, and since we're already looping over tests to find baselines we might as well query the expectations at the same time. This also changes the return type of "get_tests_needing_metadata" into a dict (rather than list of pairs), which makes it easier to attach new more statuses to a test as we process more input. This change should functionally be a no-op. Tested: built metadata with and without this change and recursively diffed. Validated that changes make sense. Bug: 937369 Change-Id: I80c68c6326f20c864c4b1c6334116c5d2c0498ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024457 Commit-Queue: Luke Z <lpz@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#742749}
-
Monica Basta authored
This CL contributes to changing the API to get the primary account from the identity manager to be consent-aware. |HasUnconsentedPrimaryAccount| is replaced with |HasPrimaryAccount(ConsentLevel::kNotRequired)| TBR=droger@chromium.org Bug: 1046746 Change-Id: I2bfe2a79e78752a58cf40011db75a8e50fb2aae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064649Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#742748}
-
Michael Crouse authored
This change records any requested/used model feature supported by the client and requested to be used by a prediction model. Bug: 1052435 Change-Id: I16e8e7b9cab39b173bdc0be5e329fb181853d656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057121 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#742747}
-
Maksym Onufriienko authored
Changes in this cl: - added test_apps(Gtest and EGtests) to reduce code duplication ( filling xctest_run files for EG1 and EG2 tests, filtering tests, creating commands to run tests). -Removes shard_xctest method and other EG sharding code from test_runner because shards only use in xcodebuild_runner. - updated *runner.py to support test_apps - replaced `iossim` with `xcodebuild` command. In following cls: 1. iossim parameter will be removed in all test-runners and unittests and then 2. ios/api.py remove iossim. Bug: 1011498 Change-Id: I9966ba1152eabeee56457fa8db3b6e9f585df3c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961166 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#742746}
-
Aga Wronska authored
We were showing paused dialog for every app that was stopped when time limit was reached. This was resulting in bad user experience when Chrome was reaching the limit, because all installed web apps are paused then and user was seeing multiple dialogs (one per every web app). Now we show the dialog only for active app. When web app is active there will be one dialog displayed. When Chrome is active there will be no dialog, but the interstitial page. This should not change anything for ARC++ apps. Bug: 1052040 Change-Id: If4b4827ffb6dd7d022170c6503bf8e109c4bfb94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063219 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#742745}
-
rbpotter authored
Updating the custom margins setting will always result in a corresponding update to the document margins reported from the backend, so adjust header/footer availability based on these margins rather than the custom margins setting value. This prevents unnecessary extra calls to the observer, and fixes a bug where the custom margins setting being initially empty caused the header/footer checkbox to disappear. Bug: 1051810 Change-Id: I851947d3e6b102154910c401ead79aed1666f43e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063869Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#742744}
-
Adrienne Walker authored
The last user is removed via: https://chromium-review.googlesource.com/c/chromium/src/+/2048032 Bug: 1015214 Change-Id: Icb7a3011ba4edfa707d2abd292a1b4b7beda3eb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048503 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#742743}
-
Michael Spang authored
We're not deleting memory objects, and in fact don't even have a binding for the deletion function. Add one and use it. Change-Id: I5354c9a8625e7408fd37362b15bdb4faf051988f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063870Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#742742}
-
Kenneth Russell authored
This reverts commit 315a40c5. Reason for revert: should have been RetryOnFailure on "win nvidia debug" only - will cause regressions to be missed. Original change's description: > gpu: Mark maps pixel test as flaky on Win10 NVIDIA > > TBR=zmo@chromium.org > > Bug: 1053892 > Change-Id: Id0fd2c696d1982101b849490bc899e3393dd84dd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063014 > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Commit-Queue: Sergey Poromov <poromov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742580} TBR=zmo@chromium.org,poromov@chromium.org Change-Id: I05726206aeaa64a6eb6bf66be679bb2d851693f9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1053892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062577Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#742741}
-
Wei-Yin Chen (陳威尹) authored
http://crrev.com/c/2036513 introduced a test dependency. It requires TabAttributeCacheUnitTest to run before TabListMediatorUnitTest, or TabListMediatorUnitTest would fail. This was due to different handling of shared preference in these two tests. TabAttributeCacheUnitTest treats shared preference as a real object, while TabListMediatorUnitTest uses a mocked one. In this CL, the shared preference in TabListMediatorUnitTest is converted to a real object. After this fix, when running in a per-class way as described in https://crbug.com/1032883#c3, there are no failures. Bug: 1032883, 1048255 Change-Id: I73d7bf723b3d039e3b494abb5d5bd0013d710ef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060909Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#742740}
-
Ben Pastene authored
This reverts commit edbc09da. Reason for revert: broke bot_update on internal bots https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3328 Original change's description: > Pull libunwind, libcxx, libcxxabi from a different mirror. > > The current mirror has been stale since LLVM moved to github. > > This checks out the same revisions as previously, so this should > be a no-op. > > Bug: 1048253 > Change-Id: I589991a315c2ea178dc4c2dde834943d1afd9bcd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062879 > Commit-Queue: Nico Weber <thakis@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742720} TBR=thakis@chromium.org,thomasanderson@chromium.org Change-Id: I0db1d8eddbf5531dc547d6375576a5c6b2ac2976 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1048253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064812Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#742739}
-
Yusuf Sengul authored
Bug: 1052627 Change-Id: I85d831091bba67c30cd0a4ceeec9594ea7fc8e59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058788Reviewed-by:
Tien Mai <tienmai@chromium.org> Commit-Queue: Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#742738}
-
Marc Treib authored
When signin cookies are cleared, then related data like the opt-in for using the account-scoped password storage should be cleared too. This CL implements that by adding a function ClearAccountStorageSettingsForAllUsers() and calling it at the appropriate times (i.e. IdentityManager::Observer::OnAccountsCookieDeletedByUserAction). (This is analogous to autofill::prefs::ClearSyncTransportOptIns().) Bug: 1052005 Change-Id: I9a1c628900b8d64573ff0eec206f151a4a128abb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062278 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#742737}
-
Avi Drissman authored
Bug: 1053786, 1054063 Tbr: mattm@chromium.org Change-Id: I5d681515d55737198caaad3e3c183904be260f75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064829Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#742736}
-
Peter Kasting authored
Bug: 1053845 Change-Id: Id8fbf754a28ec542a5958f0ee5846d6699550003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062700Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#742735}
-
Abhijeet Kandalkar authored
This CL implements MediaInternalLogRecordsImpl which works as a receiver of batched media logs sent from renderer process using class BatchingMediaLog::EventHandler. MediaLog messages are grouped together in renderer and then send to browser in bulk in order to reduce IPC pressure. Bug: 1047457 Change-Id: Iadd747a5c17ef0572744ba3c6a4366974ed5785f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051877 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Pete Williamson authored
Bug: 1992269 Change-Id: I6223388011d6d54e428a3f5d0228089751351d79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047497Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#742733}
-
Jonathan Backer authored
Two fixes: (a) Change how we create SkSurface so that we can get a texture ID from it. (b) Map the AHB for readback with ScopedSurfaceToTexture. Change-Id: I16f692b5f1ae8ada0d592944fe74902484f56975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062918 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#742732}
-
Varun Khaneja authored
Bug: 1004470 Change-Id: Iddc66a93a9102b4b514dbb7236846c22ce3d5e76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062718 Auto-Submit: Varun Khaneja <vakh@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#742731}
-
Lan Wei authored
We should try to use Testdriver Action API (an implementation of Webdriver Action API) in all the web platform tests, not gpuBenchmarking any more, because we are using Webdriver Action API on wpt serve to run all the wpt tests. Bug: 1054022 Change-Id: Id70be3776a2935e95de7e0a32e73f65cda009e3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064182Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#742730}
-
Rohit Rao authored
Removes code that is related to the DeviceManagementService and cloud policy. That code will be brought back later, when we are ready to bring up cloud policy support. For now, BrowserPolicyConnectorIOS only supports device-local policies. BUG=1024115 Change-Id: Ia3ace77846a500dd56258649955023baaff78777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063149Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#742729}
-
Chris Lu authored
- self.offTheRecordBadge is the only fullscreen badge, it doesn't have to be added to self.badges in BadgeMediator. - animates the changing of the displayed badge in a spring/zoom in motion. - change color of unread indicator to blue instead of grey. Bug: 1050781 Change-Id: I705baf6d65f04b08cb8e5b446cb7f8f0a580c537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045192 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#742728}
-
Matthew Mourgos authored
This CL adds the initial screen code for the oobe gesture navigation education. The four pages within the new screen are mostly empty and only contain a title, subtitle, and next button. For now, the new gesture screen is hidden behind ShelfConfig::shelf_controls_shown(), which means the flag kHideShelfControlsInTabletMode must be active and tablet mode must be enabled to see the new gesture oobe screen. Bug: 976949 Change-Id: I66c8271b3c865610e7a2de85d7d68a5e4a41302c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043089 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#742727}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/90c9f66cc4cc..38bb9fdf36e8 git log 90c9f66cc4cc..38bb9fdf36e8 --date=short --first-parent --format='%ad %ae %s' 2020-02-19 cwallez@chromium.org Revert "Move sampleAlphaToCoverage out of blendState" Created with: gclient setdep -r src/third_party/angle@38bb9fdf36e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I2a80ee7792b4303b5cb0582fb2e0f53b418b2375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063687Reviewed-by:
-
Nate Fischer authored
This increases the clickable area of the Spinner, so the user can click the word "Default" (or any of the blank space to the right of it), instead of being restricted to clicking the arrow. The issue was the TextView was intercepting touch events. Marking this as non-clickable means the framework will pass touch events to the Spinner (which sits just beneath it), which responds by bringing up the menu of flag states. This also marks the TextView as singleLine, to follow simple_spinner_item.xml. This should be helpful if we ever display longer text, since we don't ever want the Spinner to take up multiple lines. Bug: 1052356 Test: Manual - click "Default" and observe the menu pops up Change-Id: I0a0f090d2c525ac26ded7c1a5a3e35b5e5ac9eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063812 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#742725}
-
Javier Ernesto Flores Robles authored
Add consent screen view controller Bug: 1045453 Change-Id: Ia746f587f1a80ae62c77bfebfe37042917ddef93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063260 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#742724}
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/3651f6c52037..530e1f0dae34 git log 3651f6c52037..530e1f0dae34 --date=short --first-parent --format='%ad %ae %s' 2020-02-19 thakis@chromium.org pnacl driver: add support for non-joined -fdebug-compilation-dir flag Created with: gclient setdep -r src/native_client@530e1f0dae34 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/nacl-autoroll Please CC mseaborn@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: mseaborn@chromium.org Change-Id: Iad526a2fdc82130b5ed950c11ef5211bce0b7bd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064430Reviewed-by:
-
Guohui Deng authored
Unit test BaselinePolicy.SystemEperm in sandbox_linux_unittests fails on internal build infra and it blocks some CLs. Bug: b/148974697 Test: Internal CQ. Change-Id: Ieb8f355910f46a7aae4ab4a42e8d1e7fbf4eb2a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063537 Commit-Queue: Guohui Deng <guohuideng@chromium.org> Commit-Queue: Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#742722}
-
Jarryd authored
Add a new enum histogram, WebsiteSettings.AllSitesActions2, and userActions for the new AllSites UI surface. Bug: 997258 Change-Id: Iec1fdfd80bcd9ee360babb642876836cc3617e5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057444Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#742721}
-
Nico Weber authored
The current mirror has been stale since LLVM moved to github. This checks out the same revisions as previously, so this should be a no-op. Bug: 1048253 Change-Id: I589991a315c2ea178dc4c2dde834943d1afd9bcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062879 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#742720}
-
Roman Sorokin authored
Fixed: 1052911, 1052910 Change-Id: If17c90c77de711794c0c34039f85dcd9488a4a5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062415 Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
-
