- 05 Nov, 2020 40 commits
-
-
Sami Kyostila authored
Roll in a newer revision of Perfetto and update the mojo tracing service to match the new error status added to OnTracingDisabled(). Change-Id: I9e1e679919417f53a88da212a70f05cf4909333a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517941 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#824361}
-
Francois Beaufort authored
This CL makes sure audio and video tracks information are reflected in HTMLMediaElement audioTracks and videoTracks when source is a MediaStream. Platform features" flag enabled. Test: https://glowing-juvenile-bear.glitch.me/ with "Experimental Web Bug: 894556 Change-Id: Iceac66b1f142d5c28eeaaffefd621c095e65ecda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518856Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#824360}
-
My Nguyen authored
These names are shown in both tray menu and settings page. Cleaning up strings description in preparation for names update in http://go/cros-input-methods following http://go/cros-input-methods-naming proposal Part 2 of https://crrev.com/c/2518303 Bug: 889763 Change-Id: I345f3304ce744e0a4f218cb4dde3444595f5035b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517225 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824359}
-
Rune Lillesveen authored
We started to update the background color early for color-scheme canvas background adjustments to avoid white background painting for slowly loading sites with <meta name="color-scheme" ...>[1]. This caused us to paint a white background for other cases where the background color was passed from the renderer before starting to commit frames. This cause flash of white regressions. Make sure we only set the content background color for the color-scheme case by passing an argument to the DidChangeBackgroundColor mojo api. [1] https://crrev.com/d14781f8c3d6218c5f2683cccfd3554b07697d84 Bug: 1141290, 1136423 Change-Id: I843446cafefc656f98d8302f3740a3f9d4e3b191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517730Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Wojciech Dzierżanowski authored
Follow up on https://chromium-review.googlesource.com/c/chromium/src/+/2387643 by adding a browser test in addition to the unit test. Bug: 1139869 Change-Id: I12514d03216e559ec4449105ac78ebb30c4da1e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484793 Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#824357}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f7da52775714..c2b2b5788575 2020-11-04 jaebaek@google.com Add DebugValue for invisible store in single_store_elim (#4002) 2020-11-04 dnovillo@google.com Fix SSA re-writing in the presence of variable pointers. (#4010) 2020-11-04 afdx@google.com spirv-fuzz: Fixes to pass management (#4011) 2020-11-03 afdx@google.com spirv-fuzz: Add support for reining in rogue fuzzer passes (#3987) 2020-11-03 vasniktel@gmail.com spirv-fuzz: Fix assertion failure in FuzzerPassAddCompositeExtract (#3995) 2020-11-03 vasniktel@gmail.com spirv-fuzz: Fix invalid equation facts (#4009) 2020-11-03 vasniktel@gmail.com spirv-fuzz: Fix bugs in TransformationFlattenConditionalBranch (#4006) 2020-11-03 andreperezmaselco.developer@gmail.com spirv-fuzz: Fix bug related to transformation applicability (#3990) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: I2b74240570caa853062f6cad97e48fd86d11d0a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520620Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824356}
-
Yue Li authored
Bug: b/170769672 Test: None Change-Id: I482d2812b1191df2b5a35a7c57024dadc3f87a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487561 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#824355}
-
Francois Beaufort authored
This CL aims to check which Picture-in-Picture browser tests are still flaky. Note that after 4 runs of the CQ, none failed. It's likely that the source of the failure was fixed when Picture-in-Picture logic was moved to the PictureInPictureWindowControllerImpl. Bug: 1001538, 1002489, 1070810, 1058087 Change-Id: Iac75b3731b4785aacff0fbaf102593a27f922970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475058Reviewed-by:
-
Simon Zünd authored
Moving the TrustTokenBrowsertest class into a header will allow DevTools to re-use the functionality in its own browser tests for upcoming Trust Token debugging features. The CL https://crrev.com/c/2516225 is an example where DevTools and TrustToken browsertests are combined. R=davidvc@chromium.org Bug: chromium:1141652 Change-Id: Ibd9d9a75738d17d9eb1cc33359063ad4bd99b860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517947 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#824353}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1604534391-5a78416253c14f884fd91b82681793eb4590bf60.profdata to chrome-linux-master-1604555639-418519ab0f0a3d63001d91c3a146cb7504055699.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If9311b4db38d355a8ce5140f5f44693cbf0c50e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520619Reviewed-by:
-
Patrick Brosset authored
This adds the code necessary to highlight flex containers on hover in DevTools. For now, only the container's content box can be highlighted. Frontend CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2488661/ Bug: 1139949 Change-Id: I8268227095bec552f45cc93d4240b555c3ad2534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487065 Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#824351}
-
Clemens Backes authored
This is an optimization to increase efficiency of libfuzzer (by avoiding inputs which are unlikely to be valid JS). It's OK if other fuzzing engines still pass non-ascii input. R=mmoroz@chromium.org CC=ahaas@chromium.org Bug: chromium:1142437 Change-Id: If4560b7a8c04a044835464462893caf8549f0615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518857Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#824350}
-
Tony Herre authored
Bug: 982501 Change-Id: I23695fe917996160af4fb4ab79c1ee20de82f023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487080 Commit-Queue: Tony Price <toprice@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Dominic Farolino authored
Before this CL, we called AgentSchedulingGroupHost::SetUpMojoIfNeeded() from various getters; this was necessary because we initialized our mojo connections to the renderer-side AgentSchedulingGroup lazily on-demand. However this was somewhat tedious and contributed to confusion around when it is safe/appropriate to use interfaces. For example, in the code review [1] it was mentioned that: > Specifically here, if we proceeded to bind the interfaces and calling > CreateASG on a "dead" Renderer interface, the call would never be > resolved, nor would the disconnect handler be called, resulting in an > unrecoverable state. The above is technically true, but the situation will not happen because the RenderProcessHostImpl's renderer interface is immediately reset and reinitialized after the renderer process crashes. So using the RenderProcessHostImpl's renderer interface when IsInitializedAndNotDead() == false does not lead to the situation above, since the interface is reinitialized after the crash, but before the new process is spun up (which may not actually happen). This CL makes this more explicit. One way to achieve this would be to loosen checks around IsInitializedAndNotDead() to instead verify that the renderer interface is bound, which is what https://crrev.com/c/2465542 aims at. However this CL more generally makes the bind lifetimes of the AgentSchedulingGroupHost's mojos match those of the RenderProcessHostImpl's IPC::ChannelProxy and renderer interface by: - Invoking SetUpMojoIfNeeded() in the AgentSchedulingGroupHost's constructor. We do this because at this point the RenderProcessHostImpl's channel and interfaces are already bound and set-up, so upon construction we follow suit. - Inside AgentSchedulingGroupHost::ResetMojo(), invoking: - RenderProcessHostImpl::EnableSendQueue() - SetUpMojoIfNeeded() This further matches the flow of RenderProcessHostImpl, which both resets and reinitializes the AgentSchedulingGroupHost mojos at the same time that RenderProcessHostImpl does the same. Consequently, this CL also: - Renames AgentSchedulingGroupHost::InitProcessAndMojos() => Init(), because it simply defers to RenderProcessHostImpl::Init() now. This is because at this point, the the RenderProcessHostImpl's IPC::ChannelProxy has been initialized, and therefore so have our mojo connections. - Changes AgentSchedulingGroupHost::GetChannel() to truly be only a getter, and not conditionally invoke SetUpMojoIfNeeded(), since the flow of RenderProcessHostImpl and therefore AgentSchedulingGroupHost should take care of that. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/2397057/14..31/content/browser/renderer_host/agent_scheduling_group_host.cc#281 Bug: 1132901 Change-Id: I05b57908ad470ee7c51109e65951889d6db9df25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490442 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#824348}
-
Scott Violet authored
We have the same code a few lines down. BUG=none TEST=none Change-Id: Icb461d0257fed152b3ec01596afd875b25fa92e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519939 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#824347}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1604534391-78c794948f9915d6943b9f032cad3893f5df2156.profdata to chrome-win64-master-1604545021-6b268e7944932acdec58448c2452d297c1502b9f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ifea7029290e2cae57719714e79ec464fae98595a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520452Reviewed-by:
-
Friedrich [CET] authored
This reverts commit 5c7c88d7. Reason for revert: Most-likely suspect for CrOS compile failure: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/42591 Log: [5898/61571] ACTION //ui/file_manager/file_manager/test:create_test_main(//build/toolchain/linux:clang_x64) FAILED: gen/ui/file_manager/file_manager/test.html /b/s/w/ir/cipd_bin_packages/cpython/bin/python ../../ui/file_manager/file_manager/test/scripts/create_test_main.py --output=gen/ui/file_manager/file_manager/test.html Traceback (most recent call last): File "../../ui/file_manager/file_manager/test/scripts/create_test_main.py", line 144, in <module> write(GEN + R_GEN + colors, open(GEN + '../../' + colors).read()) IOError: [Errno 2] No such file or directory: '/b/s/w/ir/cache/builder/src/out/Release/gen/ui/file_manager/file_manager/../../chromeos/colors/cros_colors.generated.css' Original change's description: > Nearby Share: Consolidate and autogenerate grd files > > Bug: 1132403 > Change-Id: I809b1a97e43457b92ac67fde208b200bfbf37d58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507400 > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: dpapad <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824322} TBR=avi@chromium.org,dpapad@chromium.org,rbpotter@chromium.org Change-Id: I275146470b9fc70dbff9203ee8f951eda7e624d8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1132403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517734Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#824345}
-
Yoshifumi Inoue authored
This patch Introduces |CachedTextInputInfo| class to cache text content and text offsets of selection and IME composition to avoid redundant calculation of them for improving responsiveness. Background: Browser process calls |InputMethodController::TextInputInfo()| for every frame (16ms) and |GetSelectionOffsets()| for every selection changes. Without caching |TextInputInfo|, these functions do text serializing root editable element or document body for every time even if layout tree isn't changed. Note: |testRunner| doesn't call |GetSelectionOffsets()| because it is called in |RenderFrameImpl::SyncSelectionIfRequired()| and |testRunner| doesn't use it. Note: Speed of |TextInputInfo()| doesn't appeared in performance test, because it is called in |WidgetBase::WillBeginMainFrame()|. So repeated call of |selection.modify()| in JavaScript doesn't call it. Bug: 875155, 892513 Change-Id: Ib7de3849fd94af88db743806e6f8b1624cd944bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505348 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#824344}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1604534391-0b66c67528d135f745546f739dea18f4b7b0777d.profdata to chrome-mac-master-1604555639-6427f288759af11a05c7facb538fa5f1c7c3ab83.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4fd0accfae2715b13c231773ade3f22ecf70ae64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520305Reviewed-by:
-
Kent Tamura authored
This CL converts DEFINE_LAYOUT_OBJECT_TYPE_CASTS() to DowncastTraits<> for: - LayoutCustomScrollbarPart - LayoutEmbeddedContent - LayoutEmbeddedObject - LayoutHTMLCanvas - LayoutImage - LayoutReplaced This CL has no behavior changes. Bug: 891908 Change-Id: I88c9317b2ea55e682b657c32016d0cd89eda8dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519683 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Alessio Bazzica authored
The new histogram is used to keep track of how frequently APM runtime settings cannot be successfully enqueued. Used in https://webrtc-review.googlesource.com/c/src/+/190144 Bug: webrtc:9138 Change-Id: Ib2e67e2287f3e9d642db9712ddd829a14c2bd7ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495180Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Ale Bzk <alessiob@chromium.org> Cr-Commit-Position: refs/heads/master@{#824341}
-
Sigurd Schneider authored
DevTools CL: https://crrev.com/c/2123048 Bug: chromium:945786 Change-Id: I16c63ba8ebc23a70ae42cc31c5a33da247a7aa9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518059Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#824340}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2876f93d9628..d631a67cc8c7 2020-11-05 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1b62c6d11ec212a1e5a14dd310119b6ddeb98040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520522Reviewed-by:
-
Alex Rudenko authored
This CL fixes the memory usage regression (crbug/1144454) by creating the instances for unsupported_image_mime_types only when DevTools is enabled and some image types are disabled. Measurement: memory:chrome:all_processes:reported_by_chrome:blink_gc:effective_size Pinpoint job: https://pinpoint-dot-chromeperf.appspot.com/job/13be0a31520000 Fixed: 1144454 Bug: 1130556 Change-Id: Iac9472238ca3e05c393c0b6fbd62596e5148a5b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515403Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#824338}
-
Yuki Shiino authored
As a first step of IDL union implementation, implements mostly- empty code generation of IDL union bindings. Bug: 839389 Change-Id: Ia15933cfa57cd8e2f6cc5e93870ba18316dbbc3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512329Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#824337}
-
Anne Lim authored
This will prevent running into the DCHECK for empty accountId in ConvertToJavaCoreAccountId. Bug: 1135847 Change-Id: Ibaca940288f54963bc582deee5b9eb88e2122c37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518159Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#824336}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/906501df4f0c..8cdba3e3fae3 2020-11-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 6372a56f3a15 to 1e494cae8d48 (7 revisions) 2020-11-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from db8766bb239b to 6564890116fd (6 revisions) 2020-11-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 1f9589cf to e1d559cf (402 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bsalomon@google.com Test: Test: Test: dEQP-GLES31.functional.copy_image.* Change-Id: Ib7a558ad9f0522a7f15da178222e856818fcecf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520303Reviewed-by:
-
Chris Hall authored
We are aiming for feature launch in M89. Change-Id: I592d5f4fadb095c38870d46dfcf48d3206b8c4c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515803Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#824334}
-
Nidhi Jaju authored
In an effort to change the blink implementation of readable streams to better match the Web IDL descriptions in the Streams API Standard, this CL adds the ReadableStreamGerReaderOptions dictionary [1] to the ReadableStream class. This allows us to remove GetReaderValidateOptions() as well, which makes the code simpler. [1] https://streams.spec.whatwg.org/#dictdef-readablestreamgetreaderoptions Bug: 1093862 Change-Id: I6539e6da1434c2258832e3000b2015818849a0e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517214 Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
This reverts commit 94863f6a. Reason for revert: https://crrev.com/c/2518615 fixed the previous issue. Original change's description: > Revert "[DEPS] update luci-go" > > This reverts commit 1585878b. > > Reason for revert: > https://crbug.com/1144638 > https://crbug.com/webrtc/12126 > > Original change's description: > > [DEPS] update luci-go > > > > Bug: 1142713 > > Change-Id: Id330d0c9a0e225e5fbf8ae12abeb6b8d55f46262 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507246 > > Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com> > > Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com> > > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#822547} > > TBR=yyanagisawa@google.com,tikuta@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1142713, 1144638, webrtc:12126 > Change-Id: Ie06d7c40065630f28ac44fe6f2dac82f91e64da1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517405 > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823859} TBR=yyanagisawa@google.com,tikuta@chromium.org,mbonadei@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1142713 Bug: 1144638 Bug: webrtc:12126 Change-Id: I3cdb4d01a5d603b95d03b93b8dd43d81a84f7a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519179 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#824332}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I6a60bc208a04bbcf596c6c50d6480e91302dc6d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520405Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |NGCaretPosition::ToPositionInDOMTreeWithAffinity()| to avoid crash regarding null |NGOffsetMapping|. Note: This is speculative change because we don't have reproducible test case yet. Bug: 1145514 Change-Id: I8935175d721e6cc678efcb1f8c52d33275197143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519544 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Avi Drissman authored
New macOS capabilities, more utilities in Chromium. Bug: 1145672, 1145792, 1142017 Change-Id: Ibd10501429aba40aacb4db7c751385428115941d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518258 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#824329}
-
Mikel Astiz authored
These new metrics can be derived from existing metrics but simplify the analysis, in line with the general guidance by the metrics team. Change-Id: Ic0f1c59a590dbb9be43b5ee45f37a808b352cca9 Bug: 1068378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517681Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
-
Alexey Baskakov authored
This CL introduces no behavior changes. WebAppProvider class must not depend on extensions, only forward declarations are visible. All extensions-specific code and includes have been isolated in chrome/browser/web_applications/extensions/bookmark_app_provider.cc file. In long term, the whole chrome/browser/web_applications/extensions/ code directory must be deleted (see README.md in that folder) This is a preparation CL to delete web_applications_on_extensions GN source set. TBR=ccameron@chromium.org Bug: 1065748 Change-Id: I7fa1306694e80dbda8aab7159a075919ec2c42b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517233Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#824327}
-
Alexey Baskakov authored
This CL introduces no behavior changes. chrome/browser/web_applications/web_app_migration_user_display_mode_clean_up.h must not depend on extensions, only forward declarations are visible. This is a preparation CL to remove web_applications_on_extensions GN node. WebAppProvider will be moved from web_applications_on_extensions to general web_applications GN node. Bug: 1065748 Change-Id: I4a67398ad7db8107010d4b7cd165657fe1e64ba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517190Reviewed-by:
-
Shik Chen authored
Bug: b:172346047 Test: Pass Closure Compiler checks. Change-Id: I79ee47ee084149f4168978307af3c75cbade29f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515868 Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#824325}
-
Xiaocheng Hu authored
Bug: 1145406 Change-Id: I2bcc50fe3c6799586643750e7c655be0cac979dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519860 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#824324}
-
Darren Shen authored
FinishComposingText saves the old selection in order to reapply it after the composition is finished. However, it needs to also maintain the direction (the order of base vs. extent), or else a backward selection will be restored as a forward selection after calling FinishComposingText. Bug: 1145727, b/172284191 Change-Id: Ie1e8ef69fcabcb11aebbbc5003e044f70e6535d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518309 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#824323}
-
rbpotter authored
Bug: 1132403 Change-Id: I809b1a97e43457b92ac67fde208b200bfbf37d58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507400 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#824322}
-
![Friedrich [CET]'s avatar](https://secure.gravatar.com/avatar/f27b033ce4cd5371e6e413eed6db870f?s=80&d=identicon "Friedrich [CET]")
