- 02 Feb, 2018 40 commits
-
-
Sergey Ulanov authored
Updated the script to use list comprehension, which is supported on all versions of python above 2.0 TBR=wez@chromium.org Change-Id: I8f7ffad323c40a51e77374c8baba40ebbf463061 Reviewed-on: https://chromium-review.googlesource.com/900132Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#534170}
-
Mike Dougherty authored
Remove exposed plugin API since all logic is now contained to a single file and it runs immediately upon injection. The unittests are now obsolete because no API is exposed. However, all previous unittest scenarios are covered by the PluginPlaceholderTestCase EarlGrey tests. Bug: 802344 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2f31af1fe9fa4f94f678064fe2a8cc316b837757 Reviewed-on: https://chromium-review.googlesource.com/899914 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#534169}
-
Joone Hur authored
First, we need to enable Intel driver by building Mesa 17.0.2 with --with-egl-platform=surfaceless --with-dri-drivers=i965 BUG=733450 TEST=ozone_demo $ cd ~/git/chromium/src $ gn gen out/Release "--args=use_ozone=true ozone_platform_gbm=true use_intel_minigbm=true" $ ninja -C out/Release ozone_demo $ export EGL_PLATFORM=surfaceless $ out/Release/ozone_demo Change-Id: Ic560b2b4f36701f3c159fd35e771d04c2e1ec97e Reviewed-on: https://chromium-review.googlesource.com/886836Reviewed-by:
Stéphane Marchesin <marcheu@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Joone Hur <joone.hur@intel.com> Cr-Commit-Position: refs/heads/master@{#534168}
-
Jacob Dufault authored
Bug: 808486 Change-Id: If818ae74618847671f6f0ed2ecddb2ed804fa429 Reviewed-on: https://chromium-review.googlesource.com/900131Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#534167}
-
https://chromium.googlesource.com/catapult.git/+log/d7e6289f3f76..ec32a8f0bee7 $ git log d7e6289f3..ec32a8f0b --date=short --no-merges --format='%ad %ae %s' 2018-02-02 eakuefner [TBMv2] Add missing import in breakdown_tree_helpers Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ibc55ee155417c819c277e2623c62b0abae8196c1 Reviewed-on: https://chromium-review.googlesource.com/899919 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534166}
-
Daniel Cheng authored
Since there are no sequencing guarantees when evaluating function arguments, it's possible that context could be dereferenced after the state has already been consumed by the move constructor. Bug: 805881 Change-Id: Ia23c0dc593a08d024392918dcb6988f6e07dd68d Reviewed-on: https://chromium-review.googlesource.com/900045 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#534165}
-
https://webrtc.googlesource.com/src.git/+log/1d0b9d04bd87..cc7125f2400b $ git log 1d0b9d04b..cc7125f24 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I30c799a50895f447dd19a39963600f462259354b Reviewed-on: https://chromium-review.googlesource.com/900061Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534164}
-
Danyao Wang authored
This is a reland of 091e44cb. It fixes the regression in WebUITestCase/testChromeURLBackAndForwardAndReloadNavigation. WebUI needs special handling in reload because calling [WKWebView -reload] simply reloads WKWebView.URL (which is an app-specific URL in this case) and results in a provisional load failure. The other suspected test failure (ContextMenuJsTest.LinkOfTextWithCalloutNone) is not caused by the original CL. It seems to be flaky. It failed again after the revert: https://luci-milo.appspot.com/buildbot/internal.bling.main/iphone11-device-x64/2532 and it failed before the original CL was checked in: https://luci-milo.appspot.com/buildbot/internal.bling.main/iphone11-device-x64/2504 Original change's description: > [Nav Experiment] Fix form repost detection in WKBasedNavigationManager. > > This CL moves form repost detection for WKBasedNavigationManager to > in |webView:decidePolicyForNavigationAction|, where WKWebView gives a > clear signal about form reposting (WKNavigationTypeFormResubmitted). > This allows simplifying reload for WKBasedNavigationManager to directly > delegating to [WKWebView reload]. > > FormsTestCase now pass with WKBasedNavigationManager. > > Bug: 807428,705020 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: Ia35978c42b21405a3749d1764a0485cde9c805d2 > Reviewed-on: https://chromium-review.googlesource.com/894892 > Commit-Queue: Danyao Wang <danyao@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533692}t Bug: 807428 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If0bb1c907472ec402931c69f347c9259907c4f28 Reviewed-on: https://chromium-review.googlesource.com/899916Reviewed-by:
-
Ian Vollick authored
Should have had a break; it got missed. Bug: 177475 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I517d26a99ad55823b946a76865fa86c4a93ab3ca Reviewed-on: https://chromium-review.googlesource.com/899585Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#534162}
-
agrieve authored
This reverts commit bc25fa08. Reason for revert: Bot is running out of memory (see bug) Original change's description: > Increases link_pool from 3 to 8 for static and minimal_symbols android builder > > This is mainly for proguard steps which make build slow due to restricted parallelism on android_n5x_swarming_rel builder. > Example build traces from slow builds: > https://chromium-build-stats.appspot.com/ninja_log/2018/01/31/slave954-c4/ninja_log.slave954-c4.chrome-bot.20180131-023634.24049.gz/trace.html from https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/351638 > https://chromium-build-stats.appspot.com/ninja_log/2018/01/31/slave617-c4/ninja_log.slave617-c4.chrome-bot.20180131-021253.3583.gz/trace.html from https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/351634 > https://chromium-build-stats.appspot.com/ninja_log/2018/01/31/slave980-c4/ninja_log.slave980-c4.chrome-bot.20180131-021148.4142.gz/trace.html from https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/351629 > > I investigate peak memory usage of some large/long time targets with args.gn of android_n5x_swarming_rel. > |--------------------------------------------------------+-------------| > | target | peak memory | > |--------------------------------------------------------+-------------| > | chrome_public_apk.proguard.jar | 843076 KB | > | chrome_public_test_apk__apk.proguard.jar | 995208 KB | > | chrome/android/monochrome_public_apk/classes.dex | 1178664 KB | > | lib.unstripped/lib_unit_tests__library.so | 3181252 KB | > | android_clang_arm/lib.unstripped/libmonochrome.so | 2718856 KB | > | android_clang_arm/lib.unstripped/libwebviewchromium.so | 2362328 KB | > |--------------------------------------------------------+-------------| > > So 4GB is sufficient. > I tested the builder by modifing base_export.h to run linker for many targets in https://chromium-review.googlesource.com/c/894928/4 > > Bug: 804251 > Change-Id: Ic5f985dba29d063a7541553813561f85c9dd3278 > Reviewed-on: https://chromium-review.googlesource.com/894928 > Commit-Queue: Takuto Ikuta <tikuta@google.com> > Reviewed-by: agrieve <agrieve@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533547} TBR=dpranke@chromium.org,agrieve@chromium.org,tikuta@google.com,jbudorick@chromium.org NOTRY=true # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 804251, 808582 Change-Id: Iceb52c1bb4e506d9d7fa2eebfd8bdd6f67fa2722 Reviewed-on: https://chromium-review.googlesource.com/900063 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#534161}
-
Kevin McNee authored
We were substituting GFS events with GSE events when bubbling scroll from an OOPIF. This was done to prevent an OOPIF based guest from consuming a fling that is intended for bubbling (see crbug.com/770852). It seems that this can lead to an invalid input event stream. Fortunately, the main concern in that bug was with GestureScrollUpdates. The fling was a minor issue. The filtering of GSU events is still valid, so we only remove the GFS substitution. Bug: 770852, 806940, 802085 Change-Id: I647471ea4ff94396ef6e6af21fb89e1841a0eaf7 Reviewed-on: https://chromium-review.googlesource.com/899878Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#534160}
-
Nico Weber authored
This Just Works after https://chromium-review.googlesource.com/897393 Bug: 177475 Change-Id: I5769827692dfc4f864db403b3e525c9afb00436b Reviewed-on: https://chromium-review.googlesource.com/899114Reviewed-by:
Stephen Lanham <slan@chromium.org> Cr-Commit-Position: refs/heads/master@{#534159}
-
Morten Stenshorne authored
Instead of unconditionally clamping at 500 columns, try to identify legitimate use cases for many columns, and allow those. At the same time, limit (what we consider to be) illegitimate reasons even more brutally. Bug: 808189 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Icf70d655c2da0b4a1af7e256cf7f3ef8c72f8715 Reviewed-on: https://chromium-review.googlesource.com/898438 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#534158}
-
Robert Kaplow authored
This reverts commit 477b5b9f. Reason for revert: Flaky on Mac10.9 Tests Original change's description: > Test group policy for UKM. > > Refactored the pref-setting logic out of metrics_reporting_state_browsertest in a way it could be reused in UKM. Setup a parametrized UKM test which tests the enabled/disabled group policy state based on prefs and verified service is enabled/disabled. > > Bug: 805983 > Change-Id: Ic303e4116826990e7780125f186b0028a8fd6a5e > Reviewed-on: https://chromium-review.googlesource.com/895390 > Commit-Queue: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#534086} TBR=sky@chromium.org,rkaplow@chromium.org,holte@chromium.org Change-Id: I95baa0b136424e1ca0bbc740479157024ca91a0a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 805983 Reviewed-on: https://chromium-review.googlesource.com/900163Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#534157}
-
Amirhossein Simjour authored
The size is fixed to follow the design BUG=808560 Change-Id: If63ebbd676d62acd4cbc46081551d73835ced49c Reviewed-on: https://chromium-review.googlesource.com/900055Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#534156}
-
Michael Thiessen authored
Bug: 740731 Change-Id: I7183ebf13db7a317947c3c0aa5b40080258dd60a Reviewed-on: https://chromium-review.googlesource.com/899782Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#534155}
-
Stephen McGruer authored
No test is added because this is a DHCECK_IS_ON only method. Bug: 808047 Change-Id: I615a07aec4223dd4c029f6e59dc864ffc7a0f739 Reviewed-on: https://chromium-review.googlesource.com/897053Reviewed-by:
-
Alexander Alekseev authored
Bug: 805078 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib9f558e1154744b99d9ce750a165ade07a5bafb3 Reviewed-on: https://chromium-review.googlesource.com/900022Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#534153}
-
xlai authored
TBR=junov@chromium.org Bug: 807636, 807427 Change-Id: Ic5fe5abbf5deaed883c005280fd8418cf49ca9d2 Reviewed-on: https://chromium-review.googlesource.com/899962 Commit-Queue: Olivia Lai <xlai@chromium.org> Reviewed-by:
Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#534152}
-
Marco authored
https://chromium.googlesource.com/webm/libvpx.git/+log/efa786d4649c..ac54d233b6d7 $ git log efa786d46..ac54d233b --date=short --no-merges --format='%ad %ae %s' 2018-01-25 jianj Fix issue for 0 target bitrate in multi-res build. 2018-01-31 jzern vp9_scale_test: parameterize filter type 2018-01-31 marpan vp9-svc: Add condition on allocation for scaled_temp. 2018-01-31 marpan vp9-svc: Fix to initialize downsampling filters. 2018-01-15 paulwilkins Further change to code detecting slide transitions. Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com BUG=805863 Change-Id: Ieafbf459fa3230edf26ea742b7cc85fdfc88be11 Reviewed-on: https://chromium-review.googlesource.com/899605 Commit-Queue: Marco Paniconi <marpan@google.com> Reviewed-by:
Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#534151}
-
Wenzhao Zang authored
The implementation of ShowUserWallpaper has been fully moved to //ash. TBR=alemate@chromium.org, oshima@chromium.org Bug: 779221 Test: ash_unittests, manual Change-Id: I3c8de532228669baf56e336ad91c467407cfd9e5 Reviewed-on: https://chromium-review.googlesource.com/848311 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#534150}
-
Sigurdur Asgeirsson authored
Bug: 799526 Change-Id: Ie61ff4ada2c1ed57949414c0c400ea93481a68c5 Reviewed-on: https://chromium-review.googlesource.com/897904 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/11a430a2..69113b91 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I6151a0588fe29b407c53a7b7e214cc497f72f9df Reviewed-on: https://chromium-review.googlesource.com/899725Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#534148}
-
Danyao Wang authored
This reverts commit 295cd31f. Reason for revert: This change broke WindowOpenByDOMTestCase/testWindowOpenWithAboutNewTabScript. See https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.fyi%2Fios-simulator%2F14465%2F%2B%2Frecipes%2Fsteps%2Fios_chrome_web_egtests__iPhone_6s_iOS_11.2_%2F0%2Flogs%2FWindowOpenByDOMTestCase__x2f_testWindowOpenWithAboutNewTabScript%2F0 Original change's description: > [Nav Experiment] Update NavigationItem URL for location.replace. > > location.replace changes the URL of WKBackForwardListItem. Update the > URL of NavigationItem to that of the host WKBackForwardListItem upon > access. It's done this way because location.replace cannot be reliably > distinguished from normal navigations in either WKNavigationDelegate > callback or URL KVO. > > This fixes NavigationTestCase/testWindowLocationReplaceAndChangeHash. > > Bug: 807428 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: Iaef4ed5efd788283050b43a3b4e988311ec9cf76 > Reviewed-on: https://chromium-review.googlesource.com/894490 > Commit-Queue: Danyao Wang <danyao@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533315} TBR=eugenebut@chromium.org,danyao@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 807428 Change-Id: I21c346af34d87a28d0104104b03eed941df409a6 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/898002 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#534147}
-
Justin Carlson authored
This change does two things. First, it splits out the implementation of ServiceDiscoveryDeviceLister from the interface, which will allow users of the API to mock/fake it for testing. Second, it adds a service_type parameter to ServiceDiscoveryDeviceLister::Delegate::OnDeviceCacheFlushed. This allows users of the class that want to manage multiple service types with a single Delegate to disambiguate which service is being flushed. The other Delegate functions already pass in the service description so don't need any additional information for this use. Also fixup callsites for all users of this API. Bug: 808157 Change-Id: I9cf4b23692f54c66e0224e06df1769f750f846b3 Reviewed-on: https://chromium-review.googlesource.com/898184 Commit-Queue: Justin Carlson <justincarlson@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Gene Gutnik <gene@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#534146}
-
Varun Khaneja authored
No change from the original CL. The CL did not need to be reverted since the problem was with CL https://crrev.com/c/872219 only. Original CL: https://crrev.com/c/855044 Revert CL: https://crrev.com/c/895399 Reason for revert: Windows build failures (crbug/807391) TBR=jschuh,nparker Bug: 750327 Change-Id: I6f596ecfc28f21d8e6a75ed69915b58943d026b5 Reviewed-on: https://chromium-review.googlesource.com/900002Reviewed-by:
Justin Schuh <jschuh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#534145}
-
David Valleau authored
The construction of the printer's display name already contains the model, so displaying it again was redundant. R=hcarmona@chromium.org, xdai@chromium.org Bug: 793340 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8ce04994f762b23d44dd2d30a31c4f2f90afbbf5 Reviewed-on: https://chromium-review.googlesource.com/896364Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: David Valleau <valleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#534144}
-
Jonathan Metzman authored
On Mac builds, it looks like calling WriteNum on a size_t was causing the compiler to select the templated version of WriteNum rather than the uint64_t version. Hopefully it won't do the opposite (and break on calls to WriteNum(uint64_t) because of this fix. Bug: 808155, 769578 Change-Id: I8babcf6da5090b9bffdbcc98b573c11c02f2e489 Reviewed-on: https://chromium-review.googlesource.com/899906 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Cr-Commit-Position: refs/heads/master@{#534143}
-
Xi Cheng authored
Change-Id: Ie9dc6c639b3bd8c2ff028d71f3c77d4a15895b55 Reviewed-on: https://chromium-review.googlesource.com/898498 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#534142}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1f067b88df42..5d5f22ce9d6f $ git log 1f067b88d..5d5f22ce9 --date=short --no-merges --format='%ad %ae %s' 2018-02-02 agable Remove prompts to contact maruel Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Id63069f840a78f521256a52b49d683885ea2d98a Reviewed-on: https://chromium-review.googlesource.com/899870Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534141}
-
https://webrtc.googlesource.com/src.git/+log/72724535584f..1d0b9d04bd87 $ git log 727245355..1d0b9d04b --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I976a25b29de81b35a01d43b6c43f84159d40b095 Reviewed-on: https://chromium-review.googlesource.com/899911 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Mikel Astiz authored
The list of proto fields was not updated in recent changes to the proto. Change-Id: I7017c2a83a08c610e8a3644e77f6a0779c28e238 Reviewed-on: https://chromium-review.googlesource.com/899085Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#534139}
-
Ahmed Fakhry authored
Minor CL to add a skeleton for Touchable-specific colors as well as adding the non-client frame colors. BUG=805267 Change-Id: Ia1b3a344223c3d2e0b7c7b0bf0a5d2e851221558 Reviewed-on: https://chromium-review.googlesource.com/898489 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#534138}
-
Sidney San Martín authored
Updating self.image (on an NSButton subclass) in -layout or -viewWillDraw both seem to lead to an infinite loop in 10.11. I'm not sure if there's a better way to fix this; using different triggers to update the image seems safest. Bug: 805109 Change-Id: I468576069f44eae4a2f4b9058e078d88d157265a Reviewed-on: https://chromium-review.googlesource.com/899586Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#534137}
-
Tim Dresser authored
Reports the First Input Delay. PageLoad.InteractiveTiming.FirstInputDelay Observes: - MouseDown - KeyDown, RawKeyDown - PointerDown (when followed by PointerUp) - Cancelable TouchStart - GestureTap Bug: 803935 Test: WebViewTest.FirstEventQueueingTimeReported, CorePageLoadMetricsObserverTest.FirstEventQueueingTime Change-Id: I7fb9ba157d85dd097080db3f64db617aea17f090 Reviewed-on: https://chromium-review.googlesource.com/876728Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#534136}
-
Adam Langley authored
Bug: 793985 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I19f4c1e2cff81b41a919449b926616d5e0f9d813 Reviewed-on: https://chromium-review.googlesource.com/899674Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#534135}
-
erikchen authored
Remove some unneeded code. Change-Id: I47a8535189da8ebbe67853e3bae6f0cfb8cf11e6 Reviewed-on: https://chromium-review.googlesource.com/897898Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#534134}
-
Sergey Ulanov authored
Now layout tests runner copies fonts from the host to the target machine. This is the same approach that is used for Android. It will allow to reuse layout tests expectations from Linux/Android. Bug: 778467 Change-Id: Id878966c435476b8fb22441441108a74c9e40f1b Reviewed-on: https://chromium-review.googlesource.com/887745 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Brian Salomon <bsalomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#534133}
-
Danyao Wang authored
This is a partial reland of 091e44cb. It splits out only the matcher change in EarlGrey tests. The suspected test failure (ContextMenuJsTest.LinkOfTextWithCalloutNone) is not caused by the original CL. It seems to be flaky. It failed again after the revert: https://luci-milo.appspot.com/buildbot/internal.bling.main/iphone11-device-x64/2532 and it failed before the CL was checked in: https://luci-milo.appspot.com/buildbot/internal.bling.main/iphone11-device-x64/2504 Original change's description: > [Nav Experiment] Fix form repost detection in WKBasedNavigationManager. > > This CL moves form repost detection for WKBasedNavigationManager to > in |webView:decidePolicyForNavigationAction|, where WKWebView gives a > clear signal about form reposting (WKNavigationTypeFormResubmitted). > This allows simplifying reload for WKBasedNavigationManager to directly > delegating to [WKWebView reload]. > > FormsTestCase now pass with WKBasedNavigationManager. > > Bug: 807428,705020 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: Ia35978c42b21405a3749d1764a0485cde9c805d2 > Reviewed-on: https://chromium-review.googlesource.com/894892 > Commit-Queue: Danyao Wang <danyao@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533692} Bug: 705020 Change-Id: I0c5b5f893bc64eaa61538c7a75a78799ac422993 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/898263Reviewed-by:
-
Zhiheng Vincent Li authored
Fragment is detached from the activity when user says "OKG, set a timer for 1 minute", or use swipe from edge to "close" the player. When it is attached back to activity by clicking on home view's tile, onCreateView() and onStart() will be called again, but cast views and CastWebContentsSurfaceHelper already attached with current WebContents should be reused. Change-Id: Ibc6dc3a31cd0ff3fc31e16c879537db43185b2f4 Bug: b/72838507 Test: 1. Say "OKG, play a video" and see cast fragment shown; 2. Say "OKG, set a timer for 1 minute" and dismiss the timer page, see cast fragment recovered correctly and video could be resume; 3. Check log output and see 2nd call of onCreateView() and onStart() won't recreate new fragment view and reset webconent. TODO(vincentli): Add a test case to cover CastWebContentsFragment's lifecycle Change-Id: Ibc6dc3a31cd0ff3fc31e16c879537db43185b2f4 Reviewed-on: https://chromium-review.googlesource.com/898602 Commit-Queue: Zhiheng(Vincent) Li <vincentli@google.com> Reviewed-by:
-
