- 14 Aug, 2018 40 commits
-
-
Avi Drissman authored
BUG=873080 TEST=as in bug Change-Id: Icd75715ac42789c84870967b11c9917a972ae086 Reviewed-on: https://chromium-review.googlesource.com/1173342 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#582970}
-
Victor Costan authored
Some AppCache unit tests incorrectly use GURL() to get an URL with a unique origin (different from other origins in the test). The way this works may change in the future, so tests should use real origins instead. This CL also cleans up some lifecycle issues in the files touched by the change. Bug: 768460 Change-Id: Iaff5228f599209f3803c0374abcd53720e9906a9 Reviewed-on: https://chromium-review.googlesource.com/1174103Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#582969}
-
Erik Luo authored
Console Commands and Results no longer show a repeat count bubble. It was possible to get consecutive Commands using expressions starting with 'await', which collapsed when they should not. Screenshot: https://imgur.com/a/8iOkL9p Bug: 871940 Change-Id: I1dc2306d13c1511daa92fcd678520f3e8706e853 Reviewed-on: https://chromium-review.googlesource.com/1173265Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#582968}
-
Tessa Nijssen authored
If there are no suggestions, the touch bar will show an empty NSCandidateListTouchBarItem. Instead of showing that, the browser window touch bar should appear if there are no suggestions. TextSuggestionsTouchBarControllerTest.MakeTouchBar was modified to test that a text suggestions touch bar is not created if there are no suggestions. Bug: 717553 Change-Id: I2eb3286e5a96b97bb8d7737ddf6db352698804b8 Reviewed-on: https://chromium-review.googlesource.com/1173407Reviewed-by:
Sarah Chan <spqchan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Tessa Nijssen <tnijssen@google.com> Cr-Commit-Position: refs/heads/master@{#582967}
-
Sam McNally authored
BrowserPluginGuest disables navigate_on_drag_drop for all browser plugin guests. For mime handlers navigating on default drag drops is desirable. After the mime handler is attached, update the web preferences to re-enable navigate_on_drag_drop so unhandled drag drops onto mime handlers result in navigations similar to other web content. Bug: 819761 Change-Id: I5b0165be1d8c52538b189194fc9cbca9c86d96a7 Reviewed-on: https://chromium-review.googlesource.com/1173944 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#582966}
-
Robert Liao authored
Developers should include bubble_dialog_delegate_view.h instead. This is part 3 of 3 for aligning BubbleDialogDelegateView with its filename. BUG=873422 Change-Id: Ifd33203baf4d057c476026394d2833d0701e25e3 Reviewed-on: https://chromium-review.googlesource.com/1171919 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#582965}
-
Peter Beverloo authored
Change-Id: Ia20886e1d26800e084ee63ef7604c7083e3479f1 Reviewed-on: https://chromium-review.googlesource.com/1170840Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#582964}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d4322a8630bc..32c7d4dfcdca git log d4322a8630bc..32c7d4dfcdca --date=short --no-merges --format='%ad %ae %s' 2018-08-14 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 378c434627aa..80ab360d2622 (1 commits) 2018-08-14 mtklein@google.com add dstAT param to xform steps Created with: gclient setdep -r src/third_party/skia@32c7d4dfcdca The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: I368e81da43b77ddaf306cd452ef1ab5ed2035a8d Reviewed-on: https://chromium-review.googlesource.com/1174791Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582963}
-
Asanka Herath authored
Bug: none Change-Id: Ie9e3a47ec63d493c34e844ad0d99b97dcb8c3a7b Reviewed-on: https://chromium-review.googlesource.com/1169830 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#582962}
-
erikchen authored
The sources for validation_test_data was being listed as a directory rather than a list of files. This is incorrect -- directories cannot be listed as sources for the copy command in GN. This in turn caused isolate.py to think that the file .../data/validation was a dependency, which then caused isolate.py to throw an error since .../data/validation is a directory, not a file. This CL explicitly lists all file dependencies. Bug: 873208 Change-Id: I02ee6b28016bf36a612cd44079080274fcbf3744 Reviewed-on: https://chromium-review.googlesource.com/1171111Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#582961}
-
Ryan Daum authored
- Discards events produced by additional fingers during a cast side swipe gesture. - Rework unit tests to use GMock, and add test for the multiple fingers. Bug: internal b/112314035 Test: on device and unit tests Change-Id: I8c8c33299521e3e05ec9d196d835e0f0c5f04563 Reviewed-on: https://chromium-review.googlesource.com/1174566Reviewed-by:Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#582960}
-
Chris Lu authored
Bug: 856621 Change-Id: I8bae0dff5d006338a682becb8e4fdb331bc81f77 Reviewed-on: https://chromium-review.googlesource.com/1169627 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#582959}
-
Hajime Hoshi authored
Now a widget is created after a (sub)frame and per-frame task runner can be passed. However a widget is destroyed not before a frame, which is inconsistent. We want to make it consistent by making a widget before a frame, and in this case, per-frame task runner would no longer be available. This CL makes RenderView always use a thread-local task runner instead. This CL introduces 'cleanup' task runner for cleaning up. We aim to V8 executions on the default task runner and other thread-local task runners, but V8 execution is inevitable on the cleanup phase. Then this CL separates such tasks on the new task runner. Change-Id: I5513e005796f9589eb269c526c2e6ae2b79c8dfd Reviewed-on: https://chromium-review.googlesource.com/1164873Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#582958}
-
Michael Lippautz authored
Tests were using WeakPersistent<T> from stack directly. This does not work anymore as soon as unified garbage collections also traverse the stack to find wrappers. Bug: chromium:843903 Change-Id: I1f93d631c7a6e0798903111416507e9fabd90f16 Reviewed-on: https://chromium-review.googlesource.com/1174538 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
Bug: 778306 Change-Id: Ic4b1df90df4c3ab7402b58019401a65d61c1abaa Reviewed-on: https://chromium-review.googlesource.com/1174097Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#582956}
-
Fredrik Söderquist authored
Adjust casing for 'desc', 'switch' and 'mpath'. Remove a duplicate 'animateColor'. BUG=868861 Change-Id: I19256547abea3028791de402e354c47eee8ce949 Reviewed-on: https://chromium-review.googlesource.com/1174261 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#582955}
-
Rayan Kanso authored
In order to support permissions for Background Fetch, the RenderFrameHost should be made available. The binding is done from RenderFrameHostImpl now, with RendererInterfaceBinders left as a fallback (to register from service worker contexts for example). Bug: 692647 Change-Id: I3e12b60f410ba104601c68392a07fe24da1cc220 Reviewed-on: https://chromium-review.googlesource.com/1172785Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
-
Ian Vollick authored
There were a number of circular and incorrect dependencies between targets in this directory. With this change, I've largely fixed the issues by moving things to vr_base. I did, however, move ButtonState from UiInputManager to PlatformController. I've also removed vr_base_export.h, which turned out to be unnecessary. Bug: 871811 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7ee1d5c410c4098c6284dba8a3f565e6b460f34a Reviewed-on: https://chromium-review.googlesource.com/1171667Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Aldo Culquicondor <acondor@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#582953}
-
Fernando Serboncini authored
TBR=kbr@chromium.org Bug: 872102 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ieea7f9d1947975333ce2f2b174f947da44202c3d Reviewed-on: https://chromium-review.googlesource.com/1174693 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#582952}
-
Hans Wennborg authored
And configure libc++ to force inline ABI-hidden functions, as was its behaviour before r338122. Without this, the symbol tables of Mach-O binaries grow significantly due to including multiple definitions of these functions. Bug: 866225, 870907, 872926 Change-Id: I4382e9de57fc79b3baff3d329e338887cb4b133b Reviewed-on: https://chromium-review.googlesource.com/1174546 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#582951}
-
Clark DuVall authored
Followup to http://crrev.com/c/1157549 Bug: 868545 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ib1ab6a824beb147d4aab717aaaf878daf7439b4b Reviewed-on: https://chromium-review.googlesource.com/1171548Reviewed-by:
-
Victor Costan authored
BlobReader is thread-unsafe, so an instance must always be used in the same sequence. Change-Id: Ibce3b2f1ad25b4c2a4cc04a5e4cb248a52e3a9bc Reviewed-on: https://chromium-review.googlesource.com/1174015Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#582949}
-
Luum Habtemariam authored
Move motivated by IppValidator chrome service that needs it. Bug: chromium:831913 Test: base_unitttests pass and manual printing succeeds Change-Id: Ia333819b30b2ea5953d1e219be799e89105e29cb Reviewed-on: https://chromium-review.googlesource.com/1164538Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#582948}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c6163d95. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22711 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: msisov@igalia.com: external/wpt/webvtt tdresser@chromium.org: external/wpt/navigation-timing NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I6e64b4a5d4566e6663cd2a9647702d32cbe05f40 Reviewed-on: https://chromium-review.googlesource.com/1174694 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#582947}
-
Gayane Petrosyan authored
These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: I7d7e2967caa586a221b50a64b5769c281777e4df Reviewed-on: https://chromium-review.googlesource.com/1126324Reviewed-by:Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#582946}
-
W. James MacLean authored
This no longer needs to be a CHECK and is being seen sufficiently often that we should really convert it to a DCHECK. Bug: 873945 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia014c9d1721ae6dbba71fe01d00d35412ee58701 Reviewed-on: https://chromium-review.googlesource.com/1174702Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#582945}
-
Annie Sullivan authored
It's passing in perf tryjobs. Bug: 787001 Change-Id: Ie9a74b141d6dd610a1bfab3d9d9ea79b40dafc48 TBR: tdresser@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1174632Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#582944}
-
Becky Zhou authored
Bug: 872852 Change-Id: I4fd3952a493d5d840beaeb64e4ae1b94fe2918dd Reviewed-on: https://chromium-review.googlesource.com/1170089Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#582943}
-
John Delaney authored
Creates an invariant that all received bytes will eventually be seen through TransferSizeUpdates. Makes testing more reliable. This will also prevent data from not being recorded due to hung/ unresponsize url requests. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I8bb80f8e94a245018434878f66e638028368113e Reviewed-on: https://chromium-review.googlesource.com/1169834 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#582942}
-
Lukasz Anforowicz authored
This CL deletes the GetRenderProcessHostId helper function, which return the pid of a renderer process, but would only work if there is exactly a single renderer process present (making it problematic under Site Isolation where multiple renderers might be present, including the spare renderer). The CL replaces GetRenderProcessHostId with directly getting the pid of the main frame's renderer. Bug: 873780 Change-Id: Ic26ff3ffaca5045e5e5e5ad2f701dfff7cdb90be Reviewed-on: https://chromium-review.googlesource.com/1173351Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#582941}
-
Stephan Stross authored
There is an issue in generate_perf_report.py which caused all of the results generated by the script to be null in the output jsons. This CL fixes that issue. Change-Id: I74b8f826c2f7ea2b65b9b457379f9ea81a1d268a Reviewed-on: https://chromium-review.googlesource.com/1173445 Commit-Queue: Stephan Stross <stephanstross@google.com> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#582940}
-
Moe Ahmadi authored
Don't return cards from Google account as part of basic-card. https://blog.chromium.org/2018/07/bringing-google-pay-to-paymentrequest.html Bug: 869457 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If6129689aad77c33d5bc8cff1e819cbacc386778 Reviewed-on: https://chromium-review.googlesource.com/1165316 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#582939}
-
Ben Kelly authored
Cache API performance is visible to the user via page load times when service workers are in use. In addition, this value is consistent with the TaskPriority used by other storage APIs. R=jsbell@chromium.org Bug: 873771 Change-Id: I831ad645ad8adc92618f5565789103abd162ca98 Reviewed-on: https://chromium-review.googlesource.com/1174652Reviewed-by:
-
Xi Cheng authored
This completes the task to remove the current memory-inefficient execution profile representation by StackSamplingProfiler::CallStackProfile. This change also leads to the following structural changes: 1) The intermediate representation of a call stack profile -- StackSamplingProfiler::CallStackProfile is retired. 2) Module/Frame/Sample structs are moved from the StackSamplingProfiler class to the CallStackProfileBuilder class as now they are only used by the latter one. 3) Methods in call_stack_profile_proto_encoder.h are moved to stack_sampling_profiler.cc as now they are only used there. Bug: 851163, 804942 Change-Id: Ief07693499a2eb9af216d0ec71b9daf38645ecba Reviewed-on: https://chromium-review.googlesource.com/1171866Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#582937}
-
Moe Ahmadi authored
Deprecates kAutofillEnabled in favor of finer grained kAutofillProfileEnabled and kAutofillCreditCardEnabled Keeps kAutofillEnabled around to maintain backward compatibility for the extensions and the policy APIs. If kAutofillEnabled is set by an extension, values of kAutofillProfileEnabled and kAutofillCreditCardEnabled are also set. Similarly, if kAutofillEnabled is disabled by policy, the two fine-grained prefs are also disabled. Chrome extension for testing the chrome.privacy.services API: https://github.com/mhahmadi/autofill-pref-api-test-extension TBR=michaelbai@ Bug: 870328, 860526 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8e6ca4594aa73c3d9228734948353f6a686227ad Reviewed-on: https://chromium-review.googlesource.com/1166211 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#582936}
-
Christos Froussios authored
* PasswordManager.LinuxBackendMigration.Adoption Whether the client has been migrated. * PasswordManager.LinuxBackendMigration.TimeIntoEncrypted The time it took to read everything from Keyring/KWallet and write to LoginDB. * PasswordManager.LinuxBackendMigration.TimeIntoNative This measures the time it takes to merge LoginDB into Keyring/KWallet. Bug: 571003 Change-Id: I8ef2050bd9ffd9995eb515c8457f4fc5e19a70df Reviewed-on: https://chromium-review.googlesource.com/1163705Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#582935}
-
Katie D authored
This is not the same as the fancy animated focus indicator in the general chrome://settings pages but it is better than having no visual vocus indicator at all. Bug: 831397 Change-Id: I84844afb2e8227a247a93ba32451c82f9b1f943e Reviewed-on: https://chromium-review.googlesource.com/1173402Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#582934}
-
Patricia Hongo authored
If child user has never enabled arc, and then graduates, supervision transition pref is set to CHILD_TO_REGULAR, causing Play Store to be blocked. If user never enabled arc, no transition is necessary. Bug: 871550 Change-Id: I1ec4dcf66c2d336aab60004a27642e5e854032e6 Reviewed-on: https://chromium-review.googlesource.com/1169633 Commit-Queue: Patricia Hongo <phongo@google.com> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#582933}
-
Chris Lu authored
If no metadata label is set, alignment property of horizontal stack view should be fill so that the vertical stackview can fill entire vertical space. If URLlabel has no text, then it should be hidden so that the title label can be centered within the vertical stackview. Screenshots: https://drive.google.com/file/d/1rOS-DUahkcpX-Lk-iGB6IsYO8DZdKwiF/view?usp=sharing https://drive.google.com/file/d/12Sl-CL00bCdi2atkM4HKl7XFWSAxNBNP/view?usp=sharing Bug: 856620 Change-Id: I84b932600487fa17cc3aa2b55accbfc5d71d8eca Reviewed-on: https://chromium-review.googlesource.com/1167745 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
-
Donn Denman authored
Adds support for two new Contextual Search Resolve request parameters: ctxsl_pid and ctxsl_per, used to pass previous event information to the server. BUG=872902 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I68305ea75cea1dff650f4c050b0f478b56eafb82 Reviewed-on: https://chromium-review.googlesource.com/1170345Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
-
