GitLab

We want to be able to recognize tap events that the page has not handled and provide some useful default behavior for those events.  Currently taps are considered handled in many cases when they really have not been handled by the page or default behavior.  This CL is a beginning at correcting this.  We plan to also check if the tap interacted with an element with an ARIA role that indicates it was interactive.

BUG=355154

Review URL: https://codereview.chromium.org/267313008

git-svn-id: svn://svn.chromium.org/blink/trunk@175514 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=380054

Review URL: https://codereview.chromium.org/314783004

git-svn-id: svn://svn.chromium.org/blink/trunk@175513 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reason for revert:
This change breaks:
org.chromium.android_webview.test.AwSettingsTest#testBlockNetworkImagesDoesNotBlockDataUrlImage

Probably because it pre-loads images when "automatically load images" is disabled on Android.

See
http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/159696/steps/androidwebview_instrumentation_tests/logs/stdio

Original issue's description:
> Always preload all tokens before parsing
> 
> This change is in preparation for re-writing the path
> through which tokens are handled on the main thread
> to allow them to be batched and deferred until more
> important work is done:
> https://codereview.chromium.org/258013009/
> 
> Currently the threaded parser uses the main thread's
> MessageQueue as its work-queue and we'll commonly
> queue 10 chunks of work in the main thread MessageQueue
> even if the first chunk takes a long time we'll still have to
> process the next 9 before we can do more important things
> like put up a frame because we don't have a separate
> queue for parser work.  258013009 will fix that.
> 
> http/tests/security/script-crossorigin-loads-correctly-credentials-2.html
> originally started failing with this change and it
> turns out that always-preloading found a real bug
> in CORS handling with preloads. The ResourceFetcher
> was incorrectly always reusing an in-flight preload
> request, even if the CORS state didn't match. Nate
> helped me re-order the calls in requestResource to fix it.
> 
> This change also discovered 2 other bugs in the preloader.
> 1. a preload request != LinkPrefect request
> and one will cancel the other. crbug.com/379893
> 2. The preloader has no concept of script type and will
> blindly issue preloads for all <script href> regardless
> of <script type>.  I decided this didn't matter in practice.
> Making the <script type> handling threadsafe isn't
> worth the trouble.
> 
> I would anticipate that this change might make some
> speed-index scores better (we'll now be preloading
> all tokens slightly sooner, especially those
> which are in the same chunk as a long inline
> script block for instance), but may make non-network
> PLT scores lower (due to extra mallocs required
> to process every chunk since more loads will
> be preloaded just before their actually loaded).
> 
> BUG=356292
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175427

TBR=tonyg@chromium.org,japhet@chromium.org,eseidel@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=356292

Review URL: https://codereview.chromium.org/317703005

git-svn-id: svn://svn.chromium.org/blink/trunk@175512 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=380588
TBR=ojan

Review URL: https://codereview.chromium.org/319503004

git-svn-id: svn://svn.chromium.org/blink/trunk@175510 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Change fast/text/decorations-transformed.html to use the Ahem font
instead of ahem as test-only side-loaded fonts are case sensetive on
Windows. Also fix similar issue in line-break-after-question-mark
test.

BUG=378610
R=dglazkov@chromium.org

Review URL: https://codereview.chromium.org/316933003

git-svn-id: svn://svn.chromium.org/blink/trunk@175509 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=350571

Review URL: https://codereview.chromium.org/298093004

git-svn-id: svn://svn.chromium.org/blink/trunk@175508 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Following flakiness resulting from race conditions, I'm splitting the image-currentsrc
test into 3 separate layout tests.

BUG=380664

Review URL: https://codereview.chromium.org/317723003

git-svn-id: svn://svn.chromium.org/blink/trunk@175507 bbb929c8-8fbe-4397-9dbb-9b2b20218538

patch 3 of 4 to specify the deviceSource of a desired fling animation
request via enum throughout Blink and Chromium.

BUG=343327

Review URL: https://codereview.chromium.org/304823002

git-svn-id: svn://svn.chromium.org/blink/trunk@175506 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now that frames always have a layer and get their self-painting
bit updated whenever m_compositing changes, we don't need to
do a layer update when they get composited. Instead we just
need to mark the frame in the owner page as needing a compositing
update.

This removes one of the needs for applyUpdateLayerCompositingStateChickenEggHacks.

BUG=379097

Review URL: https://codereview.chromium.org/302093002

git-svn-id: svn://svn.chromium.org/blink/trunk@175505 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now function ensureTextFinder is used to create TextFinder object if it doesn't exists.

BUG=359983

Review URL: https://codereview.chromium.org/229043004

git-svn-id: svn://svn.chromium.org/blink/trunk@175504 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This should duplicate the devtools resources, with the exception of the "debug" build of devtools.

R=apavlov@chromium.org, jamesr@chromium.org

Review URL: https://codereview.chromium.org/302093008

git-svn-id: svn://svn.chromium.org/blink/trunk@175501 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The change to no longer pixel snap for ellipsis (r175434) fixed two ref
tests failures on Win7 with DirectWrite. Remove the failing expectation
for those tests accordingly.

TBR=leviw@chromium.org
BUG=378489

Review URL: https://codereview.chromium.org/311153002

git-svn-id: svn://svn.chromium.org/blink/trunk@175500 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This matches Firefox's behavior.

Review URL: https://codereview.chromium.org/302283002

git-svn-id: svn://svn.chromium.org/blink/trunk@175498 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=340522

Review URL: https://codereview.chromium.org/319453002

git-svn-id: svn://svn.chromium.org/blink/trunk@175497 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The "root" translation layer was previously below the overlap controls
host layer. This meant it was actually below the pinch viewport's scale
layer. We really want the root translation layer to be at the root so that
DevTools' screen emulation feature can scale and offset the entire tree.

BUG=370035

Review URL: https://codereview.chromium.org/308183002

git-svn-id: svn://svn.chromium.org/blink/trunk@175496 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=dglazkov@chromium.org
BUG=378610

Review URL: https://codereview.chromium.org/313903002

git-svn-id: svn://svn.chromium.org/blink/trunk@175494 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The test crashes because the createFlingAnimationCurve call hits the int version in Platform.h which is no longer matching the signature in content/test/test_webkit_platform_support.h (and content/child/blink_platform_impl.h). Instead it hits the default one in Platform.h which just returns 0.
Subsequently the WebActiveGestureAnimation calls through the null pointer in WebActiveGestureAnimation::animate.

TBR=rjkroege@chromium.org, jam@chromium.org, ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=

Review URL: https://codereview.chromium.org/310413002

git-svn-id: svn://svn.chromium.org/blink/trunk@175493 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL refactors the FrameView methods to be paintInvalidation instead
of repaint.

I have left the repaint rect output to be 'repaint' for now as that
seems like a large and scary rebaseline when it lands.

I also did not change the slowRepaints methods as they were previously
mentioned as not having to do with paint invalidation.

BUG=338691

Review URL: https://codereview.chromium.org/306413002

git-svn-id: svn://svn.chromium.org/blink/trunk@175492 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It helps to troubleshoot messages traffic between DevTools and the inspected page.

BUG=

Review URL: https://codereview.chromium.org/316813003

git-svn-id: svn://svn.chromium.org/blink/trunk@175491 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=vollick@chromium.org

Review URL: https://codereview.chromium.org/313023002

git-svn-id: svn://svn.chromium.org/blink/trunk@175490 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When we run sanitizers like ASAN and LSAN, we typically don't care about whether the tests run exactly like they do normally; we are just looking for errors that the sanitizers have detected.

This flag changes run-webkit-tests to ignore text and image failures and just look for crashes and timeouts (most crashes will be sanitizer-triggered).

In theory most of the time the tests *should* run the same way, but in practice we see a lot of noise that no one has the time to deal with, so this change should reduce a lot of the redness we see on the bots.

BUG=336971, 374043

Review URL: https://codereview.chromium.org/294973008

git-svn-id: svn://svn.chromium.org/blink/trunk@175488 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts commit r174963.
Reason for revert: the patch regressed ::content selectors for distributed
nodes in shadow DOM.

BUG=380414,356999
TBR=vsevik
NOTRY=true

Review URL: https://codereview.chromium.org/311123002

git-svn-id: svn://svn.chromium.org/blink/trunk@175487 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The specification for ready is here:
https://github.com/slightlyoff/ServiceWorker/issues/223

ready is a convenience that lets the page talk to an installed
ServiceWorker, without having to track the details of whether that
Service Worker is controlling the page, or merely installed but
waiting for the page to reload.

This implements the trivial ready case, where the page is
controlled by a Service Worker and ready can produce that one
immediately.

BUG=363967

Review URL: https://codereview.chromium.org/309233002

git-svn-id: svn://svn.chromium.org/blink/trunk@175486 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove the specialized code for tracking wheel events in favor of the
generic EventHandlerRegistry. Covered by existing tests.

See https://codereview.chromium.org/206603002/ for full review history.

BUG=359566,332793
TEST=fast/events/wheelevent-handler-count.html

Review URL: https://codereview.chromium.org/225823007

git-svn-id: svn://svn.chromium.org/blink/trunk@175485 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none

Review URL: https://codereview.chromium.org/318653003

git-svn-id: svn://svn.chromium.org/blink/trunk@175484 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The test is still very flaky on Windows, and somewhat flaky on other
platforms.

TBR=jchaffraix@chromium.org, yoav@yoav.ws
BUG=380664

Review URL: https://codereview.chromium.org/311133002

git-svn-id: svn://svn.chromium.org/blink/trunk@175483 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=361045
R=caseq@chromium.org

Review URL: https://codereview.chromium.org/311113002

git-svn-id: svn://svn.chromium.org/blink/trunk@175482 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We used to rely on timeline record to timeline category mapping, which is not
entirely correct, since the set of trace events is slightly different. Let's fork
the style map for the time being.

BUG=361045

Review URL: https://codereview.chromium.org/316553005

git-svn-id: svn://svn.chromium.org/blink/trunk@175481 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Allow sub-css-pixel font-sizes and thus smooth font scaling which in
turn allows for stable layout when zooming and drastically improves
readability and font rendering quality on high dpi devices.

This change enabled the experimental subpixel font scaling flag by
default across all supported platforms.

Entry in Chromium Dashboard
  http://www.chromestatus.com/features/6259163214643200

OWP launch tracking bug
  https://code.google.com/p/chromium/issues/detail?id=164167

Intent to ship
  https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/4-f2i7OEWeg

Originally landed as r175192 but reverted as r175308 due to chromeos
test failures.

R=eseidel@chromium.org, dglazkov@chromium.org
BUG=164167

Review URL: https://codereview.chromium.org/315623002

git-svn-id: svn://svn.chromium.org/blink/trunk@175480 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a follow-up fix after r175430.
We don't need to use a PersistentHeapVector on a stack.

BUG=340522

Review URL: https://codereview.chromium.org/316823003

git-svn-id: svn://svn.chromium.org/blink/trunk@175479 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The possible reason of crash seems to be renderer value being null.

R=tkent@chromium.org
BUG=356128

Review URL: https://codereview.chromium.org/318633002

git-svn-id: svn://svn.chromium.org/blink/trunk@175478 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Avoid calling is8Bit() for every character in SelectorChecker's
containsHTMLSpace() by doing the check once at the beginning and then call a
templated containsHTMLSpaceTemplate() for the corresponding character type that
will iterate over the raw string array.

String::operator[] is not ideal here because:
- It checks if the String's StringImpl is non-null
- It does array bound checking
- It calls is8Bit() to access the right raw string array

The new implementation avoids doing these checks for every character in the
string being checked.

I see a 2.5% progression on cssquery-jquery's div[class~=dialog] subtest
(7152.80 -> 7331.60 +/- 0.5%):
http://dromaeo.com/?id=222400,222406

R=esprehn@chromium.org, eseidel@chromium.org

Review URL: https://codereview.chromium.org/307333004

git-svn-id: svn://svn.chromium.org/blink/trunk@175477 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Stop having HTMLNameCollection override HTMLCollection::virtualItemAfter(). It
is not really needed as the same DOM tree traversal code. Instead, we simply
create 2 subclasses called DocumentNameCollection and WindowNameCollection that
define an elementMatches() method that is called from HTMLCollection, similarly
to other HTMLCollection subclasses.

This avoids having a virtual function call, brings support for efficient
backward traversal of these collections and leverages optimizations in
HTMLCollection.

This CL is inspired from WebKit r149652 from rniwa@webkit.org:
http://trac.webkit.org/changeset/149652

R=esprehn@chromium.org, adamk@chromium.org

Review URL: https://codereview.chromium.org/315473002

git-svn-id: svn://svn.chromium.org/blink/trunk@175476 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The MIME type of the JavaScript file in this test has changed. It's the
only failing test on this, so I'm disabling it until Eric can take a look.

TBR=jchaffraix@chromium.org, eseidel@chromium.org
BUG=380649

Review URL: https://codereview.chromium.org/316903002

git-svn-id: svn://svn.chromium.org/blink/trunk@175475 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357163

Review URL: https://codereview.chromium.org/313023004

git-svn-id: svn://svn.chromium.org/blink/trunk@175474 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch makes it possible to shift-drag resize widgets on responsive
design page to slow down their movement.

BUG=380190

Review URL: https://codereview.chromium.org/312813002

git-svn-id: svn://svn.chromium.org/blink/trunk@175473 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Using BlinkPlatform hides the WebView that requested the lock, making it
very hard to have a clever handling of screen lock on the browser side
given that it's unknown whom and when requested the lock.

It will also allow locking the appropriate screen in a multi-screen
scenario.

BUG=162827

Review URL: https://codereview.chromium.org/315693002

git-svn-id: svn://svn.chromium.org/blink/trunk@175472 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If we skip framework with StepInto after a stepping button was hit in front-end,
we should eventually stop somewhere in the user code. On the other hand, in case of
an Event breakpoint we should not stop at all, if the callback is handled inside the framework.

BUG=267592
R=yurys, pfeldman@chromium.org

Review URL: https://codereview.chromium.org/309013005

git-svn-id: svn://svn.chromium.org/blink/trunk@175471 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Made hoverNode()/setHoveNode() private accessors while converting over
remaining PassRefPtr<Node>/RefPtr<Node> uses to transition types.

R=tkent@chromium.org
BUG=357163

Review URL: https://codereview.chromium.org/311053003

git-svn-id: svn://svn.chromium.org/blink/trunk@175470 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Adds idl files and tests.

Initial patch (1) by tommyw@ from https://codereview.chromium.org/145583015/

BUG=338511

Review URL: https://codereview.chromium.org/286673003

git-svn-id: svn://svn.chromium.org/blink/trunk@175469 bbb929c8-8fbe-4397-9dbb-9b2b20218538