- 07 May, 2020 40 commits
-
-
Mugdha Lakhani authored
We're currently setting the click listener twice which is causing the fist click to do nothing, except set the click listener again. This CL fixes that bug. Bug: 1052375 Change-Id: I7b796fab4b0d08696f141dc195e1dc1be7d95e9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187791Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#766392}
-
Jan Wilken Dörrie authored
This change annotates PasswordForm.ManagerFill.Assistance so that it gets recorded in the UKM History table and is exposed in the UKM dashboard. Bug: 918846 Change-Id: Ibea41e8b1e4725f05490d5ed53719136c436a402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185112Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#766391}
-
Arthur Hemery authored
This patch addresses some inconsistencies with the way speculative RFH and COOP interact. Currently: - We never switch for a speculative RFH, and don't have any COOP value. - Anything that never has a network COOP never triggers a swap. This is awkward because implementing the process model relies on having homogeneous COOP for pages within an isolated BrowsingInstance. If we base the process model on what we currently have, we end up with all the speculative and non-network pages being put in a potentially crossOriginIsolated privileged process. After this patch: - (Almost) all speculative and non-network pages are computing if they need a COOP swap. - We exclude "about:blank" from the computation, because the current test_runner infrastructure hangs with a process swap on the cleanup page. - We inherit the "same-origin" value of the current page. This is required because during a crash, an optimization forces the speculative RFH to be committed instantly. At reload time, we can stay in the same BrowsingInstance. - We currently inherit same-origin-allow-popups only when we are not just opening a popup. This is otherwise incompatible from the way we store "if we swapped" on the NavigationRequest. In the scenario where a page "a.com" with same-origin-allow-popups opens a popup to "b.com" with no coop, the inherit would cause a swap (that is remembered in the NavigationRequest) when there ends up being none. This "memory" mechanism is necessary for redirects and also used by name clearing. Change-Id: I1b9116c66e19c8f5c2ccda2f9c42e4085e8f0bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162751 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#766390}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e3d1de7c5281..2871ab0727bf git log e3d1de7c5281..2871ab0727bf --date=short --first-parent --format='%ad %ae %s' 2020-05-07 fmalita@chromium.org [skottie-wasm] Add support for nested animation playback Created with: gclient setdep -r src/third_party/skia@2871ab0727bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bsalomon@google.com Change-Id: Ief2d325ca9d3ac917bb8aae4beea372b60d15d90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187529Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#766389}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Iec0195d6953f8c9123fb319d816c2b07f6c3abda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186995Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#766388}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/08afdde7726c..cd09f8e96a3a git log 08afdde7726c..cd09f8e96a3a --date=short --first-parent --format='%ad %ae %s' 2020-05-07 capn@google.com Produce MSVC error when virtual class misses virtual destructor Created with: gclient setdep -r src/third_party/swiftshader@cd09f8e96a3a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I583a76a2d95bbfdb7a7cce7ff9545fa2867a06bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187524Reviewed-by:
-
Johannes Kron authored
The allocation in ConsumerWrapper::ConsumeAudio causes contention occasionally. Move the allocation to the construction of ConsumerWrapper and reuse the object for each call. Bug: 1078786 Change-Id: I69308e83c607321cbd624616256a4635cabf5a4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2184135 Commit-Queue: Johannes Kron <kron@google.com> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Johannes Kron <kron@google.com> Cr-Commit-Position: refs/heads/master@{#766386}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3141e6914c82..40875028ce6c git log 3141e6914c82..40875028ce6c --date=short --first-parent --format='%ad %ae %s' 2020-05-07 tvanderlippe@chromium.org Update Puppeteer to v3.0.3 2020-05-07 pfaffe@chromium.org Rename the sbrk evaluator import Created with: gclient setdep -r src/third_party/devtools-frontend/src@40875028ce6c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic91efc0ce7db4c44ba858aa0d905e28504abc3ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187526Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/964c8df4b958..1c2654255f78 Created with: gclient setdep -r src-internal@1c2654255f78 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sinhak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: sinhak@google.com Change-Id: I14bcb0a68bbc65bfc8938f3e651846c14f137536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187520Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#766384}
-
DongJun Kim authored
This patch is step 3-2 in [1] and we migrate CSP and security code to use RequestDestination. If we are finish current step then implementation for RequestContextType will be removed in CSP. [1] https://docs.google.com/document/d/1kXXnH_27aJYGqjwbXLW6Bs9fW2xFhvZs8gJcXb4xnhQ/edit Bug: 889751 Change-Id: Ib4240567b9e517248ff05acd3fa7919928ec5932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2183971 Commit-Queue: DongJun Kim <djmix.kim@samsung.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#766383}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9af75432b285..d6b10943c754 git log 9af75432b285..d6b10943c754 --date=short --first-parent --format='%ad %ae %s' 2020-05-07 sclittle@chromium.org Revert "Android: Remove min_sdk_version in GN" 2020-05-06 landrey@webrtc.org Create default frame generator in the AddVideoConfig method. 2020-05-06 wnwen@chromium.org Android: Remove min_sdk_version in GN Created with: gclient setdep -r src/third_party/webrtc@d6b10943c754 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1017190 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2d6290c22a25f49280280dc073997a141ae97ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187522Reviewed-by:
-
Marc Treib authored
LoginDatabase::ReportMetrics was a >250-line method that recorded a number of mostly-unrelated metrics. This CL splits it into multiple independent helper methods. There is one potential behavior difference: If any of the involved SQL statements was invalid, then ReportMetrics would bail out, skipping recording of any further metrics. After this CL, only the current helper will bail out, and any further metrics will still get recorded. Hopefully this doesn't happen in practice anyway, but if it does, this seems like a win. Bug: 1063852 Change-Id: Ie702c06618bdf29d62d0fefe2064f4b063d150f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185111 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#766381}
-
Yuki Shiino authored
HTML specifies no [Exposed] on interface mixins as there is no need of it. Basically interface mixins do not need [Exposed] because the exposure is already controllable with 'includes' declarations. Bug: 839389 Change-Id: I1267c34b96d5240f690e47b1ba37a8c9c2654bd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186880Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ca0732e1..6f1c4463 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I46872f7fa00bc5807b1d3866f07738e91612dd4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186314Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#766379}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8dd25597363a..0f6cd95f999d git log 8dd25597363a..0f6cd95f999d --date=short --first-parent --format='%ad %ae %s' 2020-05-07 rsorokin@chromium.org telemetry: Add rsorokin@ as CrOS OOBE owner Created with: gclient setdep -r src/third_party/catapult@0f6cd95f999d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: wenbinzhang@google.com Change-Id: Ib4e1f7bc6d31c75342dc197284839fbaf4964103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187518Reviewed-by:
-
Vasilii Sukhanov authored
Bug: 1049200 Change-Id: Idd1dde62112b18e7a41603c4e0df0ee1d9f7b650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185071 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#766377}
-
Sigurd Schneider authored
This allows the devtools front-end to provide better information and to support more accurate filtering in the network view. Previously, cookie information for requests was loaded separately from the cookie store, and in some cases this caused the cookie information to be out-of-date or inaccurate, because the headers only mention the cookie name, but to identify a cookie in the cookie store, the triple (name,domain,path) is required. Additionally, this ensures that full request cookie information is present in the request without consulting the back-end again. Bug: chromium:1027752, chromium:1051163 Change-Id: I95e1ba7993eaeeebcfdec33e3ff571efb9466473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2183937 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#766376}
-
Victor Hugo Vianna Silva authored
Bug: None Change-Id: I4bd42086ce7eda5ac9ed2233d776ec5892c1c719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2184134Reviewed-by:
-
Oriol Brufau authored
This patch fixes a heap-use-after-free in legacy layout when having a an inside ::marker originated by a ::before or ::after pseudo-element which is dynamically converted into a multicol container. The problem was caused by some code that was aiming to prevent the ::marker from being placed after the generated contents of the ::before or ::after. To do so, it reinserted the ::marker as the first child of the originating list item. The problem was that, in the multicol case, the LayoutInsideListMarker is a descendant (not a child) of the LayoutListItem, since there are a LayoutMultiColumnFlowThread and a LayoutBlockFlow between them. Therefore, this patch reinserts the ::marker as the first child of its parent, instead of as the first child of the list item. BUG=1078236 TEST=third_party/blink/web_tests/external/wpt/css/css-multicol/multicol-list-item-002.html Change-Id: I580e4730d6e8ec6d41e423d0d027f67de4d48fa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185030Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#766374}
-
Gauthier Ambard authored
IPads don't have force touch. This test doesn't make sense on that form factor. Fixed: 1079165 Change-Id: Ia9dfb69d90c3bd6c87f76a2420703cf1ad9d2fd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187573 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#766373}
-
Gauthier Ambard authored
The test was failing because the screen of the phone is too small to display the action now that the "Downloads" entry is displayed. Fix it be scrolling the menu. Fixed: 1079185 Change-Id: I787bfeb9fdbcc183a247241d9f4cbe04489dd852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187490 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3c5adb7b5fa0..3141e6914c82 git log 3c5adb7b5fa0..3141e6914c82 --date=short --first-parent --format='%ad %ae %s' 2020-05-07 pfaffe@chromium.org Return an error in evaluateVariables when formatters are unavailable 2020-05-07 pfaffe@chromium.org Fix tests after vector->set change Created with: gclient setdep -r src/third_party/devtools-frontend/src@3141e6914c82 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1020120 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I54c23117bd94580d6949d00214951b1451581394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187521Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I689239a284337c2c8c4a4d25ab15a754cbb05362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187519Reviewed-by:
-
Sami Kyostila authored
This patch adds a build override for telling V8 to use the Perfetto client library built by Chromium instead of trying to build an independent copy. The feature flag (use_perfetto_client_library) is defaulted to false in V8 and overridden here when Chromium is also using Perfetto's client library[1]. Corresponding V8 change: https://chromium-review.googlesource.com/c/v8/v8/+/2182637 Bug: b/155075662 [1] https://docs.google.com/document/d/1f7tt4cb-JcA5bQFR1oXk60ncJPpkL02_Hi_Bc6MfTQk/ Change-Id: Iabdeec5fe957934dc0e3bb0364c5272a818415ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2184572 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#766369}
-
Peter Kasting authored
Include this directly in relevant test files. This lets us convert the HAS_OUT_OF_PROC_TEST_RUNNER checks in this file and view_event_test_base.h into #errors, and force people to not even include this file in files that can't use it. Bug: none Change-Id: I66e5ecc80f4c28ab79572b9112a952553a19ca5a Tbr: sky Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187192 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#766368}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d2b486219495..c8590c18bd0c git log d2b486219495..c8590c18bd0c --date=short --first-parent --format='%ad %ae %s' 2020-05-06 jaebaek@google.com Preserve debug info for wrap-opkill (#3331) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@c8590c18bd0c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: I4a9ab17e670355c1ee6de1e527463a48a33b5b80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187363Reviewed-by:
-
Maks Orlovich authored
This involves some test updates; of particular note is that iframe-no-accept-ch.php helper didn't use to test what it thought it did since it was in the wrong directory. Change-Id: I70dc9055487b69946548ecc8b2fafb270a508438 Bug: 1078353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140918Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#766366}
-
Yann Dago authored
BYPASS_POLICY_COMPATIBILITY_CHECK=<Typo in policy name> Bug: 1078951 Change-Id: I703e03354ea215564bd90c8934808de2c5959ddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186117 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#766365}
-
Roman Sorokin authored
Fit better with ChromeOS signin (also ownership-wise) Bug: none Change-Id: Iff29a93628b1d84f3a96630202b1d13cb3cfb6cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2182642Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#766364}
-
Benoit Lize authored
DNS resolution failures can be transient, especially with DoH, as they would include regular HTTP failures as well. Since the resolver turns all resolution failure errors into net::ERR_NAME_NOT_RESOLVED, it is useful for SimpleURLLoader to be able to retry requests. Bug: 1078350 Change-Id: Ic474fed0af4eb36c0d066e5e3be9c1deabde1eb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181281 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#766363}
-
Mario Sanchez Prada authored
This CL moves this message out of frame_messages.h and adds a new method in blink::mojom::LocalFrame, implemented by blink::LocalFrame, to request the renderer to continue with the focus sequence for a given frame, handling both same-process and cross-proces scenarios. This CL also removes methods WebView::AdvanceFocusAcrossFrames() and WebView::SetInitialFocus(), since that functionality is no longer needed from outside of Blink and tests can be adapted. Bug: 1047318 Change-Id: Ic83f36862931d6eb03d278cb9ae1d101a205ac2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172691 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Peter Kasting authored
This is a step towards doing full IWYU of browser_test.h, which will have other benefits. Completely mechanical and already R+ed as part of r765923. Tbr: sky Bug: none Change-Id: Icb7ab728098a6cf29c0920da4b524e96a7c024c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186411 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/28ae7c5809b2..3c5adb7b5fa0 git log 28ae7c5809b2..3c5adb7b5fa0 --date=short --first-parent --format='%ad %ae %s' 2020-05-07 sigurds@chromium.org Prepare protocol for argument renaming Created with: gclient setdep -r src/third_party/devtools-frontend/src@3c5adb7b5fa0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1027752,chromium:1051163 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I08f39b93f1d1f6d0946c05c59ccc88d61e89cc5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187513Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/459d7cc439a1..964c8df4b958 Created with: gclient setdep -r src-internal@964c8df4b958 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sinhak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: sinhak@google.com Change-Id: I5b613ef91a7968b9837905d197b0076db773e901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187369Reviewed-by:
-
Bartek Nowierski authored
There is a difference between dereferencing a pointer (operator-> and operator*) and reading/casting it (get() and operator T*/U*). The latter must not crash on nullptr, whereas the former can. The underlying implementations may treat those situations differently. Furthermore, while reading/casting feel like a good moment to check if the pointer wasn't freed (because the caller may have an intention to dereference it soon), operators ==/!= don't need that hence the implementation may choose to go through a separate, possibly faster path. Bug: 1073933 Change-Id: If14af14c5b5fd046d9d0bf1d19903b67cbbf73c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166236 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#766358}
-
Clemens Arbesser authored
Bug: b/145043394 Change-Id: I0eb1f559853a2e548ea9e6fca6422e25a05b9ba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162809 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#766357}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6a91312c..ca0732e1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I03420a93c3c49ba3d5594bdc148f4ab4e9b262d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187010Reviewed-by:
-
Karandeep Bhatia authored
This CL adds support for specifying a base::Feature dependency for an extension feature. This can be useful to add a kill switch for extension API features during launches. Also, add a feature flag for the Declarative Net Request API. BUG=696822, 1077573 Doc=https://docs.google.com/document/d/1bGHFfpDb5oCfrMihUqWKYUmInWi4N2veW-YjyRq-FGo/edit?usp=sharing (Internal only) Change-Id: I61d05df383a962bda400989c47b03bd1ad7d1cce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176987Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#766355}
-
Morten Stenshorne authored
Remove no-longer-needed first-for-node things added recently, mainly as part of CL:2111158. Inline nodes no longer need to specify this. On the physical fragment side, only *box* fragments need to specify whether they're first-for-node, so move stuff down there. Bug: 1043787 Change-Id: I0177f3bf7b3a4fe2ee160504368490283aaab079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167272 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#766354}
-
Peter E Conn authored
This CL adds the DisclosureNotificationResponseService, an IntentService that dismisses the notification and records that the disclosure has been accepted. Bug: 1068106 Change-Id: I41d8edf20e6225d550cb09376930f9a59275edbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2179007 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#766353}
-
