- 06 Jun, 2018 40 commits
-
-
Biao She authored
Previously, we want all redirection stays in Chrome while in VR. The problem is if a webpage sends a redirection request that Chrome can't navigate to (i.e. intent://*). Chrome just silently block the request. This leads to problem described in issue 848788. This CL unblocks such redirection (when redirect to an external app). Bug: 848788 Change-Id: Ia1fc66afe1d011d1c814f7a907d423f053e7fb28 Reviewed-on: https://chromium-review.googlesource.com/1087775Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#564889}
-
Scott Violet authored
It's not applicable to ws2 (because the pre-target handlers installed by ash take care of it). BUG=842295 TEST=none Change-Id: I57ae1c684580233233bff13186560c2790f56c79 Reviewed-on: https://chromium-review.googlesource.com/1088128Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#564888}
-
Chris Nardi authored
The anonymous getter in CSSStyleDeclaration only uses the DOMString type of the current union (DOMString or float), so we don't really need to have the union at all. This change simplifies the code to mark the return value as only a DOMString and not a union. Change-Id: Ibd4026a5ddc1efd47226c9e1fbd643ab93d898d9 Reviewed-on: https://chromium-review.googlesource.com/1083216Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#564887}
-
Olivier Li authored
Bug: 830892 Change-Id: I4e22700df6983b89e0c516c4cb7534f612a28d5e Reviewed-on: https://chromium-review.googlesource.com/1086047Reviewed-by:
proberge <proberge@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#564886}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/522947b..1a3e67e git log 522947b..1a3e67e --date=short --no-merges --format='%ad %ae %s' 2018-06-06 yyanagisawa@chromium.org cros_chrome_sdk: should not raise on goma fetch failure. Created with: gclient setdep -r src/third_party/chromite@1a3e67e The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:849832 TBR=chrome-os-gardeners@chromium.org Change-Id: Ibf7c3a77c7ab5e5a3312538c68e2b210f03a7fe1 Reviewed-on: https://chromium-review.googlesource.com/1088770Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564885}
-
Navid Zolghadr authored
Due to a rebucketing change the previous version lost its value. This CL adds the new metrics with the broader range of buckets up to 2 seconds to accomodate for slower devices. Bug: 849735 Change-Id: Ie683cf1bfc510da618e989eae7ca027497322da9 Reviewed-on: https://chromium-review.googlesource.com/1087529Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#564884}
-
Marcin Wiacek authored
Moving two variables into method (cleanup after https://chromium-review.googlesource.com/c/chromium/src/+/1070202) Change-Id: I6a622b5fd13e42dd347e03df2536f5af0267dc68 Reviewed-on: https://chromium-review.googlesource.com/1087962Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#564883}
-
Juan Antonio Navarro Perez authored
Test is consistently failing. TBR=nednguyen@google.com NOTRY=true Bug: 847786 Change-Id: I09dedb490c625d03f1e008012cf5d7cac097400c Reviewed-on: https://chromium-review.googlesource.com/1088916Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#564882}
-
Robert Sesek authored
This feature works in conjunction with --site-per-process. When a renderer process has only subframes, Blink's main thread isolate will be put into a memory savings mode. If a main frame is created in the process, the isolate will be taken out of memory savings mode for as long as a main frame exists. Bug: 846360 Change-Id: I09c362cce648b734fb01907a5ad758f0bdb7f752 Reviewed-on: https://chromium-review.googlesource.com/1076954Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#564881}
-
Koji Ishii authored
Following bot results are included. 6182 6192 6206 6210 6212 6225 6233 6237 30 lines were removed and 1 lines were deflaked by consecutive results since 6147. Also includes removal of unneeded comment lines pointed out by cbiesinger@chromium.org. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: If30ff52b35ee6d21bee494a64e86d9ddfe918411 Reviewed-on: https://chromium-review.googlesource.com/1087187 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#564880}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ba9d017..01f608b git log ba9d017..01f608b --date=short --no-merges --format='%ad %ae %s' 2018-06-06 thakis@chromium.org Don't suppress stderr when calling generate_breakpad_symbols.py Created with: gclient setdep -r src/third_party/catapult@01f608b The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:850055 TBR=sullivan@chromium.org Change-Id: I416a35459a6c4ca30a81147a35d16d00dd49f7b0 Reviewed-on: https://chromium-review.googlesource.com/1088810Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564879}
-
Sharif Elcott authored
Previously we were casting away const at call sites because vaCreateBuffer accepts a non-const buffer. However its documentation says that the data will be copied out, and the implementation does so as well. We can avoid this by mapping server-side memory via vaMapBuffer and copying it ourselves, as VaapiWrapper::SubmitVAEncMiscParamBuffer does. Bug: 844303 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4d66d0d6ee5e672d22a5dbe4073244515fa1b14d Reviewed-on: https://chromium-review.googlesource.com/1080495 Commit-Queue: Sharif Elcott <selcott@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#564878}
-
Andrew Grieve authored
This makes use of ninja's "restat" feature to eliminate rebuilding of dependent java libraries when a library's interface jar is unchanged. We previously approximated this behavior by having scripts use md5sum.py to early-return when input md5s didn't change. Bug: 810890 Change-Id: I08456c172f52e581c84b6a0daf9376e38d7b3df3 Reviewed-on: https://chromium-review.googlesource.com/1060697 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#564877}
-
Sylvain Defresne authored
Two inner types where named ImageDataFetcherCallback in components/image_fetcher/core, one in ImageFetcher and the other in ImageDataFetcher. The two types where typedef for callbacks accepting the same arguments except one was a RepeatingCallback while the other was a OnceCallback. This duplication caused confusion. Move ImageDataFetcherCallback into the image_fetcher namespace. Also move the related types ImageFetcherCallback and IOSImageDataFetcherCallback (this type is also renamed to ImageDataFetcherBlock as it is a typedef for a block). Since the callback is only called once, convert it to a base::OnceCallback<> and fix the code accordingly. Bug: 850019 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iab24263d8ac6e2fd8e48db5274e1a64b15e4ad16 Reviewed-on: https://chromium-review.googlesource.com/1088701 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#564876}
-
Mark Pilgrim authored
Bug: 844942 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ifda80b4277d7d4ad6f1336de6f437aa82ff75c29 Reviewed-on: https://chromium-review.googlesource.com/1087174Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#564875}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e6c72ebc..01ad164d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I1d2c1e4fe8b32e613902ad0aca20a3fb8bbdab68 Reviewed-on: https://chromium-review.googlesource.com/1088626Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#564874}
-
Peng Huang authored
Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ic881046b92c172d20d85db95b64799d38bd6d110 Reviewed-on: https://chromium-review.googlesource.com/1087682Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#564873}
-
Matt Menke authored
Bug: none Change-Id: I17e556acb43a29565631ae3dbdef9593a134bdf6 Reviewed-on: https://chromium-review.googlesource.com/1087414Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#564872}
-
John Chen authored
While sending file name to <input type='file'>, ChromeDriver can only check for the file existence on the local file system. This isn't correct for Android and remote browsers. This is now fixed. Bug: chromedriver:2339 Change-Id: Ie900513f028fee36485d477fada5a59c4e33dd22 Reviewed-on: https://chromium-review.googlesource.com/1087668Reviewed-by:
Jonathon Kereliuk <kereliuk@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#564871}
-
Jochen Eisinger authored
BUG=797942 R=blundell@chromium.org Change-Id: I51f4a5830f26c945747e9f9d3b48482b46c5239f Reviewed-on: https://chromium-review.googlesource.com/1078848Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#564870}
-
Sylvain Defresne authored
With https://crrev.com/c/1070158, base::Bind() supports block so convert uses of base::BindBlockArc() to instead use base::BindOnce() or base::BindRepeating(). Bug: 701275 Change-Id: I0a10526bd47c8c52b2cfc980bdc9d43e4883c18e Reviewed-on: https://chromium-review.googlesource.com/1087061Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#564869}
-
Jonathan Backer authored
Removes some #ifdefs from gpu_info_collector.cc to try to collect info from a GL context during GPU process initialization. If this change sticks, we can unroll some of the OSX specific changes that were made to avoid this early code path (e.g. in components/viz/service/gl/gpu_service_impl.cc) Bug: 847543 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id52dcddfb3980f3b3aee52021ebe6c9981ad150e Reviewed-on: https://chromium-review.googlesource.com/1087582Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#564868}
-
Michael Lippautz authored
- Add unit tests. - Move more UMA histograms into common bottleneck. Bug: chromium:840789 Change-Id: Ia51a60cb424fe29eb5f4590f58f5454daf16b6bb Reviewed-on: https://chromium-review.googlesource.com/1082133 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#564867}
-
Alexandr Ilin authored
This CL changes the signature of content::PreresolveUrl() so that the method returns a net::HostResolver::Request object to a caller instead of holding it inside of the callback state. It is done to guarantee that there won't be hanging requests after a caller is shut down. There are only two callers of this method: chrome_browser_net::Predictor and predictors::PreconnectManager. They become responsible for keeping Request objects alive. Bug: 845648 Change-Id: Ie057cde65288341b14813d4df4d7d90a02f588b6 Reviewed-on: https://chromium-review.googlesource.com/1080818 Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#564866}
-
Hajime Hoshi authored
To decouple the relationships between EventQueue(Impl) and ExecutionContext, make each user have their own EventQueueImpl object. For ContentSecurityPolicy class, I'll make a follow-up CL later. Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit# Bug: 846618 Change-Id: I3177bf1e69ef1db61cb8056c2309e93ad5539b94 Reviewed-on: https://chromium-review.googlesource.com/1088534 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Martin Kreichgauer authored
This is a reland of 7acb4716 with a fix. In the original CL, CredentialMetadata::HmacForStorage wrapped HMAC::Init(base::StringPiece) in a DCHECK. In non-debug this resulted in HMAC::Sign getting called on an unintialized HMAC instance. Change-Id: Ibf6e34dc381812254aaed5c20a83eb6a28d43246 Reviewed-on: https://chromium-review.googlesource.com/1087315Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#564864}
-
Peter E Conn authored
Bug: 844043 Change-Id: I8a24df699cf697762cdbcc3ca9259f839c04d212 Reviewed-on: https://chromium-review.googlesource.com/1085053Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#564863}
-
chrome://appsRamin Halavati authored
chrome://apps page is not supported in guest mode, and currently if navigated to, nothing happens which is felt as a bug to the user. This is changed to redirecting to a page saying that apps is not available to guest users. Bug: 607508 Change-Id: I14880f885eb19279429736a5b3777516435c444d Reviewed-on: https://chromium-review.googlesource.com/1087960Reviewed-by:
-
Pavol Marko authored
If the device is in factory ping embargo period, or the factory ping embargo end date is invalid (too far in the future), attempt to synchronize the system clock with the network before continuing, re-checking if the device is still in the factory ping embargo period after the clock has been synchronized. The system clock sync has a timeout of 15 seconds, if no sync could be reached by then, assume that no Initial Enrollment should be done. Also add an UMA histogram to track if Initial Enrollment was required, and if not, why not. Bug: 839353 Test: browser_tests --gtest_filter=WizardControllerDeviceState* Change-Id: I9094dd19f141e8a4dbdb8dcdcd16ef90d1ec2af5 Reviewed-on: https://chromium-review.googlesource.com/1076233Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#564861}
-
Colin Blundell authored
APIs are now in place that allow ProfileSyncServiceStartupTest to use identity_test_utils.h, which is preferable as that has a direct conversion path to the long-term IdentityTestEnvironment test infrastructure. Bug: 796544 Change-Id: I2850f950353849a50638195bd2c4276089b011a3 Reviewed-on: https://chromium-review.googlesource.com/1085463 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Hajime Hoshi authored
This is a pure refactoring. Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit# Bug: 846618 Change-Id: Ied94509c9d5af1a937142addebbc414da9c0e95f Reviewed-on: https://chromium-review.googlesource.com/1088449Reviewed-by:
-
Hitoshi Yoshida authored
With works around terminate GC, we no longer need to run additional GCs at thread termination. This CL removes such test only behavior and cleans up code of paths to it. Bug: 590802 Change-Id: Icf17118744c785a5a6d0f3e8e6101da1cf9ad3bc Reviewed-on: https://chromium-review.googlesource.com/1088536Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#564858}
-
Sergio Villar Senin authored
The current Grid data structure is mostly generic but it still depends on a grid representation based on Vectors of Vectors. In order to allow future memory efficient representations we should remove that dependency. This CL moves all the vector dependent code to a new class named VectorGrid. Apart from that, GridIterator was moved to Grid and also refectored as we would need to provide different implementations of the iterator depending on the data structure used for grids. Last but not least, in order to limit the amount of changes in the clients of these two interfaces, a couple of factory methods were added to create both Grid and GridIterator objects. These Create() methods are the ones instantiating the specific Grid (and GridIterator) representations. R=jfernandez@igalia.com, rego@igalia.com Change-Id: I59d9f8df93c3c65390a0f22aaf8064359f9248f4 Reviewed-on: https://chromium-review.googlesource.com/1075331 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#564857}
-
Colin Blundell authored
As a convenience step in the porting of the IdentityProvider interface and implementation away from OAuth2TokenService, this CL eliminates FakeIdentityProvider. This change reduces the number of IdentityProvider implementations to two and will avoid duplication of code between FakeIdentityProvider and DeviceIdentityProvider when IdentityProvider and ProfileIdentityProvider are later ported away from knowledge of/dependence on OAuth2TokenService. The change is straightforward: The remaining tests that use FakeIdentityProvider don't use any of its custom hooks for testing. All that was necessary was to let ProfileIdentityProvider have a test constructor that allows for its SigninManager instance to be null. This avoids the need for these tests to construct a FakeSigninManager(Base) instance, which is a pain to do. Once ProfileIdentityProvider is converted to take in IdentityManager, this test constructor can go away, as it is a breeze to construct IdentityManager in a testing context via IdentityTestEnvironment. Bug: 809452 Change-Id: I2f699d6776542626800e59bda731579338076077 Reviewed-on: https://chromium-review.googlesource.com/1087054Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#564856}
-
Colin Blundell authored
This CL removes the callthrough from SyncAuthManager::OnPrimaryAccountSet() to SyncAuthManager::OnRefreshTokenAvailable(). The former currently calls through to the latter when a refresh token is available. However, that call will be a no-op. OnRefreshTokenAvailable() does two things: 1. If the primary account is updated with an invalid refresh token, it takes action to stop sync. 2. If the primary account is updated with a valid refresh token, it checks if there is a need to fetch a new access token and fetches one if so. Neither of these are relevant when SyncAuthManager::OnPrimaryAccountSet() is invoked: - The flow resulting in 1 is started only in the context of there already being a primary account. - For 2, there will by design never be "a need to fetch a new access token" at the time of SyncAuthManager::OnPrimaryAccountSet(): at the time that the primary account is set we don't know whether Sync actually wants to start, e.g., the user might have explicitly disabled it. The initial access token fetch occurs as follows: The SyncEngine tries to connect to the server, but has no access token, so it ends up calling OnConnectionStatusChange(syncer::CONNECTION_AUTH_ERROR) which in turn causes SyncAuthManager to request a new access token. The sum of this reasoning is that SyncAuthManager::OnPrimaryAccountSet's callthrough to SyncAuthManager::OnRefreshTokenAvailable() is a no-op and can be removed. The concrete motivation for this CL is to facilitate porting this class to observe IdentityManager for token-related events. Bug: 825190 Change-Id: I77964296957facf22c60b2a62775c034af9e47a0 Reviewed-on: https://chromium-review.googlesource.com/1087964 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Shanmuga Pandi M authored
This patch removes the extra form data added, if "value" attribute present with non-empty value for <input type='image'> Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/hp1_-1tgvDs Bug: 753746 Change-Id: I6a4987a7fb5751b75ff2472f594063876ec076a1 Reviewed-on: https://chromium-review.googlesource.com/1086953 Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#564854}
-
Jose Dapena Paz authored
Fix build error in GCC due to an ambiguous auto resolution. An initializer list is not compatible with an std::vector in a ? : sequence, so it will fail to resolve the subsequent auto statement: ../../components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.cc -o obj/components/subresource_filter/content/browser/browser/subresource_filter_safe_browsing_activation_throttle.o ../../components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.cc: In member function ‘void subresource_filter::SubresourceFilterSafeBrowsingActivationThrottle::NotifyResult()’: ../../components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.cc:141:26: error: operands to ?: have different types ‘std::vector<subresource_filter::SubresourceFilterSafeBrowsingClient::CheckResult>’ and ‘const std::initializer_list<const subresource_filter::SubresourceFilterSafeBrowsingClient::CheckResult>’ consider_redirects ? check_results_ : last_result_array; ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.cc:145:37: error: unable to deduce ‘auto&&’ from ‘check_results_to_consider’ for (const auto& current_result : check_results_to_consider) { ^~~~~~~~~~~~~~~~~~~~~~~~~ The solution is explicitely setting the type instead of using auto, so the resolution is not ambiguous. Bug: 819294 Change-Id: Ieae11f751569ffe15a5db49833153478eed4cbcb Reviewed-on: https://chromium-review.googlesource.com/1087958 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by: -
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=muyuanli@google.com Change-Id: Icbe3ca6756388b0d46f128ba773ce1c5bc80ab3e Reviewed-on: https://chromium-review.googlesource.com/1087945Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#564852}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/79725d3..c27967f git log 79725d3..c27967f --date=short --no-merges --format='%ad %ae %s' 2018-06-06 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 d197803..0211346 (1 commits) Created with: gclient setdep -r src/third_party/skia@c27967f The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@chromium.org Change-Id: Ic97180fb1d5ab61e4ce5fa7b422fee5acd1ee041 Reviewed-on: https://chromium-review.googlesource.com/1088588Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564851}
-
Alexander Potapenko authored
TBR=dtapuska@chromium.org Bug: 838769 Change-Id: I3b772a840d382805799cc32d2555ac363bbe4d75 Reviewed-on: https://chromium-review.googlesource.com/1088613Reviewed-by:
Alexander Potapenko <glider@chromium.org> Commit-Queue: Alexander Potapenko <glider@chromium.org> Cr-Commit-Position: refs/heads/master@{#564850}
-
