- 07 May, 2020 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b8a9630e9e23..03fade52dae7 git log b8a9630e9e23..03fade52dae7 --date=short --first-parent --format='%ad %ae %s' 2020-05-07 stha09@googlemail.com IWYU: uint32_t is defined in cstdint Created with: gclient setdep -r src/third_party/webrtc@03fade52dae7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I26a52aa10ba5071fb4e4e55a739d33b34bd19a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188061Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#766574}
-
Brian Sheedy authored
Supports multiple uses of --expected-device-id in info_collection_tests. This is necessary in order to run tests on Intel HD 630 and UHD 630 machines interchangeably. Also passes an extra expected device ID on the experimental Windows builder that is using both GPUs. Bug: 1079399 Change-Id: I8b2e5da8b661ab9a5ec23dbfccc3d2cd109a70b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188059 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#766573}
-
Avery Musbach authored
As Sammie [1] speaks of "a audit of the uses to make sure their using the api correctly," I doubt that he would be happy with how ShelfView::ShelfItemReturnedFromRipOff directly sets the bounds of a view during animation. It sets the bounds and then ends the animation, and it may as well just do those two things in the opposite order, although the code needs to be one line longer that way. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=1073653#c8 Bug: 1073653 Change-Id: I0f96add7a3505042af3dbf41930c5aa86431c7b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188539Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#766572}
-
Manuel Rego Casasnovas authored
This patches fixes the problem described in crbug.com/1048070 related with elements with padding and inline-block or inline descendants. For these elements the outline was being wrongly painted as we were computing some offsets twice. This patch adds a test covering lots of cases and combinations: external/wpt/css/css-ui/outline-027.html Apart fromt that it also adds a test for outline elements and floating descendants with margins and paddings: external/wpt/css/css-ui/outline-028.html This one is unrelated to this patch and was working fine too, but in our previous attempt to fix this issue we got a regression related to floated elements (see crbug.com/1057576). Last this is also including the test that was written for the original patch that ended up being reverted https://chromium-review.googlesource.com/c/chromium/src/+/2038296: external/wpt/css/css-ui/outline-with-padding-001.html BUG=1048070 TEST=external/wpt/css/css-ui/outline-027.html TEST=external/wpt/css/css-ui/outline-028.html TEST=external/wpt/css/css-ui/outline-with-padding-001.html Change-Id: Ie7cf667b91deafa351af7915e69a066c5a665334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187311 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#766571}
-
Xing Liu authored
This CL adds an fetchImage function in ImageFetcher to use the new ImageFetcher.Params struct. The underlying ImageFetcherBridge call also only use the Params struct now. TBR=sandromaggi@chromium.org Bug: 1076515 Change-Id: I32792c695c684fbe7963df8070ed576f91c9d246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176422 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#766570}
-
Peng Huang authored
* Change some DLOG(ERROR) to LOG(ERROR) to help diagnose vulkan issue. * Fix a semaphore leak when vkAcquireNextImage() is timeout. * Fix some typos Bug: None Change-Id: I7ed4c2e726b0e1bf42917ab8544fa65344e1ccab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185931 Auto-Submit: Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#766569}
-
David Bokan authored
This CL updates touch-gesture-fling-with-page-scale.html to use browser-injected events rather than event_sender which injects events directly into Blink. This prepares the test for scroll unification. This test was added for https://crbug.com/423345 which was a scroll targeting bug in main thread fling code when the page was zoomed. Flings are now performed in the browser so this can't specifically happen in fling independent of scrolling but ensuring we correctly target scrolls while zoomed is useful in general so I've kept the test. I've rewritten it completely to be clearer and more modern. Also removed some dead code and updated some helpers in gesture-util.js to provide coordinates in visual viewport space. Bug: 1047176 Change-Id: I7e06be389e35f0ba4ad60e3ebab0b880d8c92d7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2175284 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Auto-Submit: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#766568}
-
Becca Hughes authored
Reset the media feed if the cookies expire or are deleted on any associated origin. BUG=1072704 Change-Id: Idd432ee3f468e1488d7be3ea312e68476e523454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173682 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#766567}
-
Filip Gorski authored
Creates OmniboxSuggestionsRecyclerView implementation of the OmniboxSuggestionsDropdown and a corresponding Adapter. Introduces OmniboxSuggestionsDropdownFactory, which uses ChromeFeatureList to decide which implementation of dropdown and adapter to provide. Updates AutocompleteCoordinatorImpl to use OmniboxSuggestionsDropdownFactory to create instances of the dropdown and adapter. Also handles: * keyboard interactions in RTL (enables refining selection with keyboard) * walking the URL bar by one step right, which was previously hijacked by the keyboard handling code of a suggestion. Bug: 1075602, 819575 Change-Id: I203664b9fd95bd97f54169532349e6a52f04847f Binary-Size: Increase is temporary. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173619Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#766566}
-
Elly Fong-Jones authored
Update the anchor position after creating the bubble. Bug: 1078500 Change-Id: Iee2c92c307960182e544ef2aed96b04d0bd992a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185271 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#766565}
-
shrekshao authored
Set conformance/glsl/misc/fragcolor-fragdata-invariant.html to RetryOnFailure TBR=kbr@chromium.org Bug: 1079245 Change-Id: I606f0fede5f2c2c86d1f7302385e7e2a1782a852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188555Reviewed-by:
Shrek Shao <shrekshao@google.com> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#766564}
-
Collin Baker authored
This also adds unit test coverage for all of TabDragDropDelegate. Bug: 1069869 Change-Id: I719586ffcc775b3a7ea5eab1fc8d38d5baaa665d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176675Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#766563}
-
Thomas Tellier authored
Bug: b/155794626 Change-Id: I99cfe0016006993cb07cb15feaf4feed3e11c333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187312Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#766562}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I341b0f58925c9efa10f4bece438dbad30ddccfce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188149Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#766561}
-
Rayan Kanso authored
Bug: 1077676 Change-Id: I85b7348546782b01db54e7c75b90cd17c50f8afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2182653 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#766560}
-
Geoff Lang authored
SwANGLE requires this enableable extension to have enough precision for texture filtering in WebGL content. Bug: b:146423360 Change-Id: I4e7c25d113274024fe46cb393d874cf50ee8309e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188531Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#766559}
-
Joel Hockey authored
By default, tabs will use the URL for title if it is not set. We don't ever want chrome-untrusted:// URLs to be shown to user, so set tab title empty in this case. For chrome-untrusted://terminal, we set the title once the page loads, and previously we were getting flicker of the URL being shown for a small amount of time (approx 250ms). Bug: 1060863 Change-Id: Iafb52656640c1baf734876b5888ef8dd23756bf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172720Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#766558}
-
cfredric authored
Bug: 973801 Change-Id: Ifa3c3e2a26187b0b813a5984e7ad75b97f9ba53c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173394 Commit-Queue: Chris Fredrickson <cfredric@google.com> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#766557}
-
Sebastien Marchand authored
These tests have been constantly failing for all the official builds for almost a year now and nothing is being done to fix them. These failures make most people ignore the test results on these bots. The real fix is apparently to fix the bots but there's no reason to keep these tests for official builds if they fail all the time and nobody do anything about them. Bug: 963868 Change-Id: Ie6cb93e078f7e8f484a1cdd9c99d965f06146cea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188231Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#766556}
-
Dan Sanders authored
Change-Id: I28a23d9ff976bdc0b655be4dd5f6a5b2c2d2d4da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185859Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#766555}
-
Erik Chen authored
The builder is identical to the public lacros builder, with the exception of also including src-internal. Bug: 1077348 Change-Id: I7b28f880cf0cd379901de32c41573bb934bc74ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188444 Commit-Queue: Erik Chen <erikchen@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#766554}
-
Toni Barzic authored
It was introduced to contain horizontaly swipable app list pages, but currently contains only AppsContainerView, thus making HorizontalPage abstraction obsolete. This removes HorizontalPage interface and HorizontalPageContainer, and makes the AppsContainerView an AppListPage, moving parts of HorizontalPageContainer that are still relevant to AppsContainerView. BUG=1001657 Change-Id: If5d8b826e67ee4449ee806079a85205159e22cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167012 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#766553}
-
Caitlin Fischer authored
Bug: 1079253 Change-Id: I30a45ef2eebcf946eecde0d5806478b4a4c3cbfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186364Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#766552}
-
Abhijeet Kandalkar authored
Get rid of public facing API SetInheritedEffectiveTouchAction from t_p/blink/public/web/web_frame_widget.h Bug: 1071585 Change-Id: Ia4713159d243abd63119ac6ecd8ab8a45225c37b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187931Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#766551}
-
Abhijeet Singh authored
This CL does not change behavior. QuickAnswersPreTargetHandler is factored out to a separate file to allow quick_answers::UserConsentView to share its logic. Bug: b:151111996 Test: Tested on Atlas test device. Change-Id: I434d33259a42c905eeaa71f65e13a673228737f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186127 Commit-Queue: Abhijeet Singh <siabhijeet@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#766550}
-
Mike Dougherty authored
This is not meant to be an exhastive document, but rather a starting point to help describe how to best use the Xcode IDE. TBR=noyau@chromium.org Bug: None Change-Id: I821dba060353220c1f93cd49dd12dcd74aeaf790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188519Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#766549}
-
James Cook authored
The mash flag was removed long ago, but we missed this reference to it. Bug: none Change-Id: I2a5c73e931152853ea2ce5fffcfebec893de9106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188351 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#766548}
-
Greg Thompson authored
ConnectNamedPipe returns false with a specific error code if the other end of the pipe is already open. This is not a failure. This is a partial revert of commit 3baed341. BUG=none R=dpranke@chromium.org, fdoray@chromium.org Change-Id: Iaba28fd35e1b7435392ea5d1194bdd5f477ce3b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187496 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#766547}
-
Ilya Sherman authored
This header is only sent to Google domains served over HTTPS, and only when the omnibox provider is in a non-default state. Bug: 1079341 Change-Id: Ic75978f337dc86f134943fe81f0f47bd7a1a5259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181663 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#766546}
-
Patrick Monette authored
This CL moves the factory functions of ServiceWorkerContainerHost for clients to ServiceWorkerContextCore, given that it's the owner of those hosts. This CL does not contain functional changes. Bug: 931087 Change-Id: Ie8fbed09c36e990996efe226d63ada0ef50ae4b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172162 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#766545}
-
Natalie Chouinard authored
Update the Preference title text style to use the Clank standard typography. The text size is the same, but there is a very slight color correction with this change (from #DE000000 to #202124). Bug: 1077340 Change-Id: I776f7d5820b2798f5295cc5869a9d105d2f92176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2180852Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#766544}
-
Clark DuVall authored
This allows overriding it in gn args, which is necessary to use the correct WebView target on official bots. Bug: 1054351 Change-Id: I7564595657490faba7b18c9bcc55ede21d3bffc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187858Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#766543}
-
Thomas Lukaszewicz authored
Fixes a regression from http://crrev.com/1925340 , which changed the toggled color for check and radio buttons to use kColorId_ButtonEnabledColor instead of kColorId_ProminentButtonColor. On linux GTK toggled check and radio buttons are expected to use the prominent button color. Added a checked color id to allow for platform differences. Bug: 1057942 Change-Id: Ib14bf40eaf7a895ddebc9c2b670bd50273fbd4dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185569Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#766542}
-
dpapad authored
Specifically: - Fixing several type violations and adding JS type checking for - test_site_settings_prefs_browser_proxy.js - test_local_data_browser_proxy.js - test_util.js - Removing usage of mockMethods() from TestSiteSettingsPrefsBrowserProxy, as this pattern is incompatible with static type checking. - Updating various js_library() targets with missing dependencies as needed. Bug: 1000989 Change-Id: I6b6924804ac96b048c6bde98e0101a7e90b4472a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2183015 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#766541}
-
Kyle Horimoto authored
Generated by running a script to parse go/cros-settings-search-tags. This CL also migrates AboutHandler to this section and eliminates the static Create() function which creates the handler as well as adding loadTimeData. The loadTimeData is moved to AboutSection as well as settings_localized_strings_provider.cc, and several strings which were unused by browser settings are now only added to OS settings instead of to both. Bug: 1076268 Change-Id: I6ea6ce914533166851a51c3d2771f3f9d72d3a07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185850 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#766540}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/668e41db73f4..4890aa6fee2a git log 668e41db73f4..4890aa6fee2a --date=short --first-parent --format='%ad %ae %s' 2020-05-07 duongn@microsoft.com [wasm] Disallow setting breakpoints on unbreakable lines in WAT 2020-05-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@4890aa6fee2a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1043033 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8bedb2fd22012fb304ab1df4bf154ad446a62e21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188371Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#766539}
-
Daniel Libby authored
This is a reland of d0e6eeab Original change missed Win7 baseline updates as I forgot to run that bot. PS1 has the original change, PS4 includes Win7 baseline updates. Original change's description: > Allow DirectlyCompositedImages with filters > > crrev.com/c/2144398 added support to the cc compositor to directly > composite images (raster at intrinsic image size when it is the only > thing painted into a layer). That initial change excluded any layers > that had backdrop filter or filter effects, following limitations of > the Blink implementation of the feature. > > This change removes those exclusions, and updates the baselines for > affected layout tests. > > Bug: 875110 > Change-Id: I63eb466fdc535c14b10babb2831556ae4f30f61a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151476 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Daniel Libby <dlibby@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#765771} Bug: 875110 Change-Id: I58d33675e5c731e597a301eeec76892f6a127ad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186118Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#766538}
-
Filip Gorski authored
Bug: 1077430 Change-Id: I162638854e01353c3e6c20675f47aa008f000c1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187194Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#766537}
-
Scott Violet authored
When the non-editable view is clicked, clear the text in the non-editable view and focus it. Clearing the text is useful as it's entirely possible the url is out of date at this point. Focusing makes it so you can type right away. BUG=none TEST=none Change-Id: I73631ff68f8377c0ebc7ba897f0624f6698efb3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186368Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#766536}
-
Miguel Casas authored
This CL simplifies and streamlines the vaapi_unittest main() function, so that it implements the expected command line parsing From crbug.com/1075843#c10: > Args like "--test-launcher-summary-output", "--test-launcher-retry-limit", > and "--test-launcher-batch-limit" better integrate a test into chrome's > CQ. Those things let us track the performance of individual tests over > time (flakiness, runtime) and lets us be smarter about automatic retries. Verified on my kohaku. Bug: 1075843 Change-Id: Ib6fe724ddd21ec802bf3a6c2ebe63aaf4cd5b305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186365Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#766535}
-