- 23 Aug, 2010 40 commits
-
-
jcivelli@chromium.org authored
Also making window.focus() select tab if it is not visible. The RenderViewHost now calls ActivateContent and the new DeactivateContent (instead of using the recently added TabContentsDelegate::Activate/Deactivate methods which have been removed). BUG=29643,52346 TEST=Create a page with buttons that call window.focus()/blur() directly and with a timeout. When called directly, the calls should succeed (the browser should be activated/deactivated). When called with a timeout, nothing should happen. Also test that a popup calling window.opener.focus() cause the opening tab to become selected when it is not the current tab. Review URL: http://codereview.chromium.org/3156016 TBR=jcivelli@chromium.org Review URL: http://codereview.chromium.org/3201008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57105 0039d316-1c4b-4281-b951-d872f2087c98
-
willchan@chromium.org authored
This reduces the unnecessary NetLog spam, since we would log to the NetLog everytime we created the backup ConnectJob, even though we usually wouldn't actually call Connect() on it. Now, we only create the backup ConnectJob when we intend to call Connect() on it. Includes some various cleanup necessary for this: * struct Group => class Group * method_factory moves from CSP to Group Review URL: http://codereview.chromium.org/3171017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57100 0039d316-1c4b-4281-b951-d872f2087c98
-
mirandac@chromium.org authored
Reworked Avi's patch for master prefs implemented on mac (http://codereview.chromium.org/2903014/show), so that it will work with new first run sequence on Windows and Mac. BUG=44901 TEST=in bug Review URL: http://codereview.chromium.org/3148001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57099 0039d316-1c4b-4281-b951-d872f2087c98
-
derat@chromium.org authored
I am concerned about the possibility that other users of the files in Chrome's base/ directory (e.g. Chrome OS) may build a library from these files with NDEBUG defined and then link it into a binary that includes the headers without defining NDEBUG, or vice versa. This change mangles InitLogging()'s name in logging.h based on whether NDEBUG is defined so that linking will fail if there's a mismatch (Evan provided useful advice here). BUG=chromium-os:1124 TEST=built Debug and Release Chrome, built all Chrome OS packages, and then changed a Chrome OS package that links against libbase.a to define NDEBUG and checked that it failed to link Review URL: http://codereview.chromium.org/3106032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57098 0039d316-1c4b-4281-b951-d872f2087c98
-
csilv@chromium.org authored
BUG=52520 TEST=Verify metrics are saved when changing options in dom-ui options window (--enable-tabbed-options). Review URL: http://codereview.chromium.org/3190004 TBR=csilv@chromium.org Review URL: http://codereview.chromium.org/3119038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57096 0039d316-1c4b-4281-b951-d872f2087c98
-
dhollowa@chromium.org authored
Expands size of labels in AutoFillCreditCardSheet.xib to accommodate for longer Japanese localized strings. Shifts text entry boxes to the right accordingly. BUG=52767 TEST=none Review URL: http://codereview.chromium.org/3164030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57095 0039d316-1c4b-4281-b951-d872f2087c98
-
jcivelli@chromium.org authored
Also making window.focus() select tab if it is not visible. The RenderViewHost now calls ActivateContent and the new DeactivateContent (instead of using the recently added TabContentsDelegate::Activate/Deactivate methods which have been removed). BUG=29643,52346 TEST=Create a page with buttons that call window.focus()/blur() directly and with a timeout. When called directly, the calls should succeed (the browser should be activated/deactivated). When called with a timeout, nothing should happen. Also test that a popup calling window.opener.focus() cause the opening tab to become selected when it is not the current tab. Review URL: http://codereview.chromium.org/3156016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57094 0039d316-1c4b-4281-b951-d872f2087c98
-
csilv@chromium.org authored
BUG=52520 TEST=Verify metrics are saved when changing options in dom-ui options window (--enable-tabbed-options). Review URL: http://codereview.chromium.org/3190004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57093 0039d316-1c4b-4281-b951-d872f2087c98
-
chase@chromium.org authored
This looks like a local system change after a reboot since t_ref changed, too. BUG=none TEST=xpdual/moz is green TBR=nsylvain@chromium.org Review URL: http://codereview.chromium.org/3190015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57091 0039d316-1c4b-4281-b951-d872f2087c98
-
rkc@google.com authored
ShowSingletonTab considers only base URL's as unique; adding a /path opens another tab despite one being present at the base URL; changing the path to a ref fixes it. Review URL: http://codereview.chromium.org/3155038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57090 0039d316-1c4b-4281-b951-d872f2087c98
-
thomasvl@chromium.org authored
BUG=52858 TEST=greener tree Review URL: http://codereview.chromium.org/3201007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57089 0039d316-1c4b-4281-b951-d872f2087c98
-
rohitrao@chromium.org authored
This change should be reverted as soon as we figure out what's going wrong. BUG=52918 TEST=None Review URL: http://codereview.chromium.org/3197012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57088 0039d316-1c4b-4281-b951-d872f2087c98
-
dmaclach@chromium.org authored
BUG=20868 TEST=manual Review: http://codereview.chromium.org/3158026 Review URL: http://codereview.chromium.org/3158026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57087 0039d316-1c4b-4281-b951-d872f2087c98
-
pinkerton@google.com authored
BUG=34644 TEST=Open options window, move and close the window, re-open and ensure position is saved. Contributed by Steven Pennington <spenn@engr.uvic.ca> git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57086 0039d316-1c4b-4281-b951-d872f2087c98
-
tbarzic@google.com authored
Code implements UI for downloading and burning Chrome OS images on SSD card and USB key. Actual burning is not included in the change list. BUG=chromium-os:5346 TEST=type in chrome://imagebuner in browser. UI lists all media that image can be burnt to. After selecting burning target by clicking an image right to the target name, image download should start, and download progress should be displayed. After download ends alert should pop up asking user to confirm that he wants to burn image to selected device. Clicking both ok or cancel shouldn't do anything, since actual burning isn't stil included in CL. Image should be downloaded to chrome_image folder in users Downloads directory. this folder is deleted during shutdown. This is only visible in ChromeOS... Review URL: http://codereview.chromium.org/2808100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57085 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
The source files live in chrome/common, and they're there because we need to get at version infomation all over the product (not just from the exe, like the gyp files are currently written). This refactoring is necessary for a follow-up change. TEST=compiles Review URL: http://codereview.chromium.org/3113026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57084 0039d316-1c4b-4281-b951-d872f2087c98
-
rvargas@google.com authored
to cover external files. We now keep a variable-size buffer and use it even after we know that the data is not going to be stored by a block-file. The backend keeps track of the total memory used by all entries and prevents that value from going over a max value that depends on the total memory available. This CL removes the tests that were checking the synchronous operation of sparse IO because that model is no longer supported by the public API, and this CL would add complexity to them (they fail due to thread safety concerns). BUG=6626 TEST=net_unittests Review URL: http://codereview.chromium.org/3167020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57082 0039d316-1c4b-4281-b951-d872f2087c98
-
gman@chromium.org authored
I probably need more tests but in order to test I need to figure out how to init the system with different caps enabled from the unit tests and that's probably not a small amount of work so leaving that till later. TEST=some unit tests, ran conformance tests BUG=none Review URL: http://codereview.chromium.org/3122033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57081 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
BUG=None TEST=Load DOMUI options, go to another page, load DOMUI options again, and manage search engines; the table should not be empty. Review URL: http://codereview.chromium.org/3116023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57077 0039d316-1c4b-4281-b951-d872f2087c98
-
cbentzel@chromium.org authored
--auth-schemes should be a command separated list containing one or more of the following schemes: basic, digest, ntlm, or negotiate. This will primarily be used to help triage user-reported bugs. BUG=None TEST=specify --auth-schemes and ensure that only the specified schemes are supported. Also, when unspecified all schemes should be supported. Review URL: http://codereview.chromium.org/3199002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57073 0039d316-1c4b-4281-b951-d872f2087c98
-
fgalligan@chromium.org authored
BUG=52594 TEST=Play a WebM file in debug Chrome build and renderer should not crash. Review URL: http://codereview.chromium.org/3189013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57070 0039d316-1c4b-4281-b951-d872f2087c98
-
dhg@chromium.org authored
BUG=chromium-os:5956 TEST=none Review URL: http://codereview.chromium.org/3146030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57068 0039d316-1c4b-4281-b951-d872f2087c98
-
viettrungluu@chromium.org authored
BUG=none TEST=I can't be bothered Review URL: http://codereview.chromium.org/3137031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57067 0039d316-1c4b-4281-b951-d872f2087c98
-
alyssad@google.com authored
New pyauto functional test for translate on history and downloads pages. Review URL: http://codereview.chromium.org/3109017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57065 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
appropriate) to use it. Hopefully this will help isolate why tests are failing on bot. BUG=none TEST=none; test only change. Review URL: http://codereview.chromium.org/3117030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57064 0039d316-1c4b-4281-b951-d872f2087c98
-
levin@chromium.org authored
This is to avoid a deadlock on Windows. It will be replaced by a handler on the I/O thread in a subsequent patch. BUG=38475 TEST=None Review URL: http://codereview.chromium.org/3142029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57063 0039d316-1c4b-4281-b951-d872f2087c98
-
levin@chromium.org authored
BUG=None TEST=unit_tests --gtest_filer=TemplateURL*.* Review URL: http://codereview.chromium.org/3161038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57062 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
Stuart fixed this in http://codereview.chromium.org/2147002 and I regressed it in http://codereview.chromium.org/3010054 Note that the reduced testcase on the bug is still broken. Since it's broken in Safari too, that's a WebKit problem. BUG=52914,51748 TEST=See bug Review URL: http://codereview.chromium.org/3125033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57061 0039d316-1c4b-4281-b951-d872f2087c98
-
dpolukhin@chromium.org authored
BUG=chromium-os:5762, chromium-os:5761 TEST=Enter wrong password on Chrome OS login screen. Review URL: http://codereview.chromium.org/3201003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57060 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
BUG=none TEST=none http://codereview.chromium.org/3107030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57059 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
BUG=52593,51748 TEST=Right-click a youtube video. Should get context menu. Review URL: http://codereview.chromium.org/3117035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57058 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
NO CODE CHANGE. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57057 0039d316-1c4b-4281-b951-d872f2087c98
-
mbelshe@chromium.org authored
no longer needed. (I thought we had a warning for that?) BUG=none TEST=none Review URL: http://codereview.chromium.org/3199013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57056 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57055 0039d316-1c4b-4281-b951-d872f2087c98
-
rkc@google.com authored
Review URL: http://codereview.chromium.org/3122034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57054 0039d316-1c4b-4281-b951-d872f2087c98
-
denisromanov@chromium.org authored
BUG=chromium-os:2265 TEST=Make and run out/Debug/browser_tests Review URL: http://codereview.chromium.org/3130044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57053 0039d316-1c4b-4281-b951-d872f2087c98
-
allanwoj@chromium.org authored
Location provider using the MAC address of a router the user is connected to via Ethernet to find a position fix. BUG=NONE TEST=Unit test Review URL: http://codereview.chromium.org/3153031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57052 0039d316-1c4b-4281-b951-d872f2087c98
-
dmazzoni@chromium.org authored
encoded strings. BUG=none TEST=Added new unit tests for each. Review URL: http://codereview.chromium.org/3133028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57051 0039d316-1c4b-4281-b951-d872f2087c98
-
thomasvl@chromium.org authored
TBR=thestig TEST=none BUG=53076 Review URL: http://codereview.chromium.org/3142031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57050 0039d316-1c4b-4281-b951-d872f2087c98
-
rolandsteiner@chromium.org authored
BUG=53073 TEST=see list Review URL: http://codereview.chromium.org/3130046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57049 0039d316-1c4b-4281-b951-d872f2087c98
-