- 18 Sep, 2020 40 commits
-
-
Xiaocheng Hu authored
Previous implementation only parsed percentage values for these descriptors, and treated 'normal' as a parse error. This patch allows descriptors ascent-override, descent-override and line-gap-override to parse their initial value 'normal' without triggering a parse error. Bug: 1098355 Change-Id: I5fc8ddaa0574becf6f8aa21e7c4df6b299f35533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415226 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#808537}
-
Josh Nohle authored
Ensures test coverage for active CryptAuth v2 DeviceSync field trial. See https://chromium.googlesource.com/chromium/src.git/+/master/testing/variations/ The change was made due to a Finch warning in cl/331561231. Bug: 951969 Change-Id: I62e19971aa831216056e79e1b543022b5148df7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410745 Auto-Submit: Josh Nohle <nohle@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#808536}
-
Regan Hsu authored
We are adding 3 new wallpaper apps, but this causes the "My Images" category to not be shown. This CL shrinks the margin between category list items so that all wallpaper categories in the list will be shown upon opening the app. https://screenshot.googleplex.com/h4QERzczpze5qK9 Fixed: 1129959 Change-Id: I631e28b6123804461794664d6ae37cd090ce5268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419003Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#808535}
-
Darwin Huang authored
On the clipboard, MozUrl and Filename ClipboardFormatTypes are only really used on Windows. Restricting this allows us to delete some code, and make it more clear where these formats are (and are not) used. Change-Id: Iead2dcac183147b3b6285f9a546e3a7e3f9d94a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413396 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#808534}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/03fd7930c651..788480dcff70 2020-09-18 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 86ce521c..4ed1b071 (808263:808365) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9aedc96315aa48b82559b721884b8730826f594f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419452Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808533}
-
Elly Fong-Jones authored
This change also adds two unit tests for the feedback log-gathering code: a cross-platform one that tests the basic mechanics using a key that is always present, and a Mac one that tests that the value of cpu_arch is exactly one of the three values approved by privacy review. TEST=Manual On a Mac, navigate to chrome://system and check for a "cpu_arch" key. Bug: 1126503 Change-Id: Ibed7da188eff7902038815140375d9990e4211c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419120 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#808532}
-
Daniel Cheng authored
Change-Id: I2fce37aa90b6f307b56c31f30e32e74fb32e9f09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414571Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#808531}
-
Tina Wang authored
Bug: 1113353 Change-Id: Ib14715fd050517e6099b0532bb31b829065a8951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416938Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#808530}
-
chinsenj authored
Desk renaming is inconsistent with other renaming patterns. This CL aims to make it consistent and improve it as well. It makes the following changes: - Change background color on hover. - Give desk_name_view a minimum width. - Add border when textfield is focused. - Make desk_name_view variable length so it changes size with respect to the current desk name. Test: Manual Bug: 1127498 Change-Id: I602a43146692eecb1b8dd1a0b624fd3f4f1cee65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406282Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Cr-Commit-Position: refs/heads/master@{#808529}
-
Adrienne Walker authored
Change-Id: Ic4638fce166a6a5e42c2fd02e82eec20adca52f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419408 Commit-Queue: enne <enne@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#808528}
-
Scott Violet authored
makes LimitAImageReaderMaxSizeToOne not create unnecessary std::strings and moves setting is_supported_ to member initializer list. BUG=none TEST=none Change-Id: I7e7acd9996d8e7594a70382a47aa0a27209d2494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419112Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#808527}
-
Colin Blundell authored
WebLayer Shell listens for notifications that the active tab was changed and updates the favicon of the active tab in response. However, when the active tab is removed WebLayer sets the active tab to null, which also causes an onActiveTabChanged(null) notification to be sent (cf. [1]). WebLayerShellActivity does not currently guard against this case (cf. [2]), resulting in a crash. One way to trigger this crash is to open a tab via a navigation that results in an intent launch, which will then cause the tab to be closed. Concrete example: On a device/emulator with the Play Store installed, go to booking.com and click on the Install icon. This will open a new tab for a navigation that results in an intent out to the play store, upon which WebLayer closes the newly-opened tab and the onActiveTabChanged(null) callback is sent. [1] https://source.chromium.org/chromium/chromium/src/+/master:weblayer/browser/browser_impl.cc;l=403?q=browser_impl.cc&ss=chromium [2] https://source.chromium.org/chromium/chromium/src/+/master:weblayer/shell/android/shell_apk/src/org/chromium/weblayer/shell/WebLayerShellActivity.java;l=697?q=WebLayerShellActivity.java&ss=chromium Bug: 1128607 Change-Id: I787824deeb4a3fea49f52f430c6523bed5258f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414399 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#808526}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1600408803-f0e40d48b8629d1086dbcdc0a0535ae545c69485.profdata to chrome-mac-master-1600451996-a3f5003485801b4281790ccd12c8c92cfb8c34e9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: Ie6f363d3de29c3af68382a1e02e39ca91f241232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419453Reviewed-by:
-
Fabian Henneke authored
Since Android Q, views that are labeled with importantForAutofill=no can still trigger the augmented Autofill service. If this happens, no ordinary Autofill requests will be triggered anymore for as long as the Autofill session remains active. This prevents the user-configured Autofill service from running on web contents if the user's first interaction is with the URL bar. This issue is resolved by canceling the current Autofill session when the URL bar loses focus. R=dmazzoni@chromium.org, michaelbai@chromium.org Bug: 1103555 Change-Id: If06c15f4c397107c284c4de757f58c3aeb939cf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302636Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
-
Natalie Chouinard authored
Modify the AndroidFontLookup interface and implementation to make the request to fetch the list of "available" fonts to be synchronous. Rather than constructing a list of fonts available on device, this now returns a list of fonts expected (but not guaranteed) to be available on device. If a font fetch request fails for a particular font, it will be removed from this list (stored in memory). This list is still expected to be sufficient to prevent too many unnecessary renderer IPC requests (which will be confirmed with metrics), but is faster to generate, allowing us to make this method synchronous. Also add metrics to track time for the GMS font request only. Bug: 1111148, 1127478 Change-Id: Ie0b1243d81496a975fe3b0db24e8534a02b17f38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414514 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#808523}
-
Guillaume Jenkins authored
The virtual/omt-worker-fetch/external/wpt/xhr/ xhr-timeout-longtask.any.worker.html test is consistently failing on Mac with the following error: "xhr-timeout-longtask.any.worker.html is a all-pass testharness test, but has an extra baseline file. Please remove [the baseline file]." Based on that message, this change removes the baseline file. Bug: 1129910 Change-Id: Ia4462140d9efbc86b12cf679170bd6f5ee26e42a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418985Reviewed-by:Aleks Totic <atotic@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#808522}
-
Erik Chen authored
These tests only run on Linux, not on ChromeOS devices. Change-Id: If22d19f0cdcb95efd412d7c099df05361413350f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419007 Commit-Queue: Erik Chen <erikchen@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#808521}
-
Hai Bi authored
In addition to reboot reason, we also need to know if the component has restarted either gracefully or ungracefully. Currently this only applies to Fuchsia. bug: b/168066307 Test: Added unit test Change-Id: Ib0d4882396ce75aae305f0cf42f779343793911c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399132 Commit-Queue: Hai Bi <bihai@google.com> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#808520}
-
Erik Chen authored
X11 includes should be guarded by USE_X11, not OS_LINUX. Change-Id: I4a5e666bbb01ddb41861d26b9cf999c8cc1e08a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419006 Commit-Queue: Erik Chen <erikchen@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
-
Manuel Rego Casasnovas authored
NGPhysicalFragment::ScrollableOverflowForPropagation() had an important different compared to LayoutBox::LayoutOverflowRectForPropagation() as it was not including the border box when computing the overflow for propagation. This was causing issues in some cases calculating the overflow of replaced elements in LayoutNG, legacy was working fine. This patch changes AdjustScrollableOverflowForPropagation() to also include the element's border box. Note that we cannot do this for ruby boxes as they have some special behavior (see crbug.com/1082087 and r784709 for details). We need new rebaselines for the following test fast/replaced/border-radius-clip.html This is because when you scroll down you can see the border of the embed object (which was hidden before). BUG=1128984 TEST=css/css-overflow/overflow-replaced-element-001.html Change-Id: I038ccb46db7e00a922e33a387cf10e3c805b81c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414313Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#808518}
-
My Nguyen authored
Strings approved in http://go/cros-lang-settings-ux-writing Currently search by countries isn't supported yet, so removing it from the placeholder Allow customising cr_search_field's search input width to allow for longer placeholder. Mock: http://go/cros-lang-settings-ux-slide#slide=24 Current view: http://screen/8xKZWAVmwCA7Rit Bug: 1113439 Change-Id: I4a8c05c5b0e35df020275145ee32c827d7d27817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416211Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
dpapad authored
- Add aria-label and title attributes were missing. - Fix incorrect aria-label$=... assignments where no Polymer bindings are involved. Bug: 1123470 Change-Id: I0d6c33c9338a1494d47e249bd71885f4614566fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418471 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#808516}
-
Matthew Denton authored
The syscall broker has unittests in //sandbox/linux/syscall_broker/broker_process_unittest.cc, but these test direct IPC to the broker, and don't use a BPF policy and so aren't integration tests. This CL adds a suite of integration tests that mirror the unittests. This makes it easier to test the user notifier syscall broker, which is even more in need of integration tests since the kernel itself sends the syscall arguments to the broker, rather than a custom signal handler. The integration tests use a new macro BROKER_TEST, built on top of the existing BPF_TEST and SANDBOX_TEST infrastructure. It runs each test with each combination of |fast_check_in_client_| = (true, false), and method of making a syscall (direct IPC, direct syscall, libc lib functions). Bug: 1117351 Change-Id: If1c050f55722487fea51cb479558916983c44985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360802 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#808515}
-
Jimmy Gong authored
MessageSender is responsible for sending serialized proto messages to the remote device. Bug: 1106937 Test: unit_tests Change-Id: I6caa3c77c34b7437ea6798ab680411aa0697ee74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415371 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
-
Ankit Kumar 🌪️ authored
Replace usage of PP_Point to gfx::Point in test files. Bug: 1101101 Change-Id: I1f7031e5b1845e0c8f063f3bfbcee877ff591c15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413689 Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by:K. Moon <kmoon@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#808513}
-
Christopher Cameron authored
Retrieve the IOSurface backing a CVPixelBuffer and, if it exists, construct a GpuMemoryBufferHandle to send via OnIncomingCapturedExternalBuffer. Bug: 1125879 Change-Id: I541285d6ccf08d71c93bc29cce2ed39f00c34cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412994Reviewed-by:
Markus Handell <handellm@google.com> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#808512}
-
Behdad Bakhshinategh authored
This reverts commit 5f450a37. Reason for revert: Build went green before suppression was needed. Original change's description: > Suppress timed out test (browse:news:washingtonpost) > > Skip system_health.memory_mobile/browse:news:washingtonpost:2019 to prevent time out on android-go > > TBR=jonross@chromium.org > > Bug: 1129885 > Change-Id: I8c6a6dd0e17a2256a0acee15d60dc8a9b154bd5d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418321 > Reviewed-by: Behdad Bakhshinategh <behdadb@chromium.org> > Reviewed-by: Jonathan Ross <jonross@chromium.org> > Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808488} TBR=jonross@chromium.org,behdadb@chromium.org Change-Id: I3a205cbe1d3e3b239564d308d670a694031e2759 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1129885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419571Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#808511}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600430187-d29b7adeb10d561801760f89eec79cec9539af2e.profdata to chrome-linux-master-1600451996-5d0e4e7b2c6ce44a4ee6fbde79bf678531b4af8e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: Idf1f417b0359c7893a068374c3e8016975ced0d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419455Reviewed-by:
-
Dave Tapuska authored
Agent Clusters can be different even if the origins are the same. BUG=961448 Change-Id: I1cfc8d7c386735b6c718ba6da5d932d5b459980d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416263 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#808509}
-
Mehran Mahmoudi authored
This CL will change the current startup behaviour for FDT. Instead of blocking the tab restoration and initializing the FDT, we'll do both in parallel. Bug: 1129478 Change-Id: I0b4adc42960434ae38d62cb9fa763f94ae9ad14e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416929 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
-
Jao-ke Chin-Lee authored
As part fixing washed out colors due to changes to a combination of chromaticity and luminosity changes, color spaces were pinned to sRGB for SDR content instead of using the full native color space to boost saturation. Now that other fixes have stabilized the situation, use the native color space. Bug: b:158126931 Change-Id: I57140d31897a3aaf5d8a4debeff99e4db5ea76d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415269 Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#808507}
-
Akihiro Ota authored
Bug: 1127037 Change-Id: Icde8546beba54334b08a2a6af1ea49b3824a5ac2 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406542Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#808506}
-
danakj authored
This causes v8 to crash, instead we pass no 3rd argument at all, which it will handle gracefully as an undefined. R=ishell@chromium.org Bug: 1093391 Change-Id: I1fdfe64bef348062495e2d5d6db940f36f2db982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419141Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/c01b26490a54..1da25e510364 2020-09-18 cwallez@chromium.org Add -Wduplicate-enum and -Wrange-for-analysis If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Id62c96aa95be764071c1388f59237f1ea41ffb1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419242Reviewed-by:
-
Fabrice de Gans-Riberi authored
This reverts commit dcefb79d. Reason for revert: Broke win-archive-rel https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/17700 Original change's description: > Roll DevTools Frontend from eed20333dd52 to b3859e8d65e6 (4 revisions) > > https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/eed20333dd52..b3859e8d65e6 > > 2020-09-18 tvanderlippe@chromium.org Reland "Remove support for remote modules" > 2020-09-18 andoli@chromium.org [ts] Typecheck components/ImagePreview.js with TypeScript > 2020-09-18 aerotwist@chromium.org Adds remote base helper > 2020-09-18 tvanderlippe@chromium.org Typecheck mobile_throttling/ThrottlingSettingsTab.js with TypeScript > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/devtools-frontend-chromium > Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Bug: chromium:1011811 > Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com > Change-Id: Icb5d63b8951ec5e54dedc1c8fe8e4580fcfd9877 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419248 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#808487} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6438356ecd6b02352eda3d5552072bae1ce05615 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1011811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418803Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#808503}
-
Ben Pastene authored
include_unwind_tables was removed from this bot a while ago when binary size metrics were spun up for fear that the tables would inflate the binaries. However, we don't actually ship linux-chromeos binaries, so their size metrics aren't very representative. Plus, the lack of the tables makes sheriffing more difficult since test failures won't produce full stack traces. Adding the tables back to the bot should make sheriffing it easier. Bug: None Change-Id: I67e042dfd1640d014fad62b741966ee211bb557f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419002Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#808502}
-
Sunny Sachanandani authored
This pixel test relies on using a raw YUV file in the Chromium checkout for the fake video capture device. This doesn't work when the test runs on another device than the test harness like for Android and ChromeOS. TBR=zmo@chromium.org,behdadb@chromium.org Bug: 1129879 Change-Id: Iaf0d410d7a83ea06c9add4696ee4ad7de8794d3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419334Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
-
Paul Moy authored
Expose a new routine through cros_healthd's ServiceConnection. This routine runs memtester on all of the device's available memory (except for 200MB reserved for the OS) to check that the device's memory is working correctly. The routine is modeled after crosh's memory_test. Long-term, crosh's memory_test will be migrated to this new implementation. The migration is blocked on cros_healthd becoming available on all boards, which should be done in a couple of weeks. This is part of an effort to consolidate all existing diagnostic routines into cros_healthd. Bug: chromium:1113897 Change-Id: I3bb25c1f04c1394e541af9c3c9ef66b8ae6ecd7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412956Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Paul Moy <pmoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#808500}
-
Daniel McArdle authored
net_backoff_entry_serializer_fuzzer found a test case that causes the second deserialize step in TestDeserialize() to fail. We CHECK that the return value is truthy, but it is nullptr. Prior to this CL, BackoffEntrySerializer::DeserializeFromValue() would return nullptr when the parsed absolute release time was negative. There are two reasons for removing this less-than-zero comparison: (1) It complicates the fuzzer's logic for predicting the return value. (2) The value comes from TimeBase::ToInternalValue(). We should not assume we understand the internal representation of a time value. Bug: 1113344 Change-Id: I1e1e9d5a422d116e2f9682bab42b2acefb5a0fe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398902 Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by:Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#808499}
-
Marc Treib authored
The commandline param --gaia-config allows specifying a json file that overrides various Gaia-related URLs. This CL adds support for overriding the Sync URL via the same file. Bug: 1129493 Change-Id: Ieb1fee4b32f247acb69fde659c2c0c9564bcb130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418334Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#808498}
-
