GitLab

BUG=265583

Review URL: https://codereview.chromium.org/598533004

Cr-Commit-Position: refs/heads/master@{#296513}

When verifying that the cached doodle is still valid, we load the doodle
URL and append the query param "async=es_dfp:<fingerprint>". Previously,
the ":" was being escape to "%3A", causing the server to respond with a
400 error. This mollifies the server by keeping the colon unescaped.

BUG=413845

Review URL: https://codereview.chromium.org/587943003

Cr-Commit-Position: refs/heads/master@{#296512}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3bcf32e..a8890fa

TBR=pdr@chromium.org,wjmaclean@chromium.org,ager@chromium.org

Review URL: https://codereview.chromium.org/604493002

Cr-Commit-Position: refs/heads/master@{#296511}

When creating a MediaPlayer, pass the initial CDM value, if there
is one. This may happen if setMediaKeys() has been called before
the MediaPlayer object is needed. The initial CDM value may be null.

BUG=358271
TEST=existing EME tests still pass

Review URL: https://codereview.chromium.org/594713002

Cr-Commit-Position: refs/heads/master@{#296510}

NOTRY=true

Review URL: https://codereview.chromium.org/600953002

Cr-Commit-Position: refs/heads/master@{#296509}

This moves SafeManifestParser to extensions_browser.
Also creates a new ExtensionUtility IPC message class in which
to define extensions utility process messages. The relevant
manifest parsing messages have been moved into this class.

BUG=398671

Review URL: https://codereview.chromium.org/464613002

Cr-Commit-Position: refs/heads/master@{#296508}

Tighten the directional comparison for fling accumulation, preventing
perfectly orthogonal flings from accumulating. Also adjust Android's
ContentViewScrollingTest#testFling integration test to scale the
fling by the device scale factor, ensuring consistent results all
all displays.

BUG=406848

Review URL: https://codereview.chromium.org/602873002

Cr-Commit-Position: refs/heads/master@{#296507}

Ozone compiles with USE_AURA=1 TOOLKIT_VIEWS=0 which cases compile
errors due to missing member functions ShowDisambiguationPopup
and HideDisambiguationPopup.

BUG=none
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/596373002

Cr-Commit-Position: refs/heads/master@{#296506}

Added checks for missing arguments in event_sender.cc. Also simplified the uses of x & y in EventSender::GestureEvent.

BUG=415970

Review URL: https://codereview.chromium.org/584203003

Cr-Commit-Position: refs/heads/master@{#296505}

When bookmarks experiment is enabled existing code will add a command line flag that will allow opt-out to be shown on a chrome:flags page.
On Chrome OS at time of login if they see command line flag from any experiment they restart browser. It creates delay and user will see a black screen for a couple seconds. It happens on every login, not only the first one.
I talked to CrOS devs and they strongly discourage from using command line flags.
So for Chrome OS only do not add flag to command line but still keep it in a flag_storage. Use flag storage when need to check if flag is set.

BUG=

Review URL: https://codereview.chromium.org/578333003

Cr-Commit-Position: refs/heads/master@{#296504}

Keeps the fetcher functionality as ImageFetcherImpl in chrome/browser/search/suggestions.

BUG=387751
TBR=blundell
TEST=ImageManagerTest,ImageFetcherBrowserTest

Review URL: https://codereview.chromium.org/543753002

Cr-Commit-Position: refs/heads/master@{#296503}

BUG=363590

Review URL: https://codereview.chromium.org/595423002

Cr-Commit-Position: refs/heads/master@{#296502}

BUG=416701

Review URL: https://codereview.chromium.org/602863002

Cr-Commit-Position: refs/heads/master@{#296501}

BUG=412126

Committed: https://crrev.com/01c68e8765254d9971296b291ff718b4f6af3004
Cr-Commit-Position: refs/heads/master@{#295591}

Committed: https://crrev.com/74c6ef17a08754abadb6fb64da14249898285fa8
Cr-Commit-Position: refs/heads/master@{#296107}

Review URL: https://codereview.chromium.org/565803002

Cr-Commit-Position: refs/heads/master@{#296500}

BUG=414808
TBR=maruel@chromium.org
NOTRY=true

Committed: https://chromium.googlesource.com/chromium/src/+/01b2eb0b5e291faa238d6a21def3e62056bc1fdd

Review URL: https://codereview.chromium.org/598053002

Cr-Commit-Position: refs/heads/master@{#296499}

This is a step toward to killing FileDescriptor.
This change lets FiileDescriptorSet have both Files (for owning fds)
and PlatformFiles (for non-owning fds). Doing this, we no longer
need FileDescriptor which provides |auto_close| flag.

BUG=415294
TEST=ipc_tests, ipc_mojo_unittests
R=agl@chromium.org, jam@hcromium.org, viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/583473002

Cr-Commit-Position: refs/heads/master@{#296498}

r1385: Linux: Call memset() in a couple places in ExceptionHandler.
r1386: IWYU in minidump_writer.cc to fix building with libc++.
r1387: Fix some nits raised by Timur for r1385.

Also remove Valgrind suppression Breakpad r1385 fixed.

BUG=332335

Review URL: https://codereview.chromium.org/601823003

Cr-Commit-Position: refs/heads/master@{#296497}

Keep track of the situations when Chrome expects the data reduction
proxy via header to be present in a response, but the data reduction
proxy via header is missing.

This change is the same as the reverted change
https://codereview.chromium.org/577343002/,
except that it includes a 1-line fix in
data_reduction_proxy_usage_stats_unittests.cc to make the tests pass
when run with Valgrind in release builds.

BUG=412888

Review URL: https://codereview.chromium.org/602503002

Cr-Commit-Position: refs/heads/master@{#296496}

BUG=414247

Review URL: https://codereview.chromium.org/597603003

Cr-Commit-Position: refs/heads/master@{#296495}

This changes the ExtensionWelcomeNotification to be its own keyed service,
which seperates it from the DesktopNotificationService.

BUG=

Review URL: https://codereview.chromium.org/580093003

Cr-Commit-Position: refs/heads/master@{#296494}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1216f1b..3bcf32e

TBR=pdr@chromium.org,wjmaclean@chromium.org,ager@chromium.org

Review URL: https://codereview.chromium.org/602833002

Cr-Commit-Position: refs/heads/master@{#296493}

Some devices remove cpu related files from /proc when the cores are
turned off. We assume the frequency is 0 if it's missing.

BUG=417259

Review URL: https://codereview.chromium.org/598093003

Cr-Commit-Position: refs/heads/master@{#296492}

Looks like  I made an error when I split the CL. I'll add a test in a separate CL.

BUG=None
TBR=mukai@chromium.org

Review URL: https://codereview.chromium.org/602843002

Cr-Commit-Position: refs/heads/master@{#296491}

BUG=415352

Review URL: https://codereview.chromium.org/575253003

Cr-Commit-Position: refs/heads/master@{#296490}

If the most recent profile is locked and the user uses the Windows
system tray to access the Task Manager or About Chrome, the user will
now first be presented with the User Manager, and only after selecting
or unlocking a profile will they be brought automatically to their
original destination.

BUG=409030
TEST=Enable --new-profile-management. Have at least one background app
running under your profile (e.g. Hangouts). Close Chrome. In the
system tray, Chrome ->Task Manager or About Chrome. Only after unlocking
your profile or opening a new profile, you'll see the original selection.

Review URL: https://codereview.chromium.org/564453003

Cr-Commit-Position: refs/heads/master@{#296489}

BUG=415100

Review URL: https://codereview.chromium.org/601883002

Cr-Commit-Position: refs/heads/master@{#296488}

BUG=318977

Review URL: https://codereview.chromium.org/598743002

Cr-Commit-Position: refs/heads/master@{#296487}

cc::Surface instances in the surface map have raw pointers to the
surface holder, so the holder needs to outlive the map.

BUG=417325

Review URL: https://codereview.chromium.org/603703002

Cr-Commit-Position: refs/heads/master@{#296486}

This eliminates the need for |ProxyMessagePipeEndpoint::Attach()|.

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/588193004

Cr-Commit-Position: refs/heads/master@{#296485}

BUG=352293

Review URL: https://codereview.chromium.org/595033002

Cr-Commit-Position: refs/heads/master@{#296484}

- Removed redundant output of the test command.
- Reduced the number of steps to three and wrote them as succintly as
  possible.
- Added the clarifying notes separately at the end.
BUG=404088

Review URL: https://codereview.chromium.org/596963002

Cr-Commit-Position: refs/heads/master@{#296483}

BUG=413846

Review URL: https://codereview.chromium.org/583883003

Cr-Commit-Position: refs/heads/master@{#296482}

BUG=411361

Review URL: https://codereview.chromium.org/589403006

Cr-Commit-Position: refs/heads/master@{#296481}

The old fake taskqueue just discarded all tasks. This of course
broke integration tests because refresh tasks never ran and the
in-memory memcache never got populated.

This changes the fake taskqueue so that it just executes
queued tasks immediately and synchronously.

BUG=None
TBR=kalman@chromium.org

Review URL: https://codereview.chromium.org/600073002

Cr-Commit-Position: refs/heads/master@{#296480}

When we reshow the find bar after dropping a tab into a new window,
-[BrowserWindowController layoutSubviews] is called which causes a relayout of
the tabs (without animation). In this case, a tab is in the beginning of being
animated to a new position and this relayout interrupted it by calling setFrame
on the tab view, but the tab frame ended up being the animator's target frame
instead of the relayout setFrame. This seems like an AppKit bug because it
behaves as expected on 10.9.

It is undesirable for layoutSubviews to force tabs relayout when the tap strip's
frame did not change, because it will interrupt tab animations in progress.
This change compares the old and new tab strip frame and skips tabs relayout
if the frame did not change.

BUG=415093

Review URL: https://codereview.chromium.org/593223002

Cr-Commit-Position: refs/heads/master@{#296479}

dbus::ScopedDBusError has inline constructor/destructor and
is_set() method that call into libdbus-1. By placing these
function calls in a header file, we add implicit link dependency
on components that need to use ScopedDBusError. If we move
them out to a .cc file, the dependency will be localized to
libchrome.

BUG=chromium:416628
TEST=dbus_unittests pass

Review URL: https://codereview.chromium.org/592793004

Cr-Commit-Position: refs/heads/master@{#296478}

ExtensionDownloader should be created via its factory so that all parameters
needed by the ping URL would be filled out properly.

BUG=416648

Review URL: https://codereview.chromium.org/595383002

Cr-Commit-Position: refs/heads/master@{#296477}

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/597043002

Cr-Commit-Position: refs/heads/master@{#296476}

This CL fixes a bug in commit b2454381 "Add new ExtensionManagement preference". The default value of IndividualSettings are supposed to be |default_settings_| instead of fallback value for each settings.
This bug was not exposed in unit tests since IndividualSettings contains only installation mode settings now.

BUG=177351

Review URL: https://codereview.chromium.org/593223003

Cr-Commit-Position: refs/heads/master@{#296475}

We can't call set_client on the main thread because that determines the thread
affinity of the SurfacePtr. Instead, we need to wait for the BindToClient
callback so we can bind the SurfacePtr on the impl thread.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/603663002

Cr-Commit-Position: refs/heads/master@{#296474}