GitLab

Bug: 
Change-Id: Ia5065ab6e878477732ef3bf8d38043205650090b
Reviewed-on: https://chromium-review.googlesource.com/598830Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Blake O'Hare <blakeo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491909}

This CL migrates all the remaining browser to renderer IPC messages.

Bug: 742682
Change-Id: I968d9c2f4898dd293fcb6941c746e1d20473f81f
Reviewed-on: https://chromium-review.googlesource.com/596107Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Chandan Padhi <c.padhi@samsung.com>
Cr-Commit-Position: refs/heads/master@{#491908}

Previously, user has no way to know what does the taken screenshot looks
like before opening the image. With this CL, user can know that because
the preview image is shown in the notification.
This improvement is included in MD notification mock (internal:
go/fuwow), but should also be useful in the existing style notification.

BUG=746194
TEST=manual

Change-Id: I566b15209b5a7c18b8c706117896c21dde728088
Reviewed-on: https://chromium-review.googlesource.com/580178
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491907}

I removed it in https://chromium-review.googlesource.com/c/590356 but I
need it in a new CL.

Also, don't delete the underlying PrefService when switching users
under mash. I now think it's better for the PrefService to be transiently
stale than to be null during the mojo service connection.

Bug: 752347
Change-Id: Ic35e9a250be04ae7e521fb56f82fb731bc0fb779
Reviewed-on: https://chromium-review.googlesource.com/601329Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491906}

Bug: None
Change-Id: Idda0bbb8d27813d3009d1cff367510f42e0a59fc
Reviewed-on: https://chromium-review.googlesource.com/599148Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491905}

This allows the memory-infra UKMs to correctly report the URL of the root frame
for each process, since there is no way to report multiple URLs [for child
frames].

Bug: 730783
Change-Id: I342b3a76d543c8f9e4b0e2edc34f88d331e8b4e1
Reviewed-on: https://chromium-review.googlesource.com/601164
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Oystein Eftevaag <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491904}

The setup of these tests should not be testing for speech. Instead
if speech doesn't work, the test cases will catch it.

Bug: 742592
Change-Id: I656a40ae8a304ac1161941929d88409aacc144ae
Reviewed-on: https://chromium-review.googlesource.com/599590
Commit-Queue: Doug Turner <dougt@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491903}

Building with clang-cl's PRINTF_FORMAT checking experimentally enabled
found a few dozen warnings and a few real bugs, including this
platform-specific format-string mismatch. Printing a wchar_t* string
with %s will always give incorrect results so it's not clear why this
was never noticed - I guess the debug_name is normally ignored.

TBR=pastarmovj@chromium.org
BUG=751171

Change-Id: Ia2f7ca15a89c6d6a4606139b7d874c0aa1be8fc4
Reviewed-on: https://chromium-review.googlesource.com/596618Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491902}

changes:
Regression comes from https://chromium-review.googlesource.com/c/585398
where each SearchResultTileItemView is paint to layer, so that its
opacity can be controlled. In folder view, we don't layout suggestions
container view. Thus, it is better to make suggestions container view
paint to layer.

Test: test that bug is fixed
Bug: 743180
Change-Id: Idb6151e1d58ed7265741ac4ab2c663f0a081bded
Reviewed-on: https://chromium-review.googlesource.com/599456
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491901}

locking screen

changes:
Make hiding non lock screen containers immediately for suspend imminent
induced locking screen. This will prevent the possibility of peeking the
glimpse of unlocked screen if we close/reopen lid quickly.

Also added test coverage:
--gtest_filter=PowerEventObserverTest.NonLockScreenContainersHideAnimation

Test: tested on device, bug is fixed.
Bug: 751908
Change-Id: I39ab6f8b69c1c7632c4e1d4d502b704ea61f6aa6
Reviewed-on: https://chromium-review.googlesource.com/601090
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491900}

This CL mirrors the changes in cl/163544060

Bug: 735742
Change-Id: I39ce72c38f37e2b61eafbe84d1ec431f7782382e
Reviewed-on: https://chromium-review.googlesource.com/596785Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491899}

themeChromiumLinux missed to exclude [multiple] cases. Uses
:not(:-internal-list-box) to specify menulist SELECT correctly.

TBR=keishi@chromium.org

Bug: 752079
Change-Id: Ibbcc2f6155137a4e258f74f6c9a6f79648454076
Reviewed-on: https://chromium-review.googlesource.com/600267
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491898}

In order to enable clang-cl's printf format string mismatch checking we
need to fix a few dozen existing errors. These are mostly places where
unsigned long is printed with %X or %u - an 'l' is needed.

R=primiano@chromium.org
BUG=751171

Change-Id: I5276d31a80f1fc9391e81df656cfa1ce1debdaa5
Reviewed-on: https://chromium-review.googlesource.com/596613
Commit-Queue: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491897}

nvda_chrome_tests.py tests the interactions between Chrome <> NVDA. The
tests currently are very flakey and this is an attempt to prune things
that simply no longer work anymore.

The intent is not to just leave it as is, but to continue to add tests
that work more often to these test cases.

Bug: 742592
Change-Id: I3d6c5cc82dcbf63de154fe2dd79a8b6b5f41a7ff
Reviewed-on: https://chromium-review.googlesource.com/599589
Commit-Queue: Doug Turner <dougt@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491896}

Including <new> in jpeg causes a build error on some platforms
with a clash in definition of FILE uses in JPEG.

TBR=kjellander@chromium.org
BUG=libyuv:712
TEST=local builds still work

Change-Id: Ib1ec0bb0a61fd3407b577f2697db28ca83730f50
Reviewed-on: https://chromium-review.googlesource.com/600818Reviewed-by: Frank Barchard <fbarchard@google.com>
Commit-Queue: Frank Barchard <fbarchard@google.com>
Cr-Commit-Position: refs/heads/master@{#491895}

Until we resolve the control layer we do not want new users of the classes
defined in core/exported or Web(Local|Remote)FrameImpl. To use one of these
classes they need to be moved out of exported or split into controller.

Bug: 731490
Change-Id: Iaae52859aded432364cc6a5461ba04e267e4dd1e
Reviewed-on: https://chromium-review.googlesource.com/597572Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491894}

Bug: 748620
Change-Id: I37cb0ed1288b77044909bc03119f221acb1552cc
Reviewed-on: https://chromium-review.googlesource.com/601327Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: min c <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491893}

Use the same "gn $cmd $args" format for the first line in the long docs
for gn gen as the other gn cmds.. The previous doc resulted in an incorrect
anchor of 'gen:' getting generated.

BUG=752189

Change-Id: I2366b64794a524c77d38a23776cf3860eee07ee0
Reviewed-on: https://chromium-review.googlesource.com/600538Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: Mike Bjorge <mbjorge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491892}

Removed test InstantServiceEnabledTest.SendsSearchURLsToRenderer
from instant_service_unittest.cc since RenderProcessHost does not
support Channels in tests and will not execute the mojo call.

Bug: 577685
Tbr: thakis@chromium.org
Change-Id: I299541826c1e2c8fb8dcc6ec88831db28a14d009
Reviewed-on: https://chromium-review.googlesource.com/585338
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491891}

Refactor checking of URL whitelist to happen before analyzing the
downloaded file, in order to improve SB check latency for whitelisted
URLs. Certificate whitelist checks still happen towards the end of
processing since they rely on file analysis.

Bug: 526841
Change-Id: I59e228dea251ff1a03e319efccf1c2a8aec89bc3
Reviewed-on: https://chromium-review.googlesource.com/587329
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491890}

This patch adds serialization to PaintShaders, with the exception of
PaintImage and PaintRecord.

R=enne@chromium.org

Bug: 737629
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Idbaf512f2f0c12df8edd6bcd459af0ddaaff4126
Reviewed-on: https://chromium-review.googlesource.com/590675
Commit-Queue: Vladimir Levin <vmpstr@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491889}

Since the MD update, this was duplicated in 4 places.

The only difference (modulo stylistic differences) was that the ash/mus
versions had an extra line:

  toolbar_bounds.Inset(kClientEdgeThickness, 0);

I determined this was not necessary because the clipping region of the
canvas was already smaller than toolbar_bounds by kClientEdgeThickness.

Bug: none
Change-Id: I4d2dd4bbb844f2108abb606c9f0bc2e2210834f8
Reviewed-on: https://chromium-review.googlesource.com/596813
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491888}

This reverts commit f42ff9b5.

Reason for revert: Still fails Win7 (dbg) telemetry tests

Original change's description:
> Roll SwiftShader 4d3efed..aadf3e1
> 
> https://swiftshader.googlesource.com/SwiftShader.git/+log/4d3efed..aadf3e1
> 
> BUG=
> 
> TBR=kbr@chromium.org
> 
> TEST=bots
> 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel,linux_chromium_cfi_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel
> 
> Change-Id: Ifdfd2e7f511023cf036eee83f50ddc7980b0b783
> Reviewed-on: https://chromium-review.googlesource.com/600892
> Reviewed-by: Alexis Hétu <sugoi@chromium.org>
> Commit-Queue: Alexis Hétu <sugoi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491871}

TBR=sugoi@chromium.org,kbr@chromium.org

Change-Id: I5ef897b46cbb4455b0b39a541eee4c383350baf3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel, linux_chromium_cfi_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/601443Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491887}

This also allows us to support asynchronous client certificate
verification, but this CL leaves it as a TODO for now.

Bug: 706445
Change-Id: I792eb91a854bb15a67317d7ea4d04a80ba5ca4da
Reviewed-on: https://chromium-review.googlesource.com/586431Reviewed-by: Steven Valdez <svaldez@chromium.org>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491886}

Bug: None
Change-Id: Ic9427bdefbab9ac6caee15f1d6a43a23c7830cbc
Reviewed-on: https://chromium-review.googlesource.com/592235
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491885}

This is a reland of 9869d2f1

I've marked the tests as Slow in this CL (https://chromium-review.googlesource.com/c/600829)
which is why there were flaky before.

Original change's description:
> DevTools: transform console tests (part 2)
> 
> F/u from https://chromium-review.googlesource.com/c/595238
> 
> Bug: 667560
> Change-Id: I4e387fae79ab4de0965f84a045c4fd04631b9e7d
> Reviewed-on: https://chromium-review.googlesource.com/597312
> Commit-Queue: Will Chen <chenwilliam@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491501}

Bug: 667560
Change-Id: Ie2cc4dd1249b46b7ce784a516647acaee223c39f
Reviewed-on: https://chromium-review.googlesource.com/600814Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491884}

This container behaves like a std::deque (minus random access insert/erase) but uses
an array as the underlying storage. Additional details are documented in the header.

When DCHECK is enabled, the iterators do extra checks to ensure they are not being
used after container mutations.

A new helper class called base::internal::ArrayBuffer is added to be the low-level storage.
This split was inspired by WTF::Deque although the functionality is quite different: The
added one is mostly a holder for template move and destruct helpers, while the WTF one is
to facilitate copy-on-write and buffer sharing (which is not supported by this one).

The base::void_t is moved from base::internal namespace. This C++17 emulation need not
be strictly internal to base and once I understood how to use it, it seems quite useful.

Added base::internal::is_iterator to detect if an item is an iterator. This is required
by one of the STL deque functions but the exact implementation is not specified by the
standard. This implementation checks for the presence of iterator_category in the
iterator traits.

Contains minor fixes to move_only_int.h testing helper and the addition to a non-movable
copy_only_int.h

Related docs by dskiba:
https://docs.google.com/document/d/1PEuPnSW54LaoWpUIEAHobqGt9nbD2DgQ_W5DdlJOkJU
https://docs.google.com/document/d/1YL1FORFMWo0FK0lMg7WsImnjNQ3ZpY0nK0NHGjkeHT4

Future plans:
 1. Replace some std::deque uses around the code base as a smoketest.
 2. Add a presubmit to prevent additions of std::deque and std::queue.
 3. Replace the remaining uses.

Change-Id: Ic1a5c804da90514782a6eae4984d916da45c0d32
Reviewed-on: https://chromium-review.googlesource.com/582498
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491883}

Call ExtensionBindingsSystem::WillReleaseScriptContext() for extension
service-worker contexts. This fixes
ServiceWorkerTest.EventsToStoppedWorker with extension native bindings.

          --gtest_filter=ServiceWorkerTest.EventsToStoppedWorker
          --native-crx-bindings=1

Bug: 653596
Test: browser_tests \
Change-Id: I97db2bce738f35cd8ca5909017c6c9f48f95b76e
Reviewed-on: https://chromium-review.googlesource.com/596912Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491882}

Current, we have a method _WaitForSpeech which blocks on NVDA to speak
exactly the given set of text.

What this CL does is modifies _WaitForSpeech such that it only tests
for the ordered set of given text and ignores text that may have
happened prior to the text we're looking for.

Because of this change, I also renamed the method to _TestForSpeech


Bug: 742592
Change-Id: I37f2ff890a2f8860afac17b0011300d8fd34dd3f
Reviewed-on: https://chromium-review.googlesource.com/599607
Commit-Queue: Doug Turner <dougt@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491881}

This reverts commit 91feaec9.

Reason for revert: <INSERT REASONING HERE>
This CL causes test fails about signin in settings_egtest.
https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS/builds/30291 
You can use EG tryjob by
git cl try -m tryserver.chromium.mac -b ios-simulator-eg

Original change's description:
> Enabling sign-in promo view earlgrey tests
> 
> Bug: 661794
> Change-Id: I9e9844e73583288581e9700228708edc39dfd580
> Reviewed-on: https://chromium-review.googlesource.com/561147
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> Reviewed-by: Eric Noyau <noyau@chromium.org>
> Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491761}

TBR=msarda@chromium.org,noyau@chromium.org,jlebel@chromium.org

Change-Id: I26caf6ede4734b0ec89d275ef211ff93e4adf73d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 661794
Reviewed-on: https://chromium-review.googlesource.com/601098Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Menglu Huang <huangml@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491880}

Bug: 654477
Change-Id: I01e842c3ae227410a0f002ea5383babefbdf432b
Reviewed-on: https://chromium-review.googlesource.com/601128Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491879}

This CL changes testharnessreport.js to adhere closer to
the style guide:
https://chromium.googlesource.com/chromium/src/+/master/styleguide/web/web.md#JavaScript

In this CL:
 - Wrap long lines
 - Make quotes consistent
 - Replaces var with let/const
 - Update some comments

This should not change behavior.

Change-Id: I1df1b42fd74333bba392eb8f3a91a15b4eb4d4fd
Reviewed-on: https://chromium-review.googlesource.com/600769
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491878}

This could be the first step of the larger effort to clean up wallpaper
codes. Due to legacy reasons WallpaperType exists in user_manager::User
 but it's supposed to be in WallpaperInfo together with WallpaperLayout

This fixes the bot failure listed in the bug, though it's not the
direct cause, it's good to refactor like this in the long term. 

TBR=brettw@chromium.org, ochang@chromium.org

Bug: 752215
Change-Id: Icdcfc47ac12772576f4abb18003aab935897dc3b
Reviewed-on: https://chromium-review.googlesource.com/600927Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491877}

Bug: 734150
Change-Id: I5198d481082fb5bc9e4a88b50847dcbebb97c248
Reviewed-on: https://chromium-review.googlesource.com/600292
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491876}

SVG's foreign object coordinate spaces were recently updated [1] to
clarify SVG coordinates vs HTML coordinates. SVG coordinates are
equal to HTML coordinates plus location (x and y). LayoutSVGBlock's
MapLocalToAncestor takes HTML coordinates and offsets by location.

Element::ClientQuads passed ObjectBoundingBox, which is in SVG coordinates
and includes location, to MapLocalToAncestor which would apply the
location offset twice. This patch updates Element::ClientQuads to use
AbsoluteQuads which correctly calculates the foreign object bounds.

Two TODOs have been added:
1) Element::ClientQuads and Element::BoundsInViewport are very similar and
should be unified.
2) It's not clear whether stroke should be included in Element::ClientQuads.
If it should be, SVG special-cases can be removed from Element::ClientQuads.
A spec question has been filed: https://github.com/w3c/svgwg/issues/339.

[1] https://chromium.googlesource.com/chromium/src/+/09a6cd640fb5bf07aa06477362229c2e6969a718

Bug: 741615
Change-Id: Ibec65966e8661c4c2390284708ef53b5d0c1d11a
Reviewed-on: https://chromium-review.googlesource.com/597487
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#491875}

If you look at all the times we call RevertAll(), they either also call
SelectAll(true), or wouldn't mind if we did. We wish to standardize on
this policy. It happens to fix an issue also, where a stale cursor is
produced when tabbing into the Omnibox.

Bug: 735802, 750716
Change-Id: I5aace2b656f4241f2760acadc2a156dbd5fc31f4
Reviewed-on: https://chromium-review.googlesource.com/572206Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491874}

This CL does not show the palette tray unless a stylus event has been previous seen (unless the device contains an internal stylus). Stores a pref to track whether a stylus has been seen before and if not, a pointer watcher is fired up to look for stylus events.

Bug: 740298
Test: ash_unittests "PaletteTray*Test.*"
Change-Id: I75d03dd382321a4f4e2324a5c9bec43b7b3c02c3
Reviewed-on: https://chromium-review.googlesource.com/592228
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491873}

This fixes an ubisan error in ws::EventDispatcher where the creation of a
ui::MouseWheelEvent object was copied into a ui::MouseEvent object, and then
near immediately casted back to a ui::MouseWheelEvent, which it no longer was
because the object was sliced.

Bug: 752271
Change-Id: I9e49369c0ff599b99c1b68ab3785bdd051998568
Reviewed-on: https://chromium-review.googlesource.com/601179Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Elliot Glaysher <erg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491872}

https://swiftshader.googlesource.com/SwiftShader.git/+log/4d3efed..aadf3e1

BUG=

TBR=kbr@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel,linux_chromium_cfi_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Change-Id: Ifdfd2e7f511023cf036eee83f50ddc7980b0b783
Reviewed-on: https://chromium-review.googlesource.com/600892Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491871}

This changes the following:
. child modal windows are now correctly dealt with.
. previously if the target of an event was blocked by a modal window,
  then the event was targetted at the modal window. This patch makes
  it so that either the event is not dispatched, or the event falls
  back to the root (behavior dictated by flag in EventDispatcher).

This patch brings the handling of modal windows in line with
ui/wm/core/WindowModalityController and closer to that of
RootWindowController::RootWindowController::CanWindowReceiveEvents(). I
still need more wiring to implement rest of logic in
RootWindowController::CanWindowReceiveEvents().

BUG=692282,697127
TEST=covered by tests

Change-Id: I9af1b6d214b489e5819a2452d734754b890ba0da
Reviewed-on: https://chromium-review.googlesource.com/596548Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491870}