GitLab

BUG=116138


Review URL: http://codereview.chromium.org/9583020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124868 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116239
TEST=Open a system modal dialog, lock and unlock the screen. The system modal dialog should get focus back.

Review URL: https://chromiumcodereview.appspot.com/9568045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124867 0039d316-1c4b-4281-b951-d872f2087c98

R=thestig@chromium.org
BUG=108171


Review URL: http://codereview.chromium.org/9584044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124866 0039d316-1c4b-4281-b951-d872f2087c98

R=tommi@chromium.org
BUG=108171


Review URL: http://codereview.chromium.org/9580038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124865 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Launch ChromeOS and enable Bluetooth in about://flags. Open chrome settings and ensure that the view is expanded to show advanced settings.   Click "Enable Bluetooth" and "Add a device".  Ensure that available Bluetooth devices are shown.


Review URL: http://codereview.chromium.org/9570018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124864 0039d316-1c4b-4281-b951-d872f2087c98

If a user is not logged in (e.g. in the login screen, or during an incognito
session), some of the items need to behave differently. So provide this
information to each of the items so that such customization is possible. Also,
make sure all the items get a chance to update themselves when user logs in.

BUG=110130
TEST=tested on device, logged in as normal user, and incognito.

Review URL: https://chromiumcodereview.appspot.com/9580024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124863 0039d316-1c4b-4281-b951-d872f2087c98

The following patches have been upstreamed:
- net/third_party/nss/patches/handshakeshortwrite.patch
- net/third_party/nss/patches/cbcrandomiv.patch
- net/third_party/nss/patches/nextproto.patch
- portions of patches/cachecerts.patch that add certificates to
  ss->ssl3.peerCertChain in the right order.
- portions of net/third_party/nss/patches/clientauth.patch that
  fix NSS bug 616757.

I omitted the net/third_party/nss/patches/cachedinfo.patch because
Chrome isn't using the TLS cached info extension and I wanted to
maintain fewer patches.  We can add it back later.

R=rsleevi@chromium.org,agl@chromium.org
BUG=116617
TEST=Unit tests should pass. Manual tests of SSL client auth and
origin-bound certs.

Review URL: http://codereview.chromium.org/9558017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124862 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124861 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116524
TEST=none
TBR=bashi@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9584048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124860 0039d316-1c4b-4281-b951-d872f2087c98

This function is used to get files from the file system.
For now, it always download files from the cloud.
We should have the caching layer in-pace here.

Along the way, a mssing 'return' to Remove().
Change GetDocumentUrlFromPath() to GetGDataFileInfoFromPath,
and wrote a test for it.

BUG=chromium-os:27174
TEST=unit_tests


Review URL: http://codereview.chromium.org/9583031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124857 0039d316-1c4b-4281-b951-d872f2087c98

Include base/logging explicitly

TBR=thestig@chromium.org
BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9586029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124856 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124855 0039d316-1c4b-4281-b951-d872f2087c98

TBR=xiyuan@chromium.org
BUG=chromium-os:26646
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9580039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124853 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/9558012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124852 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=trybot runs.

Review URL: http://codereview.chromium.org/9589003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124851 0039d316-1c4b-4281-b951-d872f2087c98

Setting ion=1 overrides google.com preferences, which can be a surprise.
Visible Instant is not such a surprise, since the user can actually see the
previews and thus associate it with Chrome Instant.

BUG=105390
TEST=Start with --instant-field-trial=hidden and observe that the Instant homepage requests don't have ion=1. Turn off Google Instant (using google.com/preferences) and observe that Google Instant remains turned off on an omnibox-initiated search.


Review URL: http://codereview.chromium.org/9581026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124850 0039d316-1c4b-4281-b951-d872f2087c98

Sort all code in 'class declarations' -> 'method definitions' -> 'test code' order.
Add missing OVERRIDEs

BUG=None
TEST=content_unittests --gtest_filter="URLFetcher*"


Review URL: http://codereview.chromium.org/9582002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124849 0039d316-1c4b-4281-b951-d872f2087c98

This makes the Windows IPC channel interface the same as I've created for the Posix one:
http://codereview.chromium.org/9570001/

The core reading functions DispatchInputData, ProcessIncomingMessages, and the "hello" message handling are now identical. The follow-up step will be to merge these into a common IPCChannelReader base class and eliminate the duplicate code.


Review URL: http://codereview.chromium.org/9568031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124848 0039d316-1c4b-4281-b951-d872f2087c98

This is in preparation for adding some extra functionality at the EventsTracker layer (max events throttling).


Review URL: http://codereview.chromium.org/9581021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124847 0039d316-1c4b-4281-b951-d872f2087c98

URLFetcher is going to have a new method 'SaveResponseToFile'.
FileWriter is going to manage both temporary and ordinary files.

BUG=chromium-os:26971
TEST=content_unittests --gtest_filter="URLFetcher*"


Review URL: http://codereview.chromium.org/9580003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124846 0039d316-1c4b-4281-b951-d872f2087c98

I am moving all widget styles into button.css. I will later rename it widget.css. This way, the rules that are common can be shared.

The next step will be to update/merge checkbox.css into button.css.

BUG=103688,115404
TEST=visual


Review URL: http://codereview.chromium.org/9579001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124845 0039d316-1c4b-4281-b951-d872f2087c98

This broke android build.

TBR=thestig@chromium.org
BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9582046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124844 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124843 0039d316-1c4b-4281-b951-d872f2087c98

ffmpeg rev, 124825:
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/ffmpeg/chromium/?view=log

ffmpeg hash, baa5f11e7dc682b2bb5545e9fbf037090b99fff1:
http://git.chromium.org/gitweb/?p=chromium/third_party/ffmpeg.git;a=commit;h=baa5f11e7dc682b2bb5545e9fbf037090b99fff1


BUG=116599
TEST=clang compile.

Review URL: http://codereview.chromium.org/9584039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124842 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/9570063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124841 0039d316-1c4b-4281-b951-d872f2087c98

for Bastion.  Todo added to re-enable when underlying sync is solved.
BUG=http://code.google.com/p/chromium/issues/detail?id=116285
TEST=Bastion

Review URL: http://codereview.chromium.org/9581034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124840 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/9584024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124839 0039d316-1c4b-4281-b951-d872f2087c98

Turn the GetSessionNameTask class into a simple GetSessionName function.

Use the browser thread blocking pool instead of the FILE thread.

Remove dependency on BrowserThread from internal_api.

BUG=113723
TEST=


Review URL: http://codereview.chromium.org/9565050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124838 0039d316-1c4b-4281-b951-d872f2087c98

for fetching the GData file properties and for pinning files.

BUG=chromium-os:27030,chromeium-os:27078
TEST=none


Review URL: http://codereview.chromium.org/9545006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124837 0039d316-1c4b-4281-b951-d872f2087c98

The toolbar background painting code was copying pixels out of the toolbar background image with the wrong vertical offset.  I also moved the paint code into BrowserNonClientFrameViewAura so it can get the proper tabstrip vertical offset, and also because that's a more appropriate place for the logic.

BUG=113075
TEST=visual, ensure no "step" in the gradient at the bottom of the active tab or the top of the toolbar, for both maximized and restored windows
TBR=ben@chromium.org


Review URL: http://codereview.chromium.org/9583032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124836 0039d316-1c4b-4281-b951-d872f2087c98

This does not update the docs because they have gotten badly
out of date. I will update them separately.

BUG=116490


Review URL: http://codereview.chromium.org/9584021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124835 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116567
TEST=apprtc.appspot.com

Review URL: http://codereview.chromium.org/9581015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124834 0039d316-1c4b-4281-b951-d872f2087c98

Revert 124832 - Update the tcmalloc chromium branch to r144 (gperftools 2.0), and merge chromium-specific changes.

The major reason for us is to enable a fix for HEAP_PROFILE_MMAP.

This change merges tcmalloc r144 (gperftools 2.0 f.k.a. google-perftools) with the tcmalloc/chromium branch, which is the forked Chromium version of tcmalloc.

The change is created by 3-way merge from
1) the original google-perftools r109 ( = vendor base),
2) the original gperftools 2.0  r144 ( = branch), and
3) the chromium branch ( = another branch)

with the following additional changes :
* base/allocator/allocator.gyp is modified.
* Many [#include "third_party/tcmalloc/chromium/src/google/..."] are replaced with "gperftools/".  (Many files in Chromium)
* gperftools/tcmalloc.h (formerly google/tcmalloc.h) is replaced with the original (generated) one.
* windows/gperftools/tcmalloc.h (formerly windows/google/tcmalloc.h) is replaced with the original (generated) one.
* malloc_hook-like functions are moved to libc_override*.h in gperftools 2.0.  Some changes due to it.
* MALLOC_HOOK_MAYBE_VOLATILE is redefined using __MALLOC_HOOK_VOLATILE.  (config.h, tcmalloc.cc and libc_override_glibc.h)
* The macro "CRASH(...)" is replaced with "Log(kCrash, __FILE__, __LINE__, ...)".  (Many files)
* LARGE_PAGE-related parameters (which may affect performance?) are merged.  (common.h)
* RAW_VLOG() calls are removed.  (base/googleinit.h)
* sys_{mmap|munmap|mremap}(...) calls are tentatively replaced with syscall(SYS_{mmap|munmap|mremap}, ...).  (malloc_hook_mmap_linux.h)
* tc_mallinfo is declared only when HAVE_STRUCT_MALLINFO is defined.  (gperftools/tcmalloc.h)
* "libc_override_redefine.h" is not included in Windows.  (libc_override.h)
* Chromium-original "sys_alloc" is not declared.  (windows/port.cc)
* base/spinlock_win32-inl.h is reverted from r144 because 64-bit atomicops are not implemented on Windows.  (base/atomicops-internals-windows.h)

The vendor branch is updated in another change.

BUG=114302
TEST=run all existing tests.

Review URL: https://chromiumcodereview.appspot.com/9311003

TBR=dmikurube@google.com
Review URL: https://chromiumcodereview.appspot.com/9581043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124833 0039d316-1c4b-4281-b951-d872f2087c98

The major reason for us is to enable a fix for HEAP_PROFILE_MMAP.

This change merges tcmalloc r144 (gperftools 2.0 f.k.a. google-perftools) with the tcmalloc/chromium branch, which is the forked Chromium version of tcmalloc.

The change is created by 3-way merge from
1) the original google-perftools r109 ( = vendor base),
2) the original gperftools 2.0  r144 ( = branch), and
3) the chromium branch ( = another branch)

with the following additional changes :
* base/allocator/allocator.gyp is modified.
* Many [#include "third_party/tcmalloc/chromium/src/google/..."] are replaced with "gperftools/".  (Many files in Chromium)
* gperftools/tcmalloc.h (formerly google/tcmalloc.h) is replaced with the original (generated) one.
* windows/gperftools/tcmalloc.h (formerly windows/google/tcmalloc.h) is replaced with the original (generated) one.
* malloc_hook-like functions are moved to libc_override*.h in gperftools 2.0.  Some changes due to it.
* MALLOC_HOOK_MAYBE_VOLATILE is redefined using __MALLOC_HOOK_VOLATILE.  (config.h, tcmalloc.cc and libc_override_glibc.h)
* The macro "CRASH(...)" is replaced with "Log(kCrash, __FILE__, __LINE__, ...)".  (Many files)
* LARGE_PAGE-related parameters (which may affect performance?) are merged.  (common.h)
* RAW_VLOG() calls are removed.  (base/googleinit.h)
* sys_{mmap|munmap|mremap}(...) calls are tentatively replaced with syscall(SYS_{mmap|munmap|mremap}, ...).  (malloc_hook_mmap_linux.h)
* tc_mallinfo is declared only when HAVE_STRUCT_MALLINFO is defined.  (gperftools/tcmalloc.h)
* "libc_override_redefine.h" is not included in Windows.  (libc_override.h)
* Chromium-original "sys_alloc" is not declared.  (windows/port.cc)
* base/spinlock_win32-inl.h is reverted from r144 because 64-bit atomicops are not implemented on Windows.  (base/atomicops-internals-windows.h)

The vendor branch is updated in another change.

BUG=114302
TEST=run all existing tests.

Review URL: https://chromiumcodereview.appspot.com/9311003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124832 0039d316-1c4b-4281-b951-d872f2087c98

This may be causing this crash:
Note: Google Test filter = PrerenderBrowserTest.PrerenderUnload
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from PrerenderBrowserTest, where TypeParam = 
[ RUN      ] PrerenderBrowserTest.PrerenderUnload
[2464:2324:0302/211059:6709843:FATAL:profile_dependency_manager.cc(134)] Check failed: false. Attempted to access a Profile that was ShutDown(). This is most likely a heap smasher in progress. After ProfileKeyedService::Shutdown() completes, your service MUST NOT refer to depended Profile services again.


Move InitExtensions into ExtensionSystem.
Remove a few accessors (ExtensionDevToolsManager, ExtensionMessageService). The others have too many callers to fix in one go.

BUG=104095
TEST=Open and close an incognito window; should not crash.


Review URL: http://codereview.chromium.org/9369013

TBR=yoz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9583036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124831 0039d316-1c4b-4281-b951-d872f2087c98

Mostly works, the only problem is that the first touch or gesture on switching "modes" gets lost because Windows doesn't start a touch of the "other" type when TouchRegisterWindow is called while there's a touch in progress.

TBR=cpu

Review URL: http://codereview.chromium.org/9549020

TBR=scottmg@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9572033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124830 0039d316-1c4b-4281-b951-d872f2087c98

Also shortens one bit of code while I'm here.

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9581029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124826 0039d316-1c4b-4281-b951-d872f2087c98

BUG=114732
TEST='existing tests'


Review URL: http://codereview.chromium.org/9564047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124824 0039d316-1c4b-4281-b951-d872f2087c98

Add a DeleteKey() method to delete a key from the meta table.  This will be used in the TemplateURL refactoring changes.

Reorder function definitions to match declaration order.  Shorten a few bits.

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9584031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124823 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124822 0039d316-1c4b-4281-b951-d872f2087c98