- 09 Mar, 2018 40 commits
-
-
Tetsui Ohkubo authored
This CL adds a feature pod button for Bluetooth. By clicking on the button, it will show bluetooth detailed view of the existing SystemTray. This behavior is described as Development Stage 1 in the design doc: go/cros-qs-restyling TEST=manual BUG=813499 Change-Id: I130301b9a25d31a520b1a0bb8f78839aa4b91b73 Reviewed-on: https://chromium-review.googlesource.com/948164 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#542067}
-
Kent Tamura authored
Bug: 770603 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I6cb03bc3e58a38070def0fb8e927e2d7036484b5 Reviewed-on: https://chromium-review.googlesource.com/956792Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#542066}
-
Max Morin authored
This reverts commit a7c1c185. Reason for revert: Clusterfuzz reports... Original change's description: > Fix yet another AudioOutputDevice crash. > > Bug is identical to the last :/. No idea why it's much more frequent with mojo, > possibly a race is likely to happen when destroying a frame: |callback_| is > destroyed due to frame being destroyed, and authorization is failed for the > same reason. With the per process message filter, authorization wouldn't fail > due to the frame being destructed. > > Bug: 819277 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: Ic17dc96d2c83a08732b43094bac2f2c3fa7035ad > Reviewed-on: https://chromium-review.googlesource.com/951774 > Commit-Queue: Max Morin <maxmorin@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#541801} TBR=dalecurtis@chromium.org,maxmorin@chromium.org Change-Id: I9bf3d357bd09ebd1fa60b4324d204da44b23b72a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 819277,820276,820341 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/957042Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542065}
-
arthursonzogni authored
The two tests following tests are potentially flaky: * WebViewTests/WebViewTest.Shim_TestNestedSubframes/* * WebViewTests/WebViewTest.Shim_TestNestedCrossOriginSubframes/* Why are they flaky? webview.onloadstop event handler is defined. Once called, it causes a new navigation to happens in the webview. The navigation causes the handler to be called again. This is a loop. It wasn't expected to behave that way. If the nested iframe navigation happens quickly enough, the two time nested iframe navigation might not complete quickly enough and the postMessage() may not happens. The race condition may be unfavourable several time in a row and causes a test timeout. FYI: 1) This test was disabled on Mac. Maybe this CL fixes the issue? It should be verified on a device with this OS. 2) This test is flakier after enabling NavigationMojoResponse and applying this CL: https://chromium-review.googlesource.com/c/chromium/src/+/951243/6 That's understandable, this patch allows navigation to commit faster. Bug: 674904, 705744 Change-Id: Icf2debd095519221ff085cb3bacbc058c1806e86 Reviewed-on: https://chromium-review.googlesource.com/955585Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#542064}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 770603 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I627aa5218ad008854012831ec49e484dfdf72920 Reviewed-on: https://chromium-review.googlesource.com/956902Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#542063}
-
Oleh Prypin authored
Instead build just the targets in chromium.webrtc. Bonus: remove obsolete tryjob definitions. Bug: chromium:820041, chromium:808111 TBR: machenbach@chromium.org No-Try: True Change-Id: I133593a4e51a5e1dac4d0e24d21601cd553784a0 Reviewed-on: https://chromium-review.googlesource.com/956043Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Oleh Prypin <oprypin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542062}
-
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Idb76e054c5689db7fb83ee4c308f30e5b6eae136 Reviewed-on: https://chromium-review.googlesource.com/956963 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542061}
-
Emily Hanley authored
Also updating what tests run on each shard to help debug the failing tests. Bug: 758632 Change-Id: Ib0eb60f0b9ae7e3a2cd19ae8c1f8183d4d0b7d81 Reviewed-on: https://chromium-review.googlesource.com/955676Reviewed-by:
Ashley Enstad <ashleymarie@chromium.org> Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Cr-Commit-Position: refs/heads/master@{#542060}
-
Chih-Yu Huang authored
Originally, VEA calls the flush callback before notifying the client that the last frame buffer is ready. This CL changed the calling order to ensure all frames buffer are sent back to the client before VEA notifies the flush is completed. BUG=b:71882314 TEST=run video_encode_accelerator_unittest at device Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I235411734dff3200df3b36b1f14211fbd0d41c8f Reviewed-on: https://chromium-review.googlesource.com/956653Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#542059}
-
Tatsuhisa Yamaguchi authored
Bug: 795167 Change-Id: I4223e26d23885c350337aefb8abd991427435a05 Reviewed-on: https://chromium-review.googlesource.com/828184 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#542058}
-
https://webrtc.googlesource.com/src.git/+log/8493594dc2ae..6d72c3258ff5 $ git log 8493594dc..6d72c3258 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia922556cc0419a6011b0f9fb6d2927fa38fb3101 Reviewed-on: https://chromium-review.googlesource.com/956926 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542057}
-
Emily Hanley authored
Bug: 758632 Change-Id: I33c62a8c7ce7d8afd47021dc9833bf739dd26696 Reviewed-on: https://chromium-review.googlesource.com/956089Reviewed-by:
Ashley Enstad <ashleymarie@chromium.org> Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Cr-Commit-Position: refs/heads/master@{#542056}
-
Wenzhao Zang authored
There's a delay in making local state available in //ash, so we previously created |OnReadyToSetWallpaper| to notify //chrome when it's ready. However, we do not have the mechanism to prevent early ShowUserWallpaper requests. The correct behavior should be to directly ignore it, otherwise it automatically falls back to a default wallpaper as the bug shows. This problem only exists for browser restart, but not login. Because the ShowUserWallpaper requested from login is very late due to web-ui initialization. Bug: 820196 Change-Id: Ie05235b5966b14ea80a7e83aca98f8b7147cc9b7 Reviewed-on: https://chromium-review.googlesource.com/956350Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#542055}
-
Oksana Zhuravlova authored
This changes adds a new target to the mojom template which depends on the parse target and is a dependency for all generation targets. A new action has been added to the mojom_bindings_generator.py script that compares the list of sources for all dependencies of a given mojom file target to the list of imports in this file. If missing dependencies are found, they are printed and the script exits with an error. This changes also fixes missing dependencies and not fully-qualified import statements. Dependency check has been disabled for //content/common:mojo_bindings and //content/public/common/interfaces since it caused multiple definitions linker errors on Windows (they have both direct and indirect dependencies on specific targets). Bug: 753219 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: I64613ad14af41f1fc2a77b81ac76507e26f9dfcc Reviewed-on: https://chromium-review.googlesource.com/947384 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#542054}
-
Ned Nguyen authored
Bug:805552 Change-Id: Ifd631d785f309d9f46b401daaec44d0cf89a8631 Pinpoint tryjobs: Android: https://pinpoint-dot-chromeperf.appspot.com/job/14c63ffa440000 Linux: https://pinpoint-dot-chromeperf.appspot.com/job/10787612440000 Mac: https://pinpoint-dot-chromeperf.appspot.com/job/1499113a440000 Win: https://pinpoint-dot-chromeperf.appspot.com/job/1381251a440000 Change-Id: Ifd631d785f309d9f46b401daaec44d0cf89a8631 Reviewed-on: https://chromium-review.googlesource.com/956203 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Cr-Commit-Position: refs/heads/master@{#542053}
-
Zhuoyu Qian authored
This Cl introduces "ClipboardCommands.h", move the declarations of some static functions related to clipboard to the header file. Make EditorCommand simpler for improving code health. Bug: 818552 Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: I2ebbd4ebb6a0ee3cc13f3a928c786a8d6e285bf4 Reviewed-on: https://chromium-review.googlesource.com/952744Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542052}
-
Trent Apted authored
Move all layout to Layout() so that it updates correctly when the browser window is resized with the results dropdown open. Bug: 801583 Change-Id: I7b931ff3d3b8623e5a01b4543b441767845818ac Reviewed-on: https://chromium-review.googlesource.com/942562 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#542051}
-
Wez authored
Platform-specific IPC::Channel implementations included Chrome IPC message logging, but this was not carried into the Mojo-based Channel implementation. Chrome IPC message logging is higher-level than Mojo IPC message logs, which can be useful for certain kinds of diagnosis. Bug: 816620 Change-Id: I467857fd07b66c3d468039d6fb7c2950f931c8bb Reviewed-on: https://chromium-review.googlesource.com/956347Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#542050}
-
Robert Liao authored
ExtensionView::DidStopLoading() collided with content::WebContentsObserver::DidStopLoading(). BUG=818397 TBR=rdevlin.cronin@chromium.org Method rename. Change-Id: I15ea2074f7c430429d2538ef19c858cb74f549b3 Reviewed-on: https://chromium-review.googlesource.com/954065 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#542049}
-
Han Leon authored
This prototype is 'assert_equals(actual, expected, description)', we should pass 'actual' and 'expected' in order, to make the failure message be reasonable. This CL just fixes external/wpt/service-workers/service-worker/navigate-window.https.html. BUG= Change-Id: Ic11ec67f27f7a9a5ae289ddda4362af72b4737d4 Reviewed-on: https://chromium-review.googlesource.com/955282 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#542048}
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/595b66866726..e0f4e29651e2 $ git log 595b66866..e0f4e2965 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ibad7f06f6c5fcca4823f9497eefaabefe107bdb3 Reviewed-on: https://chromium-review.googlesource.com/956746Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542047}
-
Dale Curtis authored
Per discussion on the CL below [1], we want to move decrypting decoder creation to the standard renderer factory. To do this we need to provide the WaitingForDecryptionKeyCB to the decoders at time of Initialize() to avoid duplicate callbacks for the same functionality. This has the side effect of providing the wait for key CB in new places that should eventually make use of it (Mojo, Gpu decoder). [1]: https://chromium-review.googlesource.com/c/chromium/src/+/952207 BUG=801245 TEST=no functional changes, so builds and tests pass. TBR=bbudge Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I4e6c9dc6344a798ab9a9b374acc8aff67d9dd4d1 Reviewed-on: https://chromium-review.googlesource.com/956344 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#542046}
-
Josh Pratt authored
Refactor LocationBarView to move Refresh logic for some BubbleIconViews into the respective subclasses. This is initial work for adding BubbleIconViews to Chrome OS Desktop PWAs. It partially decouples BubbleIconViews from the LocationBarView so that they can also be used in HostedAppButtonContainer. Bug: 788051 Change-Id: I986951b64fb02f2d2728abbe6a3964ff97e04909 Reviewed-on: https://chromium-review.googlesource.com/923607 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#542045}
-
Michael Giuffrida authored
These tests run on waterfall builders, so they should run in the CQ. They shouldn't be limited to Linux and CrOS trybots. AppShell is only actively developed for Linux, but it's used elsewhere for extension tests, so we should avoid regressions in AppShell-specific code on all desktop bots. Change-Id: I6a8de9bb9cb1a04756e66ba596abec1955a83a86 Reviewed-on: https://chromium-review.googlesource.com/950480Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#542044}
-
Sergey Volk authored
https://chromium.googlesource.com/chromiumos/platform/minigbm/+log/7f79cb5..6eca368 $ git log 7f79cb5..6eca368 --date=short --no-merges --format='%ad %ae %s' 2018-03-06 servolk@google.com Rename amlogic backend in minigbm into meson 2018-02-28 marcheu@chromium.org msm: Align buffer dimensions for llvmpipe 2018-02-20 Deepak.Sharma@amd.com minigbm: amdgpu: support DRM_FORMAT_YVU420_ANDROID 2018-02-07 hoegsberg@chromium.org i915: Always set the modifier when allocating BOs Also made two changes in third_party/minigbm/BUILD.gn: 1. Updates for the "amlogic" backend being renamed into "meson" 2. Added "libminigbm" target for Chromecast builds, which expect the final lib name to be <GN target name> + .so Bug: internal b/70752885 Test: build and run ozone_demo Change-Id: Ie358b925464745f27402a826ef256e3da5199ec6 Reviewed-on: https://chromium-review.googlesource.com/952165Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#542043}
-
Aleksandar Stojiljkovic authored
The recent change in MediaFoundation API requires explicit enumeration of sensor (newer depth Hello) cameras. Pass-through mode fixes in MF capture implementation. Verified using both Intel
® RealSense™ Depth Camera D435 and previous depth cameras, those that are not marked as sensors in driver inf, e.g. SR300. Minor refactoring static -> anonymous namespace. BUG=807293 Change-Id: I8c13d360bfc30cae8902f8e03d553dff69dcbf34 Reviewed-on: https://chromium-review.googlesource.com/944627 Commit-Queue: Aleksandar Stojiljkovic <aleksandar.stojiljkovic@intel.com> Reviewed-by:Max Morin <maxmorin@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#542042}
-
Tien-Ren Chen authored
This CL changes CompositingInputsUpdater to keep track of scrolling container for different type of positioned descendants, so we won't need to walk up ancestor chain to look for them. This is similar to the technique used by PrePaintTreeWalk. No behavior change is expected. BUG=818768 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I2409dd91e5b2903e348bdebca7f6ac2f1544ea94 Reviewed-on: https://chromium-review.googlesource.com/952540 Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#542041}
-
https://chromium.googlesource.com/angle/angle.git/+log/19fa1c6f8852..e8a93c6ed6fe $ git log 19fa1c6f8..e8a93c6ed --date=short --no-merges --format='%ad %ae %s' 2018-01-04 jdarpinian New transform feedback buffer binding rules 2018-03-08 lucferron Vulkan: Support of GL_UNSIGNED_BYTE type in drawElements 2018-03-05 brandon1.jones Add NPOT validation to copyTextureCHROMIUM Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Ibb5aac5ef69704b80f060b2292d0480ef99d074e Reviewed-on: https://chromium-review.googlesource.com/956891 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542040}
-
Joel Hockey authored
Bug: 813477 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iaa6c3f1acb0b6767f491fd437fa58a8764efcdcf Reviewed-on: https://chromium-review.googlesource.com/954802Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#542039}
-
Xiaocheng Hu authored
1. Removed two members stored in SpellingRequest; Changed them as passed via call stack. Note: |SpellingRequest::text_| doesn't need to be stored, either; However, it still seems natural to store it. 2. Added more comments to SpellingRequest. Change-Id: I64a07a8e1fe9b23bf5dd0757d225f309548da05b Reviewed-on: https://chromium-review.googlesource.com/956617Reviewed-by:
Rachel Blum <groby@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#542038}
-
https://chromium.googlesource.com/catapult.git/+log/df668c31259d..78d89b42c293 $ git log df668c312..78d89b42c --date=short --no-merges --format='%ad %ae %s' 2018-03-08 kjharland [Dashboard] Whitelist Fuchsia garnet-ci dev acct 2018-03-07 perezju Reland "[Telemetry] Move apk finding code to Android backend settings" Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I897909bec9222fbcf834f63642b2254d976e3fde Reviewed-on: https://chromium-review.googlesource.com/956888Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542037}
-
https://webrtc.googlesource.com/src.git/+log/8861da8356ee..8493594dc2ae $ git log 8861da835..8493594dc --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None,None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id48cefe2e32f0a1a18f9b8f2eea78cf78858fa2f Reviewed-on: https://chromium-review.googlesource.com/956412 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542036}
-
Antoine Labour authored
Before this patch, TextureDefinition considers itself "defined" if any image is defined on the source Texture. However it could be the case that the level 0 (which is the one we deal with in MailboxManagerSync) might not be defined (but others are). Make sure that this is handled correctly, by considering TextureDefinition to be "defined" iff level 0 is defined Bug: 814677 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id14f00d0c6ac36385d378a42df7b2119adbd0879 Reviewed-on: https://chromium-review.googlesource.com/956748Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#542035}
-
Wez authored
Previously LogMessage would use the POSIX getpid() API, which is not a real implementation under Fuchsia. Bug: 706592 Change-Id: I9d2b2f06efcecfea9457f7d96295457de2ef888d Reviewed-on: https://chromium-review.googlesource.com/954420Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#542034}
-
Donn Denman authored
Changes some Contextual Search tests that are flaking on KitKat. Now they only run on Android-L or later. BUG=818897 Change-Id: I97b10e45b055ccc8b05dce569b44c8f987c13d90 Reviewed-on: https://chromium-review.googlesource.com/953563 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#542033}
-
Erik Luo authored
Prepares support for BigInts in - JSAutocomplete - objectValue, heap snapshot, console styles - 'copy' command line API value Screenshot: https://imgur.com/a/KqyBg Bug: v8:7486 Change-Id: I12bab5a06dc940ebdb096c3b944fb71646f5b62c Reviewed-on: https://chromium-review.googlesource.com/940774 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#542032}
-
Alexey Kozyatinskiy authored
New version of acorn support spread and rest operators. R=dgozman@chromium.org Bug: chromium:756006 Change-Id: I8c0a5a6d0f39027920f7d0e8b8df42a711262d97 Reviewed-on: https://chromium-review.googlesource.com/956559Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#542031}
-
tzik authored
This updates //crypto to use base::OnceCallback instead of legacy base::Callback. No intended functional change is included. This reduces the number of 'base::Bind' in //crypto from 3 to 0, as tracked at http://goo.gl/LUVhDj Bug: 714018 Change-Id: I020993c154a0706a262543937d9ebe506ea01c25 Reviewed-on: https://chromium-review.googlesource.com/952507Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#542030}
-
https://pdfium.googlesource.com/pdfium.git/+log/a724cb2df9f7..5a7e330ef5e0 $ git log a724cb2df..5a7e330ef --date=short --no-merges --format='%ad %ae %s' 2018-03-08 hnakashima Unset timer in XFA scrollbar after stopping it. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: If6646e4bd84d235353bc2020d7f9b9cdc4480288 Reviewed-on: https://chromium-review.googlesource.com/956489Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542029}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=xdai@google.com Change-Id: Iec61e0be5a160775219e23f283b5bc433d4703ab Reviewed-on: https://chromium-review.googlesource.com/955915 Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#542028}
-