- 24 Jun, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1496de215a39..654e6c9ed0c3 2020-06-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 36b5bb701da9 to 7a1af5878594 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I05c9d691c7da9993ef9a4af56e7e7a7b07494703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263177Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781809}
-
Rune Lillesveen authored
The remaining references to master is from dom code apis and branch names in documentation. Change-Id: I7a1524ba2bcef3ecac612df6e513a701573e2a11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263533Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#781808}
-
Marc Treib authored
If the user presses the "No, thanks" button, Chrome shouldn't ask to move this particular password again. That requires hooking up the button to PasswordFormManager::BlockMovingCredentialsToAccountStore() which this CL does. Bug: 1060128 Change-Id: I706bffd07d9883db1544363524628d24f56e4272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263214Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#781807}
-
Omar Morsi authored
This CL does the following: - Allows adding "VPN" to ONC's DisableNetworkTypes list. - Adds a VPN device state entry in the list returned by CrosNetworkConfig::GetDeviceStateList() to be used by UI. - If VPN is disabled by policy: * Removes VPN pod from the system tray. * Removes VPN entry from the network summary page in settings. * Disables (but not removes) the "Add OpenVPN/L2TP..." button in the network summary page. Bug: 1064893, 1082327 Change-Id: I0441e3ab0eae27b2af7eafc7dd7b0f2ad5fcd5b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190216 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:dpapad <dpapad@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#781806}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/36b5bb701da9..7a1af5878594 2020-06-23 ehsannas@gmail.com Support OpCompositeExtract pattern in desc_sroa (#3456) 2020-06-23 vasniktel@gmail.com spirv-fuzz: Implement FuzzerPassAddParameters (#3399) 2020-06-23 vasniktel@gmail.com spirv-fuzz: Add GetParameters (#3454) 2020-06-23 vasniktel@gmail.com spirv-fuzz: Permute OpPhi instruction operands (#3421) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: I453d338a268eb73014f43fc8aca55866b6645112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262798Reviewed-by:
-
Guido Urdaneta authored
This reverts commit 6536130a. Reason for revert: crbug.com/1098633 Original change's description: > [PTZ] Add mocking points to VideoCaptureDeviceFactoryWin > > This CL refactors video capture device creation on Windows, removes some > code duplications related to DirectShow device enumeration and adds > mocking points for unit testing. This CL has no functional changes. > > Bug: 934063 > Change-Id: I2df08b3a361ffd702761bd9d6b400f4418390c99 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247797 > Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com> > Auto-Submit: Eero Häkkinen <eero.hakkinen@intel.com> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781357} TBR=eero.hakkinen@intel.com,guidou@chromium.org Change-Id: I967f2eccd57c9847d85201ad57d28ad804691fff No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 934063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263193Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#781804}
-
Mikel Astiz authored
The field hasn't been populated in a long time so it can be deleted from the protobuf definition, and the old legacy code (not actually exercised) deleted. Change-Id: Iaf65d73e76841c2758679cfd26a93432a438b4ae Bug: 923287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262992 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#781803}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9111c7e4..88ed5b1e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I17337fe6a850878bffe67cd79e018e774423cc32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263332Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781802}
-
Colin Blundell authored
This CL augments WebLayer's infobars implementation by handling accessibility as Chrome's does: while accessibility is enabled the infobar container view does not scroll out of view. The implementation is a port of that of //chrome's InfoBarContainer.java extended to handle the wrinkle that WebLayerAccessibilityUtil drops its observers when there are no more Browsers and doesn't re-add them on addition of a new Browser. Bug: 1093846 Change-Id: Ic58d17823068d60c9d0d25a80f7ddcf420f9a2fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254020 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#781801}
-
Makoto Shimazu authored
We don't use this metrics recently. Let's remove this. Bug: 1084027 Change-Id: Ic097e893c36f86e552c0cb4277c95727b1d707c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259701Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#781800}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f5062f6b5bcd..e0c317566197 2020-06-24 treehugger-gerrit@google.com Merge "Presubmit: remove NULL ban" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I77c8db8bd8a34fd4fefe40904f9ae8324777bd3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263176Reviewed-by:
-
Bret Sepulveda authored
This reverts commit 225f6f4c. Reason for revert: I think this is causing failures in: virtual/omt-worker-fetch/external/wpt/workers/modules/dedicated-worker-import.any.worker.html http/tests/workers/worker-usecounter.html virtual/omt-worker-fetch/http/tests/workers/worker-usecounter.html and the "webkit_lint" step. See example failure: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/47132 Original change's description: > Add StoragePartitionConfig class. > > Introducing StoragePartitionConfig to make it easier for code to > directly request the StoragePartition they need instead of having to > go through the indirection of site URLs. Grouping the 3 attributes of > a config into a class also makes several call sites simpler. This is > being done as part of an effort to reduce the amount of code that > depends on site URLs. > > - Created class for storing the storage partition > <domain, name, in_memory> tuple. > - Update GetStoragePartitionConfigForSite() and related code to use > this new class. > - Create BrowserContest::GetStoragePartition() method that takes > StoragePartitionConfig as a parameter so future callers do not need > to construct a site URL to get a storage partition. > - Remove StoragePartitionImplMap::StoragePartitionConfig struct and > convert StoragePartitionImplMap to use the new StoragePartitionConfig > class. > > Bug: 1085275 > Change-Id: I6679ee79ce88cf7cbfdfeb2686452d0cfcc1a9c3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253240 > Commit-Queue: Aaron Colwell <acolwell@chromium.org> > Reviewed-by: Aaron Colwell <acolwell@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Auto-Submit: Aaron Colwell <acolwell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781691} TBR=acolwell@chromium.org,alexmos@chromium.org,karandeepb@chromium.org,wjmaclean@chromium.org Change-Id: Iec47df87cb66a779d2d569e825c9b4ecccf1f2ef No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1085275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263216Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#781798}
-
Oleh Lamzin authored
Add unit tests for probe service. Bug: b:158658869 Change-Id: I3feff23e437d1883b7f4be9c9dcb97910f3ad85d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248185 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#781797}
-
Bret Sepulveda authored
TBR=dgozman@chromium.org Bug: 1098676 Change-Id: I23a31f259679aba894d75b6d17ec1d6b90895495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263157Reviewed-by:
-
Omar Morsi authored
This CL changes NetworkHealthUnittest after CrosNetworkConfig starts to report VPN device state when CrosNetworkConfig::GetDeviceStateList function is called. Bug: 1064893, 1082327 Change-Id: I958f530676f4847b7c62dc491a86480184a9b56c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253765 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592967357-1044ce77a8c2825b6c9c5357d74768eafbc87565.profdata to chrome-win64-master-1592971072-917710ea24284ef9aa6ebcca30f6d2746c0234cd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I926fdf3a7d7715d992f037b424494798ca82e091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263172Reviewed-by:
-
Anders Hartvoll Ruud authored
I'm guessing it differed from the main longhand order at some point, but currently it's identical to the shorthand that's generated. R=ericwilligers@chromium.org Change-Id: I388d3dd4d51ba18948246cb07083e1f48926f0a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253740Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#781793}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/839704450200..fbb9dc2cf1af 2020-06-24 johnkslang@users.noreply.github.com Merge pull request #2285 from proydakov/msvc-rtti-compilation-warning-fix If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: Ice58ab440fa5d2537e43a0121c00a9ac147aebbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263173Reviewed-by:
-
Christoph Schwering authored
This CL cleans up the UMA metric code for the Autofill.FormDynamicity metric, which is not needed anymore. Bug: 1082744 Change-Id: I4a5efe995edae005b7a431ad2d0975b06dd05d81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252181Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#781791}
-
Friedrich Horschig authored
The new metrics ReauthToUnlockAccountStore.* report whether reauth succeeded or was aborted/failed. It's split by access points: - Filling dropdown - Generation - Settings - Saving/Updating - Moving password Bug: 1063852 Change-Id: Ifd90ae032405d2677f5a5bb554275a2c14e9a67e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252809 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#781790}
-
Kushagra Sinha authored
Change-Id: Ia9a8794d62e11ca294583c524a9f6256ee7b048a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256218 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#781789}
-
Denis Kuznetsov authored
Bug: 1073095 Change-Id: I505c982ee92bf7ef4c58f419989ee64e3a50415c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260601Reviewed-by:
Renato Silva <rrsilva@google.com> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#781788}
-
Denis Kuznetsov authored
Bug: 1073095 Change-Id: I1fb8dc3865279f34be2fbb7bc7012dfb0e12d456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262953 Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
We have Net.KeepaliveRequest.BlockStatus but that doesn't count requests cancelled by the onBeforeRequest WebRequest API. Bug: 1098251 Change-Id: Iadc526a6acc7eb9b6142d643bbe0df07a56086c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260474 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#781786}
-
Denis Kuznetsov authored
Fixed: 1097739 Change-Id: Ic10887517d34390de9a05e00073d537d9f25bdbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260653 Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
-
Morten Stenshorne authored
And even (unintentionally) fix a bug in nested multicol! Avoid duplicated work and duplicated code. We used to have separate code paths for setting the block-size, depending on whether we were in a block fragmentation context or not. In the case of the block layout algorithm, we even calculated the block-size twice when we were block-fragmented: First at the common place (in FinishLayout()), then we'd just discard that, and calculate it over again, but this time correctly for block fragmentation (FinalizeForFragmentation()). Let's just do it correctly the first time instead. Cleaning up the code allows us to call FinishFragmentation() even when the fragmentation block-size is unknown (initial column balancing pass). This actually fixed a bug, which I discovered because a unit test started to fail, but that was just because of the fact that the test assumed that there was no column balancing, even though column-fill was 'balance' (initial value). Set it to 'auto' instead to get expected behavior. Also added a web test that demonstrates what got fixed. Introduce two setters and getters for block-size in NGBoxFragmentBuilder. Regular layout will set the CSS box size (as if all fragments were stitched together into one tall fragment), then pass it on to the block fragmentation machinery, which will set the actual fragment size. I also realized that intrinsic block-size makes no sense when a node fragments (nobody uses it in such cases), so we'll now DCHECK that there's only one fragment. Bug: 829028 Change-Id: I820e1b281ba19bd8e39b1b55f52288000d8b802c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255365Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#781784}
-
Oleh Lamzin authored
Introduce probe service converters. It's a good practice to use mojo::StructTraits or it's preferred to use mojo:TypeConverter even when it's deprecated, but in our case we may need to change converter in the runtime. For example, depending on some policy value we may/may not provide some fields: https://chromium.googlesource.com/chromium/src/+/refs/heads/master/docs/security/mojo.md#use-structtraits Bug: b:158658869 Change-Id: Ibfe1ef41d71e4dcb90581354135b1a9d44d28a9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252038 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Cr-Commit-Position: refs/heads/master@{#781783}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/42297a7669fc..1c99a943d920 2020-06-24 wolfi@chromium.org Revert "Logic to log event for panel closed." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1074732 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iad8769158b5f8ead3327eeccdf74f2198258123c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262797Reviewed-by:
-
Koji Ishii authored
The DCHECK was added to ensure |AddLine| is executed after |SetCurrentLine|, which is not true for this unit test. Bug: 982194 Change-Id: Idfdb0f5bd61f973937ffbc19c0da2e7d8d268047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262028 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#781781}
-
sandromaggi authored
This re-adds the hiding of keyboard if it shows up in an unexpected state. Bug: b/159113241 Bug: b/153625351 Change-Id: Iea7cdc1ffa97a4edf3fe8c4a602b7960dad19bba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253978 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#781780}
-
Fergal Daly authored
These tests are exercise the feature a lot and have seen some failures and will likely see more for RD on main frames. This will also ensure that fixes don't regress. This is a bit messy since SitePerProcessBrowserTest has many subclasses that are already parameterized. Since I care more about running the main bulk of tests parameterized against RB level, I'm not going to double-parameterizer them unless someone thinks some of them are important to get. - Create SitePerProcessBrowserTestBase and move already-parameterized tests to inherit from that. - Parameterize SitePerProcessBrowserTest and instantiate all subclasses. - Rename SitePerProcesProgrammaticScrollTest, it's missing an "s" - disable the subframe version of SitePerProcessBrowserTest.NavigateCrashedSubframeToSameSite pending the fix in https://crrev.com/c/2246087 Bug: 1064944 Change-Id: I881567e6e673a6ee29251123c5cbcace61c6d748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250142 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#781779}
-
Asami Doi authored
This CL updates browser tests in InstallableManager to support offline environment by default. By this changes, all existing tests in InstallableManager should work correctly both when the CheckOfflineCapability flag is enabled and disabled. In the following CL, I'll update fieldtrial_testing_config.json to enable the CheckOfflineCapability flag for dry run: https://chromium-review.googlesource.com/c/chromium/src/+/2235580 Bug: 965802 Change-Id: I0581172fab336539985bc88da83d0faaf90f0034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246042 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#781778}
-
Sigurd Schneider authored
The file ads_page_load_metrics_observer.cc included a mojo definition file from blink, instead of the shared version. This resulted in flaky build failures, as the blink version of the mojo is not a GN dependency, and was sometimes not yet generated. TBR=jkarlin@chromium.org Bug: chromium:1095617 Change-Id: Id6930a4f7af08c6ff0344f853dea7b79ce2d3748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262613Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#781777}
-
Alex Chau authored
- It'll be replaced by chrome/services/sharing/nearby/platform_v2 introduced in https://chromium-review.googlesource.com/c/chromium/src/+/2228543 Bug: 1091190, 1092595 Change-Id: I3e16a8831e8c5e04326485f497e1bb00354ce354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247726Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#781776}
-
Zain Afzal authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/JFXGDZ4SXUx3Hmzx9tzDH7x90Qb-Oa2Z_BqPo4BfioIC Release notes: http://go/media_app-x20/relnotes/Stable/media_app_202006230800_RC00.html Bug: b/159408606, b/159186081, b/159305536, b/133374709, b/159407608, b/159409929 Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: Ief3e29faa262ee79ccf823dfd142272887ad32cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262378Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Commit-Queue: Zain Afzal <zafzal@google.com> Cr-Commit-Position: refs/heads/master@{#781775}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I927f065cd5bcb7ccff8c77fc95b5ec3cfad41624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262796Reviewed-by:
-
Joel Hockey authored
This is a refactor to move code out of file_manager.js and into crostini_controller.js in preparation to add more features for showing messages. Updated UI tests to use FILES_NG_ENABLED and work with all files that import from chrome://resources such as files_message.html. Bug: 1095889 Change-Id: I9c9f34304e26dca8df4c0aa64a51c124650385b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259873Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#781773}
-
Mugdha Lakhani authored
Explicitly disable more features with failing WPT tests. Spreadsheet with details (Google internal only): https://docs.google.com/spreadsheets/d/1mBU2pCrRPkw67-9hlcD-xN5bE6F5LM34kccd-Ptf3wc/edit?usp=sharing Bug: 1087494 Change-Id: Iec331d5cd706b0e6e41ea7c2c8dbed9ec36c7453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254600 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#781772}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib7eceadd228ba6948b2fd3d6e66fc3505c990b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262123Reviewed-by:
-
Hajime Hoshi authored
Before this CL, the detection whether the page was in background between when the page was restored the first-paint happened was not accurate. The checking function checked only the last timings were checked and did not consider multiple restorings. This CL fixes this issue by recording all the backgrounding states related to restoring, and check an appropriate state by specifying an index. This CL also added an item to histograms.xml Change-Id: I9ae6b0bb8ee192f21ae42c518166372106bfb878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251526 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#781770}
-
