- 31 Oct, 2020 34 commits
-
-
Austin Eng authored
This adds webgl_conformance_tests with --enable-unsafe-js-fast-calls to: Optional Win10 x64 Release (NVIDIA) Win10 FYI x64 Release (NVIDIA GeForce GTX 1660) Win10 FYI x64 Release (NVIDIA) Win10 FYI x86 Release (NVIDIA) Win10 FYI x64 Exp Release (NVIDIA) They run on the trybot win_optional_gpu_tests_rel Bug: 1101475 Change-Id: Ic832e9a67528fad38874eefa70962ec70965a043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506519Reviewed-by:Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#822916}
-
Tom Anderson authored
This is a speculative fix for a crash where seccomp blocks lazy library loading, which may occur on certain versions of the Nvidia driver. R=kbr BUG=1137632 Change-Id: I7716739263ffb3b478003ad9eef4ffaa2b6467f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510360 Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
-
Michael Hansen authored
Removes the "Contacts" title and updates strings in the description for each visibility mode to match the latest specs. Screenshots: https://screenshot.googleplex.com/An6Ta8EDzfS3KZU.png https://screenshot.googleplex.com/C5WwqifMeCnLhkH.png https://screenshot.googleplex.com/C48HQVfgouJrhHF.png Strings spec: https://docs.google.com/document/d/1s-KjC1mM4ZPYeYAO7oI8lXltS_1FaYYfMMnNDdbfRag Bug: b:168841167 Change-Id: I5facb117242e22b838266c2fa5e2629b221e6794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511852Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#822914}
-
Charlene Yan authored
The ID 2001 was already in use by the SendTabToSelfMenu. Also delete some unused constexprs. Bug: 1141858 Change-Id: I10f04c0eb01f17d26f4962b37789588adde3e079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495713Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#822913}
-
Xianzhu Wang authored
- Remove unused ContiguousContainer methods such as Clear(), Swap(), etc. - Replace RemoveLast() with ReplaceLastByMoving(). This removes the logic to deal with removed items, making ContiguousContainer appending only. - Let ContiguousContainer store Buffer directly in the vector instead of through unique_ptr. - Use 'item' instead of 3 different terms 'item', 'element', 'object' in ContiguousContainer - Remove DisplayItem::IsMovedFromCachedSubsequence() because with the new PaintChunkSubset we can use PaintChunk.is_moved_from_cached_subsequence. - etc. Bug: 917911 Change-Id: I8b3004d001ea12a00fed96fc3e031986db1ee005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501064Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#822912}
-
Avi Drissman authored
Bug: 1100642 Change-Id: I1e282150bd7c0774aa00f59012a14d1330d43f1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511090 Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#822911}
-
Gordon Seto authored
Add QR code detection logic and styling to cellular esim setup. Screenshots: https://screenshot.googleplex.com/64NSd3tsBZWT2pJ.png https://screenshot.googleplex.com/7ks7FBaXpYFAt6z.png https://screenshot.googleplex.com/86VbgmA3Y2TDFAG.png Bug: 1093185 Change-Id: I9631aeeee9db8fe67a4b18cf48fd7576556b32cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495873 Commit-Queue: Gordon Seto <gordonseto@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#822910}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/e9a7015ec876..5cbd052dfba9 2020-10-30 apodtele@gmail.com Add preamble. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I4f521ab2294810c0c03ac9d3a4dcc4082d860756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509554Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#822909}
-
Shimi Zhang authored
We reinterpret scroll gestures conditionally for cursor control purpose. This is done by add a new bit |kInternalPanXScrolls| to TouchAction, This bit is suppressed by TouchAction::kPanX, i.e. we only set this bit when TouchAction::kPanLeft or TouchAction::kPanRight is set. By default, if an element has TouchAction::kPanX, it will be set. Therefore, TouchAction::kAuto has this bit as well. When |kInternalPanXScrolls| is set, we don't do cursor control. When an element is flagged as editable, we remove |kInternalPanXScrolls| bit for that element and its descendants. Therefore, if there is an editable element, because it is not equal to TouchAction::kAuto, the browser side will get a signal and set |has_touch_event_handler_| as true in TouchActionFilter. In painting stage, we also calculate horizontal scrollable information for an element, if an element or its ancestor is horizontal scrollable, we put |kInternalPanXScrolls| bit back to the corresponding TouchActionRegion to disable cursor control. When a touch start event happens, it will be dispatched to the renderer since we know there is a touch event handler, the browser will get the compositor touch action from the compositor hit test. The event will be further dispatched to the renderer main thread, we do another hit test, we also need to acquire the horizontal scrollable information for the hit test result element, so we could decide to put |kInternalPanXScrolls| back to the main thread touch action or not. Main thread touch action will also be sent to the browser. When a GestureScrollBegin generates, we use the compositor touch action and the main thread touch action to filter it, because compositor touch action is permissive, if we don't have |kInternalPanXScrolls| bit on the touch action, we delay the event until we get the main thread touch action. If |kInternalPanXScrolls| is not set and |kPanX| is allowed and this is a horizontal scroll, we set the GestureScrollBegin's |cursor_control| flag to true, therefore, the whole scroll gesture sequence will be used as cursor control. In this way, we fulfilled multiple design goals: 1) cursor control can be disabled by not set touch-action: pan-x 2) cursor control can be disabled by register a non-passive event handler of the touchstart event and calling event.preventDefault() inside. 3) cursor control is disabled when the element is horizontally scrollable. 4) cursor control is not interleaved with scroll. Bug: 1126778 Change-Id: I7a1c58f60740ff87dbee460524de66c67878dc64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435324 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#822908}
-
Jimmy Gong authored
Onboarding UI is now hidden when either the user dismisses the UI or if the user has completed the onboarding flow. Bug: 1106937 Fixed: 1141634 Test: chromeos_components_unittests Change-Id: I0e34bed1977f6b72cf45bab1f2fd289deaa630da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508953 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
-
Tim Song authored
This CL adds the following metrics logging the current screen when a given event occurs: * Ash.PhoneHub.ScreenOnSettingsButtonClicked * Ash.PhoneHub.ScreenOnBubbleOpen * Ash.PhoneHub.ScreenOnBubbleClose To implement these metrics, we also refactor the individual content views to return a Screen enum. BUG=1138137,1106937 Change-Id: I8f78bd270004a34794882252b73d68d0d8f0942f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500578Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Dale Curtis authored
The entire output buffer should be used, but apparently it's not always. So to avoid exposing uninitialized memory, zero initialize the AudioBuffers just like we do for VideoFrames given to ffmpeg. R=cassew Fixed: 1144070 Change-Id: Ic08a760cd63ca4fae26932621445991e781a0941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511969 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#822905}
-
Mike Wittman authored
Replace DISALLOW_COPY_AND_ASSIGN, delete destructor, use NoDestructor in place of LazyInstance, and make enums camel case. Change-Id: Icf278d2755acc8e3fd8fb97b071d0c199f4353b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438887 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#822904}
-
Bill Budge authored
- Adds SharedArrayBuffersAllowed method to ExecutionContext, which checks for the feature flag, or cross-origin isolated status. - Checks that SABs are enabled before transferring them. - Disables no COOP+COEP tests on desktop, as SABs are enabled by default, which causes these to fail. - Enables *most* WPT /safe-passing-of-structured-data/shared-array-buffers tests on Android. Several of these test transfer of SABs. Bug: chromium:923807 Change-Id: Ib91233884376a3ea55d9d61f06e498bc53517f49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343658 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#822903}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=nparker@chromium.org Bug: 1142671 Change-Id: Ib1f4ae0de89d1777357b2904ef6ed756fc9b1f92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500558 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#822902}
-
Sorin Jianu authored
Bug: 1144360 Change-Id: I60389ee39fd525250a768f184132d2f812a34be9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511755Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#822901}
-
Josiah K authored
AX-Relnotes: Add support for panning the fullscreen magnifier viewport with Ctrl+Alt+Arrow keys Change-Id: I263be6236f7060cd12d2037e82f070a6f0863cf4 Bug: 1140624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510911 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#822900}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I225fa0314dc0a0daa377a6e344d2f05811b065ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510666Reviewed-by:
-
Bartek Nowierski authored
The pointer is used for reinterpret_cast in: net/third_party/quiche/src/quic/core/qpack/qpack_receive_stream.cc:29 net/third_party/quiche/src/quic/core/http/quic_spdy_stream.cc:773 net/third_party/quiche/src/quic/core/http/quic_spdy_stream_body_manager.cc:99 Bug: 1069567 Change-Id: If0c54da8255f312f047bc3da6c35c601e8d868d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509891Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
Olivier Yiptong authored
Minor refactor that makes the cache initialization have clearer steps. Also paves the way for future cache invalidation functionality. Change-Id: Ie929e32e44ad890cde9313bdeb218cdb2e380086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505560 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#822897}
-
Ana Salazar authored
We want to give users a quick shortcut to access recent nearby shared files within Tote. As user receives a file via nearby share, we should be able to add them to the holding space model in a similar way we add downloads as they are completed. Bug: 1130625 Change-Id: Iba7ab69e7f8d9b7c05e740e8e4331b85a890b423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463584Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#822896}
-
Xianzhu Wang authored
We had two places where PaintLayerCompositor::CanBeComposited() was called for the LayoutView in a throttled frame. Now let the callers check throttling status and fallback to use the current compositing status when the frame is throttled. This avoids the need of forced compositing inputs update when a throttled frame is unthrottled. Bug: 1139116 Change-Id: Id8069d5b26707e1ee3422b27742a6de29029a619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505727Reviewed-by:
-
Devlin Cronin authored
The following are still useful. Extend their expiration date to 2021. PageActionController.ExtensionsWithPageActions ExtensionToolbarModel.BrowserActionsCount ExtensionToolbarModel.BrowserActionsVisible Extensions.UninstallDialogAction Extensions.ResetPermissionsIncrease Extensions.ProcessManagerStartupHostsTime2 Extensions.Permissions_WebStoreInstall3 Extensions.Permissions_AutoDisable3 Extensions.Permissions_InstallCancel3 Extensions.Permissions_WebStoreInstallCancel3 Extensions.Permissions_Load3 Extensions.Messaging.MessageSize Extensions.LoadUserScript Extensions.ExtensionServiceInitTime Extensions.EventPageIdleTime Extensions.ExtensionServiceNotifyReadyListenersTime Extensions.DidCreateScriptContext_ContentScript Extensions.DidCreateScriptContext_WebUI Extensions.DidCreateScriptContext_WebPage Extensions.DidInitializeServiceWorkerContextOnWorkerThread Extensions.DidCreateScriptContext_Unspecified Extensions.DidCreateScriptContext_LockScreenExtension Extensions.DidCreateScriptContext_BlessedWebPage Extensions.DidCreateScriptContext_Blessed Extensions.DidCreateScriptContext_Unblessed Extensions.BackgroundPageLoadTime2 Extensions.Bindings.NativeBindingCreationTime ExtensionBlacklist.SilentInstall ExtensionBlacklist.UnblacklistInstalled ExtensionBlacklist.BlockCRX ExtensionBlacklist.BlacklistInstalled Extensions.HasPermissions_WebStoreInstallAbort3 Extensions.HasPermissions_InstallAbort3 Bug: 1140057, 1140044, 1140042, 1140041, 1140040, 1140038, 1140037, 1140036, 1140035, 1140034, 1140033, 1104939, 1088786 Change-Id: If788baa32b7933c50b309be199558d175f45273d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485618Reviewed-by:Steven Holte <holte@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#822894}
-
Meilin Wang authored
This CL updates the bubble width to use |kTrayMenuWidth|. This CL also includes minor refactoring such as: - Replaces hard-coded constants with calculation. - Introduces ui_constants.h to store both appearance and URL constants. Screenshot: https://screenshot.googleplex.com/6PBiuFovTjyfjaa.png BUG=1143058,1106937 Change-Id: Icdf17321a9acd9be53b7287023e197e027fcac62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510551 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#822893}
-
Regan Hsu authored
This is a reland of a42b2a30. phone_model_test_util's CreateFakePhoneStatusModel() returned unexpected mobile status, resulting in failing tests. Created TetherControllerImplTest's own CreateFakePhoneStatusModel() to fix. Original change's description: > [CrOS PhoneHub] Mark tether ineligible if SIM has no reception. > > TetherControllerImpl will now mark the tether feature ineligible if > it is notified by the PhoneModel that the SIM state has changed to > anything other than kSimWithReception. > > Fixed: 1140812 > Bug: 1106937 > Change-Id: Ia18c5e06c57805541b03b29afea1762e85b8304f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500182 > Commit-Queue: Regan Hsu <hsuregan@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821493} Fixed: 1140812 Fixed: 1143173 Bug: 1106937 Change-Id: I310daa1d1feea6a74485ddd143608b216414f3bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507632 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
Regan Hsu authored
Sometimes, the browser tabs do not appear in PhoneHub. This may be because the decrypted metadata (which includes the pii free name) may not have been ready during initialization. This CL adds a refetch of browser tab metadata when the decrypted metadata is ready in those instances. Fixed: 1143045 Bug: 1106937 Change-Id: I7ccba192336b77fe860be9accde007dd9be70a7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505585 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/deea5b13b56d..cabef8da90bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC thomasanderson@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1142846 Tbr: thomasanderson@google.com Change-Id: I3c88aeb4d50856b9ad1d7b9db0749b5c270e31f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511200Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822890}
-
Bartek Nowierski authored
Ran the command from the lines 55-60 in the file to update the repository list. Bug: 1069567 Change-Id: I77d4a54847367605a34147d0ca117be36f2a1f9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509617Reviewed-by:
-
Michael Ludwig authored
Bug: 1143918 Change-Id: Iae97adca50d7a84e06059a4749a802fe3f43900c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508336 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Auto-Submit: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#822888}
-
Stephen Martinis authored
This CL updates the find_bad_builds.py script to look at the buildbucket data to decide which builds to cancel. CLs which land in chromium/src can often cause issues with the Chromium CQ, for a variety of reasons. Most commonly, CLs can cause test runtimes to dramatically increase, which overloads our pools. One way to mitigate issues like these is to cancel builds which contain the bad CLs, to alleviate the load on our machine pools. This CL adds a fairly simple script which finds build which contain a specific CL. There are many possible features and additions to this script, but the simple version in this CL should be useful enough for now. Bug: 1137072 Change-Id: Ib163a4bbb78c17c11ecb17c836a8e62da2b66453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464165 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#822887}
-
Aleks Totic authored
Landing TablesNG paint caused an 8% perf regression in blink_perf.paint large-table-background-change.html In my pinpoint measurements, I saw a 6% regression. https://pinpoint-dot-chromeperf.appspot.com/job/16ba906e520000 This patch brings the regression down to ~3%. The regression was caused by queries for fragment type. IsTableNGPart boolean has been added to PhysicalFragment, allowing quicker response to IsTableSection/Row queries. Bug: 1143139, 1143168 Change-Id: Ifa02a75119bfcef657106807c304dcd4a39ac3b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510830 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#822886}
-
Bartek Nowierski authored
This is continuation of crrev.com/c/2503324 -- see methodology described in the description of that CL Bug: 1069567 Change-Id: I522ba7cee257be8c08fe77f2ed97f9330b9b0b38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509611 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Stefan Smolen authored
This is a change we made to Edge to pin shell32.dll so it will not be unloaded, due to an OS bug where it would be unloaded while still in use. Bug: 1076771,1075487,1139752 Change-Id: I836ddb663ca6d76984186306023ec2a47f9d8fdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505835Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Stefan Smolen <ssmole@microsoft.com> Cr-Commit-Position: refs/heads/master@{#822884}
-
Keren Zhu authored
Reported by A11y test team, the screenreader cannot traverse into the IPH bubble. This is because the bubble was marked as A11y tree leaf node. https://bugs.chromium.org/p/chromium/issues/detail?id=1128728#c71 Bug: 1121399, 1128728, 1144334 Change-Id: I6fbfc617bdffae827b53f5c7c9e55cff5bd0e2ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511590 Auto-Submit: Keren Zhu <kerenzhu@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#822883}
-
- 30 Oct, 2020 6 commits
-
-
Bartek Nowierski authored
Change-Id: Ie9eda8b5e696099cf080b8a3477267076185b936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502708 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#822882}
-
Daniel Cheng authored
This allows RenderFrameHostImpl to make a stronger assertion about the expected state of its associated FrameTreeNode when creating a RenderFrameHostImpl with LifecycleState::kActive. Bug: 1069205 Change-Id: I3cee3c237fff1a79f32ced79c0bdd05106bb5848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509339Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#822881}
-
Bartek Nowierski authored
We want to protect it. It doesn't seem to cause crashes that we've seen in the past and perfornce doesn't regress with BRP. Bug: 1141567, 1069567 Change-Id: I29b05dfe188961c26287138009e1fdf70f871d92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509870Reviewed-by:
-
Mustaq Ahmed authored
Bug: 848778 Change-Id: If8b8f9e8ee29ac3d7acae751e2d062a7e838bf40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507512Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/740ae9f60b00..142cb87f803d 2020-10-30 johnkslang@users.noreply.github.com Merge pull request #2387 from BNieuwenhuizen/nonuniform If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: Idb0a787532500b3b3f631c27366fd060332ebccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510785Reviewed-by:
-
Akihiro Ota authored
This change fixes an issue where ChromeVox would interrupt itself when reading text content. The cause for this is that we previously restarted the nudge timer when a focus event fired. This works for buttons, but focus events do not fire when range moves between text content. Instead of restarting nudges when a focus event fires, do so when the current ChromeVox range changes. A test is also included to confirm behavior. Bug: 1141643 Change-Id: I8245e98b40398a1964bf33b1a14e16ff7e6889a9 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503635Reviewed-by:
-
