- 03 Sep, 2020 40 commits
-
-
David Van Cleve authored
We occasionally fail Trust Tokens operations due to transient unavailability of the entire Trust Tokens logic, for instance when third party cookies are being blocked unconditionally due a user setting. This logic (in url_loader_factory.cc, providing the `authorizer` callback argument to TrustTokenRequestHelperFactory) means that Trust Tokens operations will sometimes fail "during normal operation," at no fault of the caller's. We'd like to avoid printing console errors in this case. For instance, right now because third party cookies are disabled by default in incognito mode, we print a console error on every Trust Tokens operation executed in incognito mode. This CL extends the Trust Tokens-related console message suppression in FrameConsole to encompass "unactionable" Trust Tokens failures, like ones due to TrustTokenOperationStatus::kUnavailable, which represents an unavoidable unavailability of the Trust Tokens subsystem. Test: Adds an inspector-protocol WPT ensuring no errors are logged Bug: 1111572 Change-Id: I53898a272fb8063cdbddfda0e916e49525973d09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385878Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#804251}
-
Luciano Pacheco authored
Add DCHECK for conditions that fails to launch Files app. Add warning log if can't launch Files app when it isn't ready. Bug: 1090211 Change-Id: Iec2a20bb648354e83b7f7fa95df380b1f5182dca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390929 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#804250}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1d46a533aa37..c4bfa82e48ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If3242372f90e69ef6fb81add5e5667fb841bbfed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392619Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804249}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /services/video_capture This CL was uploaded by git cl split. R=chfremer@chromium.org Bug: 1110266 Change-Id: I40bf9a0a66648430358fb0de198bd648c52a1324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370733Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Sean McAllister <smcallis@google.com> Cr-Commit-Position: refs/heads/master@{#804248}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8badb56a..99d869bb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4a931bbf0aa2be63c57bd18df8c42edb3b95b93e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392576Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804247}
-
Koji Ishii authored
Change-Id: I96587805e3f3bc5e72d86eb2098fa665d7f23cb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391945Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#804246}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ef0fb4c2707e..c4bfa82e48ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I420e251cfd4df4aae58f2c1dc71d62d805278f03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392618Reviewed-by:
-
Chris Sharp authored
Bug: 1018157 Change-Id: Ie0aa4584ac2bae1f156751693beda6a94279c14e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390544Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#804244}
-
Xianzhu Wang authored
BTW avoid a possible warning of an uninitialized field (which didn't actually happen). Change-Id: I8a895b8a95d394f4652e662402f108331d71a1d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390968 Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#804243}
-
Jacobo Aragunde Pérez authored
Includes one generic test for BubbleDialogDelegateView and specific tests for bubbles that behave like alerts and are known to be properly working. The generic test does not work on Windows, this has been reported as crbug.com/1123933 and marked with a TODO. The specific tests expose a known bug about duplicated events that is already reported as crbug.com/1082217. This fact is documented with a TODO in the test code. Bug: 1082217, 1119349, 1123933 Change-Id: I5019b67c965bdfb83589da4db1402e6b9067011a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378306 Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#804242}
-
Joshua Pawlicki authored
Bug: 1114727 Change-Id: I3740a4732a97502f2e51cac7501e33399ef7d75e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346728 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#804241}
-
Antonio Sartori authored
This CL uses the "Subsume" algorithm for Content-Security-Policy Embedded Enforcement https://w3c.github.io/webappsec-cspee implemented n the services/network CSP module from the AncestorThrottle for checking whether a frame should be allowed to embed or not. The same behaviour is currently enforced by blink. The new version is hidden behind a feature flag. Change-Id: I4f72782a209bda967843e290d180167151fca852 Bug: 1094909,1086857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270206 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#804240}
-
Devlin Cronin authored
Add instructions for removing flags to flag_expiry.md. Bug: None Change-Id: Ib42fd8ccd062b1612091235204db000ca2a4fff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389015Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804239}
-
Maksim Ivanov authored
Print developer-friendly DCHECK failure messages in case the program crashes due to misuse of Task APIs - e.g., trying to post a task to the UI thread in a unit test without creating a BrowserTaskEnvironment. This targets these two (mis)usage scenarios: (1) calling content::GetUIThreadTaskRunner()/GetIOThreadTaskRunner() without having a BrowserTaskEnvironment; (2) calling base::PostTask() with |content::BrowserThread::UI|/|::IO| without having a BrowserTaskEnvironment. Before this change, these scenarios were triggering obscure crashes that are hard to decipher for developers, namely: * "[FATAL:browser_task_executor.cc(293)] Check failed: g_browser_task_executor." for scenario #1; * "[FATAL:task_executor.cc(70)] Check failed: executor." for scenario #2. In order to improve this, the following changes were made: * A DCHECK message was added into base::GetRegisteredTaskExecutorForTraits() - the previous message-less DCHECK was preventing the helpful message in base::GetTaskExecutorForTraits()'s DCHECK from being reached. This helps in the scenario #2 from above. * A DCHECK message was added into BrowserTaskExecutor::Get() that is analogous to the DCHECK message from base::GetTaskExecutorForTraits(), and code throughout the file was changed to use this Get() function instead of DCHECK'ing the same without any message. This helps in the scenario #1 from above. * A Death unit test was added that verifies that scenarios #1 and #2 trigger DCHECK failures that contain the "BrowserTaskEnvironment" substring, which would prevent from regressing in this debug logging again. Bug: none Change-Id: I959c4971537d2096321e573d148974f347a58f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368600Reviewed-by:Scott Violet <sky@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#804238}
-
Juanmi Huertas authored
Clear was not yet private as it was still being used by Canvas 2D Layer Bridge. Removing that usage now, and marking Clear as Private inside Canvas Resource Provider. Adding an explicit DidDraw to the creation of the Resource, as it has been cleared on construction. I am leaving a GetOrCreateResourceProvider in line 101 as it was called, and that would, potentially, recreate the Resource. It would be also a good follow-up to try to see if there is a way to encapsulate the things DidDraw is doing here and in other places where it is being called after the internal Clear of the CRP, to have it done internally as well. Bug: 1090081 Change-Id: I87a5b6d20a1d79606e1d986c484f2677edde2863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382612Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#804237}
-
Thomas Lukaszewicz authored
This CL fixes a bug where the Layer implementing the corner mask for the ClientView is not updated when the BubbleFrameView's corner radius is updated. Bug: 1124016 Change-Id: I30e9588080b7c7aebc792b911b3bdbbaa719eba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391640Reviewed-by:
-
Sorin Jianu authored
Since the updater is implemented only for per-user installs, restricting the testing hooks (and thus, the external constants to admin privileges) does not get us anything. And on the negative side, requiring admin privileges for integration tests breaks COM RPC in Windows with UAC on. Due to integrity control, when COM is running at high integrity, COM only looks up its registration under HKLM. The current implementation of updater is using per-user COM. Therefore, developing integration tests requires hacking of the tests, which is undesirable. For a related change, this CL also enables integration tests in component builds for Windows. Typically, Windows devs build the project as a component-build with debugging symbols (level 2), such that full debugging is possible. With this change, a Windows dev is able to develop, build, run, and debug integration tests without needing elevation at all, or another build configuration. Bug: 1124585 Change-Id: Id3e1195dfef2183faf0b3857a439a03411566c93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392082Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804235}
-
Yifan Luo authored
Bug: 1116418 Change-Id: I9a68ca6af9c3fc8c1012bf42d91c92d702a922a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391085 Commit-Queue: Yifan Luo <lyf@chromium.org> Reviewed-by:
Yifan Luo <lyf@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#804234}
-
Frédéric Wang authored
Partial support for the accent/accentunder attributes on the munder, mover and munderover elements has been added in the UA stylesheet [1]. This CL modifies the munderover layout algorithm to take these boolean attributes into account when determining gaps and shifts parameters as specified in [2] and [3]. Additionally, for overscript we also rely on the OpenType MATH.MathConstants.AccentBaseHeight parameter as specified in [3]. This makes the remaining underover-parameters-3.html test pass. Note that underover-parameters-4.html no longer corresponds to what is in the MathML Core specification [4] and we will ignore it in our implementation. Finally, this CL extends underover-parameters-3.html to also test dynamic changes of accent/accentunder attributes, using various syntaxes for true/false. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2184131 [2] https://mathml-refresh.github.io/mathml-core/#base-with-underscript [3] https://mathml-refresh.github.io/mathml-core/#base-with-overscript [4] https://github.com/web-platform-tests/wpt/commit/aab53f17c0f688da550311ddc919c1702fb8681b Bug: 6606, 1124285, 1124289 Change-Id: Ie589a2f2a00e6f49b15376bd83762d34c914fd65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391083Reviewed-by:
Rob Buis <rbuis@igalia.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#804233}
-
Nicolas Ouellet-Payeur authored
This reverts commit e97a414a. Reason for revert: crbug.com/1124751 Original change's description: > media/gpu/vaapi: Introduce ScopedVABuffer and use for encoding and Vpp > > VaapiWrapper owns VABufferIDs of the VA buffers that are used > outside of VaapiWrapper. This CL moves the ownership out of > VaapiWrapper. The VA Buffers are owned by ScopedVABuffer in order > to prevent the buffer leakage. > Ths ScopedVABuffer will be used for other VABufferIDs later. > > Bug: b:166646505, b:162962069 > Test: video_encode_accelerator_tests on atlas > Test: media_unittests --gtest_filter=VaapiVideoEncodeAcceleratorTest > Test: vaapi_unittest --gtest_filter=VaapiUtilsTest > Change-Id: I7b0dda7491d29ebba70bc42051a8657144209dda > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379423 > Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org> > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804103} TBR=mcasas@chromium.org,jchinlee@chromium.org,hiroh@chromium.org,andrescj@chromium.org,wtlee@chromium.org Change-Id: I943ecf23284c208860233bcf5f3e774e9761363a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:166646505 Bug: b:162962069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392402Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#804232}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /chrome/browser/web_applications This CL was uploaded by git cl split. R=ortuno@chromium.org Bug: 1110266 Change-Id: Idfa976a6741f19d840933bbd7eb3150e4cf50136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371283Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Sean McAllister <smcallis@google.com> Cr-Commit-Position: refs/heads/master@{#804231}
-
Nicolas Ouellet-Payeur authored
This reverts commit fc33ef5c. Reason for revert: consistent failures on linux-chromeos-dbg, e.g.: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/20275 Original change's description: > Files app: Change opening a folder navigates to the folder > > Change Files app to navigate to the directory when a "selectionURL" > provided in the launch params. Before this CL Files app would only show > the directory selected. > > This change is to support the workflow from Issue:1090211. From ARC++ > the intent to "ACTION_VIEW_DOWNLOADS" will open the Files app in the > Downloads folder. > > Bug: 1090211 > Change-Id: Ic6b9d290936f4a25576f3bfd5a799c37f6fa2195 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379345 > Reviewed-by: Alex Danilo <adanilo@chromium.org> > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804071} TBR=lucmult@chromium.org,adanilo@chromium.org Change-Id: I064c8f5ff3fdaacbd41793969ac9463cd83b5fee No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1090211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392437Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1d46a533aa37..c4bfa82e48ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie7afb1f9d4147d4ae14998f074ac9533cba8758d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392617Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3649c2a8b0f1..1580d2fe0230 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC melandory@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1104836 Tbr: melandory@google.com Change-Id: I12f0ecd24411c6e3f0a4ea790a7f83e3d80eddc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392354Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804228}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1164044d4c20..72ab3787b4b4 2020-09-03 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-09-03 wolfi@chromium.org Revert "Fix context menu for issues banner" 2020-09-03 jacktfranklin@chromium.org Component bridges presubmit check If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1123455 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibff023eeb56bc59bb5ad79555b36e439b93ff252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392657Reviewed-by:
-
Arthur Eubanks authored
Bug: 1114873 Change-Id: I45701a5d484481a54514b367ece99259abc64a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366552 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#804226}
-
Danil Chapovalov authored
Bug: None Change-Id: Ife9ebd44511859992b39e11ef13d3cba660317f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391063Reviewed-by:
-
Stephen Nusko authored
This reverts commit e8bb886c. Reason for revert: Still breaks perf bots: crbug/1124326 Original change's description: > Reland "Remove BlockThirdPartyCookies preference" > > This is a reland of 1180542b > > BLOCK_THIRD_PARTY_COOKIES usage in clank is fixed: > https://crrev.com/i/3250184 > > Original change's description: > > Remove BlockThirdPartyCookies preference > > > > The boolean BlockThirdPartyCookies preference was replaced by > > CookieControlsMode enum. Existing settings were migrated since M83. > > Since all usage of the preference has been removed, the preference > > can be removed and existing settings cleared. > > > > Bug: 1104836 > > Change-Id: Ie6e38b0a424981395c627459d684030ea84a58b7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387805 > > Reviewed-by: Balazs Engedy <engedy@chromium.org> > > Reviewed-by: Gabriel Charette <gab@chromium.org> > > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#803844} > > Tbr: gab@chromium.org > Bug: 1104836 > Change-Id: If89041daa0a46da604171acf734b9733d9a24e07 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390655 > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804217} TBR=gab@chromium.org,engedy@chromium.org,dullweber@chromium.org Change-Id: I2a6799c01373c1b5b265fa2518406a2305e1dbd7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1104836,1124326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390912Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#804224}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1599089820-30c557886a4f99c250ad2970e2bac8f9c1182d9f.profdata to chrome-win64-master-1599112620-a8868b59128a8bce1a265b8451e03eb5caa355ad.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: Ia3e059bacc63b309fc83de5f24ab799e38fc41f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392556Reviewed-by:
-
Maksim Ivanov authored
Fix double-callback-call crashes in //content/shell/browser/web_test/web_test_storage_access_manager.cc Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I9fddd7f0c65c877270a86d871044e7b636f75c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384469 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
Nicolas Ouellet-Payeur authored
This reverts commit 5cdaf457. Reason for revert: crbug.com/1124740 Original change's description: > Make NGInlineNode::ShapeText() not to reuse ShapeResult for letter-spacing > > This patch changes |NGInlineNode::ShapeText()| not to reuse > |ShapeResult| for text with CSS property "letter-spacing" because we > modify |ShapeResult| directly to apply letter spacing. Thus, letter- > spacing is applied more than once on reused portion of |ShapeResult|. > > Note: This patch also changes number of bits of > |SharepResult::num_glyphs_| from 30 to 29 to hold bit flags in > |unsigned| (32-bit) for re-landing[1]. > > [1] http://crrev.com/c/2390615 Revert "Make NGInlineNode::ShapeText() > not to reuse ShapeResult for letter-spacing" > > Bug: 1124446 > Change-Id: I120cc379a191e1499ac1548a569474ed03d0f6a5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391890 > Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> > Commit-Queue: Koji Ishii <kojii@chromium.org> > Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804185} TBR=yosin@chromium.org,tkent@chromium.org,kojii@chromium.org,ikilpatrick@chromium.org Change-Id: Ifc310dd7c34b1243d10f64f62cd2144b54bbfa88 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1124446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392577Reviewed-by:
-
Patrick Brosset authored
There is a frontend part to this change: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2379098/ The goal is to track how many grids people highlight in web pages using either the adorner in the Elements tree, or the checkboxes in the Layout panel. The histogram is done in a way where we track when users highlight 0, 1, 2, 3, 4 grids, and then between 5 and 9, 10 and 19, 20 and 49, and more than 50. We have more granularity at the bottom end of the spectrum as the expectation is that users will mostly highlight few grids at a time. Bug: 1047356 Change-Id: I6ff3a0f870b9a6054dcd66af57d90ed3cbe53a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379254Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Vidal Diazleal <vidorteg@microsoft.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Cr-Commit-Position: refs/heads/master@{#804220}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c4bfa82e48ed..fb45a94639ca 2020-09-03 taylori@google.com perfetto-ui: Make sharing/downloading trace consistent If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id89ed49d4178fea6660b8aa70272b060c452473d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392656Reviewed-by:
-
Garrett Beaty authored
These compile targets are currently specified in recipe configuration. Bug: 1091004 Change-Id: Id74efa2c63ec802b5b216e5e4238091f02dc2d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391613 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#804218}
-
Christian Dullweber authored
This is a reland of 1180542b BLOCK_THIRD_PARTY_COOKIES usage in clank is fixed: https://crrev.com/i/3250184 Original change's description: > Remove BlockThirdPartyCookies preference > > The boolean BlockThirdPartyCookies preference was replaced by > CookieControlsMode enum. Existing settings were migrated since M83. > Since all usage of the preference has been removed, the preference > can be removed and existing settings cleared. > > Bug: 1104836 > Change-Id: Ie6e38b0a424981395c627459d684030ea84a58b7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387805 > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803844} Tbr: gab@chromium.org Bug: 1104836 Change-Id: If89041daa0a46da604171acf734b9733d9a24e07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390655 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#804217}
-
Collin Baker authored
Fixed: 1123994 Change-Id: I0f099ad8196ba2a967327bca569b535b0585e9f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388761 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#804216}
-
Garrett Beaty authored
These targets are currently specified in recipe configuration. Bug: 1091004 Change-Id: I41f31ac70d92750d4e5d441d8f8fb992c206395c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391513 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
Olesia Marukhno authored
The first time when match changes its height, pedal button is misplaced and overlaps with another match. This was caused by setting wrong bounds for button row. Previous cl was reverted because wrong bounds were set and that caused button mouse events not working. This is fixed in this patch. Bug: 1121934 Change-Id: I7c1dbbd0b1ec7e59c602a2608f0a7501a26a2490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390905Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Cr-Commit-Position: refs/heads/master@{#804214}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a66a9c31a318..be72801f29f9 2020-09-03 kjlubick@google.com Reland "[canvaskit] Replace RRect objects with TypedArrays." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: Ic12a71d2cbcf40d992ea1808d5d030ece5c96c15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392348Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fc059c13722f..598906885691 2020-09-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from d846ea5a2427 to 399ebf707295 (3 revisions) 2020-09-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from b0337a548273 to 6f1037eec97a (2 revisions) 2020-09-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 09df13c2 to 5881c1ad (369 revisions) 2020-09-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from e1051cbaad46 to 75690ce7ef4a (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: Iaf501e976db782716de9b1f4a7223915b3fab9d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392346Reviewed-by:
-
