GitLab

http://src.chromium.org/viewvc/blink?view=revision&revision=185200

BUG=331251
TBR=robhogan@gmail.com

Review URL: https://codereview.chromium.org/719753004

git-svn-id: svn://svn.chromium.org/blink/trunk@185221 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts commit c67fa612fedd3cf79f999ad61f2022dec85ff032, aka r185205.

Speculative revert to green up browser_tests:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests&tests=PrerenderBrowserTest.PrerenderClickNewBackgroundTab

TBR=jochen@chromium.org
BUG=

Review URL: https://codereview.chromium.org/721793002

git-svn-id: svn://svn.chromium.org/blink/trunk@185220 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Convert fast/css/css-properties-position-relative-as-parent-fixed.html
in a ref-test test avoiding the need to rebaseline the expected results
if we do any modification.

BUG=31286,425991
TEST=fast/css/css-properties-position-relative-as-parent-fixed.html

Review URL: https://codereview.chromium.org/669143002

git-svn-id: svn://svn.chromium.org/blink/trunk@185219 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Derive from GarbageCollected<> instead whenever possible.

R=haraken
BUG=340522

Review URL: https://codereview.chromium.org/697893003

git-svn-id: svn://svn.chromium.org/blink/trunk@185218 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Instant events are now considered as having duration 1us rather than 10us which makes overlapping much less likely.

BUG=398783

Review URL: https://codereview.chromium.org/721703002

git-svn-id: svn://svn.chromium.org/blink/trunk@185217 bbb929c8-8fbe-4397-9dbb-9b2b20218538

They are included as "common definitions" in WebIDL and can thus be used
by other specifications without definition.

Review URL: https://codereview.chromium.org/715233003

git-svn-id: svn://svn.chromium.org/blink/trunk@185216 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=432104

Review URL: https://codereview.chromium.org/711383002

git-svn-id: svn://svn.chromium.org/blink/trunk@185215 bbb929c8-8fbe-4397-9dbb-9b2b20218538

According to the spec, "A grid item establishes a new formatting context
for its contents." Hence, margins should not collapse even when they may
be adjoining to its content's margins. It also prevents any 'float' protruding
content on the adjoining grid items.

BUG=430100

Review URL: https://codereview.chromium.org/697653004

git-svn-id: svn://svn.chromium.org/blink/trunk@185214 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In an attempt to modularize accessibility, we are breaking dependencies and moving files to Source/modules/. Some dependencies were simply dead code (such as RenderMenuList depending on AXMenuList). Others were changed to from #include statements to forward references (such as AXObject in AXObjectCache.h). This last change had some unfortunate side effects, because some unrelated files were depending on non-accessibility-related things like PositionWithAffinity, which is included from AXObject.h and relied on by files that only include AXObjectCache.h. Since this CL breaks that include chain, seemingly unrelated files (such as RenderText.cpp) needed additional #includes in order not to break the compile.

BUG=428285
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/713933002

git-svn-id: svn://svn.chromium.org/blink/trunk@185213 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts commit c80133d17fe11102619db29cfe9dc4cdda4603ce.

Speculative revert to try to un-crashify WinXP bots:

http://build.chromium.org/p/chromium.webkit/builders/WebKit%20XP/builds/15182

TBR=hiroshige
BUG=

Review URL: https://codereview.chromium.org/718083002

git-svn-id: svn://svn.chromium.org/blink/trunk@185212 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/723533002

git-svn-id: svn://svn.chromium.org/blink/trunk@185211 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently the ServiceWorker backend does not support register() and
getRegistration() calls on non-HTTP(s) page (eg, "file://"). Such calls
trigger a renderer crash because SWProviderHost does not have a valid
document URL and treats a request as a bad message.

This patch makes SWContainer abort such calls before sending an IPC message.


BUG=432048
TEST=run-webkit-tests fast/serviceworker/access-container-on-local-file.html

Review URL: https://codereview.chromium.org/722583002

git-svn-id: svn://svn.chromium.org/blink/trunk@185210 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/714423005

git-svn-id: svn://svn.chromium.org/blink/trunk@185209 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=432502
NOTRY=true

Review URL: https://codereview.chromium.org/717163002

git-svn-id: svn://svn.chromium.org/blink/trunk@185207 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none

Review URL: https://codereview.chromium.org/712403002

git-svn-id: svn://svn.chromium.org/blink/trunk@185206 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If a page takes clickjacks a regular click, don't allow opening
background tabs from anchor elements.

BUG=431335
TEST=none, content_shell doesn't do tabs...
R=mkwst@chromium.org

Review URL: https://codereview.chromium.org/717133002

git-svn-id: svn://svn.chromium.org/blink/trunk@185205 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent to Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/MuxvaXiyBxU

BUG=339919

Review URL: https://codereview.chromium.org/719013002

git-svn-id: svn://svn.chromium.org/blink/trunk@185204 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- rename WebInspector.Layers3DView.ActiveObject to ...Selection;
- introduce proper constructors and isEqual methods for Selection;
- generalize hover/selection handling logic for different objects;
- make hovered (but not selected) object bluish

Review URL: https://codereview.chromium.org/711423002

git-svn-id: svn://svn.chromium.org/blink/trunk@185203 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts commit 095f52e20d593fd0ca4d615455ff65b568728112 aka

https://src.chromium.org/viewvc/blink?view=rev&revision=185184

Auto rebaselines landed for that change but the bots did not cycle green.
Seems the mac needs a generic mac port image result, as it won't fallback
to use either the win or generic results. Reverting for now.

TBR=yhirano@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/717113002

git-svn-id: svn://svn.chromium.org/blink/trunk@185202 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/705063004

git-svn-id: svn://svn.chromium.org/blink/trunk@185201 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When a block element becomes a float or out of flow we should strip
any anonymous blocks wrapping its inline siblings.

BUG=331251

Review URL: https://codereview.chromium.org/253313005

git-svn-id: svn://svn.chromium.org/blink/trunk@185200 bbb929c8-8fbe-4397-9dbb-9b2b20218538

According to the specification, the first argument should be
  (HTMLOptionElement or HTMLOptGroupElement)
and the second argument should be
  (HTMLElement or long)?
(and also be optional and default to null).

This changes behavior for the first argument (previously HTMLElement)
where a call was a silent no-op for invalid element types, and where
HTMLHRElement was allowed against the specification and with no
observable effects.

The new behavior is to throw TypeError for all invalid arguments, which is
compatible with Firefox and MSIE.

Also apply the same change to HTMLOptionsCollection.add(), which is little
more than a short-hand for calling add() on the owning select element.
Also drop the custom bindings implementation for that method, which was
essentially implementing the unionized second argument.

The behavior of HTMLOptionsCollection.add() is changed to ignore all
invalid (out of range) integer second arguments, rather than to throw for
negative ones below than -1. This change is also per specification and
compatible with other implementations.

BUG=430337

Review URL: https://codereview.chromium.org/716773002

git-svn-id: svn://svn.chromium.org/blink/trunk@185199 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If an element A has a parent element, then A's assigned context menu is the assigned context menu of its parent element. Otherwise, A's assigned context menu is null.

Specification: https://html.spec.whatwg.org/multipage/forms.html#assigned-context-menu

"Each element has an assigned context menu, which can be null. If an element A has a contextmenu attribute, and there is an element with the ID given by A's contextmenu attribute's value in A's home subtree, and the first such element in tree order is a menu element whose type attribute is in the popup menu state, then A's assigned context menu is that element. Otherwise, if A has a parent element, then A's assigned context menu is the assigned context menu of its parent element. Otherwise, A's assigned context menu is null."

BUG=424494

Review URL: https://codereview.chromium.org/721603002

git-svn-id: svn://svn.chromium.org/blink/trunk@185198 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It seems that these are leftovers when I replaced Dictionary
with IDL dictionaries. Added a forward declaration in
Element.h instead (which is actually using Dictionary).

Review URL: https://codereview.chromium.org/723473002

git-svn-id: svn://svn.chromium.org/blink/trunk@185197 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously WTF_CPU_32BIT definition is inside #if of ARM.
This CL make CPU(32BIT) true on all architectures if and only if not CPU(64BIT).

BUG=432033

Review URL: https://codereview.chromium.org/712303003

git-svn-id: svn://svn.chromium.org/blink/trunk@185196 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a follow-up CL of https://codereview.chromium.org/690923004/.

It would be great to show "(A or B)" rather than "AOrB".

BUG=240176

Review URL: https://codereview.chromium.org/722523003

git-svn-id: svn://svn.chromium.org/blink/trunk@185195 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Dictionary.h has some problems (it cannot handle ExceptionState,
difficult to understand). We want to reduce Dictionary uses
in core/modules so that make it more maintainable.

Tests under fast/plugins cover this change.

BUG=403150

Review URL: https://codereview.chromium.org/720673002

git-svn-id: svn://svn.chromium.org/blink/trunk@185194 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=185184

BUG=405803
TBR=noel@chromium.org

Review URL: https://codereview.chromium.org/712173004

git-svn-id: svn://svn.chromium.org/blink/trunk@185193 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch removes the idl interfaces for getPropertyCSSValue and friends
(i.e. those behind the runtime flag CSSValue), and removes code that only
existed to support this.

BUG=331608

Review URL: https://codereview.chromium.org/717933002

git-svn-id: svn://svn.chromium.org/blink/trunk@185192 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=432051
R=philipj@opera.com

Review URL: https://codereview.chromium.org/710173004

git-svn-id: svn://svn.chromium.org/blink/trunk@185191 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The operation may take noticable time an may give the user additional information about his page performance.

BUG=424502

Review URL: https://codereview.chromium.org/717573003

git-svn-id: svn://svn.chromium.org/blink/trunk@185190 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Even though we want to avoid using generic Dictionary in IDL
files, we need them in some cases. For example, WebCrypto
uses generic Dictionary because we don't have IDL dictionary
inheritance support. Add generic Dictionary support so that
such customers can use union types.

BUG=240176

Review URL: https://codereview.chromium.org/713403004

git-svn-id: svn://svn.chromium.org/blink/trunk@185189 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=yukishiino@chromium.org
TBR=haraken@chromium.org
TESTS=build on Linux
BUG=

Review URL: https://codereview.chromium.org/717873005

git-svn-id: svn://svn.chromium.org/blink/trunk@185188 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Following r185177, these tests no longer crash.

TBR=yhirano,haraken
BUG=431996
NOTRY=true

Review URL: https://codereview.chromium.org/719023002

git-svn-id: svn://svn.chromium.org/blink/trunk@185187 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=243223

Review URL: https://codereview.chromium.org/643693006

git-svn-id: svn://svn.chromium.org/blink/trunk@185186 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently the fallback behavior for redirect responses is not implemented correctly.
https://codereview.chromium.org/705273004/ will fix this problem.
This patch adds LayoutTests for this bug.

BUG=431985

Review URL: https://codereview.chromium.org/712303002

git-svn-id: svn://svn.chromium.org/blink/trunk@185185 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Delete mac result, rebaseline to grab any new mac result, which should
match the windows result and be optimized out if things are working as
expected per issue 405803 and issue 409435.

BUG=405803
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185102

Review URL: https://codereview.chromium.org/697843005

git-svn-id: svn://svn.chromium.org/blink/trunk@185184 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We should not implement this change, since table cells would not update if we
later set their row/colspan to 1.

Review URL: https://codereview.chromium.org/688683004

git-svn-id: svn://svn.chromium.org/blink/trunk@185183 bbb929c8-8fbe-4397-9dbb-9b2b20218538

WebPluginContainerImpl::scriptableObject calls into WebPlugin::scriptableObject
which (in the PepperWebPluginImpl implementation) sends synchronous messages
to the plugin which can result in re-entrancy. This re-entrancy may cause the
plugin to be destroyed, which sets m_webPlugin to null in
WebPluginContainerImpl::dispose. We need to check for a null value to avoid
dereferencing a null pointer.

BUG=423263

Review URL: https://codereview.chromium.org/715073002

git-svn-id: svn://svn.chromium.org/blink/trunk@185182 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Make already-implemented functions up to date. Unimplemented features such
as piping and strategy are still unimplemented.

BUG=393911

Review URL: https://codereview.chromium.org/712043002

git-svn-id: svn://svn.chromium.org/blink/trunk@185181 bbb929c8-8fbe-4397-9dbb-9b2b20218538