- 29 Jul, 2020 40 commits
-
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/b88b1a15c7e4..ab04da48f45d 2020-07-29 tommek@google.com Enabling alphaToCoverage 2020-07-29 tommek@google.com Roll third_party/spirv-cross/ to enable shader-output mask in HLSL 2020-07-29 cwallez@chromium.org D3D12Info: programmatically compute the shader profiles. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I9035e56fc91da045ae20ebc495bfc5d09086ad84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325987Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792719}
-
Avi Drissman authored
Bug: 1105907 Change-Id: Ic29ebc9a008b0ef4ac64a639150ed99b62222988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325094Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792718}
-
Avi Drissman authored
Bug: 1105907 Change-Id: I7faf7a050da0babae655d4da9841fd5c0088ee17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325095Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792717}
-
Avi Drissman authored
Bug: 1105907 Change-Id: I27367f42ea8797dfac1add4d3568ed35fce558f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324893Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792716}
-
Asanka Herath authored
R=rkaplow@chromium.org Bug: 973801 Change-Id: Ib9a9bf27a91df5635751ff08f97f6133350ded77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313896 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#792715}
-
Maxim Kolosovskiy authored
In this CL, the list of scripts is prefetched when leak dialog is shown or password settings is open. Bug: 1095627 Change-Id: I35f28ec325b5925651f774fc28efd6931d301edf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325611Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#792714}
-
Hongchan Choi authored
This cleans up MediaStreamAudioNode/Handler classes. - Reorganizes the code order. - Clarifies the constructor step based on the spec algorithm. - Simplifies if() branches and the lock scope in SetFormat(). Bug: 1108477 Change-Id: I7395c500f11e9dd5f5ad8554c7b54463a4130720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316403 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#792713}
-
Richard Knoll authored
This registers the NotificationManager as background send and receive surface to get transfer update callbacks and show / update notifications accordingly. Bug: 1102348 Change-Id: Iea765b94afd620727f488ae9c9b54d1e7e9162ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323941 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#792712}
-
Marc Treib authored
Saving the password for a given account *within* that account doesn't make sense, so stop offering it. Bug: 1105846 Change-Id: Ibfee6beadbbbc983fde42b36cd5518d462bdca2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323522 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#792711}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8c7ecc1c06f4..4f587337c306 2020-07-29 cwallez@chromium.org Roll third_party/externals/spirv-cross/ d573a95a9..7778792ae (15 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: Ia94d92f341df11e4d3394e23f8a21440c3ad08ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325986Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792710}
-
Alice Wang authored
This CL fixes BookmarkPersonalizedSigninPromoTest on tablet. Bug: 1103210 Change-Id: I7a23987dda8bccbeafc1ed1ce36c5998a5b5e8ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324125Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#792709}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/501bbf2a9325..16c50deb5eb4 2020-07-29 lalitm@google.com Merge "tp: add sched table with upid included" 2020-07-29 fmayer@google.com Merge "Add Custom Allocators to changelog." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I5636c0842cc17a02330e4393940da0078ee4eec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325972Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792708}
-
Chris Hamilton authored
BUG=1085129, 1096617 Change-Id: I9cf35e58c5de9cb2d3e8907bed30ad577b206149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324164Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#792707}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ib7c7ae110dee3bfaef770d40a311c7e7aba5f89d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325985Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792706}
-
Glen Robertson authored
Test timeout on CQ seems to have mysteriously fixed itself. Bug:988323 Fixed:988323 Change-Id: Ia96d8a687bc161cf74f67fbf819ffaf7bb896755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325330 Auto-Submit: Glen Robertson <glenrob@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#792705}
-
Roman Sorokin authored
This CL makes UserSessionManager check for tokens every time profile is loaded. So in case Chrome crashed during the login - token will be downloaded on restart. Bug: 1094030 Change-Id: I97eebf54e36bff976935f217c4de22e040c5674e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315891 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#792704}
-
Katie Dillon authored
priority decisions. This CL adds a prioritisation type for the compositor queue and uses that inside of computePriority instead of QueueClass. This is more clear than QueueClass (since QueueClass::kCompositor includes other task queues that have a fixed priority). In addition, this CL adds some DCHECKS to ensure that we only create one queue of this type since there should only be one main thread compositor task queue. Change-Id: I88825288476c73e46739214bad61c2d3c8b2af93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300881 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/master@{#792703}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia12ca4e2f2c10018dd44d058ef4d9778cb4eb866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324680Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792702}
-
Victor Hugo Vianna Silva authored
Bug: 1090931 Change-Id: If41e533eefce52db80a40e1ab7fdcfe75ae906e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317873Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#792701}
-
David Maunder authored
To support the work of moving Tab attributes out of Tab to objects which implement the UserData interface so the Tab doesn't become too big and unwieldy Bug: 1109345 Change-Id: Ife994234aa53ae1f12dde47cee0abe91765b3491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318625 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#792700}
-
Sebastien Lalancette authored
Listing gambard and myself as co-owners of this directory. Bug: 1093302 Change-Id: I2e37ebeb2c5ffe4cb649026a443e0707df06f1d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323131Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#792699}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d8380b6383dc..eb118ddc8dea 2020-07-29 janscheffler@chromium.org Migrate `front_end/mobile_throttling` to `devtools_entrypoint` 2020-07-29 janscheffler@chromium.org Migrate `front_end/inline_editor` to `devtools_entrypoint` 2020-07-29 janscheffler@chromium.org Migrate `front_end/screencast` to `devtools_entrypoint` 2020-07-29 szuend@chromium.org Add basic Markdown rendering component If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1099162,chromium:1101738,chromium:1108699 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4e75d36ffbb402feeaa2da199c934d2381852b1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325983Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792698}
-
Jérôme Lebel authored
Updating Signin.SSOIdentityListRequest metrics. The metrics should record where the identity list come from when being requested. This changes don't change the values already recorded. The goal is to prepare to add a third value later: "SSO identity list returned from stale cache" Related to: + crrev.com/i/3151963 Metrics introduced with: + crrev.com/c/2201720 + crrev.com/i/2995955 Change-Id: Idc3264e2864c2a1ea98cac41f61fef0c69f74399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283744 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#792697}
-
Steven Bingler authored
Create new exclusion reasons to send to DevTools for Issue Pane messages. These new reasons will be added when the correct conditions cause a cookie to be blocked because of Schemeful Same-Site. The messages for these new reasons are in progress. Bug: 1054036 Change-Id: If23d4a01cad160b6c7b0b6b342c8982d172a672c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292686Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#792696}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/dc8e77f0e521..28e801ad3afb 2020-07-29 swiftshader.regress@gmail.com Regres: Update test lists @ dc8e77f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I1dc8ba00f6dc6824ec2cea225a288b846c04bcb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325974Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792695}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3bb07848..e5f80a2e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I949bbb0bb99aa9b26e8c7271e524002e67ed79b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324365Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792694}
-
Alexei Svitkine authored
Bug: None Change-Id: If395ad9984c944efd609f7ea2c9c86ee3f904d71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324882Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#792693}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/592c94cd987f..ab07b2bef2ac 2020-07-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 171e04fac342 to c0bf676837e4 (3 revisions) 2020-07-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 3ee5f2f1d331 to 7ab4564696a7 (1 revision) 2020-07-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from 3b36fdc64014 to a4505d37ffe7 (1 revision) 2020-07-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 12c9d4ac61f2 to dc8e77f0e521 (6 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: tobine@google.com Change-Id: I4efb1142becbd402a1d35bb4c533111f6cacf5a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325908Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792692}
-
David Jean authored
Bug: 1079422 Change-Id: I2dba760395245d3d14a6459c38955907a9bef41b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270152 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#792691}
-
Wez authored
Bug: 1053628 Change-Id: I59254c7f29b05642dee3ce30c867bf190bcc18a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315032 Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#792690}
-
Yutaka Hirano authored
Bug: 109251 Change-Id: I2dd9728b5489f0ead1c0e75d89623845844f97d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325430 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#792689}
-
Fargat Sharipov authored
There are some cases when deletable matches can be duplicates in BaseSearchProvider, so after deleting we can still observe Remove Suggest button. This CL adds checking whether there are deletable duplicates with matching contents and type. Bug: 1108674 Change-Id: Ic1a247957a3c8d0dde01134edb6205bd3006e6dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315859 Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#792688}
-
Swapnil authored
We have several installation stages that the force installed extension must go through. We want to add installation stage event to the existing events for the event based reporting for force installed extensions. Bug: 1106423 Change-Id: I0be845a1c30ad399eb62103dd3bc6ec07d783bc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302906 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#792687}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I71b438c741141bb240587a2eff5f1d696144d857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326011Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792686}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c34efe0da102..8c7ecc1c06f4 2020-07-29 reed@google.com Revert "Revert "Never share pixels when we make a subset image"" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I8f54932ae7aaabff8d63814a7f6ffd3f0de99bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325976Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792685}
-
Sreeja Kamishetty authored
Instead of clearing the user data on renderer crash, this CL clears the data only after starting next navigation when the RenderFrame goes to created state. Bug: 1099237 Change-Id: I3816d5c32ea36b4f651430076a262ae9b71b84bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292492 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#792684}
-
Alex Ilin authored
Upcoming updates to the multi-profile experience make the "main" color of the profile more prominent on several surfaces. One of these surfaces is the profile picker window which should have access to colors attributed to unloaded profiles. Currently, the profile theme info is stored in profile preferences which are read from the disk when a profile is loaded. This CL caches required colors in ProfileAttributesStorage. Data from ProfileAttributesStorage can be accessed without having to actually load a profile from disk. The colors are updated every time the profile's theme changes. This is implemented by listening for the chrome::NOTIFICATION_BROWSER_THEME_CHANGED notification in ProfileThemeUpdateService. Bug: 1102384 Change-Id: I4683ded5d7182117dd2a712437f64f1f00ceed72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317796 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#792683}
-
Mikel Astiz authored
Instead of manually creating keyed services using deprecated TestingProfile APIs, it's more appropriate to access a keyed service that is not null in tests. Change-Id: I49ecd1425a3bc2f4aa533c52aa3530da568a5bd8 Bug: 789214,1106699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325919Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#792682}
-
Victor Hugo Vianna Silva authored
This CL fixes the linked bug by ensuring the plaintext password property in ShowPasswordBehavior is reset when the element is pointed to another credential, i.e. when "entry" is changed. The result is that removing a credential, or doing a search filter will hide any plaintext passwords being shown. Before what happened was: - Deleting a pwd would update the savedPasswords array in MergePasswordsStoreCopiesBehavior. - The backing array of the iron-list of pwds in PasswordsSection would be updated. - The "entry" properties of the PasswordListItem in the iron-list would be updated *but* the "password" properties wouldn't be updated. Contrary to what one may believe, removing an element from the backing array of an iron-list doesn't actually remove the corresponding element from the DOM. The CL also makes the visibility state of the password in the edit dialog not be synced with the corresponding row in the pwd list anymore. Bug: 1110290 Change-Id: Ibb5d10999b4c966fcf382f5a18e76ce462090188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325731 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#792681}
-
Matt Jones authored
This patch replaces the obsolete ScrimView widget with the new scrim component in the autofill assistant. Some of the tests that included waiting for elements to be removed from the test web page have been updated to use criteria helpers, making them a bit less flaky. This patch also includes a change to how the touch delegate is attached to the scrim: it is now only attached if a delegate is set as it would otherwise interfere with the gesture detector. Bug: 1062099 Change-Id: I79547256efa62eef7bc1d86090942a8471a60285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308454 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#792680}
-