- 15 Oct, 2020 40 commits
-
-
Xianzhu Wang authored
This is another preparation for unified PaintController. This ensures that the pre-composited layer list is always updated for not only the GraphicsLayers, but also the painted results. As we will always collect the layer list during paint, we no longer need the "SetForeignLayerListNeedsUpdate" flag. This also fixes the crash issues caused by the previous preparation CL crrev.com/814547. The crashes were because of stale PaintChunkSubset (referencing stale PaintArtifact) in the pre-composited layer list. Bug: 1132717, 1137591 Change-Id: I5401f909e104a143511de376d90cae6805c7baff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474094Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#817694}
-
Kyle Horimoto authored
This CL completes the startup/shutdown refactor for the Nearby utility process. It adds an asynchronous ShutDown() function which is used in place of simply resetting the Mojo connection, which does not allow the process to shut down cleanly. Additionally, this CL adds a test for NearbyProcessManagerImpl which was omitted from https://chromium-review.googlesource.com/c/chromium/src/+/2459112. Fixed: 1130069 Change-Id: Ia5b0b28f185c07511ba0754a5ebf97b9b35ee737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460230 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#817693}
-
Torne (Richard Coles) authored
Enable this experiment flag by default in preparation for enabling it on stable via Finch. Extend the expiry of the related metric so that it keeps collecting data until after the default-enabling has reached stable. Bug: 1038002 Change-Id: Ieae23184ab430565df775c1aad4112dc63ae1561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477155Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#817692}
-
Jinsuk Kim authored
Extends the experiments to M92 so the flag options will be visible. Also extended Search.ContextualSearch.SelectionExpanded while I'm at it. Change-Id: If2466711bd67d1c692d0e1f3cec1fe2461f009e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472680Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#817691}
-
Claude van der Merwe authored
Mark Wifi Sync V2 translation strings in the multidevice suite as translateable and upload screenshots. Bug: 1117619 Change-Id: I44b6fdada47c6325dbd291bdb1fab82292bcbe84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468921Reviewed-by:
Jon Mann <jonmann@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Cr-Commit-Position: refs/heads/master@{#817690}
-
Thomas Lukaszewicz authored
This CL updates the FlexLayoutView with View builder support. It also removes the use of enums for property ids and adds unittests. Bug: None Change-Id: If968a111eb8945f7150cd9df99a889f30156175a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473238 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#817689}
-
Kyle Horimoto authored
This CL updates Nearby Share's NearbyProcessManager class to use the newly-created chrome::nearby::NearbyProcessManager internally in order to make connections to the Nearby utility process. In the long-term, Nearby Share's version should be renamed or potentially removed altogether, but this is not within the scope of the bug fix, so I've added a TODO to take care of this. Bug: 1130069 Change-Id: I0f8eb7e29e83ffbc6ce428eeaacd151a294d5ef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459572 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Olivier Yiptong authored
Adds a feature flag to gate a chooser API. This API's purpose is to enable developers to request access to fonts installed on users' local machines. The request will be satisfied with users selecting fonts from a "chooser"-style interface. Bug: 1138621 Change-Id: I3574fe95517c3167316f4540d113e3dfff9059cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472462 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#817687}
-
Solomon Kinard authored
Bug: None Change-Id: I5e5e05124668a459af71f4304918d0639f1bd75b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463397Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Solomon Kinard <solomonkinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#817686}
-
Daniel Rubery authored
This metric is related to the unlaunched feature: https://bugs.chromium.org/p/chromium/issues/detail?id=1066665 It will be useful until the feature is landed. Fixed: 1138394 Change-Id: I5ec6de40f12714f52bf7cda41394d2e863cb4190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472605 Auto-Submit: Daniel Rubery <drubery@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#817685}
-
Nohemi Fernandez authored
Currently the Settings link opens to the Sync & Google Services options. With this patch the Settings page will be routed directly to Sync without the option to turn off Sync. Bug: 1125631 Change-Id: Ic5d38db6d835ffc7ea7b310be5801fb6cb928acc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463306 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#817684}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/481ecff293db..95dc655bf8a6 2020-10-15 dsinclair@chromium.org [ast] Change module dump order. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: enga@google.com Change-Id: I7394e04a5024e3639c6dd6a3cef1184cb31c3939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477277Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817683}
-
Muyao Xu authored
This change binds the Logger with Cast/DialMediaSinkService before MediaRouterDesktop::OnUserGesture() is called. Now the feedback logs include discovery errors detected before users open the cast dialog. Also, since Cast/DialMediaSinkService only log channel errors, there should not be a large number of logs that take up non-cast users' memory space. Bug: b/170651293, 1117673 Change-Id: Ie231922d98b1ac566f6d88fb08acccb3a4c1435f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468462 Commit-Queue: Muyao Xu <muyaoxu@google.com> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#817682}
-
Wenbin Zhang authored
The current estimate of base_perftests is inaccurate. Updating the value based on actual runtime. Bug: chromium:1130157 Change-Id: I7f6ca8e4f8772259cda617803385ac83fbb7daa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473039 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#817681}
-
danakj authored
Include dumps of the SiteInfo and ProcessLock for the current RenderFrameHost and the speculative RenderFrameHost. Also introduce SCOPED_CRASH_KEY_${TYPE} macros in base/ to simplify writing crash keys and make them more readable. R=alexmos@chromium.org Bug: 1125106 Change-Id: I2e068592d9a74b196457be7fa5f96deae58c2011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477094 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#817680}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4c54f8638cc4..4244b5f6b438 2020-10-15 hta@webrtc.org Tidying stuff in PC resources class 2020-10-15 danilchap@webrtc.org Move scalability structures from av1 into own subfolder If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2fb5032a2cad6164cceb6651afbaa49fb995d481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477253Reviewed-by:
-
Owen Min authored
Update the owner and expire date for the following metrics: EnterpriseCheck.IsDomainJoined EnterpriseCheck.IsEnterpriseUser EnterpriseCheck.IsLocalMachine EnterpriseCheck.IsLocalUser EnterpriseCheck.IsManaged2 Bug: 1138385 Change-Id: I33c3e6c515680e017e3ba4dcd04010909ba2f576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476833Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Marc-André Decoste <mad@chromium.org> Cr-Commit-Position: refs/heads/master@{#817678}
-
Peter Kasting authored
This matches how secondary buttons are created and will facilitate converting buttons from listeners to callbacks. Bug: none Change-Id: I73d2cd81f136bdbc6827528ac4fe423782211250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468939 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#817677}
-
Brian Ho authored
Currently, P010 (both HDR and SDR) videos don't render on SkiaRenderer on Chrome OS. One issue is that creating the SkImage fails due to a color type/color format check [1]. The GrBackendFormat is created from a P010 format as GL_RGBA8_OES when hitting a NOTREACHED code block [2]. Similarly, the SkColorType is converted from P010 as kN32_SkColorType [3] which is a platform-dependent alias of either kRGBA_ or kBGRA_ [4]. If the platform supports a BGRA byte order, SkImage_Gpu::MakePromiseTexture fails because RGBA != BGRA. This CL handles P010 in some resource format conversion functions by converting to its closest neighbor- RGBA1010102. [1] https://source.chromium.org/chromium/chromium/src/+/master:third_party/skia/src/image/SkImage_Gpu.cpp;l=548;drc=1fc76ce6ff5553c3c1b98f34350c14887b6d4be7 [2] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/common/resources/resource_format_utils.cc;l=337;drc=3e072dfcd46e4d23e7b985ffe97f784ec2731b86 [3] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/common/resources/resource_format_utils.cc;l=66;drc=3e072dfcd46e4d23e7b985ffe97f784ec2731b86 [4] https://source.chromium.org/chromium/chromium/src/+/master:third_party/skia/include/core/SkImageInfo.h;l=96;drc=e3dc752d1c137b90e708d70e415d7cb1fd85326f Bug: 1138518 Change-Id: Ib7788c73919222dff1c09e315317e623e28481e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468443Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org> Cr-Commit-Position: refs/heads/master@{#817676}
-
Dave Tapuska authored
It has been used in 4 years since https://crrev.com/cb959ce66a so I don't think anyone is going to use it now. BUG=1097816 Change-Id: I492413144ca1d7905657fe3717ff8cd9c7a5f37c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476755Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#817675}
-
Robert Ogden authored
This new class will be shared between the TabHelper and all Subresource Managers and have all prefetches reported to it. On destruction, it logs all the prefetches to UKM. The UKM source page will be the Google SRP, which is where all the prefetches occur, but the UKM may not be recorded until the next page load when we know what prefetches will be reused from the cache. This class is a scoped refptr so that its ownership can be effectively transferred to the navigated prefetch's SubresourceManager, if applicable, instead of complex handling of the class in the TabHelper. See https://chromium-review.googlesource.com/c/chromium/src/+/2463544 for the full impl. Privacy doc: http://shortn/_jDobercSsm Bug: 1136174 Change-Id: I358bdd1daf2e4564732fc72ca3b0a4ca9cabe63b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465216 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#817674}
-
Peter Kasting authored
Bug: 772945 Change-Id: I3b5131b40eabe286131692bc9891ee1d94afbd1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476604 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Travis Skare <skare@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Travis Skare <skare@chromium.org> Cr-Commit-Position: refs/heads/master@{#817673}
-
Mario Bianucci authored
Because RenderWidgets exist 1:1 with tabs, if delegated ink trails are being used in one tab, and then another tab starts using them, a second mojo pipeline between browser proc and viz will try to be created. However, since there is only one receiver in viz and it is already bound, we hit a DCHECK() and crash. The fix is to just add an if check in viz, and if the receiver is already bound, then reset it and bind the new PendingReceiver. This makes sure that the feature is available on the most recent tab to use it. Moving the Remote from RenderWidgetHostViewEventHandler to somewhere that it can exist 1:many with tabs is another possible solution. This would also have the benefit of exactly one IPC to make the connection for all tabs in a window. However, that would require the Remote to move to a much less obvious place for it to live, and since the trade off is only one extra IPC call per tab switch (when the new tab starts using the API - if it never uses it, no IPC call), it is unlikely to cause any noticeable performance regression. Bug: 1138602 Change-Id: I2ea9bb0962ac6e67b21276d0b75d9c455e7ede76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472901Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Commit-Queue: Mario Bianucci <mabian@microsoft.com> Cr-Commit-Position: refs/heads/master@{#817672}
-
Yuke Liao authored
This CL adds an example to show how to use tests against a locally built ash-chrome. Change-Id: I7f7cc04a3ae594fb388c9b81a13ac5375d72db35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476902Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#817671}
-
dpapad authored
Bug: 1132403 Change-Id: I7fb7561cf7a808fe26420dae42814e5f41072b71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470305 Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#817670}
-
Jesse Schettler authored
Replace the colons in the scanner's instance name to prevent them from breaking sane-airscan's device name parsing logic. Bug: b:170976627 Change-Id: Ia62b200a6699f59b9fc55935c2ab9956279869ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476517Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#817669}
-
Kyle Horimoto authored
This CL adds policies for Phone Hub as well as its two sub-features (notifications and task continuation). The top-level feature is disallowed by default for managed users, and its subfeatures are allowed by default but only usable if the top-level feature is also allowed. The preferences for these policies are already implemented, so this CL simply hooks up the new policies to them. Bug: 1106937 Change-Id: I11d08a67af01daab95f20abebf031c67eb848d17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473337 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#817668}
-
Weblayer Skew Tests Version Updates authored
Skew tests are being added for the following versions: 1, 86.0.4240.99 TBR=estaab@chromium.org Bug: 1041619 Change-Id: Ib3f1818b30bada61f7a1c361b373881edc61b920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476580 Commit-Queue: Rakib Hasan <rmhasan@google.com> Commit-Queue: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#817667}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9dfc25eb5de2..63fa6951fb7e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC pkasting@google.com,jbroman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: pkasting@google.com,jbroman@google.com Change-Id: Ifad4cae80bee6247479f0942b7b84cc091b76157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477225Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817666}
-
Matt Jones authored
Bug: 1135465 Change-Id: I3202884bcaaa9c80c6d6b3940da77c717f54b357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459108Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#817665}
-
Austin Eng authored
This is a reland of 290037a8 It's been preceded by a fix to set dawn_use_x11=false to fix compilation on lacros. Original change's description: > Set use_dawn=true on Linux > > This enables WebGPU on Linux behind --enable-unsafe-webgpu > and --enable-features=Vulkan. Shared image support requires > SkiaRenderer (default on Linux) and Vulkan to be enabled. > > Bug: 976495 > Change-Id: I97065f2ac6aadd110971254bfe3526d366318b83 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368534 > Commit-Queue: Austin Eng <enga@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817266} Bug: 976495 Tbr: kbr@chromium.org Cq-Include-Trybots: luci.chromium.try:linux-lacros-rel Change-Id: I6bcf6daa48e838bc8e721126f353c97a5eb752e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476774 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#817664}
-
Richard Knoll authored
This adds a UMA metric that records the result of the promise returned by a call to showNotification. This allows us to spot and pinpoint common errors earlier. TBR=peter@chromium.org Bug: None Change-Id: If6505a86acbfc20f101a421b6a187c08f32c4af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475882 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1602709027-5dd91a5323ea4bffe2a30c2aaff27b21af6d45ea.profdata to chrome-win32-master-1602730724-a2f2ccfa1a9355c75a0cf65d2477506fef2f19f5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib971cbbf8cf9ce06afa307524496e6b09eacca97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474004Reviewed-by:
-
Benoit Lize authored
ThreadCacheRegistry is a singleton, using the common static local pattern. However this doesn't work for PartitionAlloc-Everywhere builds on Windows, as static locals are not safe very early on, and this one is called during CRT initialization. To avoid using a static local here, use a regular global variable in the .cc. This means that the object must be constexpr-constructible, so this CL: - Moves to PartitionLock vs base::Lock - Makes PartitionLock's constructor constexpr Bug: 998048 Change-Id: Ie16c642122696d34d9f07813a763ca986b25895c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474857 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#817661}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602762990-5610fc4d08ce928742199548ea998fa82cc20428.profdata to chrome-linux-master-1602784677-a93fbaee821e881bb685f33a6370b1d8843d7235.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic965a389f3d69598d73d67d60105595ccdfe2db8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477274Reviewed-by:
-
Steven Bennetts authored
This CL: * Removes the no longer accurate typedef * Eliminates DictionaryValue from ShillClientHelper BUG=1109627,1137487 Change-Id: I1ae00753e7a8d77c2c7948c78c7ad31c1bcabb7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466382 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#817659}
-
Gavin Williams authored
In Wallpaper app add a blue border around the category to show when focused. Screenshot: https://screenshot.googleplex.com/C6LMc4tGitLTkdA Bug: 1045359 Change-Id: Icd3e36343451e517b1f10a1de303a5df827fec94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476557Reviewed-by:
-
minch authored
Bug: 1131543 Change-Id: I358c1bac6cdb59302c15144340f64e43cead1258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472597 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#817657}
-
Ryan Heise authored
Bug: 1138953 Change-Id: Ie8475db0b7991c867564894cccd775c0cbf19dfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476674Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Ryan Heise <heiserya@google.com> Auto-Submit: Ryan Heise <heiserya@google.com> Cr-Commit-Position: refs/heads/master@{#817656}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/a3f46f23c526..bd45d582f51e 2020-10-15 jophba@chromium.org Allow loopback for discovery If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I2ccd0ed0216ae007259015a7b2ec0b80748abeb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477217Reviewed-by:
-
