GitLab

Revert of Android: Delete rezip in favor of zipalign -p (patchset #2 id:210001 of https://codereview.chromium.org/2612773005/ )

Reason for revert:
Broke system webview merging of debug builds.

Original issue's description:
> Reland of Android: Delete rezip in favor of zipalign -p
>
> There's no need for a custom alignment tool now that zipalign supports
> page-aligning libraries.
>
> Previously reverted in:
> https://codereview.chromium.org/2595233003/
>
> Reason for reland:
> Contains fix for monochrome (tested merging locally).
>
> BUG=676029,676589
>
> Review-Url: https://codereview.chromium.org/2612773005
> Cr-Commit-Position: refs/heads/master@{#442906}
> Committed: https://chromium.googlesource.com/chromium/src/+/c3fd406f53369c1714d3587087146ff6ead4adab

TBR=michaelbai@chromium.org,jbudorick@chromium.org
NOTRY=true
BUG=676029,676589

Review-Url: https://codereview.chromium.org/2621353004
Cr-Commit-Position: refs/heads/master@{#443333}

To enable latching, MouseWheelEventQueue(MWEQ) uses a timer to send GSE
events. When a fling arrives if the timer is running, MWEQ will stop it
and won't send the pending GSE.

In input_handler_proxy, ScrollBegin is called only once in
HandleGestureFlingStart. This ScrollBegin won't do a new hittesting
because CurrentlyScrollingLayer already exists (No GSE is sent before
fling to clear the CurrentlyScrollingLayer when it's being handled).

ScrollEnd won't get called in FlingScrollByMouseWheel for every wheel tick.
Instead, it will be called only once in CancelCurrentFlingWithoutNotifyingClient,
when the fling is over (last ScrollBy didn't scroll or fling time is terminated).

To test locally use the --enable-features=TouchpadAndWheelScrollLatching
runtime flag.

BUG=526463
TEST=InputHandlerProxyTest.GestureFlingTouchpadScrollLatchingEnabled

Review-Url: https://codereview.chromium.org/2625453002
Cr-Commit-Position: refs/heads/master@{#443332}

BUG=none

Review-Url: https://codereview.chromium.org/2622613003
Cr-Commit-Position: refs/heads/master@{#443331}

Revert of [wasm][asm.js] Turn on asm.js -> WebAssembly by default. (patchset #2 id:20001 of https://codereview.chromium.org/2625823006/ )

Reason for revert:
Suspecting this CL is causing these tests to fail:
fast/workers/worker-shared-asm-buffer.html
virtual/sharedarraybuffer/fast/workers/worker-shared-asm-buffer.html

From the layout test results, it seems that turning on asm.js will append some console results to the test outcome.
Example build:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/22022

Original issue's description:
> [wasm][asm.js] Turn on asm.js -> WebAssembly by default.
>
> BUG=v8:4203
> R=danno@chromium.org,titzer@chromium.org,jochen@chromium.org
>
> Review-Url: https://codereview.chromium.org/2625823006
> Cr-Commit-Position: refs/heads/master@{#443289}
> Committed: https://chromium.googlesource.com/chromium/src/+/7417bea53a78a97ae815479e5d73cf0840d90c88

TBR=jochen@chromium.org,bradnelson@google.com,danno@chromium.org,titzer@chromium.org,bradnelson@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4203

Review-Url: https://codereview.chromium.org/2631543002
Cr-Commit-Position: refs/heads/master@{#443330}

https://pdfium.googlesource.com/pdfium.git/+log/e7fb8eb3e9f2..db7647083d0a

$ git log e7fb8eb3e..db7647083 --date=short --no-merges --format='%ad %ae %s'
2017-01-12 rbpotter Add postscript path

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2626213003
Cr-Commit-Position: refs/heads/master@{#443329}

Revert of Re-enable fetching component policies for login screen apps (patchset #3 id:40001 of https://codereview.chromium.org/2603463003/ )

Reason for revert:
I'm very sorry I have to revert this since it's breaking device policy updates.

https://bugs.chromium.org/p/chromium/issues/detail?id=679956#c7

Original issue's description:
> Re-enable fetching component policies for login screen apps
>
> This CL relands enabling fetching of policies for Chrome OS login screen
> apps.
>
> The originally landed code was temporarily disabled due to DMServer
> responding with errors when an unknown policy type was requested. Now
> this can be enabled back, after the DMServer got fixed to at least
> ignore the new policy type (until it starts to actually provide policies
> with this type).
>
> BUG=644304,666720
> TEST=re-enabled browser tests;
>      manual test: sign into an enrolled device, go to chrome://policy
>      and check that the device policies were fetched successfully
>
> Committed: https://crrev.com/5eb4901df37717dd05fd071a807a0ebaf563f0f3
> Cr-Commit-Position: refs/heads/master@{#441015}

TBR=emaxx@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=644304,666720

Review-Url: https://codereview.chromium.org/2621413007
Cr-Commit-Position: refs/heads/master@{#443328}

This is a semi-mechanical change to convert i18n-content to $i18n{}. The
Non-mechancal changes are some formatting adjustments.

BUG=677338
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2626123002
Cr-Commit-Position: refs/heads/master@{#443327}

ImageTexture binding is supported for only immutable texture [1]
[1] https://www.khronos.org/opengles/sdk/docs/man31/html/glBindImageTexture.xhtml

CMAA needs to use ImageTexture binding, so it checkes internal format is RGBA8.
However, in GLES2 context, immutable texture can have RGBA internal format, because of
https://codereview.chromium.org/2458103002/
This CL makes it check immutable texture directly.

BUG=535198
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2543123003
Cr-Commit-Position: refs/heads/master@{#443326}

SyncedProperty is used as a synchronization primitive to track state on
the impl thread, necessary to resolve conflicts for concurrent main-impl
mutations. As such it should only exist on the impl thread.

Currently, the ScrollTree creates these on the main thread while they
only store the current main thread value. This is unnecessary complexity
that can be avoided. This change makes ScrollTree store just the offset
on the main thread, and a SyncedProperty for the offset on the impl thread.

BUG=662619
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2621403003
Cr-Commit-Position: refs/heads/master@{#443325}

It is unused in Chrome and its tests.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2630483002
Cr-Commit-Position: refs/heads/master@{#443324}

Revert of Stop bad results on first memory benchmark run (patchset #8 id:140001 of https://codereview.chromium.org/2589173004/ )

Reason for revert:
Suspecting that this CL is causing many failures on benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.

Example builds:

https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/11962
https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/6323

Original issue's description:
> Stop bad results on first memory benchmark run
>
> The first memory system-health story ran in a set has been reporting
> memory use differently all subsequent runs. This is due to how we
> flush the system caches.
>
> Just before we measure memory we flush the system caches unfortunately
> this doesn't immediately take effect, instead the next story run is
> effected. Due to this the first story run has anomalous results.
> This option causes us to flush caches each time before Chrome starts
> so we effect even the first story - avoiding the bug.
>
> *************** Note to Perf Sheriff ****************
>
> Regressions across several memory metrics are
> expected for system_health.memory_mobile,
> system_health.memory_desktop and memory.top10_mobile
> as we stop under counting memory use.
>
> *****************************************************
>
> BUG=chromium:671156
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq
>
> Review-Url: https://codereview.chromium.org/2589173004
> Cr-Commit-Position: refs/heads/master@{#443273}
> Committed: https://chromium.googlesource.com/chromium/src/+/3afb7e7da06df087b3e9fac2ae68593f75a051ed

TBR=perezju@chromium.org,nednguyen@google.com,hjd@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:671156

Review-Url: https://codereview.chromium.org/2627323002
Cr-Commit-Position: refs/heads/master@{#443323}

BUG=none
TEST=none

Review-Url: https://codereview.chromium.org/2628923003
Cr-Commit-Position: refs/heads/master@{#443322}

- sheretov@ and vadimgo@ no longer works on cast.
- add dougsteed@

BUG=

Review-Url: https://codereview.chromium.org/2626053003
Cr-Commit-Position: refs/heads/master@{#443321}

Currently PluginPrivateDataByOriginChecker only deletes all the data
for the specified origin if it finds at least one file that matches
the time range specified. However, if the origin has no files, it
should be cleaned up as well.

Adds a test that deletes the file for a particular origin before
clearing all PluginPrivate storage to verify it works.

BUG=678314
TEST=new content_unittest passes

Review-Url: https://codereview.chromium.org/2622403002
Cr-Commit-Position: refs/heads/master@{#443320}

BUG=602666

Review-Url: https://codereview.chromium.org/2588913002
Cr-Commit-Position: refs/heads/master@{#443319}

BUG=679375

Review-Url: https://codereview.chromium.org/2622003005
Cr-Commit-Position: refs/heads/master@{#443318}

I got the data I wanted from this UMA, and it appears to be causing
performance regressions. Removing.

R=isherman@chromium.org,zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2628833003
Cr-Commit-Position: refs/heads/master@{#443317}

BUG=680544
TBR=

Review-Url: https://codereview.chromium.org/2625273004
Cr-Commit-Position: refs/heads/master@{#443316}

Review-Url: https://codereview.chromium.org/2629503002
Cr-Commit-Position: refs/heads/master@{#443315}

The images generated on gpu reference archive are correctly showing blurry
edge on enlarged canvas.

TBR=zmo@chromium.org
BUG=676666
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2625393002
Cr-Commit-Position: refs/heads/master@{#443314}

This CL adds a count of requests using DRP and information about
compression. This will allow us to reconsider UMA (e.g., logging UMA for
Mixed content pages (HTTPS pages using DRP from HTTP sub-resources),
logging UMA for <50% of network requests using DRP, >50% of network
requests using DRP, etc.). This will also allow UMA for size of page in
terms of network bytes and in terms of original content length
(precompressed bytes from the origin). This will allow a DRP per-page
data savings histogram as well.

BUG=679893

Review-Url: https://codereview.chromium.org/2619243003
Cr-Commit-Position: refs/heads/master@{#443313}

R=mahmadi@chromium.org
BUG=679993

Review-Url: https://codereview.chromium.org/2629083002
Cr-Commit-Position: refs/heads/master@{#443312}

When the BrowserState is destroyed, the preload controller must be
notified to ensure it will be released. This prevents the preload
controller from receiving PrefChanged notifications after the browser
state has been destroyed.

BUG=677126

Review-Url: https://codereview.chromium.org/2629073003
Cr-Commit-Position: refs/heads/master@{#443311}

These tests are affected by crashes in the context menu tests.
With these tests disabled. They could also be affected by alerts,
but We now skip tests with alerts on EG tests.

BUG=675400

Review-Url: https://codereview.chromium.org/2624263004
Cr-Commit-Position: refs/heads/master@{#443310}

Precursor to some possible refactoring to extract the file_handlers API from
//chrome to //extensions.

BUG=679870
R=benwells@chromium.org

Review-Url: https://codereview.chromium.org/2621193002
Cr-Commit-Position: refs/heads/master@{#443309}

Change it from "Initializing..." to "Loading apps..." per
suggestion from UX.

BUG=633596,633243

Review-Url: https://codereview.chromium.org/2625293003
Cr-Commit-Position: refs/heads/master@{#443308}

Executor passed into JavaUrlRequest is backed by a thread-pool so it can
concurrently run tasks which can lead to crashes in underlying
HttpURLConnection.  Prevent this by serializing taskes passed to
underlying Executor.

BUG=664872
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2613393002
Cr-Commit-Position: refs/heads/master@{#443307}

This CL removes all the BlimpBrowserTest tests, and related files.

It also removes the test suite from the build bots, and a
ThreadRestrictions friend-class from //base.

BUG=677556

Review-Url: https://codereview.chromium.org/2620213004
Cr-Commit-Position: refs/heads/master@{#443306}

Required for crash server to de-obfuscate java stack traces.

BUG=620323

Review-Url: https://codereview.chromium.org/2556523002
Cr-Commit-Position: refs/heads/master@{#443305}

Since TaskManagerImpl is destructed after ~ArcServiceManager is called,
we need to check the return value from the getter.

BUG=680301
TEST=1) try, 2) sign in, wait for ARC boot, press Search+ESC,
 press Ctrl+Shift+QQ to sign out, confirm the browser does not crash

Review-Url: https://codereview.chromium.org/2625823005
Cr-Commit-Position: refs/heads/master@{#443304}

In order to support Client-side Lo-Fi and other Previews optimizations
which can be enabled in parallel, change the Lo-Fi bool to a Previews
bitmask.

TBR=mek@chromium.org
BUG=657997
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2484633004
Cr-Commit-Position: refs/heads/master@{#443303}

Prior to enabling PointerEvents, OOPIFs with TouchEvent handlers worked.
But with PointerEvents turned on, they fail. This happens because the
InputRouterImpl sending the touch events to the OOPIF never gets
notified of the current TouchAction, in turn because ChromeClientImpl
sends the TouchAction notification via RenderView and not the
RenderWidget serving the OOPIF.

Prior to PointerEvents this was not an issue, as the touch events
would continue to flow regardlesss. But with PointerEvents, touch
events are blocked after a TouchScrollStart is issued.

This CL plumbs a LocalFrame* parameter into ChromeClient::setTouchAction
so the notification can be sent via the correct channel.

BUG=680158

Review-Url: https://codereview.chromium.org/2626133002
Cr-Commit-Position: refs/heads/master@{#443302}

Suppress lint warnings for translations of the
data_reduction_promo_summary string in
values-pt-rBR/android_chrome_strings.xml and
values-cs/android_chrome_strings.xml

BUG=680246

Review-Url: https://codereview.chromium.org/2624183003
Cr-Commit-Position: refs/heads/master@{#443301}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/7f52163a4f80..ed0540fbc6ef

$ git log 7f52163a4..ed0540fbc --date=short --no-merges --format='%ad %ae %s'
2017-01-12 simonhatch Dashboard - Append a link to the doc on memory regressions for memory benchmarks.
2017-01-12 simonhatch Dashboard - Fix bisect output when no values are produced.

BUG=680226

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2633503002
Cr-Commit-Position: refs/heads/master@{#443300}

Revert r440390's debug instrumentation of ExtendableMessageEvent.

R=
BUG=655926

Review-Url: https://codereview.chromium.org/2623273004
Cr-Commit-Position: refs/heads/master@{#443299}

BUG=649427
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2628773004
Cr-Commit-Position: refs/heads/master@{#443298}

This variant of the test runs on Site Isolation Win in addition to the
regular test, hence it also needs to be disabled.

BUG=672570
NOTRY=true
TBR=lukasza@chromium.org

Review-Url: https://codereview.chromium.org/2633513002
Cr-Commit-Position: refs/heads/master@{#443297}

Neighbours can clip to the same infinity. Using two of the same
vertex in a polygon can cause the computed normal to be (0,0,0),
which causes badness and failures.

BUG=626095
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2551263002
Cr-Commit-Position: refs/heads/master@{#443296}

https://boringssl.googlesource.com/boringssl/+log/a81967b47c5eba78aedccd2bc3cb3fb95fe80bd0..8b8d22c961413c1ae465719d8252bea50587ed3f

BUG=none

Review-Url: https://codereview.chromium.org/2626273002
Cr-Commit-Position: refs/heads/master@{#443295}

https://skia.googlesource.com/skia.git/+log/d32303e7276b..693fdbd6b81a

$ git log d32303e72..693fdbd6b --date=short --no-merges --format='%ad %ae %s'
2017-01-12 reed refFoo variant for getters that naturally have a sk_sp
2017-01-12 mtklein skia_android_serial = "auto"
2017-01-12 brianosman Cleanup GrPixelConfig helper functions
2017-01-12 jvanverth Fix perf regression with SDF paths

BUG=677889

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=kjlubick@google.com

Review-Url: https://codereview.chromium.org/2627953004
Cr-Commit-Position: refs/heads/master@{#443294}