GitLab

BUG=326577

Review URL: https://codereview.chromium.org/421583002

Cr-Commit-Position: refs/heads/master@{#288493}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288493 0039d316-1c4b-4281-b951-d872f2087c98

The Chrome data reduction feature relies on HTTP headers to 
work correctly and efficiently with the data reduction 
proxy. This include both standard HTTP headers (like Via) 
and custom headers (like Chrome-Proxy). Tampering on these 
headers could lead to miserable user experience, taking 10s 
to load some pages, for example.

In the past, we have seen such headers being stripped by 
middle box proxies (for example, the WWW-Authenticate header 
was stripped by some carrier). It has been known that mobile 
carriers are doing HTTP traffic optimizations. We also want 
to know whether mobile carriers are trying to "optimize" the 
already optimized data reduction proxy response body, which 
might lead to higher cost to users.


We propose a mechanism in Chromium to enable us to learn the 
scale and the types of such tampers. In short, the mechanism 
will check whether a predefined set of HTTP response headers 
and the response body have been changed in a way that could 
affect the data reduction proxy. It will detect such changes 
by using pre-calculated header (and probably content) hashes 
sent by the server. Chromium will report through UMA the 
count of each tamper types has happened. This will only be 
enabled for a fraction of the data reduction proxy users.

BUG=381907

Review URL: https://codereview.chromium.org/338483002

Cr-Commit-Position: refs/heads/master@{#288492}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288492 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tbreisacher@chromium.org
BUG=78368

Review URL: https://codereview.chromium.org/456053003

Cr-Commit-Position: refs/heads/master@{#288491}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288491 0039d316-1c4b-4281-b951-d872f2087c98

gclient revert can no longer run now that we're using botupdate.
This works around the issue by using git reset --hard.

BUG=401129
NOTRY=True

Review URL: https://codereview.chromium.org/457793003

Cr-Commit-Position: refs/heads/master@{#288490}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288490 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/453103002

Cr-Commit-Position: refs/heads/master@{#288489}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288489 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/456923002

Cr-Commit-Position: refs/heads/master@{#288488}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288488 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/454163002

Cr-Commit-Position: refs/heads/master@{#288487}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288487 0039d316-1c4b-4281-b951-d872f2087c98

This condition was added to prevent the zlib benchmark from OOMing on the
Galaxy Nexus device. Now, it's no longer on the waterfall, so I'm just
removing the check.

This has the desired side-effect that we'll try to run this benchmark on any
device, even if we can't determine the physical memory.

BUG=391079

Review URL: https://codereview.chromium.org/450873002

Cr-Commit-Position: refs/heads/master@{#288486}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288486 0039d316-1c4b-4281-b951-d872f2087c98

In print preview mode, focus toggles for radio buttons for pagerange
settings when custom input radio button is clicked again and page 
range is empty. 

This is not desired and happens because focus is set for
another radio button on blur event for custom input radio
button when it is empty.

BUG=397094

Review URL: https://codereview.chromium.org/435393005

Cr-Commit-Position: refs/heads/master@{#288485}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288485 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/456943002

Cr-Commit-Position: refs/heads/master@{#288484}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288484 0039d316-1c4b-4281-b951-d872f2087c98

BUG=333194

Review URL: https://codereview.chromium.org/455013002

Cr-Commit-Position: refs/heads/master@{#288483}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288483 0039d316-1c4b-4281-b951-d872f2087c98

BUG=398935
TEST=Manual, see bug
R=oshima
TBR=sky (For addition of DEPS to athena/system)

Review URL: https://codereview.chromium.org/451753002

Cr-Commit-Position: refs/heads/master@{#288482}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288482 0039d316-1c4b-4281-b951-d872f2087c98

This isn't as ugly as the crazy null check, and it seems to be compiled correctly.

BUG=

Review URL: https://codereview.chromium.org/427003008

Cr-Commit-Position: refs/heads/master@{#288481}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288481 0039d316-1c4b-4281-b951-d872f2087c98

Calling connect() would not fail if there was an error connecting. Instead it
would return 0 (success) and fail on the first read/write.

The fix is to check SocketNode::last_errno_ after the wait succeeds.

BUG=none
R=noelallen@chromium.org

Review URL: https://codereview.chromium.org/458563002

Cr-Commit-Position: refs/heads/master@{#288480}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288480 0039d316-1c4b-4281-b951-d872f2087c98

NSFont returns fractional values for font metrics. We were truncating the
values, causing text to appear too high vertically. The fix is to apply the
ceiling function instead.

BUG=401345

Review URL: https://codereview.chromium.org/445363006

Cr-Commit-Position: refs/heads/master@{#288479}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288479 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#288478}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288478 0039d316-1c4b-4281-b951-d872f2087c98

Hash copied at https://codereview.chromium.org/449673003/.

R=iannucci@chromium.org
BUG=400830

Review URL: https://codereview.chromium.org/447183005

Cr-Commit-Position: refs/heads/master@{#288477}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288477 0039d316-1c4b-4281-b951-d872f2087c98

No functional change, only making the behavior of the functions more obvious.

Retail mode is obsolete in R38 and later according to crbug.com/372703 and not supported anymore after this change.

BUG=NONE
(for chrome/browser/metrics/perf_provider_chromeos.cc, API usage)
TBR=isherman@chromium.org

Review URL: https://codereview.chromium.org/450363002

Cr-Commit-Position: refs/heads/master@{#288476}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288476 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401286

Review URL: https://codereview.chromium.org/447903003

Cr-Commit-Position: refs/heads/master@{#288475}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288475 0039d316-1c4b-4281-b951-d872f2087c98

Added a dependency on "mojo/public/interfaces/bindings/tests/validation_test_interfaces.mojom" to validation_unittests.js, just to prove that the bindings can be parsed.

BUG=401977

Review URL: https://codereview.chromium.org/452963002

Cr-Commit-Position: refs/heads/master@{#288474}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288474 0039d316-1c4b-4281-b951-d872f2087c98

- add benchmark option
- add multi-thread support
- convert from c to cpp (inc. ppapi)
BUG=NONE
TEST=this is a demo

R=binji@chromium.org

Review URL: https://codereview.chromium.org/451883002

Cr-Commit-Position: refs/heads/master@{#288473}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288473 0039d316-1c4b-4281-b951-d872f2087c98

BUG=396275

Review URL: https://codereview.chromium.org/445493002

Cr-Commit-Position: refs/heads/master@{#288472}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288472 0039d316-1c4b-4281-b951-d872f2087c98

- wrap the title text
- removes the extra single pixel white border at the top.

BUG=401817

Review URL: https://codereview.chromium.org/457723002

Cr-Commit-Position: refs/heads/master@{#288471}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288471 0039d316-1c4b-4281-b951-d872f2087c98

R=luken@chromium.org

Review URL: https://codereview.chromium.org/459563002

Cr-Commit-Position: refs/heads/master@{#288470}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288470 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401881, 287883

Review URL: https://codereview.chromium.org/449993004

Cr-Commit-Position: refs/heads/master@{#288469}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288469 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/459433002

Cr-Commit-Position: refs/heads/master@{#288468}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288468 0039d316-1c4b-4281-b951-d872f2087c98

I saw it flake even with reruns: http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/881

BUG=396414
TBR=janx@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/451173002

Cr-Commit-Position: refs/heads/master@{#288467}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288467 0039d316-1c4b-4281-b951-d872f2087c98

This CL enables the user to launch the chrome remote desktop app directly into an immersive it2me helper session.
In the immersive session, the app will
1. hide the home screen
2. create an hrd_helper_session object to communicate with the it2me_background service.

Review URL: https://codereview.chromium.org/439923002

Cr-Commit-Position: refs/heads/master@{#288466}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288466 0039d316-1c4b-4281-b951-d872f2087c98

The FailedDataTypeHandler is now informed immediately of failures, including
datatype errors, and is therefore authoritative source for all errors. As such,
partial success is no longer tracked and the various ModelTypeSets for error
types in configure results are removed.

BUG=368834

Review URL: https://codereview.chromium.org/420633002

Cr-Commit-Position: refs/heads/master@{#288464}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288464 0039d316-1c4b-4281-b951-d872f2087c98

I saw it flake even with reruns: http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/977

BUG=282116
TBR=fsamuel@chromium.org

Review URL: https://codereview.chromium.org/451183002

Cr-Commit-Position: refs/heads/master@{#288463}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288463 0039d316-1c4b-4281-b951-d872f2087c98

On right click in editable node context menu was always having 'paste'
option as enabled. Added check that if clipboard is not empty
then only show 'paste' option.

BUG=396616

Review URL: https://codereview.chromium.org/443073002

Cr-Commit-Position: refs/heads/master@{#288461}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288461 0039d316-1c4b-4281-b951-d872f2087c98

BUG=254804
TBR=hirono@chromium.org
TEST=manually tested.

Review URL: https://codereview.chromium.org/451123002

Cr-Commit-Position: refs/heads/master@{#288460}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288460 0039d316-1c4b-4281-b951-d872f2087c98

Rename ValidatePage/MeasurePage -> ValidateAndMeasurePage for all files outside tools/telemetry and tools/perf.

BUG=383635

Review URL: https://codereview.chromium.org/452123002

Cr-Commit-Position: refs/heads/master@{#288459}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288459 0039d316-1c4b-4281-b951-d872f2087c98

Surface loss is only detected via the callback.

We can tolerate multiple calls to InitializeRenderer without
needing the lost-surface callback in between.

Remove Renderer::IsContextLost, but keep GLRenderer::IsContextLost.

Remove ThreadProxy::CheckOutputSurfaceStatusOnImplThread

BUG=392891

Review URL: https://codereview.chromium.org/446973002

Cr-Commit-Position: refs/heads/master@{#288457}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288457 0039d316-1c4b-4281-b951-d872f2087c98

Right now, SSLBlockingPage has both overridable_ and strict_enforcement_. 
This CL collapses both into overridable_, so that we only need to check one. 
However, strict_enforcement_ also remains on its own because it is checked 
separately in one place.

BUG=
R=palmer@chromium.org

Review URL: https://codereview.chromium.org/448163002

Cr-Commit-Position: refs/heads/master@{#288456}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288456 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#288455}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288455 0039d316-1c4b-4281-b951-d872f2087c98

BUG=109173
TEST=none
R=jam@chromium.org
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/457823002

Cr-Commit-Position: refs/heads/master@{#288454}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288454 0039d316-1c4b-4281-b951-d872f2087c98

We still need to expose these to apps, and transition things
appropriately.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/454603002

Cr-Commit-Position: refs/heads/master@{#288453}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288453 0039d316-1c4b-4281-b951-d872f2087c98

[DevTools] Make DevTools clients talk directly to DevToolsAgentHost instead of using DevToolsManager.

Previously, client used methods on DevToolsManager passing |this| to most of them.
Instead, it should hold a scoped_refptr to inspected DevToolsAgentHost and talk
to it directly. This creates a single clean entry point for the client, and allows
in the future to handle browser-wide protocol messages and debug multiple hosts at once.

BUG=401073
TBR=kalman@chromium.org

Review URL: https://codereview.chromium.org/449043002

Cr-Commit-Position: refs/heads/master@{#288452}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288452 0039d316-1c4b-4281-b951-d872f2087c98

Also added the code to store owner info into boot lockbox during enrollment.

BUG=chromium:353050
TEST=unit_tests

Review URL: https://codereview.chromium.org/438493002

Cr-Commit-Position: refs/heads/master@{#288451}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288451 0039d316-1c4b-4281-b951-d872f2087c98