- 13 Jul, 2020 40 commits
-
-
Dominique Fauteux-Chapleau authored
Bug: 1104289 Change-Id: Ica537738e30fdbd9e9c0c63ed48e58cdd137444c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292787Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#787863}
-
Dylan Sleeper authored
This CL adds two subclasses: ClipboardHTMLReader and ClipboardHTMLWriter. When HTML is read and written it is "sanitized" which means that all script objects are removed from the html. They are both entirely synchronous because it is impossible to use HTML DOM nodes off of the main thread. Design Doc: https://docs.google.com/document/d/1tzjfckWUKAAxEbKcUjg21uz7LFDMQ7ZDzfTTj3Lp93Y/edit Bug: 931839 Change-Id: I29b26f1c721102005bcbb5911549a9546aed3006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243532 Commit-Queue: Dylan Sleeper <dsleeps@google.com> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#787862}
-
Renjie Tang authored
Instead use unified methods in QuicTestUtils. Bug: 1085541 Change-Id: I7503cb2a05376d5fc9b63f071a610ced0df85fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295920Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Auto-Submit: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#787861}
-
Kyle Horimoto authored
This reverts commit e2b47be8. Reason for revert: Test has been deflaked; see https://crbug.com/1102087. Original change's description: > [CrOS Settings] Disable flaky PersonalizationPage test > > Bug: 1094896 > Change-Id: Ic8e08cca22aa18b607a2aaac0e60974e6913fab2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246235 > Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: dpapad <dpapad@chromium.org> > Reviewed-by: dpapad <dpapad@chromium.org> > Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#778416} TBR=khorimoto@chromium.org,dpapad@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Fixed: 1094896 Change-Id: I6078bbf3001a361c0ff73951c99269cf4672b7b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295210Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#787860}
-
kylechar authored
DelegatedFrameHostAndroid::EvictDelegatedFrame() is no longer used by RenderWidgetHostViewAndroid so make it private instead of public. Fixed: 938959 Change-Id: I1bc0aa50bf758dc2c11d226fb2af9263c8c67140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292123Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#787859}
-
Pete Williamson authored
For https://chromium-review.googlesource.com/c/chromium/src/+/2276685, a few comments came in after the change was in the CQ. These are the fixes that those comments requested. Bug: 1099504 Change-Id: Ib457a3f0f5d12679f2a65413afef34dde559d491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289924 Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#787858}
-
Sorin Jianu authored
This avoid retention issues and allows instances of CrxDownloader to be shared between sequences when interfacing with RPC modules such as BITS/DO for Windows. There are some mechanical changes such as removing macros.h and replacing thread checkers with sequence checkers (but not for the BITS downloader, which has thread affinity due to COM RPC). Change-Id: I62e159d4ae8999ec70da94247f91f9cc26a5d278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293461Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#787857}
-
manukh authored
Follow up to crrev.com/c/2274466 . The previous CL updated the autocomplete results to conditionally boost the max suggestions. However, the search provider limits the # of suggestions it provides to the unboosted limit, rendering the boost ineffective. This CL updates the search provider to send the max of GetMaxMatches (e.g. 8) and kDynamicMaxAutocompleteIncreasedLimitParam (e.g. 10). Change-Id: Iaa9933b4445874488d42d831d76ef30a2d9e3e8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293458Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#787856}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1a1ffb06..38ef299a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia8d7b697eadbdca14bb08e877213cea7f8bde347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295083Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787855}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia46c85012e68e45953e506e1332277b2090728e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294573Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787854}
-
wutao authored
This patch implements the topic source picker for Ambient mode. Basic functions: (1) Clicking anywhere on an unselected row selects that row, except if the click is on the subpage arrow. (2) Clicking the subpage arrow on an unselected row leads to the subpage but does not select the item. (3) Clicking anywhere on an already-selected item leads users to the subpage. (4) Up/down arrows are used to move between items. ss: https://screenshot.googleplex.com/vBKWPkWNZ5t Bug: b/159746638 Test: Manual Change-Id: Idd8efe31f8aadb7a690ecb8401fe434acc304596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284642Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#787853}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/74470aec5185..3b5a4fac1e5e 2020-07-13 brianosman@google.com Use stable sort for Viewer's help screen 2020-07-13 herb@google.com improve the speed of empty GrTextBlobs 2020-07-13 herb@google.com move drawTextPaths from RTC to SubRun 2020-07-13 johnstiles@google.com Replace ModulateRGBA effect with Xfermode using modulate blend. 2020-07-13 johnstiles@google.com Replace ModulateAlpha effect with Xfermode using src-in blend. 2020-07-13 brianosman@google.com SkRuntimeEffect: Guard against programs with no "main" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: I9387a27f796d01c683716051f946b6d92caf1e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295423Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I141fa81f5f6d183d094c7473d39bb0c9280c06ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295741Reviewed-by:
-
Maggie Chen authored
We no longer collect Vulkan info for UMA at the browser start. Rename command line switch to DX12 only. This switch is mainly used for testing. Change --disable-gpu-process-for-dx12-vulkan-info-collection to --disable-gpu-process-for-dx12-info-collection and Change kDisableGpuProcessForDX12VulkanInfoCollection[] to kDisableGpuProcessForDX12InfoCollection[] Bug: 775983 Change-Id: Iddbac1fb81cddce16df8910109fba1b6ddfb8089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280587Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#787850}
-
Varun Khaneja authored
Fixed: 1089423 Change-Id: Ib4e7f33dc6723aaecd28fe8b629991fb26ca07d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295403 Commit-Queue: Varun Khaneja <vakh@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#787849}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594640123-ecf0c679b64f8e063828d3c68ecfae268f1bc244.profdata to chrome-mac-master-1594662802-fdeeec39ffe5ca406713d5654e95a154ee25e0d8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I31ec37afa221d0c6968ae314a7da28fda6cde903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295642Reviewed-by:
-
Raymond Toy authored
The threshold for the -100 Hz sine wave is apparently just a little too tight for MacOS 10.11. Adjust the threshold slightly. Bug: 1104535 Change-Id: I7102093e2641a748d07ca63c05e9e8e63c9f8dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295211Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#787847}
-
Arthur Eubanks authored
Change-Id: I3d03a707254bc62e67909d154eaa857fdcfbed8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295823Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#787846}
-
John Lee authored
This is based off of feedback from UX research suggesting that the swipe to close tab gesture was too easy to trigger accidentally. Change-Id: I20ce1602037dea85326288ac565877d2882ddc3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291231Reviewed-by:
-
Sean Gilhuly authored
OOP raster isn't available as an option in cc_unittests, except for Vulkan where it is enabled by default. GPU raster relies on GL, and shouldn't be used with Vulkan. Make the difference between GPU raster and OOP raster options explicit, and clarify some of the messaging which mentions Vulkan and GPU raster. Bug: 1092945 Change-Id: I1d54cf8586daea3a485be8f492d59ee4500e6007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240130 Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#787844}
-
Evan Stade authored
Since this class lives in //components and is not unique to Chrome, the Chrome prefix is not entirely appropriate. Other renames: . ChromeNotificationBuilder (interface) => NotificationWrapperBuilder . NotificationBuilder => NotificationWrapperStandardBuilder . NotificationCompatBuilder => NotificationWrapperCompatBuilder . NotificationBuilder (Chrome specialization) => ChromeNotificationWrapperStandardBuilder . NotificationCompatBuilder (Chrome specialization) => ChromeNotificationWrapperCompatBuilder Bug: 1071834 Change-Id: Iec2172827fa6fc0b2aa77619ee06b7bc099eed49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291263 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#787843}
-
Christopher Cameron authored
This makes SharedImageBackingGLImage work with WebGPU. After this, it will be possible to delete SharedImageBackingIOSurface. Merge all of the Client interfaces into a single SharedImageRepresentationGLTextureClient interface, now that they all came the same functions. Bug: 894929 Change-Id: I9990e66a438d97d411788485e244182b640fe9cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293618 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#787842}
-
nancylingwang@google.com authored
Modify unit tests to use AppServiceContextMenu and make fake extension apps. Unlike ExtensionAppContextMenu, AppServiceContextMenu only generates the enabled command, so the unit tests are modified to check the enabled items. BUG=1016159 Change-Id: I245ea01de0f5a5ef05cb2bb5575babd34d466add Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280972Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#787841}
-
Peter Wen authored
Turns out my initial implementation was not enough. Classes from the META-INF/TRANSITIVE directory of direct deps may also be needed: https://crrev.com/c/2289614 Let's say A depends on B. The META-INF/TRANSITIVE directory for B.turbine.jar contains superclasses that A needs to generate headers, and A *might* need them during compilation. This means that while compiling A, we should add the transitive classes for all of its direct dependencies (B, etc) to its classpath as well as the transitive classes in its own A.turbine.jar. This has a very small impact on build speed due to extracting a few more files from targets' dependencies. Ran: tools/android/build_speed/benchmark.py all_incremental Before: chrome_java_nosig: 38.0s avg (38.8s, 37.1s) chrome_java_sig: 39.2s avg (39.6s, 38.9s) chrome_java_res: 25.6s avg (25.7s, 25.6s) base_java_nosig: 40.4s avg (40.3s, 40.4s) base_java_sig: 94.4s avg (94.3s, 94.4s) After: chrome_java_nosig: 37.1s avg (36.7s, 37.5s) chrome_java_sig: 39.3s avg (39.5s, 39.0s) chrome_java_res: 25.5s avg (25.5s, 25.6s) base_java_nosig: 40.2s avg (40.1s, 40.3s) base_java_sig: 96.0s avg (96.1s, 96.0s) Bug: 1082904 Change-Id: Id942a35bdef4eaebab60991ba71d7bca99b42c8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295321Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#787840}
-
Dylan Cutler authored
This will add instrumentation to these APIs automatically via the bindings code. This CL intentionally excludes navigator.languages since our bindings instrumentation does not support arrays yet. I will add the label to this API in a follow-up CL. I also will annotate navigator.doNotTrack in a follow-up CL since it has a different owner in another timezone, and I do not want to block the rest of this CL on that. Bug: 973801 Change-Id: I4e4f024b20319b9f9d7da29490f15c0e71d69115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290052 Commit-Queue: Dylan Cutler <dylancutler@google.com> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#787839}
-
Jeffrey Cohen authored
This also workarounds for the fact that the share code is not modularized (crbug.com/1022172) by adding a small build target with just one interface. Bug: 1093365 Change-Id: I8a7e23f90de190756e10ff37ce8a90340e3b565c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288076 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#787838}
-
Andrew Xu authored
Still not sure why the original test case failed. One possible reason is that the scroll distance in the previous code, which is 50, is not enough to scroll the shelf to the end. However, on my local device, it always works with the same gn args. This CL implements a function to get the maximum scroll distance of scrollable shelf. It ensures that the scroll distance in the test is large enough. Bug: 1100254 Change-Id: I99911faa6a51ada0fc827f740b019b2d20e18b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293468Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I35b419f120fd8e981ef64d43e2c183ea5f0686e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295419Reviewed-by:
-
Jeffrey Cohen authored
TBR=tkent@chromium.org Bug: 1104910 Change-Id: Icb800cd0260a39cb6699fcdbd75ec27612c7afa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295919Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#787835}
-
Haiyang Pan authored
This is a reland of b7a9b68b plus increasing the default timeout to make sure emulator starts successfully. Original change's description: > emulator: Disable the feature GLDMA. > > android emulator team points out that the exception is related to DMA. > Disable GLDMA temporarily to see if it can fix the timeout issue on MM > > Bug: 1093602 > Change-Id: I940b8111db48d8b542b47f350b949dab7448d1d8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293279 > Auto-Submit: Haiyang Pan <hypan@google.com> > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > Commit-Queue: Yuke Liao <liaoyuke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#787433} Bug: 1093602 Change-Id: If4c1e60c0f45bd6c1e6be2444eafbf9b1550f209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295324Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#787834}
-
Renjie Tang authored
CloseStream() will be deprecated. The reason is that this method is not closing the stream silently. QUIC specifies that when a stream closes, it needs to send out a RESET_STREAM frame to indicate closure reason. The default error code in CloseStream() is QUIC_RST_ACKNOWLEDGEMENT, which is very uninformative. ResetStream(), however, allows applications to specify reasons of closure. Change-Id: Ie0633422ab3838abcaa7c31c4068db32ae11932a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292857Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#787833}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/95d932b7e987..ecc9f3494ee9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ftirelo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ftirelo@google.com Change-Id: I93886d48054d6f229218ce23ab93773a0d89fe26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295135Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787832}
-
Alison Maher authored
fast/css/css2-system-color.html is flaky on Windows. Mark the test as such in TestExpectations until a fix is identified. Bug: 1104697 Change-Id: I36d572cf463e6ed9e675ec7792363e5fd61e6e65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295405Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#787831}
-
John Lee authored
On line 89, the drag image has a padding and is translated up, which causes the drag image to peak up a bit while the group is being dragged. This is more noticeable when there's a scrollbar. Before and after: https://imgur.com/a/p6UH8e9 Change-Id: If75024d5b3dec3ceffa7a82bdaf6ab52172fa0c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292860Reviewed-by:
-
Yulun Wu authored
Some metrics are missing for home to overview gesture. This CL adds metrics to HomeToOverviewController::HideNudge(). Bug: 1101105 Change-Id: I166cce0a489925f0e03ed61b0808044af35aaea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293459Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#787829}
-
Anna Malova authored
The message does not indicate an error, but it causes confusion. The message appears when GetChromePolicyDetailsCallback returns null for the policy (see ConfigurationPolicyHandlerList::FilterOutUnsupportedPolicies). Use an empty callback instead. Bug: 1098245 Change-Id: Ifcf43a40ebae5bfd300721bcd69310ba3ebc0914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292523Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#787828}
-
ckitagawa authored
This CL moves bitmap request logic from PlayerFrameMediator to PlayerFrameBitmapState. This is mostly a mechanical change just moving code. Bug: 1099722 Change-Id: Iddedf83510bd715b18f3b5e393099721db33b69e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292895 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Fred Mello <fredmello@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#787827}
-
Dr Alex Gouaillard authored
Bug: 1099855 Change-Id: I57368cf7bec54e97964fecb8da0dfe009d8f2968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270444 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#787826}
-
Nate Chapin authored
Several pieces of state (SecurityOrigin, ContentSecurityPolicy, and WebSandboxFlags) are set or calculated on DocumentInit, then transferred to SecurityContextInit, which is then passed to SecurityContext to complete initialization. All of this state comes from DocumentLoader (for main thread cases). Have DocumentLoader calculate the final state directly, then either pass it to SecurityContextInit (in the case of SecurityOrigin) or apply it directly to the SecurityContext for (CSP and sandbox flags). Change-Id: I40a0a6a7f68a043818eeb9eb2ccbab437e8448d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293175 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#787825}
-
Ben Kelly authored
When a new session is started, the timestamp is recorded and the session is saved as Sessions_[timestamp] or Tabs_[timestamp]. The existing session with the latest timestamp is chosen as the "last" session to restore from, and all older sessions are deleted. These new files were moved under a separate directory, to facilitate snapshotting. Snapshotting relies on static file names, so the entire folder is preserved rather than the (now dynamic) session files. The folder structure is as follows: [ProfileDir] | Sessions -----| Session_13233899802170163 | Session_13233899825256793 | Tabs_13233899802319101 | Tabs_13233899825404195 The code ensures than any new session created has a higher timestamp than any existing, in case of clock changes. If there is no older session in the new format, it falls back to the legacy files (as "Current Tabs" or "Current Session"), so current users should have no interruption in restore. Bug: 1056279,1067405 Change-Id: Ide4bc4a155e0a6de025c976ff520bc13b5edaa49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238885 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:Yann Dago <ydago@chromium.org> Reviewed-by:
-
