- 10 Jun, 2020 40 commits
-
-
My Nguyen authored
Since arrow is needed to indicate more emojis available. Only loads 5 emojis for now until arrow is implemented. Bug: 1093179 Test: manual Change-Id: I1218c860d379510d3337cfd18244b1c5c9eb1b19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237505Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#776854}
-
Chris Lu authored
This change adds SaveCardBannerRequestConfig to the known Infobar Overlays. SaveCardInfobarBannerOverlayMediator will serve to configure SaveCard Inforbar banner Overlays properly for this config. Bug: 1071914 Change-Id: I2b37d118b36ba5ab3b109f4e2b79bd1053e81d4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236692Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#776853}
-
Kunihiko Sakamoto authored
TBR=joelhockey@chromium.org No-Try: true Bug: 1093203 Change-Id: I3e2c5d9b4f76d21649a2a306327258c922cbba25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239131Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#776852}
-
David Bertoni authored
The UninstallWhileActivePageAction test was disabled for flakiness on Windows. It turns out this test was flaky on multiple platforms, because it would occasionally try to execute a JavaScript function defined in the extension's script before the script was finished initializing. The simple fix is to use TestExtensionMessageListener instances to wait for the extension script to finish initializing. Bug: 515717 Change-Id: Icc8e3accbbd6bf5e47524b1b34501eba2fe0fd41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229416Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#776851}
-
Nathan Zabriskie authored
ClusterFuzz found a potential bad address read in RasterDecoderImpl::DoWritePixelsINTERNAL when |row_bytes| < SkImageInfo::minRowBytes() for the image. This CL enforces that minimum size on the client and service sides of the command. Bug: 1087921 Change-Id: Id4e95adb7a1be9d9b5d0d6640b8b8780a580b7be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238847Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#776850}
-
Chromium WPT Sync authored
Using wpt-import in Chromium af332606. With Chromium commits locally applied on WPT: 9c24e63c "Check for first frame in CreateImageBitmap" a8a28083 "[Security][Coop] Browsing context switch reporting WPT" b2436c3b "Ensure cloning a template element into an inactive document does not crash." 027aefc6 "OPTION element: Update OPTION label even if it has invalid markup" 0776aa6d "Mark pointerevent_pointermove_in_pointerlock test non flaky" d2ee98f4 "Move manual offscreen wpt tests to own folder" 458dc853 "WPT: Migrate content-visibility tests to wpt." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools ksakamoto@chromium.org, npm@chromium.org: external/wpt/resource-timing NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I5b97cc3159beed5dade22288836283c1be8c4854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237757Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776849}
-
Adam Rice authored
The Streams implementation in Blink no longer uses JavaScript, so the eslint presubmit check is no longer necessary. Remove it. Change-Id: Ibd9362f6eb37175851df262e843a58712ef1b1a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237566Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#776848}
-
Giovanni Ortuño Urquidi authored
As precursor to adding support for chrome-untrusted:// to WebUIController we add chrome-untrusted:// to HasWebUIScheme(). After auditing uses of HasWebUIScheme() it seems fine to add chrome-untrusted:// to it. After calling HasWebUIScheme(), ChromeWebUIControllerFactory only compares hosts when looking for the WebUIController for the URL. So this change causes ChromeWebUIControllerFactory to return WebUIControllers for chrome-untrusted:// URLs with the same hosts as chrome:// URLs. To avoid this we early return if the URL's scheme is chrome-untrusted. Change-Id: Ic63ccd9fc1c9066b79957af55ffcaedb27be9cc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223709 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#776847}
-
Kunihiko Sakamoto authored
external/wpt/html/canvas/offscreen/filter/offscreencanvas.filter.w.html has been renamed to external/wpt/html/canvas/offscreen/manual/filter/offscreencanvas.filter.w.html. TBR=aaronhk@chromium.org No-Try: true Bug: 1093192,1041052,1091267 Change-Id: Ic488ff1a87cce9d27d770dfbaa745c658d572978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237584Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1c3a77ed8e33..62ace59d8c88 2020-06-10 rosasco@google.com [fuchsia] Fix fidlc command. 2020-06-10 johnstiles@google.com Revert "Update GrCircleBlurFragmentProcessor to use a child FP." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: Ia20307257e4d090b677424af00f9c3d326fc03ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239104Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776845}
-
Luciano Pacheco authored
Change SMB credentials dialog to comply with the new styles for Files app. Remove close button/icon from the dialog. Adjust the padding and spacing in the dialog, which changed the total height for the dialog from 250px to 230px. See crbug.com/992827#c38 for screenshots of before and after. Bug: 992827 Change-Id: Iaf0401186beb0f997451080e43d14b735fd93e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235228 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Anand Mistry <amistry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#776844}
-
Clark DuVall authored
WebLayer browsertests load the WebLayer implementation from the same APK the client is running in. This confuses Android and it no longer resolves dynamic attributes correctly, since a shared library APK is not expected to both be run as a normal APK and loaded as a shared lib. To fix this, switch to using app_as_shared_lib instead of shared_resources, which is what Monochrome uses to run both as Chrome and WebView. This was exposed by Colin's infobar CL which must be the first browsertest to hit a piece of UI using a dynamic attribute: http://crrev.com/c/2232555. Note that passing shared_resources to the "test" gn rule was added earlier for WebLayer, so switching to app_as_shared_lib shouldn't affect anyone else: http://crrev.com/c/1864517. Bug: 1025620 Change-Id: I95ec5500cdcf52167dfedffc9dbe79071895dc37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238706 Auto-Submit: Clark DuVall <cduvall@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#776843}
-
dpapad authored
Bug: 1091516 Change-Id: Ibcbb1dce1ca16b293f3f8998413632c29ed34042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236674 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#776842}
-
Hitoshi Yoshida authored
bindings team is going to update IDL dictionaries to be strict about their members' existence. After the update, accessing a getter on a missing dictionary member will crash. This CL fixes the potential bug in mojo conversions in ManifestImageResource. Bug: 839389 Change-Id: I90d2fd5c1361345892ce972fad7727952ab5fb60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233105Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#776841}
-
Dominic Farolino authored
It is no longer needed. This reverts the mojo traits changes from https://crrev.com/c/2229205. TBR=kinuko@chromium.org Bug: 1090391,1091711 Change-Id: I93a38bc2351bbc1e5dffda040c7944271e01cde3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238901Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
-
Kunihiko Sakamoto authored
This reverts commit b47e683b. Reason for revert: The revert didn't fix the issue. Relanding. Original change's description: > Revert "Ignore CanvasResourceProvider::Clear in OOPR Mode" > > This reverts commit 84c360e5. > > Reason for revert: Suspect this CL causes OOPBrowserTest.Basic failure on linux-trusty-rel > > https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/12426 > > Original change's description: > > Ignore CanvasResourceProvider::Clear in OOPR Mode > > > > In OOPR Canvas2D we no longer have access to Skia in the client process. > > We need to update CanvasResourceProvider::Clear to not access SkCanvas > > in the case of OOPR. A more ideal fix is tracked in > > https://crbug.com/1090081 but simply ignoring it is fine for now as > > OOPR automatically handles clearing the canvas during initialization. > > > > Bug: 1090083 > > Change-Id: I5fb75e4fac312ec00b8e5215d3756219672461ee > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236193 > > Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> > > Reviewed-by: Khushal <khushalsagar@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#776618} > > TBR=khushalsagar@chromium.org,nazabris@microsoft.com > > Change-Id: Ib906f07089a6b48eaf3e4b1f13fcfeae9d9b0896 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1090083 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237572 > Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> > Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776782} TBR=ksakamoto@chromium.org,khushalsagar@chromium.org,nazabris@microsoft.com # Not skipping CQ checks because this is a reland. Bug: 1090083 Change-Id: Ie523abd0820a9a7d02c47bda13d778e5c6f177df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237502Reviewed-by:
-
Jinsuk Kim authored
The CL was reverted due to a bug when used in Tablet which was fixed by https://crrev.com/c/2237012. Now can be landed again as is. This reverts commit c90c90f1. TBR=twellington@chromium.org Bug: 966272, 1092390 Change-Id: I4a6c671afa6544ccc2846214e1e841200e0083c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237536Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#776838}
-
Naoki Fukino authored
I'd like to move LocationLine.PathComponent class and LocationLine.getComponents_() method out of LocationLine to share the logic in LocationLine and QuickView. Bug: 1092950 Test: Existing test passes / closure compiles Change-Id: I394a4a99815f9d6d8f60aefb7fd76cf0d8e423d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237570 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#776837}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/750036ef9035..2234a98502c3 2020-06-10 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I15dd2aa64c1534b07085accb7951cef3dcd34f02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239346Reviewed-by:
-
Nektarios Paisios authored
On Windows, moving forward by one word should move to the start of the next word, punctuation or line break. On other platforms, it should first try to move to the end of the current word. This patch clarifies the attached accessibility event intents to specify whether we are moving to the end of the current word or to the start of the next one when selecting forward. Also, this patch fixes the "sentence/line/paragraphboundary" granularities to expose more information on the boundary they move to, depending on the selection direction. It fixes the "sentence/line/paragraph" granularities to always indicate that they move to the start of the next / previous boundary. AX-Relnotes: n/a. R=dmazzoni@chromium.org Change-Id: I3298f0d73b6bb5d123a15be34fc8c6c587d9594c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238186Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#776835}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/14f20b0ab38d..527080ff03ce 2020-06-10 xinghua.cao@intel.com Check FP16 support on Metal backend If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I9986ebcffab0690aff3824e8b2eaeaa27e8064ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239347Reviewed-by:
-
Guido Urdaneta authored
*Mark Media.Audio.Capture.StreamBrokerDisconnectReason as obsolete. Fixed: 881833 Change-Id: Id7737541212853b73a4090250adbf77026131eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237967Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#776833}
-
Kunihiko Sakamoto authored
Bug: 1093166 Change-Id: I28af0f945dca0b357e837587948429abff6728da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239426Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#776832}
-
Nigel Tao authored
Together with similar programs in other repositories, this helps find disagreements between Chromium's, Skia's and Wuffs' image decoders. Change-Id: I80c1386f23273263222474dfa39a5e329e6ebb1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210331Reviewed-by:
Leon Scroggins <scroggo@google.com> Reviewed-by:
-
Mario Bianucci authored
Continuing to propagate the required metadata for a delegated ink trail further down the pipeline into viz via the compositor frame metadata and storing it on the display, for now. This CL also transforms the metadata (specifically, the point and presentation area) into the root target space. This is done so that they are in the correct coordinate space for when they are eventually drawn onto the buffer prior to being swapped onto the screen. Bug: 1052145 Change-Id: I18544ee0f8b1d808669ab7ea5aa4e97792e43e3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2183328 Commit-Queue: Mario Bianucci <mabian@microsoft.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#776830}
-
Regan Hsu authored
Previously, if a query word is slightly misspelled, the result word that most closely matches the query word won't have any bolding. This CL causes the longest common substring between the query word and the result text word to be bolded. Bug: 1091063 Change-Id: I09441cc78e2cb2d55e81f526ea7baec2b5458d22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236898 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I660151081b42ffa9c1535c7a14baf6a4967344c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238784Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f43da14878ea..1c3a77ed8e33 2020-06-10 csmartdalton@google.com Re-enable GrCaps::fSampleLocationsSupport in Vulkan 2020-06-10 michaelludwig@google.com Remove unnecessary GrFixedClip includes/declarations If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: I45844eb71a34bd5de68038b3894dfc5ab7c58dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239101Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie8ad59ea2c8846d27e3dfa6b41477c74583c879a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238783Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/f9b11251a19b..586eee4d1066 2020-06-10 jophba@chromium.org Remove IPAddress, IPEndpoint static initializers 2020-06-09 jophba@chromium.org Omit empty "optional" arrays in ANSWER 2020-06-09 jophba@chromium.org Add ability to set kAnyV6 on Cast Environment 2020-06-09 jophba@chromium.org Update SimpleFraction to use abseil, improve tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I2147f531a1aa5a9e9dfa0946a43fa89866fe9005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239098Reviewed-by:
-
Jimmy Xu authored
Virtual devices will have meaningful sys info. Bug: b/157480110 Change-Id: I440922cb551b8b4342e1781d43fe18bfef5392a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231904Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Commit-Queue: Jimmy Xu <jimmyxu@google.com> Cr-Commit-Position: refs/heads/master@{#776824}
-
Joel Hockey authored
I noticed these when I was having some failures in FileManagerPathUtilTest. These were not actually causing any issues, but it is still better to revoke any registered system mount points at the end of tests. Change-Id: Ic58ff6c560de35a4839d58483d5f1d0dde13152d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237434 Commit-Queue: François Degros <fdegros@chromium.org> Reviewed-by:
François Degros <fdegros@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#776823}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: Ia5b40a2ffa60dcbd9c3ef64dc9690d4a9c51b264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237754Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776822}
-
alanlxl authored
Adding config before experiment/rollout to Beta in M84. Bug: 1067048 Change-Id: I4544f4d65b413926b039b8896ac100711c53614e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235579Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Xinglong Luan <alanlxl@chromium.org> Cr-Commit-Position: refs/heads/master@{#776821}
-
David Bertoni authored
DeclarativeContentApiTest.Overview was flaky because it did not properly wait for page action icon visibility changes before checking the visibility state. Bug: 606574 Change-Id: Iaffc72868df454ceabb3c5d6447c9aa37820a5b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229581Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#776820}
-
Fergal Daly authored
SVGs don't render in gerrit or on git links, so switch the PNG for a better user experience. Update reference in code and delete second redundant reference. Change-Id: I595cc5a5403d7b6741e22bcdb47447f3aad27bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237533Reviewed-by:
-
Dominic Farolino authored
We're seeing a spike of DumpWithoutCrashes() from NetworkServiceNetworkDelegate in crbug.com/1090391. This indicates a request's referrer violates its policy. From debugging Windows minidups, I found that all or most of the DWCs are coming from the following scenario: - A site is loaded over HTTP and is not upgraded - It is sent with the following Response Headers: - Content-Security-Policy: `upgrade-insecure-requests` - Referrer-Policy: `origin-when-cross-origin` - All subresource requests on the page are requested as relative URLs, which are necessarily upgraded to HTTPs - These upgraded URLs are of course cross-origin with the HTTP main resource, so their referrer is restricted to the origin. - However, for iframe navigations, the browser process upgrades the request to HTTPs, but does not re-compute the referrer. This CL fixes that, and adds two tests: - HTTP page with origin-when-cross-origin policy requesting an upgraded iframe - Assert that the `Referer` is correctly redacted - HTTPs page requests an HTTP iframe that gets upgraded to HTTPs to be same-origin - Assert that the `Referer` is not redacted R=jochen@chromium.org,kinuko@chromium.org Bug: 1090391, 1093160 Change-Id: Ib4e0da6e68850ae478020643d4c0fabca4e87e30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236900 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by: -
Kunihiko Sakamoto authored
This reverts commit 743cd579. Reason for revert: LocationIconViewTest.ActivateFirstInactiveBubbleForAccessibility on Win7 Tests (dbg)(1) hits LOG(DFATAL) at ax_platform_node_win.cc:650 https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/82839 Original change's description: > Add some debugging code to understand strange Views focus bugs > > R=dmazzoni > > Bug: 1039422 > Change-Id: I443859ce61d6ab73967b226b85a90b14f07e2a1a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236457 > Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776753} TBR=dmazzoni@chromium.org,aleventhal@chromium.org Change-Id: I805e68c105605bd502669c6fa59a3a1c2aac0e32 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1039422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237499Reviewed-by:
-
Luciano Pacheco authored
Change SMB add share dialog to comply with the new styles for Files app. Remove close button/icon from the dialog. Adjust the padding and spacing in the dialog, which changed the total height for the dialog from 564px to 515px. See crbug.com/992827#c38 for screenshots of before and after. Bug: 992827 Change-Id: Ia19c97c784b67bcca68ae2e042f02cdd689c1525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235146 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Xing Liu authored
DownloadDialogBridge currently holds the location dialog UI logic. This CL moves the location dialog UI logic to its own class. DownloadDialogBridge will be the place to glue the download later dialog and location dialog. Bug: 1078454 Change-Id: Ieafda28ec6feb2a4f7afcaf098ea34b789d33abd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236135 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#776815}
-
